Riskeer / Ringtoets / Common / test / Ringtoets.Common.Data.Test

UpdateDataStrategies

Clone Tools

Stats

Commits this week: 0
Total Committers: 5
Last Commit: 15 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Feb 2017
12:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1492: - Improved tests of UpdateStrategyBase: -- Introduced two additional properties which keep track of which arguments were used during function calls -- Removed two obsolete tests, assertions of removed tests are added in the functional tests to achieve better functional coverage -- Reintroduced the ItemsToRemove property to assert whether the RemoveObjectAndDependentData pass the right objects to the caller Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8470 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b68f900396707e7cef5bc71858a0a9e0081f620c

Former-commit-id: c93063f126a7003c1650f36bd9eac0a304c063e7

Options
    • -82
    • +103
    ./UpdateDataStrategyBaseTest.cs
Monday 27 Feb 2017
5:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1488: - Improved tests of StrategyBase: -- Replaced the return methods with properties to assert if they're called with the right input arguments -- Renamed several tests - Ran DeltaresClean - Inlined the ValidateItems function in the ObservableUniqueItemCollectionWithSourcePath Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8450 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4ffcec0c1dcd11672904c2b637269d6a80545364

Former-commit-id: eee856fa71a461b074affbe52ed8d0429d4a7333

Options
    • -11
    • +15
    ./ReplaceDataStrategyBaseTest.cs
    • -51
    • +45
    ./UpdateDataStrategyBaseTest.cs
  3. … 3 more files in changeset.
Friday 24 Feb 2017
3:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Generalized Update and Removing data from the concrete UpdateStrategyBase class implementations and moved it to the base class -- Fixed affected tests - Added condition: observers of the target collection should be notified when the items are added or removed from the collection -- Added test to verify behaviour -- Added deepclone method for TestItem Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8419 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b6a7ca74a432a9524fb4e100936403211e8c74e4

Former-commit-id: 78f360a48b04555133c0aac044cb8878e28ccdb4

Options
    • -49
    • +50
    ./UpdateDataStrategyBaseTest.cs
  2. … 5 more files in changeset.
1:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Separated type specific functions from type independent functions in RingtoetsPipingSurfaceLineUpdateDataStrategy - Added missing tests for the UpdateStrategies (base and concrete surface line implementation) - Updated XMLDoc - Improved tests: -- Introduced a deep clone function -- Extracted surface line names to local variables

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8417 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 65de504c56270404f419bc1d959083d05b80e420

Former-commit-id: d81ffd2896c0bdf17f166878684cf4d45d948520

Options
    • -11
    • +182
    ./UpdateDataStrategyBaseTest.cs
  2. … 6 more files in changeset.
Thursday 23 Feb 2017
4:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Updated XMLDoc - Refactored ObservableUniqueItemCollectionWithSourcePath: -- Turned class into an abstract class -- Removed generic TFeature, because explicit knowledge is not needed -- Adjusted inherited classes or classes that make direct use of the ObservableUniqueItemCollectionWithSourcePath

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8411 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 68cb3152a1c682b33bb73740c7d2e1300459cde2

Former-commit-id: 3e983eaebb15fdbe735d2ae5c62aa07d82a65242

Options
    • -24
    • +18
    ./ReplaceDataStrategyBaseTest.cs
    • -23
    • +16
    ./UpdateDataStrategyBaseTest.cs
  3. … 16 more files in changeset.
3:18 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Adjusted sql script - Added tests for the strategy template classes to assert the correct function arguments are used when the protected functions are called - Updated XMLDocs Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8409 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f4c9ff2c01986c8e24d309d3a1095352ede30c64

Former-commit-id: 668e94b92a17932f62f7583edae32491bec917d1

Options
    • -2
    • +25
    ./ReplaceDataStrategyBaseTest.cs
    • -13
    • +87
    ./UpdateDataStrategyBaseTest.cs
  3. … 8 more files in changeset.
Tuesday 21 Feb 2017
1:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1468: - Refactored the UpdateDataStrategies by introducing a template class UpDataStrategyBase:

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8358 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d012126ecc4261bcb460eaa1c5fba7ed5bac1a9b

Former-commit-id: d9faa4ce1d1f641bb915a6c1dba082f9f0c79aba

Options
    • -0
    • +266
    ./UpdateDataStrategyBaseTest.cs
  2. … 3 more files in changeset.
Monday 20 Feb 2017
4:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1468: - Optimized performance when removing all stochastic soil models by introducing a RemoveAllStochasticSoilModels function in the PipingDataSynchronizationService - Refactored the ReplaceDataStrategies by introducing a template class ReplaceDataStrategyBase: -- Applied base for RingtoetsPipingSurfaceLineReplaceDataStrategy -- Applied base for StochasticSoilModelReplaceDataStrategy -- Adjusted failing tests Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8335 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cfb50a1b0fa42c951a1b8c89e5595642c6587487

Former-commit-id: 016494966ba082d3ff5f671b9f0e8dc5540e38c7

Options
    • -0
    • +256
    ./ReplaceDataStrategyBaseTest.cs
  2. … 9 more files in changeset.