FailureMechanismSectionsImporterTest.cs

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Implement review comments WTI-1752

    • -102
    • +38
    ./FailureMechanismSectionsImporterTest.cs
  1. … 9 more files in changeset.
Review related changes WTI-1751

    • -1
    • +3
    ./FailureMechanismSectionsImporterTest.cs
  1. … 12 more files in changeset.
Use message provider in the failure mechanism sections importer WTI-1752

    • -46
    • +166
    ./FailureMechanismSectionsImporterTest.cs
  1. … 8 more files in changeset.
Cleanup WTI-1752

    • -4
    • +1
    ./FailureMechanismSectionsImporterTest.cs
Introduce update strategies for the failure mechanism section importer WTI-1752

    • -41
    • +81
    ./FailureMechanismSectionsImporterTest.cs
  1. … 9 more files in changeset.
Use new test helper in tests WTI-1751

    • -1
    • +1
    ./FailureMechanismSectionsImporterTest.cs
  1. … 7 more files in changeset.
Rename AddSections to SetSections WTI-1751

    • -1
    • +2
    ./FailureMechanismSectionsImporterTest.cs
  1. … 139 more files in changeset.
Fix compilation errors in tests WTI-1751

    • -2
    • +5
    ./FailureMechanismSectionsImporterTest.cs
  1. … 27 more files in changeset.
Committed rename changes Note: compiling erros in the tests and testutils are still present

    • -1
    • +1
    ./FailureMechanismSectionsImporterTest.cs
  1. … 138 more files in changeset.
Changed log message: - Changed expected log message to a format that is consistent with the other log messages of the importer

WTI-1699

    • -1
    • +2
    ./FailureMechanismSectionsImporterTest.cs
  1. … 3 more files in changeset.
Changed algorithm: - Added logic to deal with the situation where: -- The sum of lengths of the sections is as long as the reference line length, and -- One of the sections inbetween is shifted, resulting in a premature end of the chaining, and -- therefore the endpoints of the referenceline and the final section do not match - Fixed failing tests due to mapping a distance as a key instead of as a value

WTI-1699

    • -0
    • +27
    ./FailureMechanismSectionsImporterTest.cs
  1. … 8 more files in changeset.
Changed algorithm: - Determine the shortest distance from the point to be chained to the next section - Add a clipping functionality to clip sections in an ordered way

WTI-1699

    • -1
    • +31
    ./FailureMechanismSectionsImporterTest.cs
  1. … 16 more files in changeset.
Review related changes, renamed HasPassedSimpleAssessment and used test failuremechanism instead of simple failure mechanism WTI-1617

    • -29
    • +16
    ./FailureMechanismSectionsImporterTest.cs
  1. … 20 more files in changeset.
Refactor cleanup WTI-1617

    • -20
    • +18
    ./FailureMechanismSectionsImporterTest.cs
  1. … 39 more files in changeset.
Add notification of SectionResults when importing to the FailureMechanismSectionsImporter WTI-1617

    • -0
    • +31
    ./FailureMechanismSectionsImporterTest.cs
  1. … 2 more files in changeset.
Review related changes, cleanup and fixed some resource strings. Paired with roberttangerman WTI-1532

    • -1
    • +1
    ./FailureMechanismSectionsImporterTest.cs
  1. … 5 more files in changeset.
Implement property class for the referenceline WTI-450

    • -9
    • +4
    ./FailureMechanismSectionsImporterTest.cs
  1. … 13 more files in changeset.
Replaced methods for properties for getting the start and end point of a section. WTI-1532

    • -4
    • +4
    ./FailureMechanismSectionsImporterTest.cs
  1. … 10 more files in changeset.
Cleanup of Ringtoets.Common.* Related to Issue [WTI-1463]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12775 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f9d9cdbb2feae87c9cca7154bfb0e630390ca220

Former-commit-id: 2ace285b026b153ffd67d17b506b409376d93638

    • -20
    • +18
    ./FailureMechanismSectionsImporterTest.cs
  1. … 89 more files in changeset.
Review related changes: - Extracted test utility for ProgressNotification

Related to Issue [WTI-1343]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11381 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d28613db354328981612c51a26a013d5644fc5ee

Former-commit-id: 977abba77a423c31d26bf0aada4704e777fe78cb

    • -23
    • +4
    ./FailureMechanismSectionsImporterTest.cs
  1. … 9 more files in changeset.
Updated resource( name)s Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10185 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: caa80ed0d43933a02165c1f2d3862399d7fc5370

Former-commit-id: 26e14907c3372f9a2083348f054a6a508ffe3f83

    • -2
    • +2
    ./FailureMechanismSectionsImporterTest.cs
  1. … 14 more files in changeset.
Updated license headers in ringtoets common. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9494 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ce33ce275ba930662636e02ef99d91e788db8757

Former-commit-id: 2a4583aeb892e314df72a61727f806c446493577

    • -1
    • +1
    ./FailureMechanismSectionsImporterTest.cs
  1. … 551 more files in changeset.
Removed code redudancies using code cleanup Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9430 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a4184612412083ad60d3a4e536abd67e2556054e

Former-commit-id: 88487e11184954b002f5e4adf51ca28ff8a1ad25

    • -3
    • +3
    ./FailureMechanismSectionsImporterTest.cs
  1. … 142 more files in changeset.
Code cleanup: Ringtoets.Common Ringtoets.DuneErosion Ringtoets.HydraRing Ringtoets.Integration Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9381 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0032433ea9de109c256ed5de15ebb145f6be74fc

Former-commit-id: b5477e384031933ad12287ee6958f4f68d7f9566

    • -98
    • +97
    ./FailureMechanismSectionsImporterTest.cs
  1. … 429 more files in changeset.
Incorporated comments review 1385: (Editorial) - Made the spelling of "Canceled" or "Uncancelable (opposed to "Cancelled" or "Uncancellable") consistent throughout the application.

Note:

"Cancellation" is legit U.S. spelling and therefore unchanged. "Cancelation" is not common and rarely used.

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7669 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 665e259f03237740e63d6441088354043dae52f2

Former-commit-id: 98c98ae04c081843c7bab2c55946744a8d06dad2

    • -1
    • +1
    ./FailureMechanismSectionsImporterTest.cs
  1. … 35 more files in changeset.
- Added NotifyProgress calls when adding data to the data model - Synchronised message values across all the importers

Note:

No tests are available to verify the cancel behaviour for the FeatureBasedMapData because it has no NotifyProgress (and consequently no SetProgress handle to set the Action it should execute during the import)

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7655 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ee82e9d839a1acfffb0ccb4ff219a30856c744e7

Former-commit-id: a79f8f2e64e63d1e9bac5672052dc8bc143bf91f

    • -2
    • +2
    ./FailureMechanismSectionsImporterTest.cs
  1. … 18 more files in changeset.
Implemented Reuse tests in the concrete implementations of the FileImporterBase Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7650 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d766c4944786409b114582323cf947d60e99337f

Former-commit-id: 0ff0cb1b31a88afc319a093050888e49cd2428f5

    • -1
    • +1
    ./FailureMechanismSectionsImporterTest.cs
  1. … 5 more files in changeset.
Merged revision(s) 7595-7638 from branches/WTI-490:

Merged revision(s) 7537-7594 from trunk

........

Initial commit of changes from kleijn:

- Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles

- Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage

- Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

........

Fixed tests of the FileImporterBase and Activity:

- Checks on the states are made for the 4 different paths of the Import:

-- Import successful, canceled or not

-- Import not successful, canceled or not

- Moved logging from the activity to the importer

- Added tests to assert mentioned behaviour

........

Fixed tests of the PipingSurfaceLinesCsvImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Added resource value for the ImportActivity (missing file commit)

........

Fixed tests of the PipingSoilProfilesImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned redundant brackets

........

Fixed tests of the StructuresImporter:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

Adjusted test in PipingSoilProfilesImporterTest

- Changed initial value of the result to make clear that the value is set correctly

........

Fixed tests of the ProfilesImporters:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Removed obsolete Cancel call in the PipingSoilProfilesImporterTest

........

FileImporters should call Observers in case the import was successfull AND was cancelled at an uncancellable stage.

Note: test is missing to verify this behaviour

........

Fixed tests of the ProfilesImporters:

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Temporarily removed the Cancel tests, because the FeatureBasedMapDataImporter does not have a handle for NotifyProgress. Hence, Cancel method cannot be invoked when Import is running.

........

Fixed tests of the FailureMechanismSectionsImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned up tests in the StructuresImporterTest

........

Fixed tests of the ReferenceLineImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

........

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7646 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1c355702dfbd410c7c4733529d8db9e243496eba

Former-commit-id: 75c614862d018947936ef85e3775a125c425c032

    • -1
    • +102
    ./FailureMechanismSectionsImporterTest.cs
  1. … 26 more files in changeset.
Fixed tests of the FailureMechanismSectionsImporter: - Added test to verify behaviour when canceling at the three stages during the import - Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned up tests in the StructuresImporterTest

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7636 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 23833a1f4ab3ad81a333e16378aed3b8bbbfc8dc

Former-commit-id: a49e8600ea0079ae498547eb7ea55a3832ed1292

    • -1
    • +102
    ./FailureMechanismSectionsImporterTest.cs
  1. … 2 more files in changeset.
Incorporated comments review 1319: - Updated resource values for the error messages to desired values Related to Issue [WTI-982]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7367 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 685dd38be45ff7a444c08c44157ff7708a8da416

Former-commit-id: 736742a1adc61f6956fcd02539acb5b0cb82102f

    • -4
    • +4
    ./FailureMechanismSectionsImporterTest.cs
  1. … 2 more files in changeset.