Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- Updated texts of ValidateFilePath Added method GetFullPath that throws only ArgumentExceptions Related to Issue [WTI-1060]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8270 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c17a15c75b90157638db91f8a04112cafacf43d8

Former-commit-id: 0eed903d451361194e8d2111d155a0755c633259

  1. … 31 more files in changeset.
Changed invocations of Path.GetInvalidFileNameChars() to Path.GetInvalidPathChars() where appropriate. Related to Issue [WTI-1060]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8252 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f68419a6786407fdbcab4cc9ecb6df2d38f9629f

Former-commit-id: 95c49baffa303369bbd953c0c443b1830e8f1bb0

  1. … 7 more files in changeset.
- Updated texts - Changed ValidateFilePath to write the chars Path.GetFileName validates against (Path.GetInvalidPathChars()) in its exception Related to Issue [WTI-1060]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8247 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2035c7d87c781c6d0cc8fa7a3fdd46eb85a9b7e1

Former-commit-id: 0bb23d23531231bb7c07834ec39505714bb049a7

  1. … 23 more files in changeset.
Added validation for Probability of StochasticSoilProfile. Added StochasticSoilmodelUpdateException. Provided base implementation of the DoPostImport (cancelable behavior) and an overridable DoPostImportUpdates to implement just the model updates. Added Strategy postfix to IStochasticSoilModelUpdateStrategy implementations. Fixed liskov issue with StochasticSoilModelUpdateDataStrategy. Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8026 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1b86b03430a8714c43abdb447dbf9a561426a94e

Former-commit-id: 781140c2712d3dd80e4e97c162a8455e54d8227d

  1. … 40 more files in changeset.
Incorporated comments review 1385: (Editorial) - Made the spelling of "Canceled" or "Uncancelable (opposed to "Cancelled" or "Uncancellable") consistent throughout the application.

Note:

"Cancellation" is legit U.S. spelling and therefore unchanged. "Cancelation" is not common and rarely used.

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7669 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 665e259f03237740e63d6441088354043dae52f2

Former-commit-id: 98c98ae04c081843c7bab2c55946744a8d06dad2

  1. … 35 more files in changeset.
Get rid of AffectedNonTargetObservableInstances property in FileImporterBase Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7661 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b4399ab53f7c2aac15418f5353df3a273c66df30

Former-commit-id: ad12f9acfead5c0cbdb94f1fdff36c99392b06e6

  1. … 3 more files in changeset.
- Added NotifyProgress calls when adding data to the data model - Synchronised message values across all the importers

Note:

No tests are available to verify the cancel behaviour for the FeatureBasedMapData because it has no NotifyProgress (and consequently no SetProgress handle to set the Action it should execute during the import)

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7655 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ee82e9d839a1acfffb0ccb4ff219a30856c744e7

Former-commit-id: a79f8f2e64e63d1e9bac5672052dc8bc143bf91f

  1. … 18 more files in changeset.
Implemented Reuse tests in the concrete implementations of the FileImporterBase Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7650 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d766c4944786409b114582323cf947d60e99337f

Former-commit-id: 0ff0cb1b31a88afc319a093050888e49cd2428f5

  1. … 5 more files in changeset.
Merged revision(s) 7595-7638 from branches/WTI-490:

Merged revision(s) 7537-7594 from trunk

........

Initial commit of changes from kleijn:

- Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles

- Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage

- Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

........

Fixed tests of the FileImporterBase and Activity:

- Checks on the states are made for the 4 different paths of the Import:

-- Import successful, canceled or not

-- Import not successful, canceled or not

- Moved logging from the activity to the importer

- Added tests to assert mentioned behaviour

........

Fixed tests of the PipingSurfaceLinesCsvImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Added resource value for the ImportActivity (missing file commit)

........

Fixed tests of the PipingSoilProfilesImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned redundant brackets

........

Fixed tests of the StructuresImporter:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

Adjusted test in PipingSoilProfilesImporterTest

- Changed initial value of the result to make clear that the value is set correctly

........

Fixed tests of the ProfilesImporters:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Removed obsolete Cancel call in the PipingSoilProfilesImporterTest

........

FileImporters should call Observers in case the import was successfull AND was cancelled at an uncancellable stage.

Note: test is missing to verify this behaviour

........

Fixed tests of the ProfilesImporters:

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Temporarily removed the Cancel tests, because the FeatureBasedMapDataImporter does not have a handle for NotifyProgress. Hence, Cancel method cannot be invoked when Import is running.

........

Fixed tests of the FailureMechanismSectionsImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned up tests in the StructuresImporterTest

........

Fixed tests of the ReferenceLineImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

........

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7646 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1c355702dfbd410c7c4733529d8db9e243496eba

Former-commit-id: 75c614862d018947936ef85e3775a125c425c032

  1. … 26 more files in changeset.
Fixed tests of the ReferenceLineImporter: - Added test to verify behaviour when canceling at the two stages during the import - Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7638 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 19a87c098521b229e4db615cca959bf60833a879

Former-commit-id: 5d08cb600da99361dde2bcf491347ed73ef603fc

  1. … 1 more file in changeset.
Reverted some changes Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7594 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 393a81aac4454cde27f7e6d667c125be4feb4c81

Former-commit-id: 9f0e2dd030a3f7922b3d222910b7f7c36eff6e02

  1. … 4 more files in changeset.
Ensured PostImportUpdates are also performed for import routines that are canceled Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7538 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e656c1c86281862b19fcbed4d24fb1ad93a27d17

Former-commit-id: 64de80ca92d93bfd541aabe98834020536dda166

  1. … 4 more files in changeset.
* Extended IReferenceLineReplaceHandler with DoPostReplacementUpdates to allow for actions to be resolved after the replacement of the ReferenceLine took place. ** Main reason behind this architectural choice, is allowing for UI updates from non-UI threads. ** ReferenceLineImporter makes use of this new method in the DoPostImportUpdates method. * ReferenceLineReplaceHandler now keeps track of deleted objects and closes views for those objects in the DoPostReplacementUpdates method. ** Introduced ClearResults class for this purpose. ** Updated DataSynchronisationService methods related to replacing the ReferenceLine and now keep track of both changed objects as well as removed objects. * Cleanup in some commands to use IViewCommands. Related to Issue [WTI-1034]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7494 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 239f69a11ed199f938d5dd31e76f60772ad40072

Former-commit-id: 9cb0286bb78c272cc2d2cb43b703d0fc9ad386f3

  1. … 56 more files in changeset.
* Fixed typos. * Refactored common code to new methods. * Fixed correct responsibility of filtering out duplicate observable notification. * Improved XML docs. * Improved returning all affected objects by some 'clear' methods of DataSynchronisationService classes. * Readded license header. * Simplified RhinoMock argument restraints. * Fixed test filename. * Fixed test structure of Integration tests conform coding conventions. Related to Issue [WTI-440]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6902 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 575f790757a486d0efa5b560c8170dc02cefb1f5

Former-commit-id: 8f94dd18882a6eaa65a1a9ca5592839b0d8b8084

  1. … 33 more files in changeset.
* Introduced IReferenceLineReplaceHandler and its implementation. ** Applied Dependency Injection on ReferenceLineImporter to abstract ReferenceLine replacement specifics (also removing dependencies such as View logic!) * Moved integration test data production methods to generally available location (new test project created for it) ** Created DataImportHelper class (Replaced several IntegrationTestHelper classes with identical implementation) Related to Issue [WTI-440]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6706 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 327965238ad610377b99e3b293193784bb2ef163

Former-commit-id: efce33cd742bfd09ba26d9337f1508223c8a2559

    • -413
    • +122
    ./ReferenceLineImporterTest.cs
  1. … 90 more files in changeset.
used lower case after colon when using FileReaderErrorMessageBuilder. Added FirstToLower method in StringExtensions. Related to Issue [WTI-948]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6693 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e9d3cccc3d91f565fc53bdfffabb2449c517437e

Former-commit-id: b80c97fbcc39c0000d0348fb5fa4591371f53bed

  1. … 55 more files in changeset.
* Added standard serialization constructor to all Exception classes. * Explicitly defined culture for string.Format methods. * Replaced IFileImporter.ProgressChanged property to method (recommendation by C# coding conventions) * Renamed classes containing win32.dll invokes to NativeMethods (recommendation by C# coding conventions)

Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6471 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 78fae4fb038935c7a58a0fb534baa750b173d589

Former-commit-id: fc7d0938a3677be66218915a3e665a9cc6757df9

  1. … 164 more files in changeset.
Changed "1" to "één" Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5946 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a3cae61bf48d3fabc629f3506a158e4614818e7c

Former-commit-id: 16c84742f1230a383219da4c555157b8fe649df2

  1. … 15 more files in changeset.
Merged revision(s) 5600 from branches/Release/16_2: Performed resharper code cleanup. Related to WTI 869

........

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5604 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1f5cdbd9c71ae2e15c1a8f780256c4d349800dac

Former-commit-id: ba09cc58d6bd919ea2d05d633cd306752a558bfe

  1. … 177 more files in changeset.
changes in review. paired by bos_en Related to Issue [WTI-576]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5529 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bdbc3b3233130eb0bfa1893a4d03a8770063d893

Former-commit-id: 6f3ce69fda788e55d8e40e0ff81d68fd3d5cb729

    • -0
    • +135
    ./ReferenceLineExporterTest.cs
    • -0
    • +757
    ./ReferenceLineImporterTest.cs
    • -0
    • +272
    ./ReferenceLineMetaImporterTest.cs
    • -0
    • +219
    ./ReferenceLineReaderTest.cs
    • -0
    • +188
    ./ReferenceLineWriterTest.cs
    • -0
    • +275
    ./ReferenceLinesMetaReaderTest.cs
  1. … 34 more files in changeset.