HeightStructuresCalculationServiceTest.cs

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Incorporated comment review 1874: - Renamed variable names to clearly indicate they represent a number and not a collection - Improved tests to prove that they do not clear data in case of HBN calculations - Changed Stubs to StrictMocks when applicable - (Re)added Exception message assert in the services when the calculator fails without exception, but with a last error file content

Paired with ~janssen

Related to Issue [WTI-1271]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10252 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3a74b3dcfd078d2bc5909421e41e00f603ddc770

Former-commit-id: f66dd962ef77db47c14ca1a7c2af8acc6286d68e

    • -0
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 7 more files in changeset.
Unified usage of StriktMocks in Services and Activities Related to Issue [WTI-1271]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10210 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cd6922e11680e7041ed43c598116776b9f48bec3

Former-commit-id: 146937d3fe3311562e2ef8ea2a354c80c2133665

    • -21
    • +21
    ./HeightStructuresCalculationServiceTest.cs
  1. … 25 more files in changeset.
Got rid of redundant time indication in log messages Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10197 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c368b8291325e52f7b84fcf7ebd622eb5b73d189

Former-commit-id: 6487f84142ebb802fbc312b4507c405f435cbe61

    • -33
    • +33
    ./HeightStructuresCalculationServiceTest.cs
  1. … 77 more files in changeset.
Updated to use mockRepository.Stub<IHydraRingCalculatorFactory>(): - HeightStructures Related to Issue [WTI-1271]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10158 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1a7d229ba8ab3d1f05eb5ab5b6ae23c372185142

Former-commit-id: 22919f14f5e74a399d90f3381de0c7966bbc1690

    • -23
    • +50
    ./HeightStructuresCalculationServiceTest.cs
  1. … 5 more files in changeset.
Updated license headers in HeightStructures. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9498 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6a54d7f7fe065a9b60f53104e2ac3a97103cd5b4

Former-commit-id: 59c7fce13fd3b10731f73f2b97e8138154a3b20f

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 113 more files in changeset.
Changed all local vars to consts if possible. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9448 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4684a5017b9aff9f6175f7d781cb29409f50a18e

Former-commit-id: 853c649ebc49a9513535e40ec705d5b928af0bc4

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 283 more files in changeset.
Code cleanup: Ringtoets.ClosingStructures Ringtoets.HeightStructures Ringtoets.StabilityPointStructures Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9390 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3f4503acaaefd0ce6c0cedf203052514f2e4c106

Former-commit-id: 0b20cb147ebd8f29f45b7034e47a99711b0e3187

    • -37
    • +37
    ./HeightStructuresCalculationServiceTest.cs
  1. … 109 more files in changeset.
Got rid of ringId in HydraRing calculations Related to Issue [WTI-1059]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8081 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4bc191fed1251037ae4eef4b56b7c26f9422f239

Former-commit-id: ba1406e780c01115aa545539afaef534ff495f40

    • -1
    • +0
    ./HeightStructuresCalculationServiceTest.cs
  1. … 73 more files in changeset.
Adapted some resources Related to Issue [WTI-1050]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7864 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 79a3ced3f781b25959e8fc3332ce56b93f1a2f0e

Former-commit-id: e68fc5f94054d41bd52be4a76511d885eabecefc

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 13 more files in changeset.
Adapted resource Related to Issue [WTI-1050]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7863 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b72845a31328c9f9b084acec26e4596fa83dc783

Former-commit-id: 8191af01979e4f40454788786a7fa70777677d3c

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 9 more files in changeset.
Fixed namings fixed ignored tests Related to Issue [WTI-1102]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7795 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8381062b22facd7562bdbb67c9ffe123905955cd

Former-commit-id: 33b0a6969bd5a0d4102d02761cbb6e1011e52a01

    • -2
    • +2
    ./HeightStructuresCalculationServiceTest.cs
  1. … 16 more files in changeset.
Merged revision(s) 7773 from branches/Release/16_4: Changed type of *WidthFlowApertures* (Breedte van doorstroomopening) from CoefficientOfVariation to StandardDeviation note: storage change (names of the columns) has not yet been executed

Removed Application.Ringtoets/Application.Ringtoets.csproj post build action, which was needed for MSBuild2015

........

Related to Issue [WTI-1102]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7794 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 342282b213d520bc60ebd90113af4ab47b1c929d

Former-commit-id: 91abb8a151c800d1c462c52940cdfb3a8c7bb08d

    • -19
    • +20
    ./HeightStructuresCalculationServiceTest.cs
  1. … 70 more files in changeset.
Fixed two ignored tests Related to Issue [WTI-1102]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/16_4@7784 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5a9dd39b8b5546e82cecad025f9dd1009831b2b3

Former-commit-id: 9902902b1ed6de561fd90892f033da4338bcccb7

    • -2
    • +2
    ./HeightStructuresCalculationServiceTest.cs
* Reformatted C# 6.0 code to code patterns compatible before C# 6.0 Related to Issue [WTI-1058]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/16_4@7781 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5594b25edc81838facacccfdef2065a6c20304e6

Former-commit-id: d609e70ea13237b79eb634b26215b09d8d9e552e

    • -4
    • +4
    ./HeightStructuresCalculationServiceTest.cs
  1. … 13 more files in changeset.
Merged revision(s) 7770-7772 from branches/Release/16_4

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7775 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3573fbef3cb5a89f0722ceef8cd183f1920fe663

Former-commit-id: d79a40a94fc31ab868d173f60de590cac0fbee30

    • -8
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 41 more files in changeset.
Changed type of *WidthFlowApertures* (Breedte van doorstroomopening) from CoefficientOfVariation to StandardDeviation note: storage change (names of the columns) has not yet been executed

Removed Application.Ringtoets/Application.Ringtoets.csproj post build action, which was needed for MSBuild2015

Related to Issue [WTI-1102]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/16_4@7773 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9a076019f5caf170d779ad16f8f1c8188e9a39a3

Former-commit-id: 068fa68d9844c31b4cd81c4ff74cb1f47ab2d245

    • -23
    • +24
    ./HeightStructuresCalculationServiceTest.cs
  1. … 60 more files in changeset.
- Removed FailureMechanismSection from structure calculations. - Refactored those inputs so only the section normal is passed. Related to Issue [WTI-1058]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/16_4@7772 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6c0bdf4e704ece33df577ce94f29d6b7de1e8abf

Former-commit-id: c16ae42acda7aa160a2a7af14cea1915bafb78b6

    • -8
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 28 more files in changeset.
Refactored HydraRingCalculatorBase so it will only throw one exception. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7640 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a6de8a1ad179588f61a471c820b522033db66125

Former-commit-id: dbe8dc7f4c11ca209636bc2288143268ef5d8149

    • -2
    • +2
    ./HeightStructuresCalculationServiceTest.cs
  1. … 32 more files in changeset.
Added null checks and documentation in height structures calculation service. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7597 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ac75354b641fed54c3aac29476b3e4ea6eee9b10

Former-commit-id: a3c5ec0f83e92f501192da0ede81c6181d033f67

    • -44
    • +136
    ./HeightStructuresCalculationServiceTest.cs
  1. … 2 more files in changeset.
Performed Resharper cleanup

Related to Issue [WTI-1008]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7334 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 23d17fd6b5257a25b167839d9106eea6fa7be554

Former-commit-id: 4a817a07bc646924777514e78010c89bc0fdf9b5

    • -4
    • +4
    ./HeightStructuresCalculationServiceTest.cs
  1. … 114 more files in changeset.
* Moved HydraulicBoundaryLocation and related classes from HydraRing.Data to Ringtoets.Common.Data\Hydraulics * Removed HydraRing.Data and related test projects. * Moved importer related test data from HydraRing.IO to Ringtoets.Common.IO Related to Issue [WTI-988]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7087 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 17347220df48d78521b65d257dde9b4ffdace273

Former-commit-id: dc5ddfa6d8f3719bd2dd4a2f62ed94f98f962499

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 426 more files in changeset.
Incorporated comments review 1247: - Replaced StringAssert.StartsWith() with Assert.AreEqual when the validation message is fully defined Related to Issue [WTI-1014]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7062 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 43f3524ffa759adc37251c21f078ace17169341d

Former-commit-id: 0f6084e023a53b8c5c9fb44bdbce92519e4b4fd0

    • -7
    • +7
    ./HeightStructuresCalculationServiceTest.cs
  1. … 9 more files in changeset.
Incorporated comments review 1193

Paired with tangerma

Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6624 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8bb152605c66a45e95674b6c3cdf1de51116c3fc

Former-commit-id: cead6acfbad775228a8299b94dc07606827559d2

    • -0
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 12 more files in changeset.
Changed resources. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6601 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 43d9cfc59bafef1364ebf1e1ddaa20f6aa269bff

Former-commit-id: 200bf614d14ecd5f4fb2cc59b3da8a95e026f75a

    • -5
    • +7
    ./HeightStructuresCalculationServiceTest.cs
  1. … 46 more files in changeset.
Implemented HydraRingCalculationException in services. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6600 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b3d26fca1deff9d97c3b4fdcdd6e91bb5e487034

Former-commit-id: 1d88356f353578ef2409f223ce86e5fe467280c0

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 18 more files in changeset.
Moved HydraRingFileParserException to separate folder. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6597 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 161b72b8d2f4cca558d2cfa741731ccac9fb3401

Former-commit-id: 801650177c3694c17344ee7da5f9fb38b3335296

    • -2
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 33 more files in changeset.
Changes after review. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6592 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 201e5b35b093ae9c9665a9382ec24d081b30b051

Former-commit-id: ebcf817df7eb0524c49390febe9611d8eb5297e7

    • -22
    • +8
    ./HeightStructuresCalculationServiceTest.cs
  1. … 22 more files in changeset.
Improved service tests. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6587 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 835174f73ab06d5fc1297901d5c35d3f8e81214e

Former-commit-id: 6602b39fecdabc78fd5ded02be88684aa087cac1

    • -38
    • +37
    ./HeightStructuresCalculationServiceTest.cs
  1. … 7 more files in changeset.
Renamed property. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6579 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: daa9b5eceb67c9a8c89aba6a57de98def278f7a4

Former-commit-id: e4b18b0d55435557fc6e84e3492a334e60aa36f4

    • -3
    • +3
    ./HeightStructuresCalculationServiceTest.cs
  1. … 34 more files in changeset.
Incorporated comments review 1176

Paired with janssen

Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6532 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: caf6ee7611042698e1c3825f88054cdc6d2c419e

Former-commit-id: aa9603d60888fe2b9df0424071acb03e28bd446e

    • -8
    • +8
    ./HeightStructuresCalculationServiceTest.cs
  1. … 11 more files in changeset.