Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Incorporated comments review 1176

Paired with janssen

Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6532 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: caf6ee7611042698e1c3825f88054cdc6d2c419e

Former-commit-id: aa9603d60888fe2b9df0424071acb03e28bd446e

    • -8
    • +8
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 11 more files in changeset.
Removed redundant methods from data synchronization services. Related to Issue [WTI-953]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6508 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5dbc949e5cff76790b5d922b08d9b6c152e717a3

Former-commit-id: 2227e5be594b1c8c70dea16904feb5d0cdc9e7d6

    • -55
    • +0
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresDataSynchronizationServiceTest.cs
  1. … 9 more files in changeset.
Fixed small typo

Paired with berg_jl

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6507 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7734f6d696cf3b3f556a516f0966ad57807970b0

Former-commit-id: 59193f76becc4d550dbd79ebb0bc12780cc0c07b

    • -1
    • +1
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 10 more files in changeset.
Fixed small typo (standaard afwijking => standaardafwijking)

Paired with berg_jl

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6502 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 56ed4e1552ad59d7ce464eafc598e089e1f6487d

Former-commit-id: cbab0bcec3ba2be730d70c7dde281e1b4610664a

    • -1
    • +1
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 10 more files in changeset.
Deltares clean-up Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6498 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 63ac7722f8d3890848384ee20816ead3f90cb796

Former-commit-id: d2a9cf4a79400ddb42314b6db73f84ca256b0dc2

    • -2
    • +3
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 25 more files in changeset.
Ensured DeviationWaveDirection is no longer checked during validation Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6497 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 190d34210194dd97a3fcf7c3c12bd40e28e40e43

Former-commit-id: cf1fe0a506ab7ed913be7990c0b660e1f2271625

    • -45
    • +0
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 5 more files in changeset.
Ensured DeviationWaveDirection is no longer visible in interface for height structures Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6495 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e2ce2906e7f385590e3675c64562529bb7d950ae

Former-commit-id: ec065b9245b56e40670d6c6ea07e33d353dbaefc

    • -50
    • +1
    ./Ringtoets.HeightStructures.Forms.Test/PropertyClasses/HeightStructuresInputContextPropertiesTest.cs
  1. … 1 more file in changeset.
Replaced 'occured' with 'occurred'. Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6494 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3df71d574a05c6231d4e6368a358ebd06dc26e26

Former-commit-id: 051ae9c5619ba7837e9e41d24440044e9d962130

    • -2
    • +2
    ./Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
    • -2
    • +2
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 24 more files in changeset.
Moved test data around. Added test for invalid settings databases. Related to Issue [WTI-919]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6490 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 46f9c6e4be7dbbb2998ba083bc9981e38208ee37

Former-commit-id: f22e9626a59acc2e51422dfc525d0774d9595e6a

    • -1
    • +1
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresCalculationContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
  1. … 50 more files in changeset.
Fixed failing test Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6489 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fb6d190bf51423f16454da8818c0e7be16db4cf3

Former-commit-id: 9c06e4e15f0ba9fee068d934b7cc30e32d0cbadc

    • -3
    • +5
    ./Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
Adapted some default values Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6484 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b29b1f97725ff29de370212d731045de4e675f79

Former-commit-id: e646b5368aa8557f4eb88b08d762fc0999ac99e2

    • -1
    • +1
    ./Ringtoets.HeightStructures.Data.Test/HeightStructuresInputTest.cs
  1. … 6 more files in changeset.
Added calculatorConfig in tests for height structures.

Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6482 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9b30ce17a09cbdc9a1923ed2e1e1054f98eecbbc

Former-commit-id: 59fb43b7b8f51e32c84768ec4c5713f900b168f8

    • -1
    • +0
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresCalculationContextTreeNodeInfoTest.cs
    • -1
    • +4
    ./Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
(Editorial) - Added missing license headers - Reformatted some of the *.config files in case no return was present between the XML header and license information

Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6479 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5dfd4dc63c35031adc767ea3a2c4f4e24d7ed898

Former-commit-id: 0f3568dc4158e992538fd5781ff0ab0d52355d37

    • -1
    • +0
    ./Ringtoets.HeightStructures.IO.Test/packages.config
    • -1
    • +1
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 40 more files in changeset.
Test successful calculation instead of failing calculations. Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6472 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d4d46f20b80b959db39a9a1adee1529e0fa027b5

Former-commit-id: 05916c31c249c2fc37da0e0b2d3e70a1047b9ff1

    • -11
    • +11
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresCalculationContextTreeNodeInfoTest.cs
  1. … 4 more files in changeset.
Improved test expectancies Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6470 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: dfb8ce832a0f99a474ba54c16ec007ccaccecb07

Former-commit-id: a5350f2b53c0fc2a616caa15cd2b766b6ac715de

    • -2
    • +6
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -5
    • +8
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
  1. … 4 more files in changeset.
Ensure "Copy Local" is correctly set for all project references.

Paired with janssen

Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6460 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1a285b893488098d515aa5e5827909e39345af9e

Former-commit-id: 96fea1b85e27ae87d361d5996d7a6d16181edd0e

    • -1
    • +1
    ./Ringtoets.HeightStructures.Forms.Test/Ringtoets.HeightStructures.Forms.Test.csproj
  1. … 7 more files in changeset.
Added test for services using the HydraRingSettingsDatabaseHelper Related to Issue [WTI-919]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6452 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7e69bec547d97e77540c5c128421d413a3116521

Former-commit-id: a9588924ffe691742b90ef373d2edc330773ff4b

    • -11
    • +32
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 2 more files in changeset.
Added all calls to AssignSettingsFromDatabase after creating hydraring input. Related to Issue [WTI-919]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6449 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6dc58dbacc0c160612e1593471f38971a56a96c0

Former-commit-id: d9cfd13f1005f553e6d1fa17ee5249dc1e1ede0a

    • -17
    • +7
    ./Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
    • -1
    • +1
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationActivityTest.cs
    • -20
    • +16
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 13 more files in changeset.
* minor code cleanup Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6440 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d44d886c2d596cbbd8749e46b4bc0b35d341b6bd

Former-commit-id: ebb371cb01e4f3df4d14384e775ea76ee6791f1c

    • -2
    • +2
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
  1. … 2 more files in changeset.
Removed some redundant tests Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6437 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 95963ab254b28306a21d22fcacd0d89e56d4f98e

Former-commit-id: 4dcc096ba17e53f7f9949cd8636a0d5079ae439e

    • -71
    • +12
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 2 more files in changeset.
- Check the code coverage configuration of the trunk Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6436 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 60655265b27b5521f0a53b0998b9ce77e069342f

Former-commit-id: e0560a24c08e4583c331a82ea5348baac1a32bfe

    • -0
    • +1
    ./Ringtoets.HeightStructures.Data.Test/Ringtoets.HeightStructures.Data.Test.csproj
    • -0
    • +1
    ./Ringtoets.HeightStructures.Data.TestUtil.Test/Ringtoets.HeightStructures.Data.TestUtil.Test.csproj
    • -0
    • +1
    ./Ringtoets.HeightStructures.Data.TestUtil/Ringtoets.HeightStructures.Data.TestUtil.csproj
    • -0
    • +1
    ./Ringtoets.HeightStructures.Forms.Test/Ringtoets.HeightStructures.Forms.Test.csproj
    • -0
    • +1
    ./Ringtoets.HeightStructures.IO.Test/Ringtoets.HeightStructures.IO.Test.csproj
    • -0
    • +1
    ./Ringtoets.HeightStructures.Integration.Test/Ringtoets.HeightStructures.Integration.Test.csproj
    • -0
    • +1
    ./Ringtoets.HeightStructures.Plugin.Test/Ringtoets.HeightStructures.Plugin.Test.csproj
    • -0
    • +1
    ./Ringtoets.HeightStructures.Service.Test/Ringtoets.HeightStructures.Service.Test.csproj
    • -0
    • +1
    ./Ringtoets.HeightStructures.Utils.Test/Ringtoets.HeightStructures.Utils.Test.csproj
  1. … 89 more files in changeset.
Applied some improvements in the activity integration tests Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6435 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 29210b0c81cdd1e9c7fb7c401c7fd80e5c94435e

Former-commit-id: a231a0663ef672ab43e92971c987524f15367fb3

    • -1
    • +1
    ./Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
  1. … 3 more files in changeset.
Improved some tests by using HydraRingCalculatorFactoryConfig Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6433 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6c5050d367dc6bdad9949e1a50fa886adfd3eec6

Former-commit-id: b77180387a52de6d5b288daa4726cc7a2a962bc8

    • -20
    • +27
    ./Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
  1. … 2 more files in changeset.
Implemented Hydra-Ring last error handling for design water level and wave height calculations. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6432 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 10f638c45567137de2ed26df79672a7d312f63b9

Former-commit-id: 6045ac9c0b334c42998114ca85516d09a41bcd24

    • -0
    • +3
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 23 more files in changeset.
Improved some tests by using HydraRingCalculatorFactoryConfig Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6429 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f09c1dd27fb560a56694125e29550ef09dc0fb6c

Former-commit-id: d1df8637395dbb481b15047725abb967bc38917f

    • -0
    • +4
    ./Ringtoets.HeightStructures.Forms.Test/Ringtoets.HeightStructures.Forms.Test.csproj
    • -1
    • +7
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresCalculationContextTreeNodeInfoTest.cs
    • -12
    • +12
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -12
    • +12
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
  1. … 11 more files in changeset.
Incorporated review comments: - Editorial changes: moved lines around to improve consistency. Checked for similar tests across the Structures - Extracted function to retrieve validation rules depending on the calculation type in ClosingStructuresCalculationService - Changed parameter names

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6407 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e1580d2ed171698fd39b5bc43af134da09314a84

Former-commit-id: f5567d00dde1ac54ef7a753d24bc7c9d73dc1ff8

    • -8
    • +8
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
  1. … 8 more files in changeset.
Deltares clean-up for Ringtoets.HeightStructures Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6398 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 833c29cff59857b9765986d45ba62a90f0355883

Former-commit-id: 806406b6048b92edff660777125323394608cd76

    • -31
    • +31
    ./Ringtoets.HeightStructures.Data.Test/HeightStructuresInputTest.cs
    • -1
    • +0
    ./Ringtoets.HeightStructures.Forms.Test/PropertyClasses/HeightStructuresFailureMechanismPropertiesTest.cs
    • -3
    • +3
    ./Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresScenariosViewTest.cs
    • -6
    • +6
    ./Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
    • -11
    • +9
    ./Ringtoets.HeightStructures.Integration.Test/HeightStructuresScenariosViewIntegrationTest.cs
    • -1
    • +1
    ./Ringtoets.HeightStructures.Plugin.Test/ImportInfos/HeightStructuresContextImportInfoTest.cs
    • -12
    • +12
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 1 more file in changeset.
Incorporated review comments: - Removed Structure = new TestStructure() when TestCalculation objects are instantiated - Made type explicit when AssessmentSectionHelper.CreateAssessmentSectionStub is called - Fixed XML doc and formatting

Paired with tangerma

Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6395 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d63d3fe96336f31ad5d09f7e67078d2b07f12a95

Former-commit-id: 1b542c41b612011988665c20d48a6f2be23e3f28

    • -24
    • +19
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 10 more files in changeset.
Implemented Hydra-Ring last error handling for stability point structures.

Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6388 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 26ae25adbeac0fd981f4dda93e7b2758624e97e7

Former-commit-id: 9e2a2d9f392d316bcfdabfddadcb6e35b160bfef

    • -3
    • +2
    ./Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
  1. … 11 more files in changeset.
Implemented Hydra-Ring last error handling for height structures.

Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6385 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fd80f11b26b148da951d580a6d2a6089f0dea398

Former-commit-id: 89c17a9c27bb3285ee9cf58df1847604a47ed5e4

    • -0
    • +1
    ./Ringtoets.HeightStructures.Data.TestUtil.Test/TestHeightStructuresCalculationTest.cs
    • -0
    • +1
    ./Ringtoets.HeightStructures.Data.TestUtil/TestHeightStructuresCalculation.cs
    • -2
    • +2
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -2
    • +2
    ./Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -0
    • +110
    ./Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
    • -0
    • +190
    ./Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  1. … 5 more files in changeset.