Riskeer / Ringtoets

HeightStructures

Clone Tools

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Jul 2017
12:00 pm

Robert Tangerman <robert.tangerman@deltares.nl>

- Moved cancel method to base. - Refactored perform calculation method. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10648 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 319e32471cff41243febb3a7de2305040ffcf9f7

Former-commit-id: f4523a3c6b43ef344678bd39d1f2d5664751db8e

Options
    • -86
    • +39
    ./src/Ringtoets.HeightStructures.Service/HeightStructuresCalculationService.cs
    • -46
    • +0
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  3. … 6 more files in changeset.
10:42 am

Robert Tangerman <robert.tangerman@deltares.nl>

Refactores structure calculators to one calculator. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10642 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 070ae3378d0b61127160dbf3fc3b722b6f361c06

Former-commit-id: 9e0b0d6e749192b868c914aa53797a482098ee9e

Options
    • -2
    • +2
    ./src/Ringtoets.HeightStructures.Service/HeightStructuresCalculationService.cs
    • -6
    • +9
    ./test/Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
    • -1
    • +3
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationContextTreeNodeInfoTest.cs
    • -2
    • +3
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -2
    • +3
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -14
    • +14
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  7. … 29 more files in changeset.
9:12 am

Robert Tangerman <robert.tangerman@deltares.nl>

Refactored getting the calculation input. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10640 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 49287039b12c4b602c7989e2bcc564b9d646a3a1

Former-commit-id: 0614817094806a73d321be4b1f4bd0c82c2e0882

Options
    • -23
    • +7
    ./src/Ringtoets.HeightStructures.Service/HeightStructuresCalculationService.cs
    • -1
    • +1
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  3. … 6 more files in changeset.
8:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added calculate method with null checks to the StructuresCalculationServiceBase Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10636 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5dcc87c7f4ac386f10b4c18b41f99f06b4bf11fe

Former-commit-id: 93fd51170d798af95d9709f9d7943391e621f30f

Options
    • -17
    • +7
    ./src/Ringtoets.HeightStructures.Service/HeightStructuresCalculationService.cs
    • -63
    • +2
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  3. … 6 more files in changeset.
Tuesday 11 Jul 2017
2:53 pm

Robert Tangerman <robert.tangerman@deltares.nl>

- Implemented validate method in StructuresCalculationServiceBase. - Refactored all depending calculation services. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10629 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: eacc84c9546683908cc316390f0f9fbcc83f4b84

Former-commit-id: ce6af66ecff89a16568da6283a30bdc97de7a3db

Options
    • -95
    • +1
    ./src/Ringtoets.HeightStructures.Service/HeightStructuresCalculationService.cs
    • -167
    • +1
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  3. … 12 more files in changeset.
12:38 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Merged revision(s) from branches/WTI-1353

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10621 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e3f6c4a34585f3c0586f2c382ec6556441ee4c39

Former-commit-id: 78e7789d6b0ff7bf8b04e3a1cf63baad89575e18

Options
    • -0
    • +67
    ./src/Ringtoets.HeightStructures.Service/HeightStructuresValidationRulesRegistry.cs
    • -0
    • +1
    ./src/Ringtoets.HeightStructures.Service/Ringtoets.HeightStructures.Service.csproj
    • -0
    • +83
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresValidationRulesRegistryTest.cs
    • -0
    • +1
    ./test/Ringtoets.HeightStructures.Service.Test/Ringtoets.HeightStructures.Service.Test.csproj
  5. … 6 more files in changeset.
Monday 10 Jul 2017
3:10 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented validation rules registry for height structures. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-1353@10599 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7ba00e8571f10a6f26b65d6584bfd0ab43780e8f

Former-commit-id: d710ae844ca66455d292f8cf1a770bd853f3587d

Options
    • -0
    • +67
    ./src/Ringtoets.HeightStructures.Service/HeightStructuresValidationRulesRegistry.cs
    • -0
    • +1
    ./src/Ringtoets.HeightStructures.Service/Ringtoets.HeightStructures.Service.csproj
    • -0
    • +83
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresValidationRulesRegistryTest.cs
    • -0
    • +1
    ./test/Ringtoets.HeightStructures.Service.Test/Ringtoets.HeightStructures.Service.Test.csproj
  5. … 2 more files in changeset.
11:30 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced a StructuresOutput object: - Incorporated the StructuresOutput in the structures data structure - Updated affected services, Create and Read extensions

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10589 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 64ffbc00b2e927cbf1c3697e577697c3a12faf46

Former-commit-id: a7c4a8101d7e0566f03dc310c6553eddd52e242d

Options
    • -1
    • +1
    ./src/Ringtoets.HeightStructures.Data/HeightStructuresFailureMechanismSectionResult.cs
    • -4
    • +7
    ./src/Ringtoets.HeightStructures.Service/HeightStructuresCalculationService.cs
    • -2
    • +4
    ./test/Ringtoets.HeightStructures.Data.Test/HeightStructuresFailureMechanismSectionResultTest.cs
    • -6
    • +6
    ./test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismResultViewTest.cs
    • -3
    • +4
    ./test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismSectionResultRowTest.cs
    • -4
    • +5
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationContextTreeNodeInfoTest.cs
    • -7
    • +7
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresDataSynchronizationServiceTest.cs
  8. … 28 more files in changeset.
Friday 07 Jul 2017
2:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Extended StructureInputBase with a property ShouldIllustrationPointsBeCalculated: - Extended corresponding input class as well: property should always appear at the bottom (last item in the property info) Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10584 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 604435166824e4af22c8d6b5abec94f07391ad66

Former-commit-id: 68b19731d552d98264a707c445848c6e9add2aa3

Options
    • -1
    • +2
    ./test/Ringtoets.HeightStructures.Forms.Test/PropertyClasses/HeightStructuresInputContextPropertiesTest.cs
  2. … 8 more files in changeset.
9:56 am

Elmar Kleijn

Introduced StructuresCalculationServiceBase Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10580 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1f6d248b8179af6a9078b63bafc15d2818d32465

Former-commit-id: bbf53a7ff4361c1b8c388201a7639ee725fde530

Options
    • -2
    • +3
    ./src/Ringtoets.HeightStructures.Service/HeightStructuresCalculationService.cs
    • -0
    • +11
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  3. … 6 more files in changeset.
Monday 03 Jul 2017
4:00 pm

Elmar Kleijn

Adapted ExportInfo names Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10539 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 085068b47c31a5e26279ea7cd27fe53e4505b94d

Former-commit-id: 9b405e1393df991b8e1ce131bd72b7002b45ecbf

Options
    • -1
    • +1
    ./test/Ringtoets.HeightStructures.Plugin.Test/ExportInfos/HeightStructuresCalculationContextExportInfoTest.cs
    • -1
    • +1
    ./test/Ringtoets.HeightStructures.Plugin.Test/ExportInfos/HeightStructuresCalculationGroupContextExportInfoTest.cs
  3. … 27 more files in changeset.
Friday 30 Jun 2017
9:12 am

Elmar Kleijn

Improved log messaging (removed duplication on calculation names and others) Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10512 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7f80d5d4b3fe2cb329fc7a00666f09e0858a333c

Former-commit-id: 6a5fe69c43427946827b8a6ee1455e1649475356

Options
    • -4
    • +4
    ./src/Ringtoets.HeightStructures.Service/HeightStructuresCalculationService.cs
    • -2
    • +2
    ./src/Ringtoets.HeightStructures.Service/Properties/Resources.Designer.cs
    • -2
    • +2
    ./src/Ringtoets.HeightStructures.Service/Properties/Resources.resx
    • -6
    • +6
    ./test/Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
    • -6
    • +6
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationContextTreeNodeInfoTest.cs
    • -12
    • +13
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -12
    • +13
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -37
    • +35
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  9. … 93 more files in changeset.
Thursday 29 Jun 2017
4:04 pm

Elmar Kleijn

Ensured activities always produce a start message Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10508 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4086bbc704fa8a2619493fc89ba1df166f2ba331

Former-commit-id: 5c9cad2e7ac939b5a3a2dcded3a09c6b784a0c94

Options
    • -10
    • +12
    ./test/Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
    • -7
    • +8
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationContextTreeNodeInfoTest.cs
    • -13
    • +15
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -13
    • +15
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
  5. … 50 more files in changeset.
Tuesday 27 Jun 2017
1:13 pm

Elmar Kleijn

Extended validation and calculation related log messages Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10475 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fa73d0b98b4ad7f339d76bb51f1f8c1a54595a13

Former-commit-id: f7874c6fe8426c9d0fc4f2ff32d293e96073407e

Options
    • -12
    • +12
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -12
    • +12
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
  3. … 37 more files in changeset.
Wednesday 21 Jun 2017
4:38 pm

Marten Janssen <marten.janssen@deltares.nl>

Updated data model such that only interfaces of HydraulicBoundaryLocation are used

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-1303%20with%20IHydraulicBoundaryLocation@10393 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 510970323f90fee3fd374da7747633bbaa353c5a

Former-commit-id: e49b00fbf98884ee9efb5c3facbb4cc100be8abb

Options
    • -3
    • +3
    ./src/Ringtoets.HeightStructures.IO/Configurations/HeightStructuresCalculationConfigurationImporter.cs
  2. … 37 more files in changeset.
Tuesday 20 Jun 2017
1:09 pm

Joël van den Berg

minor changes, making test more strict Related to Issue [WTI-1132]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10373 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 93b4878917c3abf6ae6b262e71fbf388fedbf1f5

Former-commit-id: 2ce3c76d3e86cbcb4ff02c4be05157b9185f6313

Options
    • -1
    • +1
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  2. … 9 more files in changeset.
Thursday 15 Jun 2017
4:42 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated XML Docs Related to Issue [WTI-1281]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10319 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7d721c0085959e2036c9560edf5bbae0d161a612

Former-commit-id: 6ae5865637aa3da90776989da3f7348878f85bef

Options
    • -0
    • +11
    ./src/Ringtoets.HeightStructures.IO/HeightStructuresImporter.cs
  2. … 2 more files in changeset.
3:46 pm

Dennis Tang <dennis.tang@deltares.nl>

Added functional tests for the importers to verify behaviour when: - All relevant structure parameters are missing and a duplicate irrelevant parameter is present - Some parameters are missing and a duplicate irrelevant parameter is present - Moved test-data files to their respective folders to clearly indicate what they represent Related to Issue [WTI-1281]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10316 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cabe56098ff78344893ffe12fe5cc8a10a4cf0a5

Former-commit-id: ca0d668356f92be1209e15b4adcbc22709db9a45

Options
    • -3
    • +107
    ./test/Ringtoets.HeightStructures.IO.Test/HeightStructuresImporterTest.cs
    • -6
    • +0
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/Kunstwerken.csv
    • binary
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/Kunstwerken.dbf
    • -1
    • +0
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/Kunstwerken.prj
    • binary
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/Kunstwerken.shp
    • binary
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/Kunstwerken.shx
    • -0
    • +8
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/MissingAndDuplicateIrrelevantParameters/Kunstwerken.csv
    • binary
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/MissingAndDuplicateIrrelevantParameters/Kunstwerken.dbf
    • -0
    • +1
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/MissingAndDuplicateIrrelevantParameters/Kunstwerken.prj
    • binary
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/MissingAndDuplicateIrrelevantParameters/Kunstwerken.shp
    • binary
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/MissingAndDuplicateIrrelevantParameters/Kunstwerken.shx
    • -0
    • +6
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/MissingParameters/Kunstwerken.csv
    • binary
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/MissingParameters/Kunstwerken.dbf
    • -0
    • +1
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/MissingParameters/Kunstwerken.prj
    • binary
    ./test/Ringtoets.HeightStructures.IO.Test/test-data/HeightStructuresImporter/MissingParameters/Kunstwerken.shp
  16. … 37 more files in changeset.
2:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented the filter of the structure parameter rows: - Added test which contains a single structure where all the relevant parameters are defined including a duplicate irrelevant/undefined parameter Related to Issue [WTI-1281]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10308 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cb915214bb014caab8ff12c106beeb65ef09b271

Former-commit-id: 9df1c3bfc0b2339bb0f2396bf0cd35970b32fdce

Options
    • -1
    • +3
    ./src/Ringtoets.HeightStructures.IO/HeightStructuresImporter.cs
    • -0
    • +42
    ./test/Ringtoets.HeightStructures.IO.Test/HeightStructuresImporterTest.cs
  3. … 8 more files in changeset.
10:58 am

Dennis Tang <dennis.tang@deltares.nl>

Added functional tests for the UpdateDataStrategies for the Structures related failure mechanisms Related to Issue [WTI-1331]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10298 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ba3a2b875987a5c526ae3f3347b8eb911b4b9758

Former-commit-id: 41e144449015968fd1ec86c0fe2d1505ce19253d

Options
    • -0
    • +66
    ./test/Ringtoets.HeightStructures.Plugin.Test/FileImporters/HeightStructureUpdateDataStrategyTest.cs
  2. … 2 more files in changeset.
Friday 09 Jun 2017
11:34 am

Elmar Kleijn

Review related changes Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10259 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a8d4c2d5af821c90f435710462ec8a5052e4c8fa

Former-commit-id: c0cdd50de3513b86395bba31381872b157d28648

Options
    • -3
    • +3
    ./src/Ringtoets.HeightStructures.Service/HeightStructuresCalculationService.cs
    • -7
    • +7
    ./src/Ringtoets.HeightStructures.Service/Properties/Resources.Designer.cs
    • -2
    • +2
    ./src/Ringtoets.HeightStructures.Service/Properties/Resources.resx
  4. … 22 more files in changeset.
Thursday 08 Jun 2017
5:29 pm

Joël van den Berg

Extracted methods for asserting validation and calculations start and end messages. Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10254 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 800138c6ae1e8954eeb1d3be81d23bfe161a622f

Former-commit-id: 0283b091686a545589ac4f2d957165b7cf704cb4

Options
    • -6
    • +7
    ./test/Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
    • -0
    • +4
    ./test/Ringtoets.HeightStructures.Integration.Test/Ringtoets.HeightStructures.Integration.Test.csproj
    • -0
    • +4
    ./test/Ringtoets.HeightStructures.Plugin.Test/Ringtoets.HeightStructures.Plugin.Test.csproj
    • -6
    • +7
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationContextTreeNodeInfoTest.cs
    • -32
    • +33
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
    • -0
    • +4
    ./test/Ringtoets.HeightStructures.Service.Test/Ringtoets.HeightStructures.Service.Test.csproj
  7. … 61 more files in changeset.
3:31 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comment review 1874: - Renamed variable names to clearly indicate they represent a number and not a collection - Improved tests to prove that they do not clear data in case of HBN calculations - Changed Stubs to StrictMocks when applicable - (Re)added Exception message assert in the services when the calculator fails without exception, but with a last error file content

Paired with ~janssen

Related to Issue [WTI-1271]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10252 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3a74b3dcfd078d2bc5909421e41e00f603ddc770

Former-commit-id: f66dd962ef77db47c14ca1a7c2af8acc6286d68e

Options
    • -0
    • +1
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  2. … 7 more files in changeset.
10:42 am

Marten Janssen <marten.janssen@deltares.nl>

Added tests Renamed tests Related to Issue [WTI-1221]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10242 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2603839a19138e7d77a2aeb2c5fdc6063851b9a4

Former-commit-id: 022a61f50f397337e57ff3b46b2220aeb63e6bd9

Options
    • -0
    • +13
    ./test/Ringtoets.HeightStructures.IO.Test/Configurations/HeightStructuresCalculationConfigurationTest.cs
  2. … 8 more files in changeset.
10:11 am

Marten Janssen <marten.janssen@deltares.nl>

Unified public/internal renamed method Related to Issue [WTI-1221]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10241 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e983e434ff6859419e7a65d179cb96ea057e4cf1

Former-commit-id: e3435687a96947951606b10f60b83a7b00c7f297

Options
    • -1
    • +1
    ./src/Ringtoets.HeightStructures.IO/Configurations/HeightStructuresConfigurationSchemaIdentifiers.cs
  2. … 9 more files in changeset.
9:48 am

Marten Janssen <marten.janssen@deltares.nl>

review suggestions - Renames of properties - Updated XMLdocx Related to Issue [WTI-1221]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10239 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 61bbf50b6a687cdbefdf2d4cb1e1a9c796f88d3e

Former-commit-id: 4f6178badee4096e8028b72e3dd21aea30ca39a4

Options
    • -6
    • +8
    ./src/Ringtoets.HeightStructures.IO/Configurations/HeightStructuresCalculationConfigurationExporter.cs
  2. … 42 more files in changeset.
8:25 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleaned up test setup and teardown overrides. Related to Issue [WTI-1266]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10236 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a3972a00ae40034528c2dd481fcc58265848d341

Former-commit-id: e662dfe97914fbadabc44b2226a1e80973fb08ff

Options
    • -3
    • +1
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationContextTreeNodeInfoTest.cs
    • -10
    • +9
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -10
    • +9
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -3
    • +1
    ./test/Ringtoets.HeightStructures.Plugin.Test/UpdateInfos/HeightStructuresContextUpdateInfoTest.cs
  5. … 43 more files in changeset.
Wednesday 07 Jun 2017
2:15 pm

Marten Janssen <marten.janssen@deltares.nl>

Introduced HydraRingCalculatorTestCaseProvider to provide several test cases where a calculator can fail Related to Issue [WTI-1271]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10223 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 454dd7421243f00203b0be87b75c3942f5869860

Former-commit-id: 4f5de7cb8d9c2a8d04413b21b0ad0d1be06acdef

Options
    • -5
    • +11
    ./test/Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
  2. … 18 more files in changeset.
8:41 am

Marten Janssen <marten.janssen@deltares.nl>

Unified usage of StriktMocks in Services and Activities Related to Issue [WTI-1271]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10210 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cd6922e11680e7041ed43c598116776b9f48bec3

Former-commit-id: 146937d3fe3311562e2ef8ea2a354c80c2133665

Options
    • -8
    • +8
    ./test/Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
    • -21
    • +21
    ./test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
  3. … 24 more files in changeset.
Tuesday 06 Jun 2017
3:40 pm

Marten Janssen <marten.janssen@deltares.nl>

Renamed calculators to nrOfCalculators Unified usage of Stubs and StriktMocks in TreeNodeInfos Related to Issue [WTI-1271]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10209 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8d6e5844d79c8308a22b1d6ff72ec6261761416c

Former-commit-id: 366bf0fbfe29299cdb5714d9dbfd8309edbaf491

Options
    • -2
    • +2
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -2
    • +2
    ./test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
  3. … 14 more files in changeset.