Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merged revision(s) 12837 from branches/Release/17_2: Cleanup review related changes

........

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12840 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: aada8240c10f5ae25d15db1e4809f5bcf436041b

Former-commit-id: e9251210806734461ea032c84be8dd5503b10975

  1. … 10 more files in changeset.
Cleanup review related changes Related to Issue [WTI-1463]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/17_2@12837 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 111607616f24facb52538f0818b9367543716726

Former-commit-id: 682f10306898888c004d95bc4792df2b70b29591

  1. … 11 more files in changeset.
Cleanup of Ringtoets.HydraRing.* Related to Issue [WTI-1463]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12793 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c318e843dfb53f575444fb229758fd80b54f1443

Former-commit-id: a52198d30536a111e4743c5fd95a627058dc66e2

  1. … 26 more files in changeset.
Review related changes Related to Issue [WTI-1405]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11838 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 36c65a06089b59a0e0d7060a482c042d6e9241a9

Former-commit-id: fc15f1e10efa631d55f1fadc32e65d6d9cadbd4b

  1. … 27 more files in changeset.
- Modified the illustration point query such that the combination type is read from the parent, instead of its own illustration point - Added tests to assert that behaviour Related to Issue [WTI-1312]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11612 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 08b9c0ad07a79548cf80a4b46cc37aac2c6a43cb

Former-commit-id: 8f34367b3180ec5a573eb13f61caaaf8b8fce15b

  1. … 1 more file in changeset.
Added validation that child count of HydraRingIllustrationPointTreeNode must be 0 or 2. Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10701 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1d10d09048cace62e57818f6744c2c3e20c6bba1

Former-commit-id: 945e83f3e6f257b7502121a40cfa2787434ed93a

  1. … 9 more files in changeset.
Added illustration point results for the StructuresCalculator: - Improved tests for existing calculators with IllustrationPoint outputs - Made HydraRing data model stricter for the FaultTreeIllustrationPoint Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10692 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 087962fcfcaf1415ad807a2a517b89070364612c

Former-commit-id: cf9598a18ac57f8e02eaebe20344553bc1d35491

  1. … 9 more files in changeset.
Fixed bug for reading illustration points for hydraulic boundary locations for which not all closing situations are being calculated. Related to Issue [WTI-1302]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10594 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e4996a30f3c16da0e2c186f7386abb819b00893c

Former-commit-id: 3425bacf99fc479c3401f4f93bd3a89fe21d7339

  1. … 5 more files in changeset.
Updated control finder Updated XMLdoc Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10573 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e15aa23d3227943f41e2c7a9138d7236882b748f

Former-commit-id: fb560b352cd217039b6379dbd870f392a4b89ed2

  1. … 7 more files in changeset.
Review suggestions: - Added exception to IllustrationPointsParser when no governing wind direction could be found in the database. - Refactored IllustrationPointsParser such that it either creates a new GeneralResult or throws an exception Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10566 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 73e9239abcc55c1306fc6d248fb391a541c10029

Former-commit-id: d5076edaf9d246405a6bf685abd0269dd1e6714b

  1. … 6 more files in changeset.
Added exception message for scenario where beta values are not present. Removed filter on PeriodId for GeneralBetaValues and GeneralAlphaValues and added the filter to governingWindDirection determination. Related to Issue [WTI-1302]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10551 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e348f31843b3ff5d13ac6b30f774adaf2aad9112

Former-commit-id: f2acddb06ef4cea1023f7b9d310f7b118ff1363b

  1. … 3 more files in changeset.
Renamed Submechanism<X> to SubMechanism<X> for the illustration points: - Performed on the HydraRing side only

Related to Issue [WTI-1305]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10540 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 077a7d4ec43c5777d2a58aadf38de8e9b3fa83f4

Former-commit-id: 8c99502b1f2539ddb4f05f81c55536fa19398ce4

  1. … 20 more files in changeset.
Renamed IllustrationPoint to SubmechanismIllustrationPoint: - Done to mirror the items of the fault tree representation more accurately - Fixed inconsistency in the hydra ring side, SubMechanismIllustrationPoint --> SubmechanismIllustrationPoint Related to Issue [WTI-1305]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10524 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ab7ea1efe7a38a5dfd582fa8c12dfb84d6405feb

Former-commit-id: 280ffcdbd4442a1d1930adbeb5338d41a3c5b4fd

  1. … 36 more files in changeset.
Renamed RealizedStochast to SubmechanismIllustrationPointStochast: - Done to represent a clearer association with its parent component - Only done on the HydraRing side - Fixed failing tests

Related to Issue [WTI-1305]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10521 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 75ee7fbbd00df14720485f37984ac33ea31941eb

Former-commit-id: 1480a6d37d6d2c3d9a627929b3e7c85ebd0fea20

  1. … 14 more files in changeset.
Used key made up of submechanism, winddirection and closing situation, rather than just picking the first for submechanisms illustration point results, stochasts and beta values. Related to Issue [WTI-1302]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10499 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f4cf919be9482f36c04d7089d64654c361bd5d3c

Former-commit-id: 4e918fd44938d271011781f5ab46fe68770bab07

  1. … 1 more file in changeset.
Cleanup Added XMLdocs Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10457 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2f29edc2ddc2ae1b1408acc3ec607052104bc634

Former-commit-id: 23de8e1609c270614922b5e6cb16b2167657cc96

  1. … 5 more files in changeset.
Refactored GeneralResult such that the data model is more strict Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10449 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4f90c9228d91088a2f8ec546754f390a67e31423

Former-commit-id: 87f2ecb460dad9538403f0ee7c55910806270ae8

  1. … 9 more files in changeset.
Made Stochast stricter in HydraRing side: - Converted properties to readonly properties by means of constructor - Applied the same for derived class RealizedStochast - Adjusted functionality in the parser - Updated XMLDoc Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10437 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 978f80c85db63caa1f7cbaca16174d3ee63d79a3

Former-commit-id: 2d257d21be61b21ba8aece291caf3607e5a258f1

  1. … 8 more files in changeset.
Refactored IllustrationPointResult such that the data model is more strict Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10436 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c58bc1ffbb4fa628ffcd832b21aff56c55d51317

Former-commit-id: 6b170b574c4ac18fb172f2e37feedc1568e84c30

  1. … 5 more files in changeset.
Made SubMechanismIllustrationPoint stricter in HydraRing side: - Converted collection properties in IEnumerable to prevent unwanted modifications - Adjusted functionality in the parser - Removed constructor which accepted two parameters - Updated XMLDoc

Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10433 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ebf7d94e6b4ce017ec33fc9e71ac0eeafd849196

Former-commit-id: 7f210cd0c03c74eb83a22f6255af6cabfa9dbf87

  1. … 5 more files in changeset.
Added validation to IllustrationPointsParser where double values can be DBNull Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10432 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 97c5cdb8e50fced507025066390a959a1681fa21

Former-commit-id: 509f6edbe1e6029345536e8a4a8212f8c1bca679

  1. … 9 more files in changeset.
Made SubMechanismIllustrationPoint stricter in HydraRing side: - Removed setters - Introduced constructor - Updated XMLDocs

Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10430 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 928411571e7ea4b4122116cbf8016cd154e702a9

Former-commit-id: 7b8eef4620f040c3a4e098e976047a810101cd89

  1. … 6 more files in changeset.
Made WindDirection stricter in HydraRing side: - Introduced constructor which ensures that values are always set - Removed obsolete tests - Removed validation for the WindDirectionAngle due to consistency reasons: there's no validation done on the WaveConditionsOutput for the WaveHeight Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10427 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 72762a843c903273c036b8d74a125bae3c05a00e

Former-commit-id: f8a9edc05d12c51e353c0fa44cafa89fdedd5055

  1. … 15 more files in changeset.
Refactored FaultTreeIllustrationPoint such that the data model is more strict Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10424 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4a1274ab926238ba9e8bcce6549f97e40b6304ce

Former-commit-id: 72ca4012960d4f6a26c280eab80d712da71f1990

  1. … 3 more files in changeset.
Change after review. Related to Issue [WTI-1302]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10421 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 895e02e224e495051c472d5bcefd64aea4d2964a

Former-commit-id: adf5c5750b134afdcaff85038890725852b325c3

Moved hydraring illustration point data model to Data/Output/IllustrationPoints Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10420 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 82586716e967302c3debd0beb6123aa331e57043

Former-commit-id: 1cbe04f7cffe9510e996704b793ac145002700b1

    • -1
    • +1
    ./IllustrationPointsDatabaseConstants.cs
  1. … 53 more files in changeset.
Introduced WindDirectionClosingScenarioIllustrationPoint item class to store every combination of wind directions, closing scenarios and illustration points: - Introduced object in the RT GeneralResult - Introduced a TestIllustrationPoint test object - Made the accessors public in the WindDirectionClosingSituation in the HydraRing side, this will be needed for the converter creating WindDirectionClosingScenarioIllustrationPoint objects - Moved IllustrationPoint related test objects to their respective folder

Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10407 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 36313b8f5a946d595b772e08b053a1f6b2de6253

Former-commit-id: 2b1b07b0b603b5a732f79dbb2d88b9998def8e75

  1. … 16 more files in changeset.
Doc cleanup. extracted common query parts in IllustrationPointQueries. Simplified uses of GetIterator Related to Issue [WTI-1302]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10400 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fcdecee17407ba43f14e58480daa30eba3c57c6d

Former-commit-id: b6f93dadf7ac6d4d53669a5b2a88d1d9dad7c64b

  1. … 3 more files in changeset.
Added missing name properties for sub mechanism and fault tree Related to Issue [WTI-1302]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10399 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 859e9a09bb5f12feb7e63358a14521f4490ebfc9

Former-commit-id: c2949290160cd4b653753e7a08352bbe542116c3

    • -0
    • +2
    ./IllustrationPointsDatabaseConstants.cs
  1. … 1 more file in changeset.
Added tests for error cases Related to Issue [WTI-1302]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10390 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f74222ff42776d7eb0766cb91b669532d85090e0

Former-commit-id: 9f5e5d17ba6bcd461f3e81ecf4d060d49ea95093

  1. … 11 more files in changeset.