Riskeer / Ringtoets

HydraRing

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 10 Dec 2018
11:11 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added missing documentation. WTI-1486

Options
    • -2
    • +2
    ./src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs
11:10 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added read method for the hydraulic location configuration database. WTI-1486

Options
    • -0
    • +10
    ./src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReader.cs
    • -1
    • +85
    ./test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
10:49 am

Dennis Tang <dennis.tang@deltares.nl>

Intermediate cleanup: WTI-1923

- Cleaned up XMLDoc

- Formatted files

- Corrected mocks configurations

Options
    • -4
    • +3
    ./src/Ringtoets.HydraRing.Calculation/Data/Input/HydraRingCalculationSettings.cs
    • -61
    • +61
    ./test/Ringtoets.HydraRing.Calculation.Test/Calculator/HydraRingCalculatorBaseTest.cs
    • -4
    • +2
    ./test/Ringtoets.HydraRing.Calculation.Test/Calculator/StructuresCalculatorTest.cs
  4. … 3 more files in changeset.
10:34 am

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced read object for hydraulic location configuration database. WTI-1486

Options
    • -0
    • +45
    ./src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabase.cs
    • -0
    • +1
    ./src/Ringtoets.HydraRing.IO/Ringtoets.HydraRing.IO.csproj
    • -0
    • +44
    ./test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseTest.cs
    • -0
    • +1
    ./test/Ringtoets.HydraRing.IO.Test/Ringtoets.HydraRing.IO.Test.csproj
9:47 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1486

Options
    • -16
    • +16
    ./test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
9:46 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fix rebase errors. WTI-1486

Options
    • -15
    • +13
    ./src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs
8:44 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added tests for reading locations. WTI-1486

Options
    • -0
    • +24
    ./test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
8:39 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added test for parsing error while reading location. WTI-1486

Options
    • -0
    • +19
    ./test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
8:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fix reading incomplete version. WTI-1486

Options
    • -1
    • +6
    ./src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs
Friday 07 Dec 2018
2:18 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added tests. WTI-1486

Options
    • binary
    ./test/Ringtoets.HydraRing.IO.Test/test-data/HydraulicBoundaryDatabaseReader/corruptLocationSchema.sqlite
    • binary
    ./test/Ringtoets.HydraRing.IO.Test/test-data/HydraulicBoundaryDatabaseReader/incompleteVersion.sqlite
1:39 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated WaveHeightCalculator calls: WTI-1923

- Corrected for the HydraRing calculation factory

Options
    • -3
    • +2
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs
    • -7
    • +7
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs
1:32 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added tests. WTI-1486

Options
    • -3
    • +61
    ./test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
    • binary
    ./test/Ringtoets.HydraRing.IO.Test/test-data/HydraulicBoundaryDatabaseReader/emptySchemaGeneral.sqlite
1:32 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented reading the database. WTI-1486

Options
    • -0
    • +117
    ./src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs
11:22 am

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced new reader. WTI-1486

Options
    • -0
    • +46
    ./src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs
    • -0
    • +1
    ./src/Ringtoets.HydraRing.IO/Ringtoets.HydraRing.IO.csproj
    • -0
    • +87
    ./test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
    • -0
    • +1
    ./test/Ringtoets.HydraRing.IO.Test/Ringtoets.HydraRing.IO.Test.csproj
11:15 am

Robert Tangerman <robert.tangerman@deltares.nl>

Renamed current reader so a new one can be introduced. WTI-1486

Options
    • -173
    • +0
    ./src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs
    • -0
    • +173
    ./src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/OldHydraulicBoundaryDatabaseReader.cs
    • -1
    • +1
    ./src/Ringtoets.HydraRing.IO/Ringtoets.HydraRing.IO.csproj
    • -281
    • +0
    ./test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
    • -0
    • +281
    ./test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/OldHydraulicBoundaryDatabaseReaderTest.cs
    • -1
    • +1
    ./test/Ringtoets.HydraRing.IO.Test/Ringtoets.HydraRing.IO.Test.csproj
  7. … 3 more files in changeset.
11:08 am

Dennis Tang <dennis.tang@deltares.nl>

Updated DesignWaterLevelCalculator calls: WTI-1923

- Corrected for the HydraRing calculation factory

Options
    • -3
    • +2
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs
    • -7
    • +7
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs
10:44 am

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced new ReadHydraulicBoundaryDatabase. WTI-1486

Options
    • -0
    • +59
    ./src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/ReadHydraulicBoundaryDatabase.cs
    • -0
    • +1
    ./src/Ringtoets.HydraRing.IO/Ringtoets.HydraRing.IO.csproj
    • -0
    • +49
    ./test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/ReadHydraulicBoundaryDatabaseTest.cs
    • -0
    • +1
    ./test/Ringtoets.HydraRing.IO.Test/Ringtoets.HydraRing.IO.Test.csproj
Thursday 06 Dec 2018
3:47 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated WaveConditionsCalculator calls: WTI-1923

- Updated the HydraRing factory calls

Options
    • -3
    • +2
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs
    • -7
    • +7
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs
1:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated StructureCalculator calls: WTI-1923

- Only corrected on the HydraRing side (calculator factory)

Options
    • -3
    • +2
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs
    • -7
    • +7
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs
1:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated OvertoppingCalculator calls. WTI-1923

Options
    • -3
    • +2
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs
    • -7
    • +7
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs
  3. … 9 more files in changeset.
9:46 am

Dennis Tang <dennis.tang@deltares.nl>

Updated DikeHeightCalculator calls: WTI-1923

- Updated XMLDoc in the interface declaration of the factory.

Options
    • -3
    • +2
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs
    • -9
    • +9
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs
  3. … 3 more files in changeset.
Wednesday 05 Dec 2018
5:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated OverToppingRateCalculator calls. WTI-1923

Options
    • -3
    • +2
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs
    • -7
    • +7
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs
  3. … 3 more files in changeset.
4:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated DuneBoundaryCalculator calls: WTI-1923

- Fixed failing tests after changing the calculator calls

-- Updated XMLDoc

Options
    • -0
    • +1
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs
  2. … 10 more files in changeset.
3:07 pm

Dennis Tang <dennis.tang@deltares.nl>

Applied temporary fix in the HydraRingCalculationFactory. WTI-1923

- Wrapped the directory arguments when creating the calculators to resolve the compilation errors.

Note: this fix will be gradually removed when the individual calculators are refactored on the calling side.

Options
    • -8
    • +15
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs
2:41 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated DuneBoundaryCalculator calls. WTI-1923

Options
    • -3
    • +3
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/HydraRingCalculatorFactory.cs
    • -7
    • +6
    ./src/Ringtoets.HydraRing.Calculation/Calculator/Factory/IHydraRingCalculatorFactory.cs
  3. … 11 more files in changeset.
1:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed constructor arguments from derived classes: WTI-1923

- Removed directory constructor from the base class. Calculation directories should be passed through the HydraRingCalculationSettings object.

-- Adjusted derived classes

Options
    • -7
    • +7
    ./src/Ringtoets.HydraRing.Calculation/Calculator/DesignWaterLevelCalculator.cs
    • -7
    • +7
    ./src/Ringtoets.HydraRing.Calculation/Calculator/DunesBoundaryConditionsCalculator.cs
    • -34
    • +3
    ./src/Ringtoets.HydraRing.Calculation/Calculator/HydraRingCalculatorBase.cs
    • -7
    • +7
    ./src/Ringtoets.HydraRing.Calculation/Calculator/HydraulicLoadsCalculator.cs
    • -7
    • +7
    ./src/Ringtoets.HydraRing.Calculation/Calculator/OvertoppingCalculator.cs
    • -7
    • +6
    ./src/Ringtoets.HydraRing.Calculation/Calculator/StructuresCalculator.cs
    • -7
    • +7
    ./src/Ringtoets.HydraRing.Calculation/Calculator/WaveConditionsCosineCalculator.cs
    • -7
    • +7
    ./src/Ringtoets.HydraRing.Calculation/Calculator/WaveHeightCalculator.cs
    • -1
    • +2
    ./test/Ringtoets.HydraRing.Calculation.Test/Calculator/DesignWaterLevelCalculatorTest.cs
    • -1
    • +2
    ./test/Ringtoets.HydraRing.Calculation.Test/Calculator/DunesBoundaryConditionsCalculatorTest.cs
    • -1
    • +2
    ./test/Ringtoets.HydraRing.Calculation.Test/Calculator/HydraulicLoadsCalculatorTest.cs
    • -1
    • +2
    ./test/Ringtoets.HydraRing.Calculation.Test/Calculator/OvertoppingCalculatorTest.cs
    • -1
    • +5
    ./test/Ringtoets.HydraRing.Calculation.Test/Calculator/StructuresCalculatorTest.cs
    • -1
    • +2
    ./test/Ringtoets.HydraRing.Calculation.Test/Calculator/WaveConditionsCosineCalculatorTest.cs
    • -1
    • +2
    ./test/Ringtoets.HydraRing.Calculation.Test/Calculator/WaveHeightCalculatorTest.cs
1:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced test factory to create instances of HydraRingCalculationSettings. WTI-1923

- Replaced local definitions

Options
    • -12
    • +10
    ./test/Ringtoets.HydraRing.Calculation.Test/Calculator/HydraRingCalculatorBaseTest.cs
    • -0
    • +20
    ./test/Ringtoets.HydraRing.Calculation.TestUtil.Test/HydraRingCalculationSettingsTestFactoryTest.cs
    • -0
    • +1
    ./test/Ringtoets.HydraRing.Calculation.TestUtil.Test/Ringtoets.HydraRing.Calculation.TestUtil.Test.csproj
    • -0
    • +21
    ./test/Ringtoets.HydraRing.Calculation.TestUtil/HydraRingCalculationSettingsTestFactory.cs
    • -0
    • +1
    ./test/Ringtoets.HydraRing.Calculation.TestUtil/Ringtoets.HydraRing.Calculation.TestUtil.csproj
11:53 am

Dennis Tang <dennis.tang@deltares.nl>

Changed wiring in the HydraRingInitializationService: WTI-1923

- Removed directory constructor parameters, as they are grouped into a ConfigurationSettings object.

-- Adjusted the calculator base and cleaned up its tests which still use the directories as argument

Options
    • -5
    • +4
    ./src/Ringtoets.HydraRing.Calculation/Calculator/HydraRingCalculatorBase.cs
    • -10
    • +0
    ./src/Ringtoets.HydraRing.Calculation/HydraRingFileConstants.cs
    • -7
    • +13
    ./src/Ringtoets.HydraRing.Calculation/Services/HydraRingInitializationService.cs
    • -30
    • +8
    ./test/Ringtoets.HydraRing.Calculation.Test/Calculator/HydraRingCalculatorBaseTest.cs
    • -7
    • +27
    ./test/Ringtoets.HydraRing.Calculation.Test/Services/HydraRingInitializationServiceTest.cs
11:48 am

Dennis Tang <dennis.tang@deltares.nl>

Removed unused reference. WTI-1923

Options
    • -1
    • +0
    ./src/Ringtoets.HydraRing.Calculation/Data/Input/HydraRingCalculationSettings.cs
11:12 am

Dennis Tang <dennis.tang@deltares.nl>

Added constructor in the HydraRing CalculatorBase: WTI-1923

- Started replacing the constructor with the calculation settings overload.

Options
    • -1
    • +1
    ./src/Ringtoets.HydraRing.Calculation/Calculator/HydraRingCalculatorBase.cs
    • -7
    • +15
    ./test/Ringtoets.HydraRing.Calculation.Test/Calculator/HydraRingCalculatorBaseTest.cs