Riskeer / Ringtoets / Integration / src

Ringtoets.Integration.Service

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 17:15
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 16 Jul 2018
9:54 am

Robert Tangerman <robert.tangerman@deltares.nl>

Renamed exception. WTI-1750

Options
    • -68
    • +0
    ./Exceptions/AssessmentSectionProviderException.cs
    • -0
    • +68
    ./Exceptions/LoadAssessmentSectionException.cs
    • -2
    • +2
    ./Merge/ILoadAssessmentSectionService.cs
    • -2
    • +2
    ./Merge/LoadAssessmentSectionService.cs
    • -1
    • +1
    ./Ringtoets.Integration.Service.csproj
  6. … 5 more files in changeset.
9:40 am

Robert Tangerman <robert.tangerman@deltares.nl>

Renamed method. WTI-1750

Options
    • -2
    • +2
    ./Merge/ILoadAssessmentSectionService.cs
    • -1
    • +1
    ./Merge/LoadAssessmentSectionService.cs
    • -1
    • +1
    ./Merge/LoadAssessmentSectionsActivity.cs
  4. … 3 more files in changeset.
9:40 am

Robert Tangerman <robert.tangerman@deltares.nl>

Renamed method. WTI-1750

Options
    • -2
    • +2
    ./Merge/ILoadAssessmentSectionService.cs
    • -1
    • +1
    ./Merge/LoadAssessmentSectionService.cs
    • -1
    • +1
    ./Merge/LoadAssessmentSectionsActivity.cs
  4. … 3 more files in changeset.
8:50 am

Robert Tangerman <robert.tangerman@deltares.nl>

Renamed interface. WTI-1750

Options
    • -42
    • +0
    ./Merge/IAssessmentSectionProvider.cs
    • -0
    • +42
    ./Merge/ILoadAssessmentSectionService.cs
    • -1
    • +1
    ./Merge/LoadAssessmentSectionService.cs
    • -7
    • +7
    ./Merge/LoadAssessmentSectionsActivity.cs
    • -10
    • +8
    ./Merge/LoadAssessmentSectionsActivityFactory.cs
    • -1
    • +1
    ./Ringtoets.Integration.Service.csproj
  7. … 3 more files in changeset.
8:50 am

Robert Tangerman <robert.tangerman@deltares.nl>

Renamed interface. WTI-1750

Options
    • -42
    • +0
    ./Merge/IAssessmentSectionProvider.cs
    • -0
    • +42
    ./Merge/ILoadAssessmentSectionService.cs
    • -1
    • +1
    ./Merge/LoadAssessmentSectionService.cs
    • -7
    • +7
    ./Merge/LoadAssessmentSectionsActivity.cs
    • -10
    • +8
    ./Merge/LoadAssessmentSectionsActivityFactory.cs
    • -1
    • +1
    ./Ringtoets.Integration.Service.csproj
  7. … 3 more files in changeset.
Thursday 12 Jul 2018
8:35 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3053:

- Editorial changes related to typos and formatting

- Editorial changes related to parameter names

WTI-1745

Options
    • -2
    • +2
    ./Merge/LoadAssessmentSectionService.cs
    • -8
    • +8
    ./Merge/LoadAssessmentSectionsActivity.cs
  3. … 3 more files in changeset.
8:28 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3053:

- Added license headers in the Integration.Data and Integration.Service source files

WTI-1761

Options
    • -1
    • +22
    ./Comparers/AssessmentSectionMergeComparer.cs
    • -1
    • +22
    ./Comparers/IAssessmentSectionMergeComparer.cs
    • -1
    • +22
    ./Exceptions/AssessmentSectionProviderException.cs
    • -1
    • +22
    ./Merge/LoadAssessmentSectionService.cs
    • -1
    • +22
    ./Merge/LoadAssessmentSectionsActivity.cs
    • -1
    • +22
    ./Merge/LoadAssessmentSectionsActivityFactory.cs
    • -1
    • +22
    ./Properties/Resources.Designer.cs
    • -0
    • +22
    ./packages.config
  9. … 7 more files in changeset.
Wednesday 11 Jul 2018
9:48 am

Dennis Tang <dennis.tang@deltares.nl>

Implemented comments review 3057:

- Formatting

Paired with ~carloslubbers

WTI-1733

Options
    • -16
    • +32
    ./AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.cs
  2. … 1 more file in changeset.
Tuesday 10 Jul 2018
10:30 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changes, update signature of factory methods WTI-1733

Options
    • -32
    • +16
    ./AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.cs
  2. … 4 more files in changeset.
10:27 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changes, improve tests and xmldoc, remove checks from Plugin WTI-1733

Options
    • -1
    • +1
    ./AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.cs
  2. … 6 more files in changeset.
Monday 09 Jul 2018
1:34 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changed, improved tests and set copylocal to false for added reference WTI-1744 Paired with dennistang

Options
    • -0
    • +1
    ./Ringtoets.Integration.Service.csproj
  2. … 1 more file in changeset.
10:32 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced description for the activity. WTI-1761

Options
    • -0
    • +3
    ./Merge/LoadAssessmentSectionsActivity.cs
    • -0
    • +72
    ./Properties/Resources.Designer.cs
    • -0
    • +123
    ./Properties/Resources.resx
    • -0
    • +11
    ./Ringtoets.Integration.Service.csproj
  5. … 1 more file in changeset.
10:04 am

Dennis Tang <dennis.tang@deltares.nl>

Made activity internal. WTI-1761

Options
    • -3
    • +3
    ./Merge/LoadAssessmentSectionsActivity.cs
    • -1
    • +3
    ./Properties/AssemblyInfo.cs
10:01 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced factory to create activity to load collections of AssessmentSections from a file

- Done to maintain consistency within the Activity - Factory structure within the application

WTI-1761

Options
    • -0
    • +47
    ./Merge/LoadAssessmentSectionsActivityFactory.cs
    • -0
    • +1
    ./Ringtoets.Integration.Service.csproj
  3. … 2 more files in changeset.
8:22 am

Dennis Tang <dennis.tang@deltares.nl>

Renamed service. WTI-1761

Options
    • -56
    • +0
    ./Merge/AssessmentSectionProviderService.cs
    • -0
    • +56
    ./Merge/LoadAssessmentSectionService.cs
    • -1
    • +1
    ./Ringtoets.Integration.Service.csproj
  4. … 3 more files in changeset.
8:20 am

Dennis Tang <dennis.tang@deltares.nl>

Renamed activity. WTI-1761

Options
    • -72
    • +0
    ./Merge/AssessmentSectionProviderActivity.cs
    • -0
    • +71
    ./Merge/LoadAssessmentSectionsActivity.cs
    • -1
    • +1
    ./Ringtoets.Integration.Service.csproj
  4. … 3 more files in changeset.
Friday 06 Jul 2018
3:56 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Add calculate all factory method and context menu to the Hydraulische Randvoorwaarden folder WTI-1733

Options
    • -0
    • +20
    ./AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.cs
  2. … 5 more files in changeset.
3:29 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up Activity:

- Added missing NULL checks

- Cleaned up tests for clarity

WTI-1761

Options
    • -1
    • +32
    ./Merge/AssessmentSectionProviderActivity.cs
  2. … 1 more file in changeset.
3:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up AssessmentSectionProvider:

- Cleaned up Service, call should always return a collection of AssessmentSections or something went wrong during the read.

- Cleaned up tests for clarity

- Added XMLDoc to the interface.

WTI-1761

Options
    • -1
    • +6
    ./Merge/AssessmentSectionProviderService.cs
    • -0
    • +3
    ./Merge/IAssessmentSectionProvider.cs
  3. … 1 more file in changeset.
3:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Added tests to assert the run and cancelled logic of this activity. WTI-1761

Options
    • -4
    • +13
    ./Merge/AssessmentSectionProviderActivity.cs
  2. … 1 more file in changeset.
2:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced owner as constructor argument of the activity to hold the assessment sections after reading. WTI-1761

Options
    • -1
    • +4
    ./Merge/AssessmentSectionProviderActivity.cs
  2. … 1 more file in changeset.
2:00 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Introduce factory for creating hbl calculations for all category boundaries WTI-1733

Options
    • -0
    • +122
    ./AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.cs
    • -0
    • +1
    ./Ringtoets.Integration.Service.csproj
  3. … 2 more files in changeset.
1:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Added initial setup for the provider activity. WTI-1761

Options
    • -0
    • +29
    ./Merge/AssessmentSectionProviderActivity.cs
    • -0
    • +1
    ./Ringtoets.Integration.Service.csproj
  3. … 2 more files in changeset.
1:31 pm

Dennis Tang <dennis.tang@deltares.nl>

Wrapped StorageException when it occurs in the provider service. WTI-1761

Options
    • -3
    • +7
    ./Merge/AssessmentSectionProviderService.cs
  2. … 1 more file in changeset.
1:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Added custom exception to wrap around the StorageException when it occurs in the provider service. WTI-1761

Options
    • -0
    • +47
    ./Exceptions/AssessmentSectionProviderException.cs
    • -0
    • +1
    ./Ringtoets.Integration.Service.csproj
  3. … 2 more files in changeset.
12:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Initial setup of a RingtoetsProjectServiceProvider. WTI-1761

Options
    • -0
    • +47
    ./Merge/AssessmentSectionProviderService.cs
    • -0
    • +6
    ./Ringtoets.Integration.Service.csproj
    • -0
    • +4
    ./packages.config
  4. … 2 more files in changeset.
11:38 am

Dennis Tang <dennis.tang@deltares.nl>

Moved interface for the AssessmentSectionProvider to service. WTI-1761

Options
    • -0
    • +39
    ./Merge/IAssessmentSectionProvider.cs
    • -0
    • +1
    ./Ringtoets.Integration.Service.csproj
  3. … 4 more files in changeset.
Wednesday 04 Jul 2018
3:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - fixed typo in XMLDoc. WTI-1744

Options
    • -1
    • +1
    ./Comparers/IAssessmentSectionMergeComparer.cs
2:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up interface.

- Comparer should work on AssessmentSection instead of the IAssessmentSection or NULL checks must be implemented for all properties it checks

- Cleaned up parameter names for clarity.

WTI-1744

Options
    • -11
    • +12
    ./Comparers/AssessmentSectionMergeComparer.cs
    • -7
    • +7
    ./Comparers/IAssessmentSectionMergeComparer.cs
    • -0
    • +4
    ./Ringtoets.Integration.Service.csproj
2:51 pm

Dennis Tang <dennis.tang@deltares.nl>

Added first implementation of the comparer.

WTI-1744

Options
    • -0
    • +87
    ./Comparers/AssessmentSectionMergeComparer.cs
    • -0
    • +1
    ./Ringtoets.Integration.Service.csproj
  3. … 2 more files in changeset.