Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Incorporated comments PO: WTI-1925

- Added log message when there's no ScenarioInformation present in the HLCD.

    • -7
    • +7
    ./Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -0
    • +9
    ./Ringtoets.Integration.IO/Properties/Resources.Designer.cs
  1. … 1 more file in changeset.
Added progress notification. WTI-1927

    • -1
    • +3
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
  1. … 1 more file in changeset.
Added call handler to add read data to data model. WTI-1927

    • -0
    • +11
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
  1. … 3 more files in changeset.
Added getting confirmation. WTI-1927

    • -0
    • +17
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
  1. … 1 more file in changeset.
Added methods to update handler. WTI-1927

    • -1
    • +25
    ./Ringtoets.Integration.IO/Handlers/IHydraulicLocationConfigurationDatabaseUpdateHandler.cs
Added cancellation to importer. WTI-1927

    • -3
    • +3
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -0
    • +10
    ./Ringtoets.Integration.IO/Properties/Resources.Designer.cs
  1. … 1 more file in changeset.
Added progress notifications. WTI-1927

    • -0
    • +3
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
  1. … 1 more file in changeset.
Removed trackId from data model. WTI-1927

    • -1
    • +0
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
  1. … 3 more files in changeset.
Added reading TrackId. WTI-1927

    • -1
    • +30
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
  1. … 7 more files in changeset.
Incorporated comments review 3443: WTI-1925

- Added ArgumentException when the read hydraulic location configuration database contains multiple or zero items for the database settings.

-- Added factory and factory methods to verify behaviour

-- Renamed factory methods to be more representative

- Updated logic in the importer

    • -0
    • +2
    ./Ringtoets.Integration.IO/Handlers/IHydraulicBoundaryDatabaseUpdateHandler.cs
    • -6
    • +2
    ./Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -9
    • +24
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -20
    • +0
    ./Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
  1. … 7 more files in changeset.
Incorporated comments review 3443: WTI-1925

- Removed the IsScenarioInformationPresent flag from the read object.

    • -1
    • +1
    ./Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -1
    • +1
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -1
    • +1
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
  1. … 8 more files in changeset.
Cleanup. WTI-1927

    • -11
    • +2
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
Added scenario information validation. WTI-1927

    • -0
    • +18
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -0
    • +10
    ./Ringtoets.Integration.IO/Properties/Resources.Designer.cs
  1. … 3 more files in changeset.
Added reading HLCD. WTI-1927

    • -0
    • +40
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
  1. … 3 more files in changeset.
Set TrackId in update handler. WTI-1927

    • -0
    • +1
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
  1. … 1 more file in changeset.
Updated log message of the importer: WTI-1925

- Log message updated for consistency reasons.

- Performed minor cleanups

    • -1
    • +1
    ./Ringtoets.Integration.IO/Properties/Resources.Designer.cs
  1. … 2 more files in changeset.
Added check that HLCD is in same folder as HRD. WTI-1927

    • -1
    • +21
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -0
    • +20
    ./Ringtoets.Integration.IO/Properties/Resources.Designer.cs
  1. … 1 more file in changeset.
Moved default string values to Resources. WTI-1925

    • -11
    • +11
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -0
    • +20
    ./Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
Added Hydraulic boundary database to the importer. WTI-1927

    • -1
    • +8
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
  1. … 1 more file in changeset.
Added handler to importer. WTI-1927

    • -2
    • +12
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
  1. … 1 more file in changeset.
Added interface for update handler. WTI-1927

    • -0
    • +30
    ./Ringtoets.Integration.IO/Handlers/IHydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -0
    • +1
    ./Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
Added base class to importer. WTI-1927

    • -1
    • +1
    ./Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -1
    • +23
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
  1. … 1 more file in changeset.
Added importer for hlcd. WTI-1927

    • -0
    • +30
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -0
    • +1
    ./Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
  1. … 2 more files in changeset.
Added hlcd file path as argument for the handler. WTI-1925

    • -2
    • +4
    ./Ringtoets.Integration.IO/Handlers/IHydraulicBoundaryDatabaseUpdateHandler.cs
    • -1
    • +1
    ./Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -7
    • +12
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
  1. … 2 more files in changeset.
Expanded importer: WTI-1925

- Added log message in case an invalid HLCD with an invalid number of ScenarioInformation entries was read

- Improved tests

    • -1
    • +1
    ./Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -0
    • +10
    ./Ringtoets.Integration.IO/Properties/Resources.Designer.cs
  1. … 1 more file in changeset.
Added logic to the UpdateHandler: WTI-1925

- Added logic to set values of the HydraulicLocationConfigurationSettings of the HydraulicBoundaryDatabase based on the input arguments.

    • -0
    • +39
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
  1. … 1 more file in changeset.
Improvements after review. WTI-1486

    • -3
    • +3
    ./Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
  1. … 5 more files in changeset.
Improvements after review. WTI-1486

    • -5
    • +5
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
  1. … 6 more files in changeset.
Added validation logic in the importer: WTI-1925

- Added validation logic to verify the ScenarioInformation within the ReadHydraulicLocationConfiguration object

-- If ScenarioInformation is present, only 1 entry should be present; else stop importing

    • -4
    • +30
    ./Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
  1. … 13 more files in changeset.
Improvements after review. WTI-1486

    • -0
    • +5
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
  1. … 4 more files in changeset.