Riskeer / Ringtoets / Integration / test / Ringtoets.Integration.Forms.Test

Views

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 25 Apr 2018
1:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up tests

WTI-1679

Options
    • -16
    • +1
    ./FailureMechanismAssemblyCategoryGroupResultRowTest.cs
    • -1
    • +29
    ./FailureMechanismAssemblyResultRowBaseTest.cs
    • -24
    • +1
    ./FailureMechanismAssemblyResultRowTest.cs
12:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Extracted base class for the failure mechanism assembly result rows: - Failure mechanism assembly result factories for groups 3 and 4 only return a FailureMechanismCategoryGroup - Applied changes to the view

WTI-1679

Options
    • -0
    • +213
    ./FailureMechanismAssemblyCategoryGroupResultRowTest.cs
    • -0
    • +99
    ./FailureMechanismAssemblyResultRowBaseTest.cs
    • -5
    • +5
    ./FailureMechanismAssemblyResultRowTest.cs
  4. … 6 more files in changeset.
11:03 am

Dennis Tang <dennis.tang@deltares.nl>

Connected assembly factories of groups 1 and 2 to the view - Extended tests: added test to verify UpdateLogic on the rows - Extracted private helper function which asserts all the failure mechanism rows - Made the AssertAssemblyRow more generic by using a ProbabilityFormattingHelper

WTI-1679

Options
    • -55
    • +91
    ./AssemblyResultTotalViewTest.cs
10:47 am

Dennis Tang <dennis.tang@deltares.nl>

- Connected assembly factories of groups 1 and 2 to the view - Cleaned up the row

WTI-1679

Options
    • -43
    • +67
    ./AssemblyResultTotalViewTest.cs
  2. … 2 more files in changeset.
8:54 am

Dennis Tang <dennis.tang@deltares.nl>

Added button to the view: - Added minimum size to prevent button from overflowing the button group box, localized the button text - Connected the button to the refresh logic. Note, it's not tested if the rows are refreshed to the right values

WTI-1679

Options
    • -1
    • +35
    ./AssemblyResultTotalViewTest.cs
  2. … 4 more files in changeset.
Tuesday 24 Apr 2018
4:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed exception messages on both category and probability columns: - Functional change: exception should be displayed for only the category column

WTI-1679

Options
    • -14
    • +3
    ./FailureMechanismAssemblyResultRowTest.cs
  2. … 1 more file in changeset.
2:43 pm

Dennis Tang <dennis.tang@deltares.nl>

- Cleaned up testnames - Used a backing field for the rows --> rows will need to be updated (instead of creating new rows) when the control is updated

WTI-1679

Options
    • -2
    • +2
    ./AssemblyResultTotalViewTest.cs
  2. … 1 more file in changeset.
1:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Added error handling logic in the row: - Columnstates are set accordingly in case an exception occurs when executing the delegate - Default values for both the category group and probability are set

WTI-1679

Options
    • -0
    • +117
    ./FailureMechanismAssemblyResultRowTest.cs
  2. … 1 more file in changeset.
12:53 pm

Dennis Tang <dennis.tang@deltares.nl>

Added column state definitions to the row in order to format the cells based on category and handle exceptions in case they occur.

WTI-1679

Options
    • -0
    • +11
    ./FailureMechanismAssemblyResultRowTest.cs
  2. … 1 more file in changeset.
11:58 am

Dennis Tang <dennis.tang@deltares.nl>

Added columns to the view to display the category group and the probability of the assembly result of a failure mechanism.

WTI-1679

Options
    • -1
    • +9
    ./AssemblyResultTotalViewTest.cs
    • -2
    • +2
    ./FailureMechanismAssemblyResultRowTest.cs
  3. … 2 more files in changeset.
11:51 am

Dennis Tang <dennis.tang@deltares.nl>

Added function to retrieve the failure mechanism assembly to the row: - Function was used, as each failure mechanism has its own dedicated factory that determines how the assembly is calculated.

WTI-1679

Options
    • -2
    • +39
    ./FailureMechanismAssemblyResultRowTest.cs
  2. … 2 more files in changeset.
11:25 am

Dennis Tang <dennis.tang@deltares.nl>

Extracted failure mechanisms and inserting rows manually in the view instead of dynamically resolving them: - Performed due to each failure mechanism having its own factory which determines the assembly result

WTI-1679

Options
    • -14
    • +90
    ./AssemblyResultTotalViewTest.cs
  2. … 3 more files in changeset.
9:06 am

Dennis Tang <dennis.tang@deltares.nl>

Connected the AssemblyResultTotalView to the Ringtoetsplugin: - Added AssessmentSection auto property on the view --> necessary to determine when the view should be closed

WTI-1679

Options
    • -0
    • +1
    ./AssemblyResultTotalViewTest.cs
  2. … 5 more files in changeset.
Monday 23 Apr 2018
4:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Renamed view: - View represents mainly the assembly total results (on assessment section level)

WTI-1679

Options
    • -0
    • +138
    ./AssemblyResultTotalViewTest.cs
    • -137
    • +0
    ./AssessmentSectionCombinedAssemblyResultViewTest.cs
  3. … 8 more files in changeset.
4:36 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced failure mechanism assembly result rows in the view: - Create a row for each failure mechanism that is present in the AssessmentSection

WTI-1679

Options
    • -1
    • +19
    ./AssessmentSectionCombinedAssemblyResultViewTest.cs
  2. … 1 more file in changeset.
4:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced failure mechanism assembly result rows: - Used to create rows for the failure mechanisms for the data grid view control in the AssessmentSectionCombinedAssemblyResultView

WTI-1679

Options
    • -0
    • +71
    ./FailureMechanismAssemblyResultRowTest.cs
  2. … 3 more files in changeset.
4:13 pm

Elmar Kleijn

Renamed HydraulicBoundaryLocationOutput into HydraulicBoundaryLocationCalculationOutput. WTI-1698

Options
    • -1
    • +1
    ./AssessmentSectionViewTest.cs
    • -4
    • +4
    ./DesignWaterLevelCalculationsViewTest.cs
    • -4
    • +4
    ./WaveHeightCalculationsViewTest.cs
  4. … 86 more files in changeset.
4:05 pm

Dennis Tang <dennis.tang@deltares.nl>

Added initial setup of the total assembly for the assessment section: - added view with a datagridview control and tests

WTI-1679

Options
    • -0
    • +119
    ./AssessmentSectionCombinedAssemblyResultViewTest.cs
  2. … 5 more files in changeset.
Thursday 19 Apr 2018
4:43 pm

Carlos Lubbers

Fix failing tests WTI-1686

Options
    • -1
    • +1
    ./FailureMechanismContributionViewTest.cs
  2. … 18 more files in changeset.
Monday 16 Apr 2018
2:37 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Review related changes. Paired with kleijn. WTI-1612

Options
    • -9
    • +3
    ./AssessmentSectionViewTest.cs
  2. … 4 more files in changeset.
Thursday 12 Apr 2018
9:58 am

Elmar Kleijn

Review related changes. WTI-1612

Options
    • -6
    • +4
    ./AssessmentSectionViewTest.cs
  2. … 9 more files in changeset.
Tuesday 10 Apr 2018
2:48 pm

Elmar Kleijn

Review related changes. WTI-1612

Options
    • -5
    • +5
    ./AssessmentSectionViewTest.cs
  2. … 6 more files in changeset.
10:16 am

Elmar Kleijn

Review related changes. WTI-1612

Options
    • -10
    • +7
    ./AssessmentSectionViewTest.cs
  2. … 11 more files in changeset.
Friday 06 Apr 2018
12:02 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Renamed ObservableTestAssessmentSectionStub to AssessmentSectionStub WTI-1612

Options
    • -7
    • +7
    ./AssessmentSectionViewTest.cs
    • -1
    • +1
    ./DesignWaterLevelCalculationsViewTest.cs
    • -1
    • +1
    ./WaveHeightCalculationsViewTest.cs
  4. … 86 more files in changeset.
Wednesday 04 Apr 2018
1:25 pm

Elmar Kleijn

Adapted DesignWaterLevelCalculationsView and WaveHeightCalculationsView. WTI-1612

Options
    • -9
    • +9
    ./DesignWaterLevelCalculationsViewTest.cs
    • -9
    • +9
    ./WaveHeightCalculationsViewTest.cs
  3. … 2 more files in changeset.
Thursday 29 Mar 2018
10:53 am

Robert Tangerman <robert.tangerman@deltares.nl>

Uset setting all locations once instead of adding separate locations. WTI-1612

Options
    • -6
    • +26
    ./AssessmentSectionViewTest.cs
  2. … 15 more files in changeset.
Wednesday 28 Mar 2018
4:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2630: - Cleaned up tests -- Cleaned up for derivatives of the DataGridViewControl

WTI-1538

Options
    • -9
    • +12
    ./AssessmentSectionAssemblyCategoriesTableTest.cs
  2. … 4 more files in changeset.
4:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2630: - Cleaned up tests -- Cleaned up for derivatives of the DataGridViewControl

WTI-1538

Options
    • -9
    • +12
    ./AssessmentSectionAssemblyCategoriesTableTest.cs
  2. … 4 more files in changeset.
4:15 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2630: - Cleaned up tests -- removed hard coded constants as much as possible - Improved implementation of row object: -- Used attribute type converter instead of making a display wrapper every time - Renamed helper for clarification

WTI-1538

Options
    • -2
    • +2
    ./AssessmentSectionAssemblyCategoriesTableTest.cs
    • -10
    • +19
    ./AssessmentSectionAssemblyCategoriesViewTest.cs
    • -9
    • +7
    ./AssessmentSectionAssemblyCategoryRowTest.cs
  4. … 16 more files in changeset.
4:15 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2630: - Cleaned up tests -- removed hard coded constants as much as possible - Improved implementation of row object: -- Used attribute type converter instead of making a display wrapper every time - Renamed helper for clarification

WTI-1538

Options
    • -2
    • +2
    ./AssessmentSectionAssemblyCategoriesTableTest.cs
    • -10
    • +19
    ./AssessmentSectionAssemblyCategoriesViewTest.cs
    • -9
    • +7
    ./AssessmentSectionAssemblyCategoryRowTest.cs
  4. … 16 more files in changeset.