Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Incorporated comments review 3445: WTI-1925

- Cleaned up code

- Moved logging from the importer to the update helper

-- Cleaned up resources

-- Cleaned up tests

    • -14
    • +20
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
    • -4
    • +11
    ./HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
  1. … 9 more files in changeset.
Cleaned up test file WTI-1927

    • -4
    • +3
    ./HydraulicLocationConfigurationDatabaseImportHandlerTest.cs
Renamed interface method definition. WTI-1927

    • -3
    • +3
    ./HydraulicLocationConfigurationDatabaseImportHandlerTest.cs
  1. … 4 more files in changeset.
Added implementation of the import handler. WTI-1927

    • -1
    • +132
    ./HydraulicLocationConfigurationDatabaseImportHandlerTest.cs
  1. … 7 more files in changeset.
Added clearing output. WTI-1927

    • -1
    • +71
    ./HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
  1. … 1 more file in changeset.
Added constructor parameter. WTI-1927

    • -7
    • +24
    ./HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
  1. … 1 more file in changeset.
Return changed objects. WTI-1927

    • -0
    • +20
    ./HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
  1. … 1 more file in changeset.
Set settings in update handler. WTI-1927

    • -7
    • +45
    ./HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
  1. … 2 more files in changeset.
Moved helper to Helpers folder and moved constants to separate file. WTI-1927

    • -105
    • +0
    ./HydraulicLocationConfigurationSettingsUpdateHelperTest.cs
  1. … 8 more files in changeset.
Introduced helper for setting the settings. WTI-1927

    • -0
    • +105
    ./HydraulicLocationConfigurationSettingsUpdateHelperTest.cs
  1. … 3 more files in changeset.
Added null checks. WTI-1927

    • -0
    • +44
    ./HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
  1. … 1 more file in changeset.
Added confirmation dialog. WTI-1927

    • -1
    • +41
    ./HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
  1. … 3 more files in changeset.
Introduced update handler. WTI-1927

    • -0
    • +41
    ./HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
  1. … 3 more files in changeset.
Introduced import handler to handle with HLCD imports from the hydraulic boundary database property panel: WTI-1927

- Added empty handler class to be substituted in the RingtoetsPlugin to prevent ArgumentNullExceptions on runtime.

    • -0
    • +41
    ./HydraulicLocationConfigurationDatabaseImportHandlerTest.cs
  1. … 8 more files in changeset.
Incorporated comments PO: WTI-1925

- Changed default values for the HLCD information when there's no ScenarioInformation present in order to make it more insightful that default values are used.

    • -1
    • +1
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 1 more file in changeset.
Removed trackId from data model. WTI-1927

    • -1
    • +0
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 3 more files in changeset.
Incorporated comments review 3443: WTI-1925

- Added ArgumentException when the read hydraulic location configuration database contains multiple or zero items for the database settings.

-- Added factory and factory methods to verify behaviour

-- Renamed factory methods to be more representative

- Updated logic in the importer

    • -2
    • +38
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 11 more files in changeset.
Incorporated comments review 3443: WTI-1925

- Removed the IsScenarioInformationPresent flag from the read object.

    • -2
    • +2
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 10 more files in changeset.
Set TrackId in update handler. WTI-1927

    • -0
    • +1
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 1 more file in changeset.
Incorporated comments review 3442: WTI-1486

- Performed minor cleanup

    • -2
    • +2
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 1 more file in changeset.
Added hlcd file path as argument for the handler. WTI-1925

    • -41
    • +77
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 4 more files in changeset.
Added logic to the UpdateHandler: WTI-1925

- Added logic to set values of the HydraulicLocationConfigurationSettings of the HydraulicBoundaryDatabase based on the input arguments.

    • -0
    • +87
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 1 more file in changeset.
Improvements after review. WTI-1486

    • -2
    • +2
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 5 more files in changeset.
Improvements after review. WTI-1486

    • -7
    • +6
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 6 more files in changeset.
Improvements after review. WTI-1486

    • -10
    • +4
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 2 more files in changeset.
Improvements after review. WTI-1486

    • -57
    • +81
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 4 more files in changeset.
Improved handler to set right id. WTI-1486

    • -8
    • +17
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 1 more file in changeset.
Implemented filtering of locations. WTI-1486

    • -1
    • +82
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 1 more file in changeset.
Added null check. WTI-1486

    • -0
    • +19
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 1 more file in changeset.
Fixed compilation errors. WTI-1486

    • -11
    • +24
    ./HydraulicBoundaryDatabaseUpdateHandlerTest.cs
  1. … 2 more files in changeset.