Riskeer / Ringtoets / MacroStabilityInwards / src / Ringtoets.MacroStabilityInwards.Service

MacroStabilityInwardsInputValidator.cs

Clone Tools

Stats

Commits this week: 0
Total Committers: 5
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 03 Sep 2018
11:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Final improvements after review. WTI-1714

Options
    • -1
    • +2
    ./MacroStabilityInwardsInputValidator.cs
  2. … 2 more files in changeset.
11:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Final improvements after review. WTI-1714

Options
    • -1
    • +2
    ./MacroStabilityInwardsInputValidator.cs
  2. … 2 more files in changeset.
Friday 31 Aug 2018
9:56 am

Elmar Kleijn

Removed some duplicate resources. WTI-1714

Options
    • -1
    • +1
    ./MacroStabilityInwardsInputValidator.cs
  2. … 7 more files in changeset.
9:35 am

Elmar Kleijn

Removed some duplicate resources. WTI-1714

Options
    • -1
    • +1
    ./MacroStabilityInwardsInputValidator.cs
  2. … 11 more files in changeset.
Friday 24 Aug 2018
1:24 pm

Carlos Lubbers

Reduce code smells from sonarqube in macrostability namespace WTI-1787

Options
    • -5
    • +3
    ./MacroStabilityInwardsInputValidator.cs
  2. … 3 more files in changeset.
Thursday 16 Aug 2018
1:23 pm

Elmar Kleijn

Renamed "randvoorwaarden" into "belastingen". WTI-1714

Options
    • -1
    • +3
    ./MacroStabilityInwardsInputValidator.cs
  2. … 19 more files in changeset.
Thursday 15 Mar 2018
9:03 am

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.3: Incorporated comments review 2573: - Removed obsolete guard clause

paired with ~kleijn

Related to Issue [WTI-1593]

Options
    • -8
    • +0
    ./MacroStabilityInwardsInputValidator.cs
8:46 am

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.2: Incorporated comments review 2573: - Removed obsolete guard clause

paired with ~kleijn

Related to Issue [WTI-1593]

Options
    • -8
    • +0
    ./MacroStabilityInwardsInputValidator.cs
8:46 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2573: - Removed obsolete guard clause

paired with ~kleijn

Related to Issue [WTI-1593]

Options
    • -8
    • +0
    ./MacroStabilityInwardsInputValidator.cs
8:43 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated edge case: - Improved algorithm to also take the soil profile coordinates into account when discretizing the surfaceline to prevent the resolution of the surfaceline discretization to be too course for the validation - Added testcase Related to Issue [WTI-1593]

Options
    • -6
    • +44
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
8:43 am

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.3: Incorporated edge case: - Improved algorithm to also take the soil profile coordinates into account when discretizing the surfaceline to prevent the resolution of the surfaceline discretization to be too course for the validation - Added testcase Related to Issue [WTI-1593]

Options
    • -6
    • +44
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
8:43 am

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.2: Incorporated edge case: - Improved algorithm to also take the soil profile coordinates into account when discretizing the surfaceline to prevent the resolution of the surfaceline discretization to be too course for the validation - Added testcase Related to Issue [WTI-1593]

Options
    • -6
    • +44
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
Friday 09 Mar 2018
3:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2556: - Made tolerances for 2D profile similar as the 1D profile and adjusted tests - Cleaned up sourcefile, improved clipping logic -- Added tests to verify clipping Related to Issue [WTI-1593]

Options
    • -14
    • +14
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
3:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.2: Incorporated comments review 2556: - Made tolerances for 2D profile similar as the 1D profile and adjusted tests - Cleaned up sourcefile, improved clipping logic -- Added tests to verify clipping Related to Issue [WTI-1593]

Options
    • -14
    • +14
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
3:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.3: Incorporated comments review 2556: - Made tolerances for 2D profile similar as the 1D profile and adjusted tests - Cleaned up sourcefile, improved clipping logic -- Added tests to verify clipping Related to Issue [WTI-1593]

Options
    • -14
    • +14
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
3:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.2: Incorporated comments tester: - Improved algorithm: instead of determining (Euclidean) distance between segments and points of the surfaceline, do: -- Discretize the surfaceline while it's clipped to the soil profile definition -- Look for the maximum Y coordinate of the soil profile on each discretized X coordinate of the surfaceline - Added and improved tests Related to Issue [WTI-1593]

Options
    • -49
    • +43
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
3:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments tester: - Improved algorithm: instead of determining (Euclidean) distance between segments and points of the surfaceline, do: -- Discretize the surfaceline while it's clipped to the soil profile definition -- Look for the maximum Y coordinate of the soil profile on each discretized X coordinate of the surfaceline - Added and improved tests Related to Issue [WTI-1593]

Options
    • -49
    • +43
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
3:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.3: Incorporated comments tester: - Improved algorithm: instead of determining (Euclidean) distance between segments and points of the surfaceline, do: -- Discretize the surfaceline while it's clipped to the soil profile definition -- Look for the maximum Y coordinate of the soil profile on each discretized X coordinate of the surfaceline - Added and improved tests Related to Issue [WTI-1593]

Options
    • -49
    • +43
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
Wednesday 28 Feb 2018
4:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.3: Incorporated comments review 2522: - Improved tests - Improved algorithm: instead of selecting X,Y coordinates at X for each layer, determine the intersections of the profile at X and retrieve its Y-coordinates Related to Issue [WTI-1593]

Options
    • -14
    • +15
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
4:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2522: - Improved tests - Improved algorithm: instead of selecting X,Y coordinates at X for each layer, determine the intersections of the profile at X and retrieve its Y-coordinates Related to Issue [WTI-1593]

Options
    • -14
    • +15
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
4:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.2: Incorporated comments review 2522: - Improved tests - Improved algorithm: instead of selecting X,Y coordinates at X for each layer, determine the intersections of the profile at X and retrieve its Y-coordinates Related to Issue [WTI-1593]

Options
    • -14
    • +15
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
4:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.2: Incorporated comments review 2518: - Improved tests - Renamed functions and updated XMLDocs Related to Issue [WTI-1592]

Options
    • -2
    • +2
    ./MacroStabilityInwardsInputValidator.cs
  2. … 20 more files in changeset.
4:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.3: Incorporated comments review 2523: - Improved tests - Updated XMLDocs

Related to Issue [WTI-1592]

Options
    • -2
    • +2
    ./MacroStabilityInwardsInputValidator.cs
  2. … 19 more files in changeset.
4:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2518: - Improved tests - Renamed functions and updated XMLDocs Related to Issue [WTI-1592]

Options
    • -2
    • +2
    ./MacroStabilityInwardsInputValidator.cs
  2. … 20 more files in changeset.
Tuesday 27 Feb 2018
2:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented fix for no validation messages when the soil layer bottom lies on the surface line, but the top does not: - Renamed variable names

Related to Issue [WTI-1593]

Options
    • -7
    • +7
    ./MacroStabilityInwardsInputValidator.cs
2:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.2: Implemented fix for no validation messages when the soil layer bottom lies on the surface line, but the top does not: - Renamed variable names

Related to Issue [WTI-1593]

Options
    • -7
    • +7
    ./MacroStabilityInwardsInputValidator.cs
2:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.3: Implemented fix for no validation messages when the soil layer bottom lies on the surface line, but the top does not: - Renamed variable names

Related to Issue [WTI-1593]

Options
    • -7
    • +7
    ./MacroStabilityInwardsInputValidator.cs
2:25 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented fix for no validation messages when the soil layer bottom lies on the surface line, but the top does not: - Changed validation: take the maximum Y coordinate for each X coordinate and compare these with the surface line instead of determining if there's any layer on the surface line

Related to Issue [WTI-1593]

Options
    • -8
    • +37
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
2:25 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.2: Implemented fix for no validation messages when the soil layer bottom lies on the surface line, but the top does not: - Changed validation: take the maximum Y coordinate for each X coordinate and compare these with the surface line instead of determining if there's any layer on the surface line

Related to Issue [WTI-1593]

Options
    • -8
    • +37
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
2:25 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.3: Implemented fix for no validation messages when the soil layer bottom lies on the surface line, but the top does not: - Changed validation: take the maximum Y coordinate for each X coordinate and compare these with the surface line instead of determining if there's any layer on the surface line

Related to Issue [WTI-1593]

Options
    • -8
    • +32
    ./MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.