Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merged from release 17.2:

Implemented fix for erroneous validation messages when the soil layer has its start- and end point defined on one side of the surfaceline:

- Added function in Math2D to convert line points to segments with one added segment to close the gap between start- and end point

- Added testcases for the validator

Related to Issue [WTI-1592]

    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
  1. … 3 more files in changeset.
Introduced method to bind events after loading view instead of in constructor. WTI-1627

    • -5
    • +8
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  1. … 20 more files in changeset.
Incorporated comments review 2511: - Updated XMLDocs - Improved tests and testnames

Paired with ~carloslubbers

WTI-1616

    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  1. … 6 more files in changeset.
Made GetDataAtRow return value typed. WTI-1627

    • -3
    • +2
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  1. … 18 more files in changeset.
Made AddDataGridColumns abstract. WTI-1627

    • -1
    • +4
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  1. … 19 more files in changeset.
Made return type of CreateFailureMechanismSectionResultRow in FailureMechanismResultView the type of the section result row. WTI-1627

    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  1. … 19 more files in changeset.
Added failure mechanism section result row type to the FailureMechanismResultView. WTI-1627

    • -3
    • +2
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
    • -2
    • +2
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismSectionResultRow.cs
  1. … 44 more files in changeset.
Improved GetViewName implementation in ViewInfo. WTI-1563 => Original data is now passed instead of view data

    • -6
    • +6
    ./Ringtoets.MacroStabilityInwards.Plugin/MacroStabilityInwardsPlugin.cs
  1. … 13 more files in changeset.
Review related improvements. Add xmldocs, remove unneeded null checks in containers and added tests to some detailed assessment extensions WTI-1616

    • -4
    • +4
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -22
    • +60
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultDetailedAssessmentExtensions.cs
  1. … 15 more files in changeset.
Review related changes. Improve calculator/factories and their tests. WTI-1616

    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  1. … 30 more files in changeset.
Review related changes. Use data model instead of cell value when checking for read-onlyness WTI-1617

    • -2
    • +2
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  1. … 21 more files in changeset.
Rename resources containing "(afgerond)" to include _Rounded_ WTI-1531

    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/MacroStabilityInwardsFailureMechanismProperties.cs
  1. … 8 more files in changeset.
Review related changes, rename resources and cleanup WTI-1617

    • -3
    • +3
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  1. … 22 more files in changeset.
Review related changes, renamed HasPassedSimpleAssessment and used test failuremechanism instead of simple failure mechanism WTI-1617

    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  1. … 20 more files in changeset.
Review related changes, update xmldoc and fix tests WTI-1617

    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResult.cs
  1. … 19 more files in changeset.
Move inheritdoc tag and use helper method for dune erosion result view WTI-1617

    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  1. … 17 more files in changeset.
Review related changes. Improve assembly factory formatting. WTI-1620

    • -2
    • +2
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  1. … 6 more files in changeset.
Review related changes. Improve formatting of factories WTI-1620

    • -9
    • +13
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  1. … 9 more files in changeset.
Review related changes. Rename AssemblyFactoryException -> AssemblyException WTI-1620

    • -4
    • +4
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  1. … 43 more files in changeset.
Review related changes, update XMLDoc for assembly factory methods WTI-1620

    • -4
    • +4
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  1. … 17 more files in changeset.
Review related changes, update XMLDoc for assembly factories WTI-1620

    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  1. … 17 more files in changeset.
Rename detailed assessment extension classes and tests WTI-1616

    • -179
    • +0
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionDetailedAssessmentResultExtensions.cs
    • -0
    • +179
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultDetailedAssessmentExtensions.cs
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/Ringtoets.MacroStabilityInwards.Data.csproj
  1. … 33 more files in changeset.
Add tests for grass cover erosion inwards assembly factory WTI-1616

    • -2
    • +2
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  1. … 3 more files in changeset.
Rename AssessmentLayerTwoA -> DetailedAssessmentProbability WTI-1616

    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionDetailedAssessmentResultExtensions.cs
  1. … 17 more files in changeset.
Add detailed assessment assembly factory method to macro stability inwards WTI-1616

    • -0
    • +131
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -68
    • +0
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultsAssemblyFactory.cs
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/Ringtoets.MacroStabilityInwards.Data.csproj
    • -2
    • +0
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismSectionResultRow.cs
  1. … 6 more files in changeset.
Rename data model properties for macrostability inwards WTI-1616

    • -174
    • +0
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSection2aAssessmentResultExtensions.cs
    • -0
    • +179
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionDetailedAssessmentResultExtensions.cs
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/Ringtoets.MacroStabilityInwards.Data.csproj
    • -7
    • +7
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
    • -16
    • +3
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismSectionResultRow.cs
  1. … 7 more files in changeset.
Rename GetSectionSpecificN to GetN WTI-1616

    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/MacroStabilityInwardsFailureMechanismProperties.cs
  1. … 8 more files in changeset.
Revert Func --> RoundedDouble Replacement for MacroStabilityInwards

This reverts commit f00ef179f4b76ecd6fcfe67b1e6ea797e8525509.

WTI-1562

    • -7
    • +11
    ./Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/MacroStabilityInwardsInputContextProperties.cs
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Plugin/MacroStabilityInwardsPlugin.cs
  1. … 4 more files in changeset.
Rename SimpleAssessmentInput->SimpleAssessmentResult WTI-1617

    • -2
    • +2
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResult.cs
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultsAssemblyFactory.cs
    • -3
    • +3
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
    • -3
    • +3
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismSectionResultRow.cs
  1. … 3 more files in changeset.
Rename some resources WTI-1617

    • -2
    • +2
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  1. … 21 more files in changeset.