Riskeer / Ringtoets

MacroStabilityInwards

Clone Tools

Stats

Commits this week: 0
Total Committers: 6
Last Commit: 26 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 23 Jul 2018
3:37 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced new calculation input interface for exposing hydraulic boundary location. WTI-1731

Options
    • -6
    • +3
    ./src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsInput.cs
  2. … 11 more files in changeset.
Tuesday 03 Jul 2018
3:56 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3036

- Renamed factory method for clarification.

WTI-1473

Options
    • -6
    • +6
    ./test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationActivityFactoryTest.cs
  2. … 3 more files in changeset.
3:14 pm

Carlos Lubbers

Implement review comments, improve tests and move methods in plugins WTI-1740

Options
    • -14
    • +14
    ./src/Ringtoets.MacroStabilityInwards.Plugin/MacroStabilityInwardsPlugin.cs
  2. … 6 more files in changeset.
Friday 29 Jun 2018
4:19 pm

Carlos Lubbers

Implement review comments WTI-1738

Options
    • -2
    • +2
    ./src/Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsCalculationActivityFactory.cs
    • -3
    • +27
    ./test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationActivityFactoryTest.cs
  3. … 4 more files in changeset.
3:49 pm

Carlos Lubbers

Update xmldoc WTI-1739

Options
    • -2
    • +2
    ./src/Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsCalculationActivityFactory.cs
  2. … 2 more files in changeset.
1:20 pm

Carlos Lubbers

Update test name WTI-1741

Options
    • -1
    • +1
    ./test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationActivityFactoryTest.cs
9:50 am

Carlos Lubbers

Make macro stability inwards calculation activity private and use factory in plugin WTI-1741

Options
    • -24
    • +11
    ./src/Ringtoets.MacroStabilityInwards.Plugin/MacroStabilityInwardsPlugin.cs
    • -1
    • +1
    ./src/Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsCalculationActivity.cs
9:46 am

Carlos Lubbers

Introduce factory for macro stability inwards WTI-1741

Options
    • -0
    • +116
    ./src/Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsCalculationActivityFactory.cs
    • -0
    • +1
    ./src/Ringtoets.MacroStabilityInwards.Service/Ringtoets.MacroStabilityInwards.Service.csproj
    • -0
    • +266
    ./test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationActivityFactoryTest.cs
    • -0
    • +1
    ./test/Ringtoets.MacroStabilityInwards.Service.Test/Ringtoets.MacroStabilityInwards.Service.Test.csproj
Tuesday 26 Jun 2018
9:02 am

Carlos Lubbers

Remove contribution check from macro inwards WTI-1755

Options
    • -37
    • +6
    ./src/Ringtoets.MacroStabilityInwards.Plugin/MacroStabilityInwardsPlugin.cs
    • -57
    • +0
    ./test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsCalculationGroupContextTreeNodeInfoTest.cs
    • -44
    • +0
    ./test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsCalculationScenarioContextTreeNodeInfoTest.cs
    • -54
    • +0
    ./test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsFailureMechanismContextTreeNodeInfoTest.cs
Monday 25 Jun 2018
1:04 pm

Carlos Lubbers

Implement review comments, update test names in common activites and add asserts in piping and macro treenode info tests for calculate all log messages WTI-1754

Options
    • -11
    • +30
    ./test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsCalculationGroupContextTreeNodeInfoTest.cs
    • -10
    • +28
    ./test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsFailureMechanismContextTreeNodeInfoTest.cs
  3. … 5 more files in changeset.
12:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Committed rename changes Note: compiling erros in the tests and testutils are still present

Options
    • -2
    • +2
    ./src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanism.cs
    • -3
    • +3
    ./test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsFailureMechanismAssemblyFactoryTest.cs
    • -3
    • +3
    ./test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsFailureMechanismTest.cs
    • -2
    • +2
    ./test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsTestDataGenerator.cs
    • -1
    • +1
    ./test/Ringtoets.MacroStabilityInwards.Data.TestUtil/TestMacroStabilityInwardsFailureMechanism.cs
    • -14
    • +14
    ./test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsCalculationsViewTest.cs
    • -4
    • +4
    ./test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsFailureMechanismViewTest.cs
    • -8
    • +8
    ./test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsScenariosViewTest.cs
    • -4
    • +4
    ./test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsCalculationGroupContextTreeNodeInfoTest.cs
    • -2
    • +2
    ./test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsCalculationScenarioContextTreeNodeInfoTest.cs
  11. … 129 more files in changeset.
Friday 22 Jun 2018
9:18 am

Elmar Kleijn

Review related changes. WTI-1719

Options
    • -1
    • +1
    ./test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationActivityTest.cs
  2. … 2 more files in changeset.
Wednesday 20 Jun 2018
4:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2978: - Cleaned up tests - Refactored

WTI-1694

Options
    • -3
    • +3
    ./src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsInputView.cs
    • -17
    • +18
    ./test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsInputViewTest.cs
    • -0
    • +1
    ./test/Ringtoets.MacroStabilityInwards.Plugin.Test/ViewInfos/MacroStabilityInwardsInputViewInfoTest.cs
  4. … 2 more files in changeset.
2:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2977: - Remove exception messages for NotSupportedExceptions that only occur in the 'default' switch state.

WTI-1694

Options
    • -1
    • +1
    ./src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultDetailedAssessmentExtensions.cs
  2. … 23 more files in changeset.
2:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Fixed failing tests

WTI-1694

Options
    • -0
    • +4
    ./test/Ringtoets.MacroStabilityInwards.Plugin.Test/ViewInfos/MacroStabilityInwardsInputViewInfoTest.cs
1:39 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced assessment section as a constructor argument: - Wired view in the plugin -- Fixed associated view info tests

WTI-1694

Options
    • -1
    • +2
    ./src/Ringtoets.MacroStabilityInwards.Plugin/MacroStabilityInwardsPlugin.cs
    • -15
    • +48
    ./test/Ringtoets.MacroStabilityInwards.Plugin.Test/ViewInfos/MacroStabilityInwardsInputViewInfoTest.cs
10:56 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced assessment section as a constructor argument: - View should subscribe to the correct hydraulic boundary location calculation after the normative norm changes. -- Added tests to verify behaviour

WTI-1694

Options
    • -1
    • +13
    ./src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsInputView.cs
    • -1
    • +55
    ./test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsInputViewTest.cs
10:40 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced assessment section as a constructor argument: - View should subscribe to the correct hydraulic boundary location calculation after the normative norm changes.

WTI-1694

Options
    • -0
    • +3
    ./src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsInputView.cs
    • -13
    • +169
    ./test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsInputViewTest.cs
10:28 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Fixed failing tests

WTI-1694

Options
    • -18
    • +24
    ./test/Ringtoets.MacroStabilityInwards.Plugin.Test/ViewInfos/MacroStabilityInwardsInputViewInfoTest.cs
10:27 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Cleaned up test for the input view

Note: the input of the assessment level generated by the hydraulic boundary location cannot be asserted, because the daily waternet calculator input overwrites the extreme waternet calculator input.

WTI-1694

Options
    • -49
    • +34
    ./test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsInputViewTest.cs
8:52 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced extension method for the assessmentsection based on its normtype to retrieve the corresponding normative hydraulic boundary location calculation: - Rewired the macrostability inwards view

WTI-1694

Options
    • -1
    • +1
    ./src/Ringtoets.MacroStabilityInwards.Plugin/MacroStabilityInwardsPlugin.cs
Tuesday 19 Jun 2018
4:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Changed Func from returning assessment level to a hydraulic boundary location calculation: - Done to perform a dynamic resolving the assessment level in the view for redrawing the waternet zones -- Added observer to listen to changes of the hydraulic boundary location calculation - Removed setter logic --> data is set by means of constructor arguments

WTI-1694

Options
    • -11
    • +18
    ./src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsInputView.cs
    • -23
    • +119
    ./test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsInputViewTest.cs
4:21 pm

Elmar Kleijn

Adapted corresponding tests. WTI-1719

Options
    • -18
    • +2
    ./test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationActivityTest.cs
  2. … 1 more file in changeset.
4:14 pm

Elmar Kleijn

Adapted PipingCalculationActivity and MacroStabilityInwardsCalculationActivity. WTI-1719

Options
    • -19
    • +12
    ./src/Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsCalculationActivity.cs
  2. … 1 more file in changeset.
10:30 am

Elmar Kleijn

Adapted tests for all wave condition calculations (3x). WTI-1719

Options
    • -1
    • +0
    ./test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsCalculationTest.cs
  2. … 4 more files in changeset.
10:23 am

Elmar Kleijn

Adapted tests for piping and macro stabilty inwards. WTI-1719

Options
    • -4
    • +36
    ./test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsCalculationTest.cs
  2. … 1 more file in changeset.
9:37 am

Elmar Kleijn

Adapted PipingCalculation, MacroStabilityInwardsCalculation and the wave condition calculations (3x). WTI-1719

Options
    • -0
    • +8
    ./src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsCalculation.cs
  2. … 5 more files in changeset.
Monday 18 Jun 2018
11:05 am

Dennis Tang <dennis.tang@deltares.nl>

Changed intersection algorithm: - Clip the draw area between maximum and minimum X coordinates of the surface line when relevant to prevent intersections not being found when the soil model has coordinates outside the surface line X interval -- Only relevant for waternet zones who are partially above the surface line - Adjusted area definition algorithm -- Algorithm did not take intermediate intersection points into account when the waternet zone top is above the y coordinate of the surfaceline, while the waternet zone bottom is exactly on the y coordinate of the surface line -- Adjusted failing tests to include these coordinates as well.

WTI-1664

Options
    • -10
    • +17
    ./src/Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataPointsFactory.cs
    • -3
    • +84
    ./test/Ringtoets.MacroStabilityInwards.Forms.Test/Factories/MacroStabilityInwardsChartDataPointsFactoryTest.cs
Wednesday 13 Jun 2018
3:19 pm

Carlos Lubbers

Wire new view to Ringtoets plugin WTI-1542

Options
    • -3
    • +4
    ./test/Ringtoets.MacroStabilityInwards.Plugin.Test/ViewInfos/MacroStabilityInwardsFailureMechanismSectionsProbabilityAssessmentViewInfoTest.cs
  2. … 11 more files in changeset.
2:16 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Wrap FailureMechanismSection assembly error for macro stability inwards. WTI-1724

Options
    • -6
    • +11
    ./src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    ./test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsFailureMechanismAssemblyFactoryTest.cs