PipingSurfaceLinesCsvImporterTest.cs

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Incorporated comments review 1444: - Improved test and variable names - Renamed test class to reflect which class it's actually testing Related to Issue [WTI-1083]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8122 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 361a2b40edd09623e9908c2a3554a95e477a196a

Former-commit-id: 63116986ccb04e7f07fecf7919539179bf1ac726

    • -2
    • +2
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 4 more files in changeset.
Converted the ObservableCollection holding the surface lines in the PipingFailureMechanism into an ObservableCollectionWithSourcePath: - Fixed compiling errors and failing tests

Note: storage functionality is not enabled yet and file location will not persist at this moment!

Related to Issue [WTI-1083]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8070 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4f6e7d5a4f4e8f047a6230835920361b8cf39f2d

Former-commit-id: 3699faaf2ab4c01df1729eb0c274687cedb599b8

    • -81
    • +66
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 17 more files in changeset.
Enable canceling when importing the piping surface lines: - Removed obsolete message to indicate adding imported data to the data model started - Adjusted affected tests

Related to Issue [WTI-492]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7711 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8b0d2f22603df608a58d5968d19089bb36f2669c

Former-commit-id: 45262a5aaf08943706c2f5aaa61a89736dfe9a78

    • -28
    • +18
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 3 more files in changeset.
Enable canceling when importing the piping surface lines: - Removed obsolete message to indicate adding imported data to the data model was finished - Removed alias for the RingtoetsPipingPluginResources in the importer - Adjusted affected tests Related to Issue [WTI-492]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7710 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d936c482a1dfea814cecb7ddf310ce0ce88cd087

Former-commit-id: d06eed43a24d9562290ee2d93a740f8a4d0efa91

    • -30
    • +20
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 3 more files in changeset.
Enable canceling when importing the piping surface lines: - Extracted the add-function from the AddImportedDataToModel - Added test to verify behavior when canceling during the processing of the imported data

Note:

There's no test to verify the behavior when the user cancels between the steps of processing the import data and actually adding the processed import data to the ObservableList of PipingSurfaceLines. This is because there's no NotifyProgress handle in this stage to subscribe on (and subsequently cancel the action)

Related to Issue [WTI-492]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7706 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: db6a521f81e69375ec4d9677ca802918d911aa7b

Former-commit-id: fbb8d18747770829ef3c6d51afc3ccc031bcaf5b

    • -6
    • +7
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 1 more file in changeset.
Incorporated comments review 1385: (Editorial) - Made the spelling of "Canceled" or "Uncancelable (opposed to "Cancelled" or "Uncancellable") consistent throughout the application.

Note:

"Cancellation" is legit U.S. spelling and therefore unchanged. "Cancelation" is not common and rarely used.

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7669 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 665e259f03237740e63d6441088354043dae52f2

Former-commit-id: 98c98ae04c081843c7bab2c55946744a8d06dad2

    • -1
    • +1
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 35 more files in changeset.
- Added NotifyProgress calls when adding data to the data model - Synchronised message values across all the importers

Note:

No tests are available to verify the cancel behaviour for the FeatureBasedMapData because it has no NotifyProgress (and consequently no SetProgress handle to set the Action it should execute during the import)

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7655 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ee82e9d839a1acfffb0ccb4ff219a30856c744e7

Former-commit-id: a79f8f2e64e63d1e9bac5672052dc8bc143bf91f

    • -9
    • +9
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 18 more files in changeset.
Implemented Reuse tests in the concrete implementations of the FileImporterBase Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7650 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d766c4944786409b114582323cf947d60e99337f

Former-commit-id: 0ff0cb1b31a88afc319a093050888e49cd2428f5

    • -1
    • +2
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 5 more files in changeset.
Merged revision(s) 7595-7638 from branches/WTI-490:

Merged revision(s) 7537-7594 from trunk

........

Initial commit of changes from kleijn:

- Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles

- Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage

- Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

........

Fixed tests of the FileImporterBase and Activity:

- Checks on the states are made for the 4 different paths of the Import:

-- Import successful, canceled or not

-- Import not successful, canceled or not

- Moved logging from the activity to the importer

- Added tests to assert mentioned behaviour

........

Fixed tests of the PipingSurfaceLinesCsvImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Added resource value for the ImportActivity (missing file commit)

........

Fixed tests of the PipingSoilProfilesImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned redundant brackets

........

Fixed tests of the StructuresImporter:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

Adjusted test in PipingSoilProfilesImporterTest

- Changed initial value of the result to make clear that the value is set correctly

........

Fixed tests of the ProfilesImporters:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Removed obsolete Cancel call in the PipingSoilProfilesImporterTest

........

FileImporters should call Observers in case the import was successfull AND was cancelled at an uncancellable stage.

Note: test is missing to verify this behaviour

........

Fixed tests of the ProfilesImporters:

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Temporarily removed the Cancel tests, because the FeatureBasedMapDataImporter does not have a handle for NotifyProgress. Hence, Cancel method cannot be invoked when Import is running.

........

Fixed tests of the FailureMechanismSectionsImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned up tests in the StructuresImporterTest

........

Fixed tests of the ReferenceLineImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

........

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7646 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1c355702dfbd410c7c4733529d8db9e243496eba

Former-commit-id: 75c614862d018947936ef85e3775a125c425c032

    • -32
    • +84
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 26 more files in changeset.
Fixed tests of the PipingSoilProfilesImporter: - Added test to verify behaviour when canceling at the three stages during the import - Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base - Cleaned redundant brackets Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7620 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: abd77e13efd2eb809d6cb6c117aaa59c65c65d46

Former-commit-id: f0404e75a098165b1f9b664e5d8a02b9d6ee08ba

    • -1
    • +1
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 2 more files in changeset.
Fixed tests of the PipingSurfaceLinesCsvImporter: - Added test to verify behaviour when canceling at the two stages during the import - Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base - Added resource value for the ImportActivity (missing file commit)

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7618 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 57abd999d6185e5e4841d6fa1c380dc3c8c9cc39

Former-commit-id: 836f2fc05903415944c167b13983d49f290d5216

    • -32
    • +84
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 5 more files in changeset.
Initial commit of changes from kleijn: - Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles - Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage - Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7598 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 409bfee1e3deebb4fe4368cb7010a8c4c37dae5e

Former-commit-id: 98175da77f6910f259097a90626bbb10450e2c8f

    • -2
    • +2
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 20 more files in changeset.
* Added standard serialization constructor to all Exception classes. * Explicitly defined culture for string.Format methods. * Replaced IFileImporter.ProgressChanged property to method (recommendation by C# coding conventions) * Renamed classes containing win32.dll invokes to NativeMethods (recommendation by C# coding conventions)

Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6471 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 78fae4fb038935c7a58a0fb534baa750b173d589

Former-commit-id: fc7d0938a3677be66218915a3e665a9cc6757df9

    • -59
    • +54
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 164 more files in changeset.
Review related changes Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6322 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 37e86559ae4790987e4af641c1fb382679c89a8f

Former-commit-id: e122779f90d7530bd1f06a3a41b86278552c458b

    • -2
    • +2
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 15 more files in changeset.
Changed "1" to "één" Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5946 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a3cae61bf48d3fabc629f3506a158e4614818e7c

Former-commit-id: 16c84742f1230a383219da4c555157b8fe649df2

    • -2
    • +2
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 15 more files in changeset.
* RingtoetsPipingSurfaceLinesContext now works on ObservableList<RingtoetsPipingSurfaceLine> Related to Issue [WTI-497]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5094 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1c1acec869ee9e16d670526cc7a923e3ccd54de2

Former-commit-id: 79cfeb6f25efeaa03fef8cf37a774a360c44e5f1

    • -3
    • +3
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 9 more files in changeset.
Renamed GuiTestHelper.cs to PluginTestHelper.cs to better match its purpose and to prevent name collision. Added aliasses for Ringtoets.Common.Forms resources. Related to Issue [WTI-746]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5042 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 892483c63a47a4fc32f420ff756c73639adf6212

Former-commit-id: 4e4de303f6d384789d4b975aba493e9d5106dce9

    • -1
    • +0
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 86 more files in changeset.
* FileImporterBase now takes the import targets as constructor argument. ** Removed targetItem argument from IFileImporter.DoPostImportUpdates. * Removed abstract keyword from FileImportBase.ProgressChanged. Related to Issue [WTI-497]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5033 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5a81cae977dee513511a3257dedbeba6df57983a

Former-commit-id: cc770d424d622685b68b2d59f2c6fe21d1cd949c

    • -1
    • +1
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 17 more files in changeset.
* Moved filePath argument from IFileImporter.Import to import class constructor. Related to Issue [WTI-497]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5023 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7c21b2cb0e14ce82b05211488ea6dd8b8f3ef8a4

Former-commit-id: 38d3653a05f0b36eb7d42bd93a7b8a1f4b44f453

    • -56
    • +56
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 29 more files in changeset.
* Removed unsued properties and methods from IFileImporter. ** Added 'name' argument to FileImportActivity constructor. * Removed 'targetItem' from IFileImport.Import method. * Refactored GuiImportHandler to work with importInfo. Related to Issue [WTI-497]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5016 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bdc6bd3e00fb0ed24703b91de78e974e322b8cdf

Former-commit-id: 52be75d229dca9b85b83ee556983e03267adadf1

    • -84
    • +29
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 24 more files in changeset.
* Migrated PipingSurfaceLinesCsvImporter to ImportInfo

Related to Issue [WTI-497]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@4996 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1af9c83ba4402cb87418b593d486ab4f9c8a2724

Former-commit-id: 0c6b2a6ce5727efae2355a06a2f11f5b224f0288

    • -447
    • +145
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 10 more files in changeset.
Merged revision(s) 4809 from branches/Release/16_1_1: used types instead of classes. ........

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@4810 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 609707e227dfe347a5c146a366a08f545f707a4f

Former-commit-id: 7fbafeaee300c9098f33e9d5c0f15762322a1aaf

    • -1
    • +1
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 42 more files in changeset.
used types instead of classes.

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/16_1_1@4809 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2d49d291c751b83d18db1b127964cf6fad11f9f0

Former-commit-id: 089fa64a64d1179fa789896214136c696961151a

    • -1
    • +1
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 42 more files in changeset.
used types instead of classes.

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/16_1_1@4809 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 30fb3d6137e169b12adce2135be45125c2b4891c

Former-commit-id: 875a2da43679e9aa7d3f2524a730418ae601a007

    • -1
    • +1
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 42 more files in changeset.
* Cleanup Ringtoets.Piping.KernelWrapper and Ringtoets.Piping.IO Related to Issue [WTI-737]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@4757 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6fea391b9079b9f544d150daaaffac45d1a00164

Former-commit-id: 2794c744ed67102183220edda69a3c67b102db73

    • -3
    • +3
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 19 more files in changeset.
* Cleanup Ringtoets.Piping.Plugin.Test Related to Issue [WTI-737]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@4728 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bb29673b77cbdcb23b98f26ad1f54873774bdbd1

Former-commit-id: 415c5344d38ca4a3f34c7b09b9f98fc2b4190360

    • -128
    • +178
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 5 more files in changeset.
* Improved readability of tests * Turned String into string Related to Issue [WTI-757]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@4612 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 701ea98de739f0f328ead01558e5e443c904e706

Former-commit-id: cdb77cc67acfc2869c510cc8a1f32c0201a5f40e

    • -4
    • +4
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 141 more files in changeset.
Improvements after review. Related to Issue [WTI-396]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@3965 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 513b1c15424504ca557524bd3571bc295ca80d06

Former-commit-id: dea10becb9ac4710865c5e164c211656b2019ffa

    • -1
    • +1
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 10 more files in changeset.
Corrected spelling mistake + simplified messages. Related to Issue [WTI-469]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@3940 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f3d9231c37e95d363aeb69e9b15f3f0ace0e859c

Former-commit-id: ab60cd4a840f6a0c81a9f9011299209620bccf0b

    • -1
    • +1
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 13 more files in changeset.
Implemented validation in surface line importer; Entry point cannot be greater than exit point. Related to Issue [WTI-396]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@3862 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 48eca9e4def2df03c875ddfd090b184c817633d5

Former-commit-id: f1f61609ced85cf835a8d4ad6bc518d08b31b24c

    • -5
    • +56
    ./PipingSurfaceLinesCsvImporterTest.cs
  1. … 8 more files in changeset.