Riskeer / Ringtoets

StabilityPointStructures

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 03 Nov 2016
10:56 am

Marten Janssen <marten.janssen@deltares.nl>

- Check the code coverage configuration of the trunk Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6436 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 60655265b27b5521f0a53b0998b9ce77e069342f

Former-commit-id: e0560a24c08e4583c331a82ea5348baac1a32bfe

Options
    • -0
    • +1
    ./test/Ringtoets.StabilityPointStructures.Data.Test/Ringtoets.StabilityPointStructures.Data.Test.csproj
    • -0
    • +1
    ./test/Ringtoets.StabilityPointStructures.Data.TestUtil.Test/Ringtoets.StabilityPointStructures.Data.TestUtil.Test.csproj
    • -1
    • +2
    ./test/Ringtoets.StabilityPointStructures.Data.TestUtil/Ringtoets.StabilityPointStructures.Data.TestUtil.csproj
    • -0
    • +1
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/Ringtoets.StabilityPointStructures.Forms.Test.csproj
    • -0
    • +1
    ./test/Ringtoets.StabilityPointStructures.IO.Test/Ringtoets.StabilityPointStructures.IO.Test.csproj
    • -0
    • +1
    ./test/Ringtoets.StabilityPointStructures.Integration.Test/Ringtoets.StabilityPointStructures.Integration.Test.csproj
    • -0
    • +1
    ./test/Ringtoets.StabilityPointStructures.Plugin.Test/Ringtoets.StabilityPointStructures.Plugin.Test.csproj
    • -0
    • +1
    ./test/Ringtoets.StabilityPointStructures.Service.Test/Ringtoets.StabilityPointStructures.Service.Test.csproj
  9. … 90 more files in changeset.
10:53 am

Elmar Kleijn

Applied some improvements in the activity integration tests Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6435 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 29210b0c81cdd1e9c7fb7c401c7fd80e5c94435e

Former-commit-id: a231a0663ef672ab43e92971c987524f15367fb3

Options
    • -1
    • +1
    ./test/Ringtoets.StabilityPointStructures.Integration.Test/StabilityPointStructuresCalculationActivityIntegrationTest.cs
  2. … 3 more files in changeset.
10:27 am

Joël van den Berg

Moved HydraulicDatabaseHelper to Ringtoets.Common.IO project. Added validation for settings database to HydraulicDatabaseHelper. Related to Issue [WTI-919]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6434 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 171ff0f3f3dbe21be31af24be61309853967fd5a

Former-commit-id: 63c8b931ad8d57dd5f011643575ce5367f410bde

Options
    • -1
    • +1
    ./src/Ringtoets.StabilityPointStructures.Plugin/StabilityPointStructuresPlugin.cs
    • -0
    • +5
    ./src/Ringtoets.StabilityPointStructures.Service/Ringtoets.StabilityPointStructures.Service.csproj
    • -1
    • +1
    ./src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
  4. … 32 more files in changeset.
10:10 am

Elmar Kleijn

Improved some tests by using HydraRingCalculatorFactoryConfig Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6433 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6c5050d367dc6bdad9949e1a50fa886adfd3eec6

Former-commit-id: b77180387a52de6d5b288daa4726cc7a2a962bc8

Options
    • -21
    • +28
    ./test/Ringtoets.StabilityPointStructures.Integration.Test/StabilityPointStructuresCalculationActivityIntegrationTest.cs
  2. … 2 more files in changeset.
9:54 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments - Removed GetValidationRules function, as it also modifies the ValidationResults for StabilityPointStructures in case an invalid load schematization is selected. SRP would be broken Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6431 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 456a9614f43085ca67a3561466344e059a19934d

Former-commit-id: c0f67622829d90881ed2c31675d83d62c2972564

Options
    • -44
    • +38
    ./src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
9:20 am

Elmar Kleijn

Improved some tests by using HydraRingCalculatorFactoryConfig Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6429 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f09c1dd27fb560a56694125e29550ef09dc0fb6c

Former-commit-id: d1df8637395dbb481b15047725abb967bc38917f

Options
    • -0
    • +4
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/Ringtoets.StabilityPointStructures.Forms.Test.csproj
    • -2
    • +8
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresCalculationContextTreeNodeInfoTest.cs
    • -16
    • +14
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -16
    • +14
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresFailureMechanismContextTreeNodeInfoTest.cs
  5. … 11 more files in changeset.
Wednesday 02 Nov 2016
4:36 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments: - Changed behaviour when no LoadSchematizationType is selected: validation error message will be generated instead of throwing an exception - Extracted function for retrieving validation rules

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6414 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 70bb3378a42aee1aa48c31e1639af73c610992ca

Former-commit-id: 72644a4e86c67299114519c326efdd1e0edacc64

Options
    • -1
    • +11
    ./src/Ringtoets.StabilityPointStructures.Service/Properties/Resources.Designer.cs
    • -0
    • +3
    ./src/Ringtoets.StabilityPointStructures.Service/Properties/Resources.resx
    • -38
    • +44
    ./src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
    • -9
    • +14
    ./test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
4:15 pm

Marten Janssen <marten.janssen@deltares.nl>

Some XMLdoc related changes Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6411 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bbaac1a45d2179e5546f77417be59b41eecc6132

Former-commit-id: bb39b174b57eece0753191d02bc3f692afb84fc6

Options
    • -1
    • +1
    ./src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
  2. … 11 more files in changeset.
4:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments: - Editorial changes: moved lines around to improve coherence in the validation rules - Incorporated all changes related to the validation rules: changed resource name and documentation, removed unnecessary aliases and renamed function Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6410 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 23de8d55848dbe268d4cf73c0900c9cfe03b4f0f

Former-commit-id: dd70d0530bc045690a16927f5fc56ddbf5cfb98e

Options
    • -16
    • +8
    ./src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
  2. … 20 more files in changeset.
3:47 pm

Marten Janssen <marten.janssen@deltares.nl>

Deltares clean-up for Ringtoets.Revetment and Ringtoets.StabilityPointStructures Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6408 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6ab756305ce10a83275fc93899a868b985b1d3d0

Former-commit-id: 274bb7bccc5be0b20bdb0fdf5dade11492ef369e

Options
    • -1
    • +1
    ./src/Ringtoets.StabilityPointStructures.Data/LoadSchematizationType.cs
    • -1
    • +1
    ./src/Ringtoets.StabilityPointStructures.Data/StabilityPointStructureInflowModelType.cs
    • -1
    • +1
    ./src/Ringtoets.StabilityPointStructures.Forms/PresentationObjects/StabilityPointStructuresContext.cs
    • -50
    • +50
    ./src/Ringtoets.StabilityPointStructures.Forms/PropertyClasses/StabilityPointStructuresInputContextProperties.cs
    • -1
    • +0
    ./src/Ringtoets.StabilityPointStructures.Plugin/StabilityPointStructuresPlugin.cs
    • -2
    • +2
    ./src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
    • -2
    • +0
    ./test/Ringtoets.StabilityPointStructures.Data.Test/StabilityPointStructuresFailureMechanismSectionResultTest.cs
    • -5
    • +5
    ./test/Ringtoets.StabilityPointStructures.Data.TestUtil.Test/TestStabilityPointStructureTest.cs
    • -1
    • +1
    ./test/Ringtoets.StabilityPointStructures.Data.TestUtil/TestStabilityPointStructure.cs
    • -2
    • +2
    ./test/Ringtoets.StabilityPointStructures.Data.TestUtil/TestStabilityPointStructuresCalculation.cs
    • -1
    • +0
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresFailureMechanismPropertiesTest.cs
    • -1
    • +1
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresFailureMechanismSectionResultContextTreeNodeInfoTest.cs
    • -12
    • +12
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismResultViewTest.cs
    • -1
    • +0
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismSectionResultRowTest.cs
    • -5
    • +5
    ./test/Ringtoets.StabilityPointStructures.Integration.Test/StabilityPointStructuresCalculationActivityIntegrationTest.cs
  16. … 5 more files in changeset.
3:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments: - Editorial changes: moved lines around to improve consistency. Checked for similar tests across the Structures - Extracted function to retrieve validation rules depending on the calculation type in ClosingStructuresCalculationService - Changed parameter names

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6407 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e1580d2ed171698fd39b5bc43af134da09314a84

Former-commit-id: f5567d00dde1ac54ef7a753d24bc7c9d73dc1ff8

Options
    • -11
    • +10
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresCalculationContextTreeNodeInfoTest.cs
    • -11
    • +12
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -191
    • +191
    ./test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
  4. … 6 more files in changeset.
2:09 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments: - Removed Structure = new TestStructure() when TestCalculation objects are instantiated - Made type explicit when AssessmentSectionHelper.CreateAssessmentSectionStub is called - Fixed XML doc and formatting

Paired with tangerma

Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6395 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d63d3fe96336f31ad5d09f7e67078d2b07f12a95

Former-commit-id: 1b542c41b612011988665c20d48a6f2be23e3f28

Options
    • -51
    • +25
    ./test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
  2. … 10 more files in changeset.
11:47 am

Marten Janssen <marten.janssen@deltares.nl>

- Renamed private variables to match naming rule settings Related to Issue [WTI-924]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6389 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 493a1c24eee556aa6ee9a5ac644f28f4542f5617

Former-commit-id: 057b70959b5fd40d0ebfe0b5985a9a947c583381

Options
    • -280
    • +280
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresInputContextPropertiesTest.cs
11:46 am

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented Hydra-Ring last error handling for stability point structures.

Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6388 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 26ae25adbeac0fd981f4dda93e7b2758624e97e7

Former-commit-id: 9e2a2d9f392d316bcfdabfddadcb6e35b160bfef

Options
    • -3
    • +14
    ./src/Ringtoets.StabilityPointStructures.Service/Properties/Resources.Designer.cs
    • -2
    • +6
    ./src/Ringtoets.StabilityPointStructures.Service/Properties/Resources.resx
    • -3
    • +30
    ./src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
    • -2
    • +4
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -2
    • +4
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -0
    • +112
    ./test/Ringtoets.StabilityPointStructures.Integration.Test/StabilityPointStructuresCalculationActivityIntegrationTest.cs
    • -1
    • +193
    ./test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
  8. … 5 more files in changeset.
11:29 am

Marten Janssen <marten.janssen@deltares.nl>

- Updated EnumTypeConverter to -- Throw an Exception when value is not a valid value when a ResouceDisplayName is defined -- Return the string representation of the Enum when no ResourcesDisplayNameAttribute has been defined for that value -- Return the string representation of the Enum when value is not a valid Enum value - Added missing tests to StabilityPointStructuresInputContextPropertiesTest - Other review related changes in StabilityPointStructuresInputContextPropertiesTest paired by bouvrie Related to Issue [WTI-924]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6387 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f700dd7d630b7b8877ca3c22083f01d1511886d6

Former-commit-id: 9e9944cf50b0b5f6ac2c26d07ba8c46efe99052c

Options
    • -164
    • +200
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresInputContextPropertiesTest.cs
  2. … 4 more files in changeset.
10:09 am

Elmar Kleijn

Review related changes Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6380 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0cf1f8776919dacfbfa186feeb66eaf4bab0cbc3

Former-commit-id: e5dcf337529347eaa7b7b46554b65b47a4fa44ec

Options
    • -2
    • +2
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresInputContextPropertiesTest.cs
  2. … 3 more files in changeset.
Tuesday 01 Nov 2016
7:10 pm

Dennis Tang <dennis.tang@deltares.nl>

Implement validation service: - Connected plugin with the validation routine of the calculation service - Added missing test in the failure mechanism for closing structures: validation routine was not asserted

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6375 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8e28ed71866679074ae4ad303d95a2fea394381a

Former-commit-id: 1fb1c2c43d3044e9b9267ffdaf53b29c8e45d9b8

Options
    • -2
    • +13
    ./src/Ringtoets.StabilityPointStructures.Plugin/StabilityPointStructuresPlugin.cs
    • -0
    • +69
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresCalculationContextTreeNodeInfoTest.cs
    • -24
    • +98
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -0
    • +73
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresFailureMechanismContextTreeNodeInfoTest.cs
  5. … 1 more file in changeset.
4:43 pm

bouvrie <bouvrie@example.com>

* Hide particular properties from PropertyGridView, dependent on ModelType and SchematisationType of StabilityPointStructure calculation.

Related to Issue [WTI-924]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6373 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 792a06ce30276ca19417bf30e8c79b6585313e5b

Former-commit-id: f9e5511170da8ea97a1660deb1be28617324dba3

Options
    • -2
    • +2
    ./src/Ringtoets.StabilityPointStructures.Data/LoadSchematizationType.cs
    • -0
    • +75
    ./src/Ringtoets.StabilityPointStructures.Forms/PropertyClasses/StabilityPointStructuresInputContextProperties.cs
    • -86
    • +895
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresInputContextPropertiesTest.cs
    • -0
    • +2
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresCalculationContextTreeNodeInfoTest.cs
    • -0
    • +4
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -2
    • +6
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -0
    • +6
    ./test/Ringtoets.StabilityPointStructures.Integration.Test/StabilityPointStructuresCalculationActivityIntegrationTest.cs
    • -2
    • +6
    ./test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
2:50 pm

Robert Tangerman <robert.tangerman@deltares.nl>

- Implemented new parser for the last_error.txt file. - Made sure the last error content is always set despite exceptions that are thrown. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6366 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7a3bb4fabee4812c891dc7d1e786c1eca405a417

Former-commit-id: c214d381a759ffe8a93f74a7e49e8d40e3fc9fcf

Options
    • -0
    • +1
    ./test/Ringtoets.StabilityPointStructures.Integration.Test/StabilityPointStructuresCalculationActivityIntegrationTest.cs
  2. … 9 more files in changeset.
2:25 pm

Dennis Tang <dennis.tang@deltares.nl>

Implement validation service: - Added two additional test scenarios for the calculation and validation routines that should result in an InvalidEnumArgumentException. Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6363 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e4ac60cde7406448eb6662e34b183cfe7a44c638

Former-commit-id: a42c576c4a6fd405314e7a18b45760e6c00f73b8

Options
    • -97
    • +103
    ./test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
2:09 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Show temp Hydra-Ring working directory in log messages instead of output file contents. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6362 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ffee509c70a3b27af0b78536abc002b38b1a3d2a

Former-commit-id: 8c1f43038a30d3db98b08807548c7fee71164814

Options
    • -10
    • +30
    ./src/Ringtoets.StabilityPointStructures.Service/Properties/Resources.Designer.cs
    • -3
    • +2
    ./src/Ringtoets.StabilityPointStructures.Service/Properties/Resources.resx
    • -0
    • +1
    ./src/Ringtoets.StabilityPointStructures.Service/Ringtoets.StabilityPointStructures.Service.csproj
    • -1
    • +1
    ./src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
    • -1
    • +0
    ./src/Ringtoets.StabilityPointStructures.Service/packages.config
    • -1
    • +1
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresCalculationContextTreeNodeInfoTest.cs
    • -2
    • +2
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -2
    • +2
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/TreeNodeInfos/StabilityPointStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -2
    • +2
    ./test/Ringtoets.StabilityPointStructures.Integration.Test/StabilityPointStructuresCalculationActivityIntegrationTest.cs
    • -2
    • +2
    ./test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
  11. … 63 more files in changeset.
2:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Implement validation service: - Implemented validation rules for all relevant inputs for the StabilityPointStructures - Made StabilityPointsStructures resources publicly accessible - Synchronised StructureNormalOrientation property of StabilityPointStructures: StructureNormalOrientation does not update when a structure is selected

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6361 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d655187563dcb9622232e3fe079e646292479b31

Former-commit-id: ef09fae5dea6690866ba451f3b36e323273fa1a9

Options
    • -0
    • +1
    ./src/Ringtoets.StabilityPointStructures.Data/StabilityPointStructuresInput.cs
    • -64
    • +43
    ./src/Ringtoets.StabilityPointStructures.Forms/Properties/Resources.Designer.cs
    • -1
    • +1
    ./src/Ringtoets.StabilityPointStructures.Forms/Ringtoets.StabilityPointStructures.Forms.csproj
    • -0
    • +10
    ./src/Ringtoets.StabilityPointStructures.Service/Ringtoets.StabilityPointStructures.Service.csproj
    • -4
    • +190
    ./src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
    • -0
    • +2
    ./test/Ringtoets.StabilityPointStructures.Data.Test/StabilityPointStructuresInputTest.cs
    • -1
    • +1
    ./test/Ringtoets.StabilityPointStructures.Data.TestUtil.Test/TestStabilityPointStructuresCalculationTest.cs
    • -2
    • +302
    ./test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
1:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Corrected inputs that are send to HydraRing: input for ModelFactorSuperCriticalFlow was used instead of ModelFactorSubCritical flow when constructing hydraring input objects for flooded culvert calculations

Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6355 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c63080103b96b169fbb5fde0d88aa8b8f2ae2f46

Former-commit-id: 9dbf38589d0ee44a201ebea0851db86b65289915

Options
    • -4
    • +4
    ./src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
    • -32
    • +32
    ./test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
1:03 pm

Elmar Kleijn

Review related changes Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6354 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 037c82e46f3bc330e7e436cf57a18b0c7a83d1d2

Former-commit-id: 4ceb1716cbb4ba6f80d7d1c21f7c8b82f558c05c

Options
    • -63
    • +39
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresInputContextPropertiesTest.cs
  2. … 3 more files in changeset.
11:57 am

Dennis Tang <dennis.tang@deltares.nl>

Corrected inputs that are send to HydraRing: input for ModelFactorSuperCriticalFlow was duplicated when constructing a HydraRing input object for Low Sill calculations Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6351 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3b9a922813427e145717126ec9a16ecc2ffe47d4

Former-commit-id: 9041f880ed640243b08d48b28025465e4ff477da

Options
    • -4
    • +4
    ./src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
    • -4
    • +4
    ./test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
11:09 am

Elmar Kleijn

Review related changes Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6347 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c3fae05878814971a1005b95c5b710e92d2b4c2e

Former-commit-id: 3047c86cde0b4464be757d98ba00bf6a78d4f1c5

Options
    • -0
    • +1
    ./test/Ringtoets.StabilityPointStructures.Data.Test/StabilityPointStructuresInputTest.cs
    • -1
    • +1
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructurePropertiesTest.cs
    • -1
    • +1
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresFailureMechanismPropertiesTest.cs
    • -1
    • +1
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresInputContextPropertiesTest.cs
  5. … 50 more files in changeset.
9:54 am

Dennis Tang <dennis.tang@deltares.nl>

Implement validation service: - Implemented initial test setup for the StabilityPointStructuresCalculationService

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6341 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8d1b87312bd9a58b460b9c643ae485a65838ab37

Former-commit-id: d60b120f2971dbd1288c5939da1722f301c9c09f

Options
    • -0
    • +190
    ./test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
  2. … 1 more file in changeset.
8:49 am

Elmar Kleijn

Review related changes Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6339 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b017da77bfd60684c84e0905da667fac35bc975a

Former-commit-id: 01b338bf085f8e5ae9cba241c69546cb86fd8f10

Options
    • -26
    • +26
    ./test/Ringtoets.StabilityPointStructures.Data.Test/StabilityPointStructuresInputTest.cs
  2. … 2 more files in changeset.
8:32 am

Robert Tangerman <robert.tangerman@deltares.nl>

Changes after review. Related to Issue [WTI-570]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6337 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 875c6050812cd6cfff05c35a99b7192ff4f34083

Former-commit-id: 48e529a4a056509b183a6faa7f327baf793a3590

Options
    • -1
    • +3
    ./src/Ringtoets.StabilityPointStructures.Forms/PresentationObjects/StabilityPointStructuresInputContext.cs
    • -1
    • +4
    ./src/Ringtoets.StabilityPointStructures.Forms/PropertyClasses/StabilityPointStructuresInputContextProperties.cs
    • -0
    • +1
    ./src/Ringtoets.StabilityPointStructures.Forms/Ringtoets.StabilityPointStructures.Forms.csproj
    • -1
    • +0
    ./test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismResultViewTest.cs
  5. … 2 more files in changeset.
8:32 am

Dennis Tang <dennis.tang@deltares.nl>

Quality check: - (Editorial) Removed double call comment in affected service tests - Changed inconsistent types

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6336 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1a0b601976b4ab1601a2c42387eafc04d75fabf9

Former-commit-id: 2b9fe616233429c2da20f794e270342cd830453c

Options
    • -5
    • +4
    ./test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
  2. … 1 more file in changeset.