Riskeer / Ringtoets

StabilityStoneCover

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 31 Jul 2018
3:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed HBL file path as constructor argument from the CalculationActivity

- Performed for StabilityStoneCover

- Removed because of:

-- Constructor argument assessment section contains all information that's required

-- there's currently no check on the assessment section level which causes an argument null exception when an activity is created while there's no HB database is selected.

WTI-1720

Options
    • -11
    • +2
    ./src/Ringtoets.StabilityStoneCover.Service/StabilityStoneCoverWaveConditionsCalculationActivity.cs
    • -1
    • +0
    ./src/Ringtoets.StabilityStoneCover.Service/StabilityStoneCoverWaveConditionsCalculationActivityFactory.cs
    • -23
    • +3
    ./test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationActivityTest.cs
Wednesday 25 Jul 2018
3:57 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3099:

- Fixed test name

Paired with ~carloslubbers

WTI-1735

Options
    • -1
    • +1
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverFailureMechanismContextTreeNodeInfoTest.cs
3:38 pm

Carlos Lubbers

Add hydraulic boundary database check to calculate all context menu item for stability stone cover WTI-1735

Options
    • -1
    • +7
    ./src/Ringtoets.StabilityStoneCover.Plugin/StabilityStoneCoverPlugin.cs
    • -0
    • +32
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverFailureMechanismContextTreeNodeInfoTest.cs
2:37 pm

Carlos Lubbers

Refactor section (result) clearing, now uses a template method. WTI-1751

Options
    • -2
    • +1
    ./src/Ringtoets.StabilityStoneCover.Data/StabilityStoneCoverFailureMechanism.cs
    • -3
    • +1
    ./test/Ringtoets.StabilityStoneCover.Data.Test/StabilityStoneCoverFailureMechanismTest.cs
  3. … 39 more files in changeset.
11:24 am

Carlos Lubbers

Use new test helper in tests WTI-1751

Options
    • -3
    • +3
    ./test/Ringtoets.StabilityStoneCover.Data.Test/StabilityStoneCoverFailureMechanismAssemblyFactoryTest.cs
    • -2
    • +2
    ./test/Ringtoets.StabilityStoneCover.Data.Test/StabilityStoneCoverFailureMechanismTest.cs
    • -2
    • +2
    ./test/Ringtoets.StabilityStoneCover.Forms.Test/Views/StabilityStoneCoverFailureMechanismViewTest.cs
    • -1
    • +1
    ./test/Ringtoets.StabilityStoneCover.Forms.Test/Views/StabilityStoneCoverResultViewTest.cs
  5. … 124 more files in changeset.
10:37 am

Carlos Lubbers

Rename AddSections to SetSections WTI-1751

Options
    • -3
    • +3
    ./test/Ringtoets.StabilityStoneCover.Data.Test/StabilityStoneCoverFailureMechanismAssemblyFactoryTest.cs
    • -2
    • +2
    ./test/Ringtoets.StabilityStoneCover.Data.Test/StabilityStoneCoverFailureMechanismTest.cs
    • -2
    • +2
    ./test/Ringtoets.StabilityStoneCover.Forms.Test/Views/StabilityStoneCoverFailureMechanismViewTest.cs
    • -1
    • +1
    ./test/Ringtoets.StabilityStoneCover.Forms.Test/Views/StabilityStoneCoverResultViewTest.cs
  5. … 136 more files in changeset.
Tuesday 24 Jul 2018
2:07 pm

Carlos Lubbers

Fix compilation errors in tests WTI-1751

Options
    • -1
    • +4
    ./test/Ringtoets.StabilityStoneCover.Forms.Test/Views/StabilityStoneCoverResultViewTest.cs
  2. … 18 more files in changeset.
1:57 pm

Carlos Lubbers

Fix compilation errors in tests WTI-1751

Options
    • -7
    • +13
    ./test/Ringtoets.StabilityStoneCover.Forms.Test/Views/StabilityStoneCoverFailureMechanismViewTest.cs
  2. … 27 more files in changeset.
1:29 pm

Carlos Lubbers

Fix compilation errors in failure mechanism tests WTI-1751

Options
    • -8
    • +14
    ./test/Ringtoets.StabilityStoneCover.Data.Test/StabilityStoneCoverFailureMechanismTest.cs
  2. … 16 more files in changeset.
1:06 pm

Carlos Lubbers

Fix compilation errors in tests WTI-1751

Options
    • -3
    • +12
    ./test/Ringtoets.StabilityStoneCover.Data.Test/StabilityStoneCoverFailureMechanismAssemblyFactoryTest.cs
  2. … 27 more files in changeset.
10:30 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3082: - Cleaned up tests --> use AddRange - Added missing testcases to verify behaviour of Activity when calculations fail for the Revetment related activities

Paired with ~carloslubbers

WTI-1735

Options
    • -3
    • +9
    ./test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs
    • -2
    • +5
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverFailureMechanismContextTreeNodeInfoTest.cs
  3. … 3 more files in changeset.
Monday 23 Jul 2018
2:23 pm

Carlos Lubbers

Implement review comments WTI-1736

Options
    • -15
    • +8
    ./test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs
  2. … 2 more files in changeset.
2:15 pm

Carlos Lubbers

Implement review comments WTI-1735

Options
    • -65
    • +2
    ./test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs
    • -4
    • +4
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverFailureMechanismContextTreeNodeInfoTest.cs
    • -12
    • +14
    ./test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationActivityFactoryTest.cs
  4. … 4 more files in changeset.
Thursday 19 Jul 2018
3:01 pm

Carlos Lubbers

Cleanup WTI-1735

Options
    • -65
    • +52
    ./test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs
3:01 pm

Carlos Lubbers

Cleanup WTI-1735

Options
    • -65
    • +52
    ./test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs
1:19 pm

Elmar Kleijn

Review related changes. WTI-1732

Options
    • -1
    • +1
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverFailureMechanismContextTreeNodeInfoTest.cs
  2. … 6 more files in changeset.
1:19 pm

Elmar Kleijn

Review related changes. WTI-1732

Options
    • -1
    • +1
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverFailureMechanismContextTreeNodeInfoTest.cs
  2. … 6 more files in changeset.
11:54 am

Carlos Lubbers

Move calculation notification logic to activity OnFinish WTI-1736

Options
    • -8
    • +10
    ./test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs
  2. … 3 more files in changeset.
11:54 am

Carlos Lubbers

Move calculation notification logic to activity OnFinish WTI-1736

Options
    • -8
    • +10
    ./test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs
  2. … 3 more files in changeset.
10:04 am

Carlos Lubbers

Add calculate all to the failure mechanism context menu WTI-1735

Options
    • -0
    • +12
    ./src/Ringtoets.StabilityStoneCover.Plugin/StabilityStoneCoverPlugin.cs
    • -0
    • +182
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverFailureMechanismContextTreeNodeInfoTest.cs
10:04 am

Carlos Lubbers

Add calculate all to the failure mechanism context menu WTI-1735

Options
    • -0
    • +12
    ./src/Ringtoets.StabilityStoneCover.Plugin/StabilityStoneCoverPlugin.cs
    • -0
    • +182
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverFailureMechanismContextTreeNodeInfoTest.cs
Friday 13 Jul 2018
1:50 pm

Carlos Lubbers

Make stability stone cover calculation activity internal WTI-1735

Options
    • -25
    • +7
    ./src/Ringtoets.StabilityStoneCover.Plugin/StabilityStoneCoverPlugin.cs
    • -1
    • +3
    ./src/Ringtoets.StabilityStoneCover.Service/Properties/AssemblyInfo.cs
    • -2
    • +2
    ./src/Ringtoets.StabilityStoneCover.Service/StabilityStoneCoverWaveConditionsCalculationActivity.cs
    • -60
    • +151
    ./test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs
    • -3
    • +0
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverWaveConditionsCalculationContextTreeNodeInfoTest.cs
    • -7
    • +0
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs
  7. … 1 more file in changeset.
1:04 pm

Carlos Lubbers

Introduce factory for creating stability stone cover calculation activities WTI-1735

Options
    • -0
    • +1
    ./src/Ringtoets.StabilityStoneCover.Service/Ringtoets.StabilityStoneCover.Service.csproj
    • -0
    • +132
    ./src/Ringtoets.StabilityStoneCover.Service/StabilityStoneCoverWaveConditionsCalculationActivityFactory.cs
    • -0
    • +1
    ./test/Ringtoets.StabilityStoneCover.Service.Test/Ringtoets.StabilityStoneCover.Service.Test.csproj
    • -0
    • +350
    ./test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationActivityFactoryTest.cs
  5. … 1 more file in changeset.
Monday 25 Jun 2018
12:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Committed rename changes Note: compiling erros in the tests and testutils are still present

Options
    • -1
    • +1
    ./src/Ringtoets.StabilityStoneCover.Data/StabilityStoneCoverFailureMechanism.cs
    • -3
    • +3
    ./test/Ringtoets.StabilityStoneCover.Data.Test/StabilityStoneCoverFailureMechanismAssemblyFactoryTest.cs
    • -3
    • +3
    ./test/Ringtoets.StabilityStoneCover.Data.Test/StabilityStoneCoverFailureMechanismTest.cs
    • -4
    • +4
    ./test/Ringtoets.StabilityStoneCover.Forms.Test/Views/StabilityStoneCoverFailureMechanismViewTest.cs
    • -1
    • +1
    ./test/Ringtoets.StabilityStoneCover.Forms.Test/Views/StabilityStoneCoverResultViewTest.cs
  6. … 134 more files in changeset.
Friday 22 Jun 2018
3:29 pm

Carlos Lubbers

Fix failing tests for calculation treenode infos and gui services WTI-1754

Options
    • -4
    • +5
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs
  2. … 16 more files in changeset.
Thursday 21 Jun 2018
2:15 pm

Dennis Tang <dennis.tang@deltares.nl>

Changed accessor for the AddSectionResult function

Options
    • -2
    • +2
    ./src/Ringtoets.StabilityStoneCover.Data/StabilityStoneCoverFailureMechanism.cs
  2. … 16 more files in changeset.
Wednesday 20 Jun 2018
4:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2977: - Fixed failing tests

WTI-1707

Options
    • -4
    • +6
    ./src/Ringtoets.StabilityStoneCover.Forms/StabilityStoneCoverCalculationConfigurationHelper.cs
  2. … 2 more files in changeset.
3:57 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2977: - Inlined variables - Updated XMLDocs

WTI-1694

Options
    • -10
    • +5
    ./src/Ringtoets.StabilityStoneCover.Forms/StabilityStoneCoverCalculationConfigurationHelper.cs
    • -2
    • +1
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/TreeNodeInfos/StabilityStoneCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs
  3. … 5 more files in changeset.
Tuesday 19 Jun 2018
3:43 pm

Elmar Kleijn

Fixed failing tests. WTI-1719

Options
    • -5
    • +0
    ./src/Ringtoets.StabilityStoneCover.Service/StabilityStoneCoverWaveConditionsCalculationActivity.cs
    • -19
    • +0
    ./test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationActivityTest.cs
  3. … 18 more files in changeset.
3:41 pm

Carlos Lubbers

Remove assessment section observer WTI-1695

Options
    • -5
    • +5
    ./src/Ringtoets.StabilityStoneCover.Plugin/StabilityStoneCoverPlugin.cs
    • -4
    • +2
    ./test/Ringtoets.StabilityStoneCover.Plugin.Test/ViewInfos/StabilityStoneCoverWaveConditionsInputViewInfoTest.cs
  3. … 6 more files in changeset.