Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert "Possible fix for test parallellization."

This reverts commit e177433c5d29e78e41416e66c6579181d43f345b.

    • -5
    • +5
    ./Ringtoets.Storage.Core.Test/SqLiteEntityConnectionStringBuilderTest.cs
  1. … 2 more files in changeset.
Possible fix for test parallellization.

    • -5
    • +5
    ./Ringtoets.Storage.Core.Test/SqLiteEntityConnectionStringBuilderTest.cs
  1. … 2 more files in changeset.
Fixed compilation errors:

- Removed obsolete ModelFactorSuperCriticalFlow for stability point structures.

WTI-1800

    • -1
    • +0
    ./Ringtoets.Storage.Core.Test/Create/StructuresCalculationCreateExtensionsTest.cs
  1. … 1 more file in changeset.
Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

    • -2
    • +2
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

    • -4
    • +0
    ./Ringtoets.Storage.Core.Test/Read/StructureCalculationEntityReadExtensionsTest.cs
    • -8
    • +0
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

    • -1
    • +2
    ./Ringtoets.Storage.Core.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -52
    • +48
    ./Ringtoets.Storage.Core.Test/Read/StabilityPointStructures/StabilityPointStructuresCalculationEntityReadExtensionsTest.cs
Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

    • -9
    • +0
    ./Ringtoets.Storage.Core.Test/Create/StructuresCalculationCreateExtensionsTest.cs
Review related changes. WTI-1714

    • -2
    • +2
    ./Ringtoets.Storage.Core.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
  1. … 24 more files in changeset.
Added validation for Identical Apertures in input data model. WTI-1236

    • -4
    • +8
    ./Ringtoets.Storage.Core.Test/Read/CalculationGroupEntityReadExtensionsTest.cs
    • -6
    • +14
    ./Ringtoets.Storage.Core.Test/Read/ClosingStructures/ClosingStructuresCalculationEntityReadExtensionsTest.cs
    • -1
    • +2
    ./Ringtoets.Storage.Core.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
  1. … 4 more files in changeset.
Renamed column name, because it represents a probability only

- Regenerated .rtd file

- Fixed compilation errors for the read- and create extensions

WTI-1236

    • -1
    • +1
    ./Ringtoets.Storage.Core.Test/Create/StructuresCalculationCreateExtensionsTest.cs
    • -3
    • +3
    ./Ringtoets.Storage.Core.Test/Read/ClosingStructures/ClosingStructureEntityReadExtensionsTest.cs
    • -2
    • +2
    ./Ringtoets.Storage.Core.Test/Read/ClosingStructures/ClosingStructuresCalculationEntityReadExtensionsTest.cs
  1. … 9 more files in changeset.
Renamed ProbabilityOrFrequencyOpenStructureBeforeFlooding to ProbabilityOpenStructureBeforeFlooding for closing structures input. WTI-1236

    • -2
    • +2
    ./Ringtoets.Storage.Core.Test/Create/StructuresCalculationCreateExtensionsTest.cs
    • -1
    • +1
    ./Ringtoets.Storage.Core.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -1
    • +1
    ./Ringtoets.Storage.Core.Test/Read/ClosingStructures/ClosingStructuresCalculationEntityReadExtensionsTest.cs
  1. … 15 more files in changeset.
Renamed ProbabilityOrFrequencyOpenStructureBeforeFlooding to ProbabilityOpenStructureBeforeFlooding for closing structure. WTI-1236

    • -1
    • +1
    ./Ringtoets.Storage.Core.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -2
    • +2
    ./Ringtoets.Storage.Core.Test/Read/ClosingStructures/ClosingStructureEntityReadExtensionsTest.cs
  1. … 17 more files in changeset.
Incorporated comments review 3146:

- Ran DeltaresClean and removed unused references from files and projects

- Updated XMLDocs and testname typos

WTI-1764

    • -1
    • +0
    ./Ringtoets.Storage.Core.Test/Read/GrassCoverSlipOffInwardsSectionResultEntityReadExtensionsTest.cs
    • -1
    • +0
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
  1. … 16 more files in changeset.
Introduced ManualFailureMechanismSectionAssemblyCategoryGroup for TechnicalInnovation. WTI-1764

    • -2
    • +1
    ./Ringtoets.Storage.Core.Test/Create/TechnicalInnovation/TechnicalInnovationFailureMechanismSectionResultCreateExtensionsTest.cs
    • -2
    • +1
    ./Ringtoets.Storage.Core.Test/Read/TechnicalInnovationSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
  1. … 12 more files in changeset.
Introduced ManualFailureMechanismSectionAssemblyCategoryGroup for StrengthStabilityLengthWise. WTI-1764

    • -2
    • +1
    ./Ringtoets.Storage.Core.Test/Create/StrengthStabilityLengthwise/StrengthStabilityLengthwiseConstructionFailureMechanismSectionResultCreateExtensionsTest.cs
    • -2
    • +1
    ./Ringtoets.Storage.Core.Test/Read/StrengthStabilityLengthwiseConstructionSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
  1. … 12 more files in changeset.
Introduced ManualFailureMechanismSectionAssemblyCategoryGroup for PipingStructure. WTI-1764 Description

    • -2
    • +1
    ./Ringtoets.Storage.Core.Test/Create/PipingStructure/PipingStructureFailureMechanismSectionResultCreateExtensionsTest.cs
    • -2
    • +1
    ./Ringtoets.Storage.Core.Test/Read/PipingStructure/PipingStructureSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
  1. … 12 more files in changeset.
Introduced ManualFailureMechanismSectionAssemblyCategoryGroup for GrassCoverSlipOffOutwards. WTI-1764

    • -2
    • +1
    ./Ringtoets.Storage.Core.Test/Create/GrassCoverSlipOffOutwards/GrassCoverSlipOffOutwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -2
    • +1
    ./Ringtoets.Storage.Core.Test/Read/GrassCoverSlipOffOutwardsSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
  1. … 12 more files in changeset.
Introduced ManualFailureMechanismSectionAssemblyCategoryGroup for GrassCoverSlipOffInwards. WTI-1764

    • -2
    • +1
    ./Ringtoets.Storage.Core.Test/Create/GrassCoverSlipOffInwards/GrassCoverSlipOffInwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    ./Ringtoets.Storage.Core.Test/Read/GrassCoverSlipOffInwardsSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
  1. … 12 more files in changeset.
Cleanup:

- Removed unused references

- Updated XMLDocs

WTI-1764

    • -1
    • +0
    ./Ringtoets.Storage.Core.Test/Create/MacrostabilityOutwards/MacroStabilityOutwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +0
    ./Ringtoets.Storage.Core.Test/Create/Microstability/MicrostabilityFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +0
    ./Ringtoets.Storage.Core.Test/Read/MacroStabilityOutwards/MacroStabilityOutwardsSectionResultEntityReadExtensionsTest.cs
    • -1
    • +0
    ./Ringtoets.Storage.Core.Test/Read/MicrostabilitySectionResultEntityReadExtensionsTest.cs
  1. … 6 more files in changeset.
Introduced ManualFailureMechanismSectionAssemblyCategoryGroup for WaterpressureAsphaltCover. WTI-1764

    • -2
    • +1
    ./Ringtoets.Storage.Core.Test/Create/WaterPressureAsphaltCover/WaterPressureAsphaltCoverFailureMechanismSectionResultCreateExtensionsTest.cs
    • -2
    • +1
    ./Ringtoets.Storage.Core.Test/Read/WaterPressureAsphaltCoverSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
  1. … 12 more files in changeset.
Introduced ManualFailureMechanismSectionAssemblyCategoryGroup for MicroStability

- Fixed failing test for macrostability outwards

WTI-1764

    • -1
    • +1
    ./Ringtoets.Storage.Core.Test/Create/Microstability/MicrostabilityFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    ./Ringtoets.Storage.Core.Test/Read/MicrostabilitySectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
  1. … 13 more files in changeset.
Introduced ManualFailureMechanismSectionAssemblyCategoryGroup for MacroStabilityOutwards:

- Fixed majority of compiling errors, except for the factory.

WTI-1764

    • -2
    • +2
    ./Ringtoets.Storage.Core.Test/Create/MacrostabilityOutwards/MacroStabilityOutwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -2
    • +2
    ./Ringtoets.Storage.Core.Test/Read/MacroStabilityOutwards/MacroStabilityOutwardsSectionResultEntityReadExtensionsTest.cs
    • -2
    • +2
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
  1. … 7 more files in changeset.
Incorporated comments reviews 3126, 3128

- Restored missing asserts

- Replaced random.NextDouble() * X with extension method for the ranges

- Improved tests

WTI-892

    • -1
    • +2
    ./Ringtoets.Storage.Core.Test/Read/Piping/PipingCalculationEntityReadExtensionsTest.cs
  1. … 6 more files in changeset.
Fixed failing test. WTI-1759

    • -1
    • +1
    ./Ringtoets.Storage.Core.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
Fixed failing tests:

- Fixed reference project that's being used for the Merge functionality

- Fixed failing tests in the storage

WTI-1759

    • -1
    • +1
    ./Ringtoets.Storage.Core.Test/Create/HeightStructures/HeightStructuresFailureMechanismCreateExtensionsTest.cs
    • -2
    • +2
    ./Ringtoets.Storage.Core.Test/Create/WaterPressureAsphaltCover/WaterPressureAsphaltCoverFailureMechanismCreateExtensionsTest.cs
    • -0
    • +1
    ./Ringtoets.Storage.Core.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
  1. … 2 more files in changeset.
Fix failing test WTI-1751

    • -1
    • +1
    ./Ringtoets.Storage.Core.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
Adjusted integration tests:

- Also assert the sourcepath for the failure mechanism sections to ensure that storage works correctly

WTI-1759

    • -0
    • +1
    ./Ringtoets.Storage.Core.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -0
    • +11
    ./Ringtoets.Storage.Core.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -2
    • +2
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
Adjusted Read extensions:

- Included reading the failure mechanism sections sourcepath from the rtd file

- Cleaned up tests:

-- On assessment section level, only the first direct layer needs to be asserted. Cleaned up file for consistency

WTI-1759

    • -822
    • +59
    ./Ringtoets.Storage.Core.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -9
    • +237
    ./Ringtoets.Storage.Core.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
  1. … 1 more file in changeset.
Adjusted Create extensions:

- Write the sourcepath to the entity

- Cleaned up and simplified tests

-- Attempted to make tests consistent between the various extensions.

WTI-1759

    • -30
    • +13
    ./Ringtoets.Storage.Core.Test/Create/ClosingStructures/ClosingStructuresFailureMechanismCreateExtensionsTest.cs
    • -11
    • +8
    ./Ringtoets.Storage.Core.Test/Create/DuneErosion/DuneErosionFailureMechanismCreateExtensionsTest.cs
    • -9
    • +10
    ./Ringtoets.Storage.Core.Test/Create/FailureMechanismCreateExtensionsTest.cs
    • -16
    • +16
    ./Ringtoets.Storage.Core.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismCreateExtensionsTest.cs
    • -11
    • +8
    ./Ringtoets.Storage.Core.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismCreateExtensionsTest.cs
    • -11
    • +9
    ./Ringtoets.Storage.Core.Test/Create/GrassCoverSlipOffInwards/GrassCoverSlipOffInwardsFailureMechanismCreateExtensionsTest.cs
    • -11
    • +9
    ./Ringtoets.Storage.Core.Test/Create/GrassCoverSlipOffOutwards/GrassCoverSlipOffOutwardsFailureMechanismCreateExtensionsTest.cs
    • -62
    • +15
    ./Ringtoets.Storage.Core.Test/Create/HeightStructures/HeightStructuresFailureMechanismCreateExtensionsTest.cs
    • -2
    • +6
    ./Ringtoets.Storage.Core.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -11
    • +9
    ./Ringtoets.Storage.Core.Test/Create/MacrostabilityOutwards/MacroStabilityOutwardsFailureMechanismCreateExtensionsTest.cs
    • -11
    • +9
    ./Ringtoets.Storage.Core.Test/Create/Microstability/MicrostabilityFailureMechanismCreateExtensionsTest.cs
    • -2
    • +19
    ./Ringtoets.Storage.Core.Test/Create/Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -11
    • +7
    ./Ringtoets.Storage.Core.Test/Create/PipingStructure/PipingStructureFailureMechanismCreateExtensionsTest.cs
    • -32
    • +12
    ./Ringtoets.Storage.Core.Test/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismCreateExtensionsTest.cs
    • -13
    • +9
    ./Ringtoets.Storage.Core.Test/Create/StabilityStoneCover/StabilityStoneCoverFailureMechanismCreateExtensionsTest.cs
  1. … 5 more files in changeset.
Cleanup for storage:

- Removed remaining checks for the preprocessor.

WTI-1766

    • -6
    • +0
    ./Ringtoets.Storage.Core.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -3
    • +0
    ./Ringtoets.Storage.Core.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -4
    • +1
    ./Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs