Riskeer

Ringtoets

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 16 Jan
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 15 Jan 2019
2:10 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3446: WTI-1926

- Removed migration log message

Options
    • -12
    • +0
    ./Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_18.1_19.1.sql
    • -4
    • +1
    ./Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo191IntegrationTest.cs
    • -1
    • +0
    ./Migration/test/Ringtoets.Migration.Test/RingtoetsProjectMigratorTest.cs
2:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3446: WTI-1926

- Ran Cleanup

Options
    • -1
    • +2
    ./Storage/src/Ringtoets.Storage.Core/Read/HydraulicBoundaryDatabaseEntityReadExtensions.cs
1:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3445: WTI-1925

- Cleaned up code

- Moved logging from the importer to the update helper

-- Cleaned up resources

-- Cleaned up tests

Options
    • -5
    • +1
    ./HydraRing/test/Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
    • -6
    • +2
    ./Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -9
    • +0
    ./Integration/src/Ringtoets.Integration.IO/Properties/Resources.Designer.cs
    • -3
    • +0
    ./Integration/src/Ringtoets.Integration.IO/Properties/Resources.resx
    • -0
    • +6
    ./Integration/src/Ringtoets.Integration.Plugin/Helpers/HydraulicLocationConfigurationSettingsUpdateHelper.cs
    • -0
    • +10
    ./Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
    • -0
    • +3
    ./Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.resx
    • -25
    • +14
    ./Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
    • -14
    • +20
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
    • -4
    • +11
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
    • -4
    • +11
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Helpers/HydraulicLocationConfigurationSettingsUpdateHelperTest.cs
10:54 am

Dennis Tang <dennis.tang@deltares.nl>

Extracted HLCD file name editor: WTI-1927

- Editor extracted to allow overrides for a custom file filter.

- Fixed failing test of the property info which is introdcued due to a dependency on the GUI.MainWindow

Options
    • -0
    • +39
    ./Integration/src/Ringtoets.Integration.Forms/Editors/HlcdFileNameEditor.cs
    • -0
    • +9
    ./Integration/src/Ringtoets.Integration.Forms/Properties/Resources.Designer.cs
    • -0
    • +3
    ./Integration/src/Ringtoets.Integration.Forms/Properties/Resources.resx
    • -1
    • +2
    ./Integration/src/Ringtoets.Integration.Forms/PropertyClasses/HydraulicBoundaryDatabaseProperties.cs
    • -0
    • +2
    ./Integration/src/Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
    • -0
    • +41
    ./Integration/test/Ringtoets.Integration.Forms.Test/Editors/HlcdFileNameEditorTest.cs
    • -0
    • +7
    ./Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/HydraulicBoundaryDatabasePropertiesTest.cs
    • -0
    • +2
    ./Integration/test/Ringtoets.Integration.Forms.Test/Ringtoets.Integration.Forms.Test.csproj
    • -0
    • +13
    ./Integration/test/Ringtoets.Integration.Plugin.Test/PropertyInfos/HydraulicBoundaryDatabasePropertyInfoTest.cs
10:02 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced string description for the import HLCD activity. WTI-1927

Options
    • -1
    • +2
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseImportHandler.cs
    • -0
    • +10
    ./Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
    • -0
    • +3
    ./Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.resx
9:14 am

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up test file WTI-1927

Options
    • -4
    • +3
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationDatabaseImportHandlerTest.cs
Monday 14 Jan 2019
4:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Added ReadOnly property for the HLCD filepath. WTI-1927

- File path should not be editable in case there's no hydraulic boundary database linked.

Options
    • -1
    • +25
    ./Integration/src/Ringtoets.Integration.Forms/PropertyClasses/HydraulicBoundaryDatabaseProperties.cs
    • -0
    • +102
    ./Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/HydraulicBoundaryDatabasePropertiesTest.cs
3:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Renamed interface method definition. WTI-1927

Options
    • -1
    • +1
    ./Integration/src/Ringtoets.Integration.Forms/PropertyClasses/HydraulicBoundaryDatabaseProperties.cs
    • -1
    • +1
    ./Integration/src/Ringtoets.Integration.Forms/PropertyClasses/IHydraulicLocationConfigurationDatabaseImportHandler.cs
    • -1
    • +1
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseImportHandler.cs
    • -1
    • +1
    ./Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/HydraulicBoundaryDatabasePropertiesTest.cs
    • -3
    • +3
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationDatabaseImportHandlerTest.cs
3:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Added implementation of the import handler. WTI-1927

Options
    • -0
    • +2
    ./Integration/src/Ringtoets.Integration.Forms/PropertyClasses/IHydraulicLocationConfigurationDatabaseImportHandler.cs
    • -1
    • +48
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseImportHandler.cs
    • -5
    • +16
    ./Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -1
    • +132
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationDatabaseImportHandlerTest.cs
    • binary
    ./Integration/test/Ringtoets.Integration.Plugin.Test/test-data/HydraulicLocationConfigurationDatabaseImportHandler/HLCD.sqlite
    • binary
    ./Integration/test/Ringtoets.Integration.Plugin.Test/test-data/HydraulicLocationConfigurationDatabaseImportHandler/complete.config.sqlite
    • binary
    ./Integration/test/Ringtoets.Integration.Plugin.Test/test-data/HydraulicLocationConfigurationDatabaseImportHandler/complete.sqlite
    • binary
    ./Integration/test/Ringtoets.Integration.Plugin.Test/test-data/HydraulicLocationConfigurationDatabaseImportHandler/hlcdWithScenarioInformation.sqlite
3:02 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added clearing output. WTI-1927

Options
    • -0
    • +3
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -1
    • +71
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
2:21 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added constructor parameter. WTI-1927

Options
    • -0
    • +19
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -7
    • +24
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
2:15 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Return changed objects. WTI-1927

Options
    • -1
    • +6
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -0
    • +20
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
2:07 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Set settings in update handler. WTI-1927

Options
    • -2
    • +4
    ./Integration/src/Ringtoets.Integration.IO/Handlers/IHydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -6
    • +6
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -7
    • +45
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
1:47 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1927

Options
    • -22
    • +24
    ./Integration/src/Ringtoets.Integration.Plugin/Helpers/HydraulicLocationConfigurationSettingsUpdateHelper.cs
1:46 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Use helper in handler. WTI-1927

Options
    • -41
    • +4
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
1:45 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Moved helper to Helpers folder and moved constants to separate file. WTI-1927

Options
    • -88
    • +0
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationSettingsUpdateHelper.cs
    • -0
    • +36
    ./Integration/src/Ringtoets.Integration.Plugin/Helpers/HydraulicLocationConfigurationSettingsConstants.cs
    • -0
    • +83
    ./Integration/src/Ringtoets.Integration.Plugin/Helpers/HydraulicLocationConfigurationSettingsUpdateHelper.cs
    • -1
    • +3
    ./Integration/src/Ringtoets.Integration.Plugin/Properties/AssemblyInfo.cs
    • -1
    • +2
    ./Integration/src/Ringtoets.Integration.Plugin/Ringtoets.Integration.Plugin.csproj
    • -105
    • +0
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationSettingsUpdateHelperTest.cs
    • -0
    • +39
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Helpers/HydraulicLocationConfigurationSettingsConstantsTest.cs
    • -0
    • +105
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Helpers/HydraulicLocationConfigurationSettingsUpdateHelperTest.cs
    • -1
    • +2
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
1:36 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced helper for setting the settings. WTI-1927

Options
    • -0
    • +88
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationSettingsUpdateHelper.cs
    • -0
    • +1
    ./Integration/src/Ringtoets.Integration.Plugin/Ringtoets.Integration.Plugin.csproj
    • -0
    • +105
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationSettingsUpdateHelperTest.cs
    • -0
    • +1
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
12:55 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added null checks. WTI-1927

Options
    • -0
    • +15
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -0
    • +44
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
12:50 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added confirmation dialog. WTI-1927

Options
    • -2
    • +9
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -0
    • +12
    ./Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
    • -0
    • +5
    ./Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.resx
    • -1
    • +41
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
11:57 am

Robert Tangerman <robert.tangerman@deltares.nl>

Changed handler API. WTI-1927

Options
    • -3
    • +3
    ./Integration/src/Ringtoets.Integration.IO/Handlers/IHydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -1
    • +1
    ./Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -1
    • +1
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -3
    • +3
    ./Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicLocationConfigurationDatabaseImporterTest.cs
11:56 am

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced update handler. WTI-1927

Options
    • -0
    • +47
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -0
    • +1
    ./Integration/src/Ringtoets.Integration.Plugin/Ringtoets.Integration.Plugin.csproj
    • -0
    • +41
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandlerTest.cs
    • -0
    • +1
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
11:43 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added location id validation. WTI-1927

Options
    • -0
    • +10
    ./Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -0
    • +9
    ./Integration/src/Ringtoets.Integration.IO/Properties/Resources.Designer.cs
    • -0
    • +3
    ./Integration/src/Ringtoets.Integration.IO/Properties/Resources.resx
    • -11
    • +42
    ./Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicLocationConfigurationDatabaseImporterTest.cs
    • -0
    • +4
    ./Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
    • binary
    ./Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicLocationConfigurationDatabaseImporter/completeHrd.config.sqlite
10:48 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced import handler to handle with HLCD imports from the hydraulic boundary database property panel: WTI-1927

- Added empty handler class to be substituted in the RingtoetsPlugin to prevent ArgumentNullExceptions on runtime.

Options
    • -5
    • +18
    ./Integration/src/Ringtoets.Integration.Forms/PropertyClasses/HydraulicBoundaryDatabaseProperties.cs
    • -0
    • +40
    ./Integration/src/Ringtoets.Integration.Forms/PropertyClasses/IHydraulicLocationConfigurationDatabaseImportHandler.cs
    • -0
    • +1
    ./Integration/src/Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
    • -0
    • +38
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseImportHandler.cs
    • -0
    • +1
    ./Integration/src/Ringtoets.Integration.Plugin/Ringtoets.Integration.Plugin.csproj
    • -1
    • +1
    ./Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -12
    • +107
    ./Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/HydraulicBoundaryDatabasePropertiesTest.cs
    • -0
    • +41
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicLocationConfigurationDatabaseImportHandlerTest.cs
    • -0
    • +1
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
9:59 am

Robert Tangerman <robert.tangerman@deltares.nl>

First ask confirmation. WTI-1927

Options
    • -8
    • +8
    ./Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -0
    • +7
    ./Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicLocationConfigurationDatabaseImporterTest.cs
7:41 am

Robert Tangerman <robert.tangerman@deltares.nl>

Add Sqlite core to test project. WTI-1927

Options
    • -1
    • +11
    ./Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
    • -0
    • +1
    ./Integration/test/Ringtoets.Integration.IO.Test/packages.config
Sunday 13 Jan 2019
10:40 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added DoPostImportUpdates. WTI-1927

Options
    • -0
    • +10
    ./Integration/src/Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -1
    • +41
    ./Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicLocationConfigurationDatabaseImporterTest.cs
Friday 11 Jan 2019
4:41 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration script: WTI-1926

- Added log messages when migrating project files that contain hydraulic boundary location entities.

Options
    • -8
    • +30
    ./Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_18.1_19.1.sql
    • -1
    • +11
    ./Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo191IntegrationTest.cs
    • -0
    • +3
    ./Migration/test/Ringtoets.Migration.Test/RingtoetsProjectMigratorTest.cs
3:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Added default values to migration script. WTI-1926

Options
    • -9
    • +9
    ./Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_18.1_19.1.sql
    • -8
    • +8
    ./Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo191IntegrationTest.cs
3:37 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments PO: WTI-1925

- Changed default values for the HLCD information when there's no ScenarioInformation present in order to make it more insightful that default values are used.

Options
    • -1
    • +2
    ./Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -1
    • +1
    ./Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
3:25 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments PO: WTI-1925

- Added log message when there's no ScenarioInformation present in the HLCD.

Options
    • -7
    • +7
    ./Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -0
    • +9
    ./Integration/src/Ringtoets.Integration.IO/Properties/Resources.Designer.cs
    • -0
    • +3
    ./Integration/src/Ringtoets.Integration.IO/Properties/Resources.resx
    • -15
    • +26
    ./Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs