Merged revision(s) 5531-5707 from trunk: changes in review. paired by bos_en
Related to Issue WTI 576
........
- Changed documentation
- Ex… Show more
Related to Issue WTI 576
........
- Changed documentation
- Ex… Show more
Merged revision(s) 5531-5707 from trunk: changes in review. paired by bos_enRelated to Issue WTI 576........- Changed documentation- Extracted common method for the CloseForDataView in the plugin- Implemented hard cast for the set Data property in the DesignWaterLevel and WaveHeight view for GrassCoverErosionOutwards - Added missing tests Related to Issue WTI 882 ........- Added property info for the GrassCoverErosionWaveHeightLocations- Fixed failing tests- Fixed string names to desired values according to the comments Related to Issue WTI 882 ........Added classes that will replace services eventually........Merged revision(s) 5527-5533 from branches/Release/16_2:Prevented update of datasource when only calculations are performed.Related to WTI 881........OvertoppingCalculationWaveHeightParser now looks for the first occurrence of Governing wind direction, instead of assuming it's on the first line of the section.Related to WTI 893........- Changed documentation- Extracted common method for the CloseForDataView in the plugin- Implemented hard cast for the set Data property in the DesignWaterLevel and WaveHeight view for GrassCoverErosionOutwards - Added missing tests Related to WTI 882........- Added property info for the GrassCoverErosionWaveHeightLocations- Fixed failing tests- Fixed string names to desired values according to the comments Related to WTI 882................Added missing tests.Performed cleanups.Related to Issue WTI 881 ........Merged revision(s) 5536 from branches/Release/16_2:Added missing tests.Performed cleanups.Related to Issue WTI 881................- Extended failure mechanism with GeneralClosingStructuresInput and CalculationsGroupRelated to Issue WTI 547 ........Added submodel for assessment section relations........Changes after review.Related to Issue WTI 882 ........Merged revision(s) 5540 from branches/Release/16_2:Changes after review.Related to WTI-882................Extended Technical design.eap........* Basic interface spec for WTI-579Related to Issue WTI 577 ........Implemented basic StructuresClosureCalculationInput.Related to Issue WTI 545 ........Implemented hydraRingSection and GetSubMechanismModelId.Related to Issue WTI 545 ........* Defined properties for StructuresParameterRowRelated to Issue WTI 577 ........- Added ClosingStructuresFailureMechanismContext.cs- Added tests- optimised referencesRelated to Issue WTI 547 ........updated excelRelated to Issue WTI 547 ........Introduced a NewGrassCoverErosionInwardsCalculationActivity which will replace GrassCoverErosionInwardsCalculationActivity.Added NewHydraRingActivity which will replace HydraRingActivityAdded parsers which throw exceptionsAdded calculator for overtopping to be able to perform a complete GrassCoverErosionInwards calculation........Made StructuresClosureCalculationInput abstract and implemented base variables.Related to Issue WTI 545 ........Corrected name of variableRelated to Issue WTI 547 ........- Added empty class for the HeightStructure object (needed to create a context object) Related to Issue WTI 580 ........- Added HeightStructureContext - Modified the failure mechanism to include an ObservableList HeightStructures with HeightStructure objectsRelated to Issue WTI 580 ........- Removed obsolete resource string in Piping - Updated documentation for the HeightStructureContext- Renamed test to make it more representative for what's being testedRelated to Issue WTI 580 ........- Added GeneralStabilityPointStructuresInput- Extended StabilityPointStructuresFailureMechanismRelated to Issue WTI 561 ........Implemented input object for vertical wall structures closure calculation.Related to Issue WTI 545 ........Renamed variables for consistencyRelated to Issue WTI 580 ........- Created StabilityPointStructuresPlugin- Moved StabilityPointStructuresFailureMechanismSectionResultRelated to Issue WTI 561 ........- Added StabilityPointStructures pluginRelated to Issue WTI 561 ........Removed test project from installerRelated to Issue WTI 561 ........Implemented input object for low threshold structures closure calculation.Related to Issue WTI 545 ........Use modified Beta for when calculating water levels and wave heights from the locations views in grass cover erosion outwards.Related to Issue WTI 881 ........* Moved classes from HeightStructures/IO to Ringtoets.Common.IO/Structures.Related to Issue WTI 577 ........- Moved ClosingStructureFailureMechanismContextTreeNodeInfoTest- Set FailureMechanismContextAssociation in RingtoetsPluginRelated to Issue WTI 561 ........- Fixed FailureMechanismContextAssociationRelated to Issue WTI 547 ........Fixed bug where results for grass cover erosion outwards locations were cleared when the database was not changed.Related to Issue WTI 881 ........* Renamed HeightStructuresCharacteristicsCsvReader to StructuresCharacteristicsCsvReader* StructuresCharacteristicsCsvReader reads file and parses values. Read per line instead whole file in 1 go.* StructuresParameterRow now has LocationId property.Related to Issue WTI 577 ........Type-O in logger.Related to Issue WTI 881 ........Use NewGrassCoverErosionInwardsCalculationActivity for calculating a single calculation from context menu.........Merged revision(s) 5562-5568 from branches/Release/16_2:Use modified Beta for when calculating water levels and wave heights from the locations views in grass cover erosion outwards.Related to Issue WTI 881........Fixed bug where results for grass cover erosion outwards locations were cleared when the database was not changed.Related to Issue WTI 881........Type-O in logger.Related to Issue WTI 881................- Added ClosingStructure dummy class + test in order to create the TreeNodeInfo- Added ObservableList with ClosingStructure objects inside the failure mechanism- Extracted generic resource value "Kunstwerken" for ClosingStructures and HeightStructuresRelated to Issue WTI 589 ........- Added Berekeningen folder- Added first implementation of calculation, input, and output for StabilityPointStructuresFailureMechanismRelated to Issue WTI 562 ........- Added context menu's for failure mechanismRelated to Issue WTI 562 ........* Write test coverage for StructuresCharacteristicsCsvReader.GetLineCount()Related to Issue WTI 577 ........Added new Hydra-Ring settings filesPaired with berg_jlRelated to Issue WTI 895 ........Merged revision(s) 5575 from branches/Release/16_2:Added new Hydra-Ring settings filesPaired with berg_jlRelated to Issue [WTI 895 ........- Added various PresentationObjects- Added feature to add calculations to StabilityPointStructures failure mechanismRelated to Issue WTI 564 ........- Added CalculationGroupContext for the ClosingStructures - Added ClosingStructuresContext - Added relevant testsRelated to Issue WTI 548 ........Renamed input class for structures closure.Related to Issue WTI 545 ........- Added tree node info testsRelated to Issue WTI 564 ........- Added tests for tree node info- Removed redundant referencesRelated to Issue WTI 564 ........Implemented input object for flooded culvert structures closure calculation.Related to Issue WTI 545 ........- Added demo data for StabilityPointStructuresRelated to Issue WTI 564 ........Added foreland points to structures closure calculation input.Related to Issue WTI 545 ........- Added demo data for StabilityStoneCoverRelated to Issue WTI 564 ........Changed description of wave direction.Related to Issue WTI 898 ........Merged revision(s) 5586 from branches/Release/16_2Related to Issue [WTI 898 ........- Added demo data for WaveImpactAsphaltCoverRelated to Issue WTI 564 ........- Added documentation and resources- Added initial test setup ClosingStructuresCalculationGroupContextTreeNodeInfoTest- Added "Berekenen" folder and context menu items for the FailureMechanismTreeNodeInfo. Adjusted affected testsRelated to Issue WTI 548 ........- Updated ExcelRelated to Issue WTI 564 ........Updated according review comments:- Documentation- Method names- Adjusted tests: stubs instead of mocksRelated to Issue WTI 580 ........Updated according review comments:- Code readability- Added test HeightStructureContextTreeNodeInfoTestNote: CreateHeightStructure() needs to be filled as part of issue WTI579Related to Issue WTI 580 ........Removed unused referenceRelated to Issue WTI 580 ........- Partially reverting 5591, edit in wrong file- Renamed test according to reviewRelated to Issue WTI 580 ........Incorporated review comments:- Added documentation- Added missing TreeNodeInfo testRelated to Issue WTI 589 ........* Moved text to resources.* Test coverage for StructuresCharacteristicsCsvReaderRelated to Issue WTI 577 ........- Removed obsolete references- Removed the ClosingStructuresFailureMechanismSectionResult for the test case after discussing with ElmarRelated to Issue WTI 548 ........Added Hydra-Ring input classes for structure stability pointRelated to Issue WTI 559 ........Create importer for definitions of structures - hoogteRelated to Issue WTI 679 ........Performed resharper code cleanup.Related to Issue WTI 869 ........Changed method name in test so overtopping is removed.Related to Issue WTI 545 ........* Final cleanupRelated to Issue WTI 577 ........Changed variable id of StructuresClosureCalculationInputRelated to Issue WTI 545 ........Merged revision(s) 5600 from branches/Release/16_2:Performed resharper code cleanup.Related to WTI 869................Turned StructuresStabilityPointCalculationInput into ExceedanceProbabilityCalculationInputRelated to Issue WTI 559 ........Added abstract override of GetSubMechanismModelId to StructuresStabilityPointCalculationInputRelated to Issue WTI 599 ........Incorporated review comments:- Fixed documentation- Ran DeltaresClean- Stubbed objects that were "stubbable" Related to Issue WTI 548 ........* Interpunction in XMl docs* Made variable explicit* Replaced assertion with CollectionAssert.AreEqualRelated to Issue WTI 580 ........* Some small consistency fixesRelated to Issue WTI 589 ........Replaced GrassCoverErosionInwardsCalculationActivity, GrassCoverErosionInwardsCalculationService with new implementations.Removed GrassCoverErosionInwardsCalculationServiceOutput.Removed OvertoppingCalculationWaveHeightParser in favor of OvertoppingCalculationWaveHeightExceptionParser........Added constants for the calculation input objectRelated to Issue WTI 553 ........Added new implementation of the DesignWaterLevelCalculation Activity, Service and Calculator.........Replaced manual with newest versionRelated to Issue WTI 870 ........Merged revision(s) 5613 from branches/Release/16_2:Replaced manual with newest versionRelated to Issue WTI 870................* Reader now reads 'AlphanumicValue' column from file.** Updated files with new required column.Related to Issue WTI 588 ........* Extended StructuresStabilityPointCalculationInput with variable definitions* Adapted variables in other structure related input classesRelated to Issue WTI 599 ................Increased version due to tagRelated to Issue WTI 869 ........* Renamed HeightStructureContext to HeightStructuresCollectionContext because that better reflects the wrapped data, while also freeing up that classname in case a PresentationObject is required for HeightStructure classRelated to Issue WTI 582 ........Added new implementation of the WaveHeightCalculation Activity, Service and Calculator.........Extended variable definitions of StructuresStabilityPoint related calculation input objectsRelated to Issue WTI 599 ........* Improved Structures.png (better shading and color gradients, improved texturing details of the water).* Added HeightStructure to HeightStructuresFailureMechanism created with 'add demo traject' button.* TreeNodeInfo implemented for HeightStructure instance.Related to Issue WTI 582 ........Fixed typosFixed failing testRelated to Issue WTI 599 ........Create importer for definitions of structures - hoogteRelated to Issue WTI 679 ........Added new implementation of the WaveConditions Activity, Service and Calculator.........- Adjusted tests based on the excel sheets- Initial commit of the ClosingStructuresInput class + tests that contains all the configurable parameters for the calculations. Related to Issue WTI 553 ........- Fixed typoRelated to Issue WTI 553 ........processed review commentsRelated to Issue WTI 547 ........Quality control check- Ensure that the constants in the GeneralClosingStructuresInput class matches with the properties in the Excel sheet- Corrected naming when necessary (naming based on the HydraRing input classes) Related to Issue WTI 553 ........Processed review commentsRelated to Issue WTI 561 ........Quality control check- Made checks explicit for the general input class, check explicitly for the values without instantiating a probability distribution object - Extracted general method that asserts doubles and RoundedDoubles for equalityRelated to Issue WTI 553 ........Cleaned up StructuresStabilityPointCalculationInput related classesRelated to Issue WTI 559 ........Processed review commentsRelated to Issue WTI 562 ........Removed commentRelated to Issue WTI 562 ........Added WaveConditionsCalculationServiceBase as a base for calculating wave conditions for grass, asphalt and stone cover. ........Cleaned up StructuresOvertoppingCalculationInputRelated to Issue WTI 599 ........- Added missing input Hydraring parameter (ID 107, deviation of wavedirection)- Moved resources for the failure probability message to CommonDataResources- Added missing input parameters for the ClosingStructuresRelated to Issue WTI 553 ........Fixed ordering bug of Grass Cover Erosion Inwards' Hydraulic Boundary Locations.Reviewed by: kleijnRelated to Issue WTI 899 ........Create importer for definitions of structures - hoogteRelated to Issue WTI 679 ........Merged revision(s) 5638 from branches/Release/16_2:Fixed ordering bug of Grass Cover Erosion Inwards' Hydraulic Boundary Locations.Reviewed by: kleijnRelated to Issue WTI 899........Related to Issue WTI 899 ........Review comments processedRelated to Issue WTI 564 ........Revert version for re-releasing 16.2.1........Added / removed some white spaces after review commentsRelated to Issue WTI 562 ........Increased version due to tag........Quality control check- Updated property names to be consistent with the hydraring input variables naming- Corrected units tests to match with the Excel sheet in correctness and orderRelated to Issue WTI 553 ........Improved StructuresClosureCalculationInput related classesRelated to Issue WTI 559 ........Quality control check- Updated documentation: remarks added to make clear when ONLY the mean is set of a property- Updated variable names to match with the HydraRing input namesRelated to Issue WTI 553 ........Cleaned up Hydra-Ring input classesRelated to Issue WTI 559 ........Moved Importers from Integration.Plugin to Common.IORelated to Issue WTI 679 ........- Added "Kunstwerken" submenu for StabilityPointStructuresFailureMechanismRelated to Issue WTI 598 ........Further cleaned up Hydra-Ring related input classesRelated to Issue WTI 559 ........Fixed tests according to review 1066.Cross-check with janssenRelated to Issue WTI 564 ........Cleaned up Hydra-Ring related input test classesRelated to Issue WTI 559 ........- Created base class for the various StructuresRelated to Issue WTI 598 ........- Added calculation class for the closing structures- Removed unused references from the HeightStructuresInput class and test definition- Added missing parameters to the ClosingStructuresInput Related to Issue WTI 553 ........Added SQL dependency.Related to Issue WTI 679 ........- Added foreshore profileRelated to Issue WTI 553 ........Extended StructuresStabilityPointCalculationInputTestRelated to Issue WTI 559 ........Fixed null reference bugRelated to Issue WTI 564 ........Added project for StabilityPointStructures utilitiesRelated to Issue WTI 564 ........Extended StructuresStabilityPointCalculationInput related classesRelated to Issue WTI 559 ........- Fixed calculations from groupRelated to Issue WTI 564 ........- Added validation for the orientation of the structure: acceptable range is between 0 and 360 degrees. Clipping will occur when the values are smaller or larger than the boundaries. Related to Issue WTI 553 ........- Added testsRelated to Issue WTI 564 ........- Added projects were not needed in the end... RemovedRelated to Issue WTI 564 ........Processed review commentsRelated to Issue WTI 598 ........Cleaned up Hydra-Ring related input test classesRelated to Issue WTI 559 ........Introduced RayleighN distribution typeRelated to Issue WTI 559 ........Renamed failure mechanism context tree node info test.Related to Issue WTI 561 ........Changed parameter check.Related to Issue WTI 679 ........Fixed test for: Changed parameter check.Related to Issue WTI 679 ........- Added fields for the hydraulic boundary location and foreshore profiles in the failure mechanism Related to Issue WTI 553 ........Added break water property to structure related Hydra-Ring input objectsRelated to Issue WTI 559 ........Extended StructuresOvertoppingCalculationInput with foreland related propertiesRelated to Issue WTI 559 ........Quality control check- Updated variable names to match with the HydraRing input names- Added tests to verify the probability distribution typesRelated to Issue WTI 553 ........Quality control check- Updated variable names to match with the HydraRing input names- Added tests to verify probability distribution types- Matched properties of the tests with the input Excel sheetRelated to Issue WTI 567 ........Changed HydraRing input variable values in tests for better testability.Related to Issue WTI 559 ........Renamed ClosingStructuresContext into ClosingStructuresContextBaseRelated to Issue WTI 591 ........Renamed ClosingStructureContext into ClosingStructuresContextRelated to Issue WTI 591 ........Added integration tests for closure structures hydra ring inputRelated to Issue WTI 559 ........Added IO as accepted abbreviation ........Renamed HeightStructuresContext into HeightStructuresContextBaseRenamed HeightStructuresCollectionContext into HeightStructuresContextRelated to Issue WTI 591 ........Fixed review comments paired with bouvrieRelated to Issue WTI 577 ........Removed redundant height structures testRenamed StabilityPointStructuresContext to StabilityPointStructuresContextBaseRelated to Issue WTI 591 ........Renamed StabilityPointStructureContext to StabilityPointStructuresContextRelated to Issue WTI 591 ........* Implemented properties class for HeightStructureRelated to Issue WTI 582 ........Initial commit for the input class:- Added hydraulic loads and data input properties - Added orientation input propertyRelated to Issue WTI 567 ........Adapted default value for storm durationRelated to Issue WTI 559 ........Added Rayleigh-N distribution properties for wave peak h maxRelated to Issue WTI 567 ........Added integration tests for structures stability point hydra ring inputRelated to Issue WTI 559 ........Made to hydra ring variables int instead of double.Related to Issue WTI 559 ........Cleanup........Switched stability and constructive strength related parametersRelated to Issue WTI 559 ........git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-867@5710 5a3db67b-de53-47b5-99c8-a1c30a6650e2Former-commit-id: 0618a50b22b82aa90a3698c277a3d0890f3eab27Former-commit-id: eb04d363032e167cc0cc71014e2866e744aad709
Show less
