Merged revision(s) 6879-6930 from trunk: Incorporated comments review 1223: - Implemented IComparable in the RoundedDouble - Added null-chec…
Show more
Merged revision(s) 6879-6930 from trunk: Incorporated comments review 1223: - Implemented IComparable in the RoundedDouble - Added null-check in the HydraulicBoundaryLocationEditor, because the GetPropertiesObject(context) can be null.Related to Issue [WTI 989]........Merged revision(s) from branches/Map-spikeRelated to Issue [WTI 1018]........Incorporated comments rodriqu_dd:- Implemented IComparable in the RoundedDouble, removed .Value in the Linq expression as RoundedDoubles can be sorted now- Added null-check in the HydraulicBoundaryLocationEditor, because the GetPropertiesObject(context) AND the hydraulic boundary location can be null. Related to Issue [WTI 989]........Incorporated comments kleijn, added missing tests to improve coverage:- GetReferenceLocation()- GetHydraulicBoundaryLocations()Related to Issue [WTI 989]........Improvements after review.Related to Issue [WTI 958]........Improved map data properties tests.Related to Issue [WTI 958]........Improvements after review.Related to Issue [WTI 958]........Slightly adapted map data convertersRelated to Issue [WTI 1018]........Added TMapFeatureLayer type to MapDataConverterRelated to Issue [WTI 1018]........Implemented custom equality logic in GrassCoverErosionOutwardsHydraulicBoundaryLocationContextPaired with berg_jlRelated to Issue [WTI 956]........- Renamed tests to reflect the situation better- Added some additional code in the SelectionEditor based on janssen input - Reverted proposed refactoring of selectableHydraulicBoundaryLocation, because distance was not visible anymore in the dropdown list after selecting an entry. Reverse merged revision(s) 6890, 6854-6853 from trunk:Incorporated comments kleijn, added missing tests to improve coverage:- GetReferenceLocation()- GetHydraulicBoundaryLocations()Related to Issue [WTI 989]........Incorporated comments review 1223:- Refactored IHasHydraulicBoundaryLocationProperty such that implemented classes do not depend on SelectableHydraulicBoundaryLocation- Moved logic for generating the list of HBL to display in the dropdown menu to the HydraulicBoundaryLocationEditor. Added additional tests to verify behaviourRelated to Issue [WTI 989]........Incorporated comments review 1223:- Extended SelectionEditor to convert from the PresentationType to a DomainTypeRelated to Issue [WTI 989]................(Editorial)- Ran DeltaresClean to cleanup affected files of revision 6896Related to Issue [WTI 989]........Extended IMapDataConverter with ConvertLayerFeatures and ConvertLayerProperties methodsRelated to Issue [WTI 1018]........Fixed problem with typing in selectionEditor.Related to Issue [WTI 957]........Made SelectedMetaDataAttribute readonly when no meta data is present.Related to Issue [WTI 957]........* Fixed typos.* Refactored common code to new methods.* Fixed correct responsibility of filtering out duplicate observable notification.* Improved XML docs.* Improved returning all affected objects by some 'clear' methods of DataSynchronisationService classes.* Readded license header.* Simplified RhinoMock argument restraints.* Fixed test filename.* Fixed test structure of Integration tests conform coding conventions.Related to Issue [WTI 440]........Set hydraulicBoundaryDatabase observer when it's not set yet in the view.Related to Issue [WTI 957]........* Refactored logic statements involging && and || to have improved outlining.* Removed nesting of 'remarks' clause within 'summary' clause in XML docs.* Fixed typos.* Replaced empty array initializers with empty array constructor.Related to Issue [WTI 958]........- Extended StatisticsConverter with ProbabilityToReliability and ReliabilityToProbability- Renamed NormToBeta to ReturnPeriodToReliability- Renamed "norm" to "return period" in tests Related to Issue [WTI 897]........Renamed "norm" to "return period" in tests and HydraRing input classesRelated to Issue [WTI 897]........Renamed "norm" to "return period" in tests and calculation services/activitiesRelated to Issue [WTI 897]........Fixed failing testsRelated to Issue [WTI 897]........Extended MapFeatureLayerFactory with ConvertLayerFeatures and ConvertLayerProperties methodRelated to Issue [WTI 1018]........Integrated new methods in MapFeatureLayerFactoryRelated to Issue [WTI 1018]........Reverted some changesRelated to Issue [WTI 1018]........Changed labels category.Paired with kleijnRelated to Issue [WTI 957]........Renamed "GetMechanismSpecificNorm" to "GetMechanismSpecificReturnPeriod" in tests and calculation services/activitiesRelated to Issue [WTI 897]........Renamed "norm" to "return period" in tests and calculation services/activitiesRelated to Issue [WTI 897]........* Made variable explicit.* Extracted result of method call for reuse.Related to Issue [WTI 989]........Extended tests for the StatisticsConverter:- Added more testcases between and including the maximum user input value- ReliabilityToProbability and vice versa explicitly coveredRelated to Issue [WTI 897]........Removed local definitions of ReliabilityToProbability and ProbabilityToReliability. Make use of the defined methods in StatisticsConverter.Related to Issue [WTI 897]........Implement additional properties for the output:- Added a parser to the WaveConditionsCosineCalculator and the WaveConditionsCalculationOutput to store the parsed WaveDirection- Extended the WaveConditionsCalculationParser to parse the wave direction (wave angle w.r.t north) Related to Issue [WTI 897]........* Fixed bug in FailureMechanismContributionView where pressing Esc validated current value before reverting the value back to the value in the data model.* Improved XML docs.* Added preconditions for FailureMechanismContributionNormChangeHandler and create unit tests for whole implementation.* Improved resources.Related to Issue [WTI 791]........Updated XMLdoc from *param* to *paramref* when a parameter is referenced in a summary........Minor cleanupsReviewed by: bouvrieRelated to Issue [WTI 440]........Minor cleanupReviewed by: bouvrieRelated to Issue [WTI 791]........Implement additional properties for the output:- Extended the WaveConditionsOutput to store the target- and calculated reliability. Also stores the wave direction - Extended the WaveConditionsOutputProperties to display the: -- Wave direction-- target and calculated probability/reliability- Simplified tests for the WaveConditionsOutputProperties by using PropertiesTestHelperNote WaveConditionsOutput constructor currently contains 3 optional variables to store the wave direction and reliabilities, this will be phased out. Related to Issue [WTI 897]........Updated XMLdoc from *param* to *paramref* when a parameter is referenced in a summarySet PDFLATEX mode to nonstop........Added TestUtil project for Revetment to define a TestWaveConditionsOutput class at a centralized location Related to Issue [WTI 897]........Added:- License headers- TestWaveConditionsOutput object to be used for unit testsRelated to Issue [WTI 897]?\008........* Added missing unit tests.Related to Issue [WTI 1013]........?\008git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/CustomHydraulicBoundaries@6931 5a3db67b-de53-47b5-99c8-a1c30a6650e2Former-commit-id: c32b017ad2b1e3ce42f08424b271afc73d2a8880Former-commit-id: 3d18480b68b36e30439a663b90f5718a5048aaa3
Show less
