HeightStructuresCalculationServiceTest.cs

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved GrassCoverErosionOutwardsWaveConditionsCalculationActivityIntegrationTest Improved GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest Improved HeightStructuresCalculationServiceTest Related to Issue [WTI-1497]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/17_2_Development@12949 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 749ac454acd0b48c0e5807e97c97ec3579543b0a

Former-commit-id: 24b6a969d9d0179069ed744210e89e616ce39048

    • -6
    • +82
    ./HeightStructuresCalculationServiceTest.cs
  1. … 2 more files in changeset.
Changed the API for CalculationServiceHelper and removed all "Validatie mislukt/waarschuwing" prefixes in log messages. Related to Issue [WTI-1296]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12115 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 03e8800a28f0230a4342b35d452bac2b01da444a

Former-commit-id: 33baf7e0be14ef789b5108e7167d78dce4ae2a59

    • -6
    • +6
    ./HeightStructuresCalculationServiceTest.cs
  1. … 39 more files in changeset.
Review related changes Related to Issue [WTI-1405]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11838 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 36c65a06089b59a0e0d7060a482c042d6e9241a9

Former-commit-id: fc15f1e10efa631d55f1fadc32e65d6d9cadbd4b

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 27 more files in changeset.
Removed "Stub" suffix Related to Issue [WTI-1311]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11049 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6ec0472b8ccabd994658a1c7ffd7fc0fea4f2dc4

Former-commit-id: e9b8bc2df3cc78565a9293c2a0341fc023858e4d

    • -43
    • +43
    ./HeightStructuresCalculationServiceTest.cs
  1. … 31 more files in changeset.
- Moved performing the calculation to the base. - Changed type parameters of base. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10663 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4a75417bd348972b9f9f1acbf6e6859ed47a1fbd

Former-commit-id: 220809cd3396870cbb1272378802252605f3fa1b

    • -22
    • +34
    ./HeightStructuresCalculationServiceTest.cs
  1. … 17 more files in changeset.
- Moved cancel method to base. - Refactored perform calculation method. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10648 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 319e32471cff41243febb3a7de2305040ffcf9f7

Former-commit-id: f4523a3c6b43ef344678bd39d1f2d5664751db8e

    • -46
    • +0
    ./HeightStructuresCalculationServiceTest.cs
  1. … 7 more files in changeset.
Refactores structure calculators to one calculator. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10642 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 070ae3378d0b61127160dbf3fc3b722b6f361c06

Former-commit-id: 9e0b0d6e749192b868c914aa53797a482098ee9e

    • -14
    • +14
    ./HeightStructuresCalculationServiceTest.cs
  1. … 34 more files in changeset.
Refactored getting the calculation input. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10640 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 49287039b12c4b602c7989e2bcc564b9d646a3a1

Former-commit-id: 0614817094806a73d321be4b1f4bd0c82c2e0882

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 7 more files in changeset.
Added calculate method with null checks to the StructuresCalculationServiceBase Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10636 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5dcc87c7f4ac386f10b4c18b41f99f06b4bf11fe

Former-commit-id: 93fd51170d798af95d9709f9d7943391e621f30f

    • -63
    • +2
    ./HeightStructuresCalculationServiceTest.cs
  1. … 7 more files in changeset.
- Implemented validate method in StructuresCalculationServiceBase. - Refactored all depending calculation services. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10629 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: eacc84c9546683908cc316390f0f9fbcc83f4b84

Former-commit-id: ce6af66ecff89a16568da6283a30bdc97de7a3db

    • -167
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 13 more files in changeset.
Introduced StructuresCalculationServiceBase Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10580 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1f6d248b8179af6a9078b63bafc15d2818d32465

Former-commit-id: bbf53a7ff4361c1b8c388201a7639ee725fde530

    • -0
    • +11
    ./HeightStructuresCalculationServiceTest.cs
  1. … 7 more files in changeset.
Improved log messaging (removed duplication on calculation names and others) Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10512 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7f80d5d4b3fe2cb329fc7a00666f09e0858a333c

Former-commit-id: 6a5fe69c43427946827b8a6ee1455e1649475356

    • -37
    • +35
    ./HeightStructuresCalculationServiceTest.cs
  1. … 100 more files in changeset.
minor changes, making test more strict Related to Issue [WTI-1132]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10373 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 93b4878917c3abf6ae6b262e71fbf388fedbf1f5

Former-commit-id: 2ce3c76d3e86cbcb4ff02c4be05157b9185f6313

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 9 more files in changeset.
Extracted methods for asserting validation and calculations start and end messages. Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10254 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 800138c6ae1e8954eeb1d3be81d23bfe161a622f

Former-commit-id: 0283b091686a545589ac4f2d957165b7cf704cb4

    • -32
    • +33
    ./HeightStructuresCalculationServiceTest.cs
  1. … 66 more files in changeset.
Incorporated comment review 1874: - Renamed variable names to clearly indicate they represent a number and not a collection - Improved tests to prove that they do not clear data in case of HBN calculations - Changed Stubs to StrictMocks when applicable - (Re)added Exception message assert in the services when the calculator fails without exception, but with a last error file content

Paired with ~janssen

Related to Issue [WTI-1271]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10252 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3a74b3dcfd078d2bc5909421e41e00f603ddc770

Former-commit-id: f66dd962ef77db47c14ca1a7c2af8acc6286d68e

    • -0
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 7 more files in changeset.
Unified usage of StriktMocks in Services and Activities Related to Issue [WTI-1271]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10210 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cd6922e11680e7041ed43c598116776b9f48bec3

Former-commit-id: 146937d3fe3311562e2ef8ea2a354c80c2133665

    • -21
    • +21
    ./HeightStructuresCalculationServiceTest.cs
  1. … 25 more files in changeset.
Got rid of redundant time indication in log messages Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10197 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c368b8291325e52f7b84fcf7ebd622eb5b73d189

Former-commit-id: 6487f84142ebb802fbc312b4507c405f435cbe61

    • -33
    • +33
    ./HeightStructuresCalculationServiceTest.cs
  1. … 77 more files in changeset.
Updated to use mockRepository.Stub<IHydraRingCalculatorFactory>(): - HeightStructures Related to Issue [WTI-1271]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10158 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1a7d229ba8ab3d1f05eb5ab5b6ae23c372185142

Former-commit-id: 22919f14f5e74a399d90f3381de0c7966bbc1690

    • -23
    • +50
    ./HeightStructuresCalculationServiceTest.cs
  1. … 5 more files in changeset.
Updated license headers in HeightStructures. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9498 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6a54d7f7fe065a9b60f53104e2ac3a97103cd5b4

Former-commit-id: 59c7fce13fd3b10731f73f2b97e8138154a3b20f

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 113 more files in changeset.
Changed all local vars to consts if possible. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9448 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4684a5017b9aff9f6175f7d781cb29409f50a18e

Former-commit-id: 853c649ebc49a9513535e40ec705d5b928af0bc4

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 283 more files in changeset.
Code cleanup: Ringtoets.ClosingStructures Ringtoets.HeightStructures Ringtoets.StabilityPointStructures Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9390 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3f4503acaaefd0ce6c0cedf203052514f2e4c106

Former-commit-id: 0b20cb147ebd8f29f45b7034e47a99711b0e3187

    • -37
    • +37
    ./HeightStructuresCalculationServiceTest.cs
  1. … 109 more files in changeset.
Got rid of ringId in HydraRing calculations Related to Issue [WTI-1059]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8081 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4bc191fed1251037ae4eef4b56b7c26f9422f239

Former-commit-id: ba1406e780c01115aa545539afaef534ff495f40

    • -1
    • +0
    ./HeightStructuresCalculationServiceTest.cs
  1. … 73 more files in changeset.
Adapted some resources Related to Issue [WTI-1050]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7864 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 79a3ced3f781b25959e8fc3332ce56b93f1a2f0e

Former-commit-id: e68fc5f94054d41bd52be4a76511d885eabecefc

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 13 more files in changeset.
Adapted resource Related to Issue [WTI-1050]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7863 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b72845a31328c9f9b084acec26e4596fa83dc783

Former-commit-id: 8191af01979e4f40454788786a7fa70777677d3c

    • -1
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 9 more files in changeset.
Fixed namings fixed ignored tests Related to Issue [WTI-1102]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7795 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8381062b22facd7562bdbb67c9ffe123905955cd

Former-commit-id: 33b0a6969bd5a0d4102d02761cbb6e1011e52a01

    • -2
    • +2
    ./HeightStructuresCalculationServiceTest.cs
  1. … 16 more files in changeset.
Merged revision(s) 7773 from branches/Release/16_4: Changed type of *WidthFlowApertures* (Breedte van doorstroomopening) from CoefficientOfVariation to StandardDeviation note: storage change (names of the columns) has not yet been executed

Removed Application.Ringtoets/Application.Ringtoets.csproj post build action, which was needed for MSBuild2015

........

Related to Issue [WTI-1102]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7794 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 342282b213d520bc60ebd90113af4ab47b1c929d

Former-commit-id: 91abb8a151c800d1c462c52940cdfb3a8c7bb08d

    • -19
    • +20
    ./HeightStructuresCalculationServiceTest.cs
  1. … 70 more files in changeset.
Merged revision(s) 7770-7772 from branches/Release/16_4

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7775 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3573fbef3cb5a89f0722ceef8cd183f1920fe663

Former-commit-id: d79a40a94fc31ab868d173f60de590cac0fbee30

    • -8
    • +1
    ./HeightStructuresCalculationServiceTest.cs
  1. … 41 more files in changeset.
Refactored HydraRingCalculatorBase so it will only throw one exception. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7640 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a6de8a1ad179588f61a471c820b522033db66125

Former-commit-id: dbe8dc7f4c11ca209636bc2288143268ef5d8149

    • -2
    • +2
    ./HeightStructuresCalculationServiceTest.cs
  1. … 32 more files in changeset.
Added null checks and documentation in height structures calculation service. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7597 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ac75354b641fed54c3aac29476b3e4ea6eee9b10

Former-commit-id: a3c5ec0f83e92f501192da0ede81c6181d033f67

    • -44
    • +136
    ./HeightStructuresCalculationServiceTest.cs
  1. … 2 more files in changeset.
Performed Resharper cleanup

Related to Issue [WTI-1008]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7334 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 23d17fd6b5257a25b167839d9106eea6fa7be554

Former-commit-id: 4a817a07bc646924777514e78010c89bc0fdf9b5

    • -4
    • +4
    ./HeightStructuresCalculationServiceTest.cs
  1. … 114 more files in changeset.