Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 01 Jan 70
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 04 Dec 2018
1:35 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Updated test names to a more descriptive one

-- Corrected typos

Options
    • -1
    • +1
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapLineDataConverterTest.cs
    • -2
    • +2
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPointDataConverterTest.cs
    • -2
    • +2
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPolygonDataConverterTest.cs
10:38 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors in the converter test of the FeatureBasedMapData.

Options
    • -70
    • +189
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
Monday 03 Dec 2018
9:08 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors in the converter tests of the derived map data classes

Options
    • -11
    • +8
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapLineDataConverterTest.cs
    • -10
    • +7
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPointDataConverterTest.cs
    • -11
    • +10
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPolygonDataConverterTest.cs
Friday 30 Nov 2018
12:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Renamed test names

- Improved XMLDoc

Options
    • -1
    • +1
    /Core/Components/src/Core.Components.Gis/Theme/LineCategoryTheme.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.Gis/Theme/MapTheme.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.Gis/Theme/PointCategoryTheme.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.Gis/Theme/PolygonCategoryTheme.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.Gis.Test/Theme/CategoryThemeTest.cs
11:54 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors in the converters after changes in the datamodel for the derived classes of the FeatureBasedMapData

-- Moved all generic functions to the base class

-- Moved general operation definitions to the base class

Options
    • -47
    • +64
    /Core/Components/src/Core.Components.DotSpatial/Converter/FeatureBasedMapDataConverter.cs
    • -26
    • +7
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapLineDataConverter.cs
    • -24
    • +5
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPointDataConverter.cs
    • -32
    • +16
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPolygonDataConverter.cs
9:09 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors as a consequence of changes in the derived classes of FeatureBasedMapData

-- Fixed for the demo thematical map

Options
    • -68
    • +56
    /Demo/Ringtoets/src/Demo.Ringtoets/Commands/OpenThematicalMapViewCommand.cs
Thursday 29 Nov 2018
5:09 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors as a consequence of changes in the derived classes of FeatureBasedMapData

-- Fixed for the property classes

Options
    • -26
    • +21
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/MapLineDataPropertiesTest.cs
    • -26
    • +21
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/MapPointDataPropertiesTest.cs
    • -26
    • +21
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/MapPolygonDataPropertiesTest.cs
5:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors due to changes in the derived classes from the FeatureBasedMapData

-- Fixed for the MapDataFactories

Options
    • -6
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Factories/AssemblyMapDataFactory.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Factories/CombinedSectionAssemblyMapDataFactory.cs
4:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Fixed compilation errors of the derived classes from the FeatureBasedMapData as a consequence of the data model change.

Options
    • -7
    • +15
    /Core/Components/src/Core.Components.Gis/Data/MapLineData.cs
    • -7
    • +16
    /Core/Components/src/Core.Components.Gis/Data/MapPointData.cs
    • -7
    • +15
    /Core/Components/src/Core.Components.Gis/Data/MapPolygonData.cs
    • -4
    • +50
    /Core/Components/test/Core.Components.Gis.Test/Data/MapLineDataTest.cs
    • -3
    • +52
    /Core/Components/test/Core.Components.Gis.Test/Data/MapPointDataTest.cs
    • -2
    • +49
    /Core/Components/test/Core.Components.Gis.Test/Data/MapPolygonDataTest.cs
4:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Added typed derivative of the FeatureBasedMapData in order to prevent duplication of specific converters

Options
    • -1
    • +29
    /Core/Components/src/Core.Components.Gis/Data/FeatureBasedMapData.cs
    • -1
    • +33
    /Core/Components/test/Core.Components.Gis.Test/Data/FeatureBasedMapDataTest.cs
4:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Swapped constructor arguments for the CategoryThemeProperties

- Refactored property return value

- Further cleanup

Options
    • -18
    • +18
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/CategoryThemeProperties.cs
    • -3
    • +3
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/LineCategoryThemeProperties.cs
    • -1
    • +1
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/MapLineDataProperties.cs
    • -1
    • +1
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/MapPointDataProperties.cs
    • -1
    • +1
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/MapPolygonDataProperties.cs
    • -3
    • +3
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/PointCategoryThemeProperties.cs
    • -3
    • +3
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/PolygonCategoryThemeProperties.cs
    • -1
    • +1
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/CategoryThemePropertiesTest.cs
    • -4
    • +4
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/LineCategoryThemePropertiesTest.cs
    • -4
    • +4
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/PointCategoryThemePropertiesTest.cs
    • -4
    • +4
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/PolygonCategoryThemePropertiesTest.cs
3:57 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3395: WTI-1887

- Cleaned up properties (test)

Options
    • -4
    • +9
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/CategoryThemeProperties.cs
    • -2
    • +1
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/FeatureBasedMapDataProperties.cs
    • -1
    • +0
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/CategoryThemePropertiesTest.cs
8:32 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments. WTI-977

- Reviews 3396, 3397, 3400.

-- Cleanup unused references

-- Renamed test function

Paired with ~tangerma

Options
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/ReferenceLineTestFactoryTest.cs
    • -5
    • +3
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/ReferenceLineTestFactory.cs
    • -1
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/ReferenceLineUpdateHandler.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionViewTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableAssessmentSectionFactoryTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ExportInfos/AssemblyResultsContextExportInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/ReferenceLineUpdateHandlerTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Test/ReferenceLineImporterIntegrationTest.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/DerivedMacroStabilityInwardsOutputFactoryTest.cs
Wednesday 28 Nov 2018
3:52 pm

Dennis Tang <dennis.tang@deltares.nl>

Reused resource property for view. WTI-1906

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionMapView.Designer.cs
3:43 pm

Dennis Tang <dennis.tang@deltares.nl>

Merge branch 'feature/1906'

Options
    • -1
    • +25
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionMapView.cs
    • -6
    • +115
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionMapViewTest.cs
3:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Added warning panel to display warning on the map view. WTI-1906

Options
    • -4
    • +69
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionMapView.Designer.cs
    • -1
    • +25
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionMapView.cs
    • -5
    • +114
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionMapViewTest.cs
9:49 am

Robert Tangerman <robert.tangerman@deltares.nl>

Adapted assembly results per section map view. WTI-977

Options
    • -13
    • +7
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionMapView.cs
    • -20
    • +37
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionMapViewTest.cs
9:27 am

Robert Tangerman <robert.tangerman@deltares.nl>

Merge branch 'feature/977'

Options
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Ringtoets.Integration.Plugin.csproj
    • -12
    • +17
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -66
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/AssessmentSectionTest.cs
    • -12
    • +6
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Factories/AssessmentSectionAssemblyMapDataFeaturesFactoryTest.cs
    • -11
    • +10
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionMapViewTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
    • -4
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/AssemblyResultPerSectionMapViewInfoTest.cs
8:41 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-977

Options
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismViewTest.cs
    • -17
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil/MapDataTestHelper.cs
    • -0
    • +15
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil/MapFeaturesTestHelper.cs
    • -3
    • +3
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneErosionFailureMechanismViewTest.cs
    • -3
    • +3
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/Views/GrassCoverErosionInwardsFailureMechanismViewTest.cs
    • -3
    • +3
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/Views/GrassCoverErosionOutwardsFailureMechanismViewTest.cs
    • -3
    • +3
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismViewTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssessmentSectionViewTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismWithDetailedAssessmentViewTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismWithoutDetailedAssessmentViewTest.cs
    • -3
    • +3
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsFailureMechanismViewTest.cs
    • -3
    • +3
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/Views/PipingFailureMechanismViewTest.cs
    • -3
    • +3
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismViewTest.cs
    • -3
    • +3
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Forms.Test/Views/StabilityStoneCoverFailureMechanismViewTest.cs
    • -3
    • +3
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Forms.Test/Views/WaveImpactAsphaltCoverFailureMechanismViewTest.cs
Tuesday 27 Nov 2018
1:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed obsolete helper. WTI-1894

Options
    • -34
    • +0
    /Core/Components/src/Core.Components.Gis/Helpers/MapDataCollectionHelper.cs
    • -67
    • +0
    /Core/Components/test/Core.Components.Gis.Test/Helpers/MapDataCollectionHelperTest.cs
1:57 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed obsolete constructor parameter. WTI-1894

- Visibility property is readonly, parents are therefore not required anymore to notify.

Options
    • -1
    • +1
    /Core/Plugins/src/Core.Plugins.Map/MapPlugin.cs
    • -14
    • +3
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/MapDataCollectionProperties.cs
    • -15
    • +3
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/MapDataCollectionPropertiesTest.cs
1:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Added display names to MapDataCollectionVisisbility. WTI-1894

Options
    • -0
    • +6
    /Core/Components/src/Core.Components.Gis/Data/MapDataCollectionVisibility.cs
    • -2
    • +29
    /Core/Components/src/Core.Components.Gis/Properties/Resources.Designer.cs
    • -0
    • +9
    /Core/Components/src/Core.Components.Gis/Properties/Resources.resx
    • -1
    • +20
    /Core/Components/test/Core.Components.Gis.Test/Data/MapDataCollectionVisibilityTest.cs
1:41 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted visibility properties of the MapDataCollection. WTI-1894

- Made property readonly

- Changed return type

Options
    • -33
    • +5
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/MapDataCollectionProperties.cs
    • -70
    • +10
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/MapDataCollectionPropertiesTest.cs
1:16 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup migration script: WTI-1884

- Removed unnecessary tables which generate migration log messages for failure mechanisms

Note: In case log messages for failure mechanisms need to be generated, restore this commit

Options
    • -122
    • +3
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_18.1_18.2.sql
11:44 am

Dennis Tang <dennis.tang@deltares.nl>

Added log message when the transparency was changed of the background map. WTI-1884

Options
    • -1
    • +200
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_18.1_18.2.sql
    • -2
    • +6
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo182IntegrationTest.cs
    • -1
    • +4
    /Ringtoets/Migration/test/Ringtoets.Migration.Test/RingtoetsProjectMigratorTest.cs
Monday 26 Nov 2018
3:05 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration script for the background map transparency. WTI-1884

- Adjusted test file, included two cases for verification

Options
    • -1
    • +20
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_18.1_18.2.sql
    • binary
    /Ringtoets/Migration/test/Ringtoets.Migration.Core.Test/test-data/MigrationTestProject181.rtd
    • -0
    • +34
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo182IntegrationTest.cs
1:49 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-977

Options
    • -2
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.IO/ReferenceLines/ReferenceLineImporter.cs
    • -1
    • +11
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/ReferenceLines/ReferenceLineImporterTest.cs
1:42 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-977

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Factories/RingtoetsMapDataFeaturesFactory.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -12
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Comparers/AssessmentSectionMergeComparer.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Plugin/MacroStabilityInwardsPlugin.cs
    • -4
    • +4
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/PipingPlugin.cs
1:35 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-977

Options
    • -3
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/ReferenceLineTestFactoryTest.cs
    • -5
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/ReferenceLineTestFactory.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionViewTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableAssessmentSectionFactoryTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ExportInfos/AssemblyResultsContextExportInfoTest.cs
    • -11
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Comparers/AssessmentSectionMergeComparerTest.cs
    • -3
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Test/ReferenceLineImporterIntegrationTest.cs
1:28 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-977

Options
    • -34
    • +12
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/ReferenceLines/ReferenceLineImporterTest.cs
    • -6
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/HeightStructuresPlugin.cs
    • -6
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -6
    • +17
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ExportInfos/ReferenceLineContextExportInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ImportInfos/ForeshoreProfilesContextImportInfoTest.cs
    • -1
    • +1
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs