Riskeer

Clone Tools

Stats

Commits this week: 34
Total Committers: 31
Last Commit: 01 Jan 70
Commits this week: 34

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Edwin Spee

changes after 2nd review

Options
    • -79
    • +0
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PresentationObjects/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismContextTest.cs
    • -9
    • +82
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs
Friday 17 Apr
1:49 pm

Edwin Spee

add extra tests in PresentationObjects

Options
    • -1
    • +80
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PresentationObjects/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismContextTest.cs
11:58 am

Edwin Spee

update expected string

Options
    • -1
    • +1
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Data.Test/GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs
11:55 am

Edwin Spee

reformatting

Options
    • -5
    • +6
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs
    • -1
    • +0
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Forms/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismProperties.cs
    • -2
    • +1
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Data.Test/GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs
11:51 am

Edwin Spee

more review comments

Options
    • -1
    • +22
    /Riskeer/Piping/src/Riskeer.Piping.Data/Properties/Resources.Designer.cs
    • -11
    • +12
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs
    • -12
    • +33
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.Designer.cs
    • -4
    • +4
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Data.Test/GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs
11:27 am

Edwin Spee <34799234+epsig@users.noreply.github.com>

Apply suggestions from code review

Co-authored-by: Elmar Kleijn <34710209+kleijn@users.noreply.github.com>

Options
    • -1
    • +1
    /Riskeer/Piping/src/Riskeer.Piping.Data/Properties/Resources.resx
    • -1
    • +1
    /Riskeer/Piping/test/Riskeer.Piping.Data.Test/GeneralPipingInputTest.cs
    • -1
    • +1
    /Riskeer/Piping/test/Riskeer.Piping.Forms.Test/PropertyClasses/CalculationsState/PipingFailureMechanismPropertiesTest.cs
    • -2
    • +2
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs
    • -1
    • +1
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.resx
    • -12
    • +20
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Data.Test/GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs
Tuesday 14 Apr
3:20 pm

Edwin Spee

add test for invalid values of param C

Options
    • -1
    • +1
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.Designer.cs
    • -1
    • +1
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.resx
    • -0
    • +20
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Data.Test/GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs
2:48 pm

Edwin Spee

move validation for param C to data

improve error message for param volume of water in piping

Options
    • -26
    • +4
    /Riskeer/Piping/src/Riskeer.Piping.Data/Properties/Resources.Designer.cs
    • -28
    • +28
    /Riskeer/Piping/src/Riskeer.Piping.Data/Properties/Resources.resx
    • -2
    • +2
    /Riskeer/Piping/test/Riskeer.Piping.Data.Test/GeneralPipingInputTest.cs
    • -4
    • +4
    /Riskeer/Piping/test/Riskeer.Piping.Forms.Test/PropertyClasses/CalculationsState/PipingFailureMechanismPropertiesTest.cs
    • -4
    • +31
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs
    • -23
    • +10
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.Designer.cs
    • -27
    • +30
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.resx
    • -15
    • +1
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Forms/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismProperties.cs
Friday 10 Apr
5:08 pm

Edwin Spee

add propertyChangeHandler to WaveImpactAsphaltCoverFailureMechanismProperties

Options
    • -4
    • +32
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Forms/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismProperties.cs
    • -2
    • +2
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Plugin/WaveImpactAsphaltCoverPlugin.cs
    • -3
    • +4
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs
2:07 pm

Edwin Spee

add unit tests

Options
    • -0
    • +56
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Data.Test/GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs
    • -1
    • +18
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs
1:19 pm

Edwin Spee

fix failing test

Options
    • -1
    • +1
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs
1:14 pm

Edwin Spee

simply constructor

Options
    • -11
    • +8
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs
    • -1
    • +1
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/WaveImpactAsphaltCoverFailureMechanism.cs
11:55 am

Edwin Spee

only update C if in valid range

Options
    • -1
    • +15
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Forms/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismProperties.cs
9:23 am

Edwin Spee

setter in param C only for asphalt

Options
    • -1
    • +1
    /Riskeer/Revetment/src/Riskeer.Revetment.Data/GeneralWaveConditionsInput.cs
    • -0
    • +59
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs
    • -4
    • +3
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/WaveImpactAsphaltCoverFailureMechanism.cs
    • -6
    • +6
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Service/WaveImpactAsphaltCoverWaveConditionsCalculationService.cs
    • -2
    • +2
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs
    • -2
    • +2
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Integration.Test/WaveImpactAsphaltCoverWaveConditionsCalculationActivityIntegrationTest.cs
    • -2
    • +2
    /Riskeer/WaveImpactAsphaltCover/test/Riskeer.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs
8:53 am

Edwin Spee

add setters for param C

Options
    • -2
    • +2
    /Riskeer/Revetment/src/Riskeer.Revetment.Data/GeneralWaveConditionsInput.cs
    • -1
    • +5
    /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Forms/PropertyClasses/HydraulicLoadsState/WaveImpactAsphaltCoverFailureMechanismProperties.cs
Wednesday 08 Apr
9:21 am

Elmar Kleijn

Added new version of RSPstelsel. WTI-2955

Options
    • binary
    /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/EmbeddedResources/RSPstelsel.dbf
    • -1
    • +1
    /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/EmbeddedResources/RSPstelsel.prj
    • binary
    /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/EmbeddedResources/RSPstelsel.shp
Thursday 26 Mar
2:14 pm

Elmar Kleijn

Match with dune locations based on name. WTI-2955

Options
    • -1
    • +1
    /Riskeer/DuneErosion/src/Riskeer.DuneErosion.Service/DuneErosionDataSynchronizationService.cs
2:07 pm

Elmar Kleijn

Ensured offset is correctly rounded. WTI-2955

Options
    • -1
    • +1
    /Riskeer/DuneErosion/src/Riskeer.DuneErosion.Service/DuneErosionDataSynchronizationService.cs
    • -1
    • +1
    /Riskeer/DuneErosion/test/Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs
1:46 pm

Elmar Kleijn

Turning offset in ReadDuneLocation into integer. WTI-2955

Options
    • -9
    • +15
    /Riskeer/DuneErosion/test/Riskeer.DuneErosion.IO.Test/DuneLocationsReaderTest.cs
1:08 pm

Elmar Kleijn

Turning offset in ReadDuneLocation into integer. WTI-2955

Options
    • -1
    • +1
    /Riskeer/DuneErosion/test/Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs
1:07 pm

Elmar Kleijn

Turning offset in ReadDuneLocation into integer. WTI-2955

Options
    • -2
    • +2
    /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/DuneLocationsReader.cs
1:06 pm

Elmar Kleijn

Turning offset in ReadDuneLocation into integer. WTI-2955

Options
    • -8
    • +3
    /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/ReadDuneLocation.cs
    • -0
    • +11
    /Riskeer/DuneErosion/test/Riskeer.DuneErosion.IO.Test/ReadDuneLocationTest.cs
1:03 pm

Elmar Kleijn

Turning offset in ReadDuneLocation into integer. WTI-2955

Options
    • -4
    • +3
    /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/ReadDuneLocation.cs
    • -15
    • +3
    /Riskeer/DuneErosion/test/Riskeer.DuneErosion.IO.Test/ReadDuneLocationTest.cs
12:58 pm

Elmar Kleijn

Adding units to summaries. WTI-2955

Options
    • -0
    • +2
    /Riskeer/DuneErosion/src/Riskeer.DuneErosion.Data/DuneLocation.cs
    • -0
    • +1
    /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/ReadDuneLocation.cs
12:13 pm

Elmar Kleijn

Match with dune locations based on name. WTI-2955

Options
    • -24
    • +25
    /Riskeer/DuneErosion/src/Riskeer.DuneErosion.Service/DuneErosionDataSynchronizationService.cs
    • -2
    • +2
    /Riskeer/DuneErosion/test/Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs
12:06 pm

Elmar Kleijn

Match with dune locations based on name. WTI-2955

Options
    • -15
    • +14
    /Riskeer/DuneErosion/src/Riskeer.DuneErosion.Service/DuneErosionDataSynchronizationService.cs
11:52 am

Elmar Kleijn

Match with dune locations based on name. WTI-2955

Options
    • -3
    • +3
    /Riskeer/DuneErosion/test/Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs
11:40 am

Elmar Kleijn

Match with dune locations based on name. WTI-2955

Options
    • -24
    • +13
    /Riskeer/DuneErosion/test/Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs
11:19 am

Elmar Kleijn

Match with dune locations based on name. WTI-2955

Options
    • -36
    • +0
    /Riskeer/DuneErosion/test/Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs
11:17 am

Elmar Kleijn

Match with dune locations based on name. WTI-2955

Options
    • -4
    • +7
    /Riskeer/DuneErosion/test/Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs