Riskeer / Ringtoets / Piping / src / Ringtoets.Piping.Plugin / FileImporter

RingtoetsPipingSurfaceLineUpdateStrategy.cs

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 20 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 27 Feb 2017
11:38 am

Marten Janssen <marten.janssen@deltares.nl>

review suggestions paird with tang_ds Related to Issue [WTI-1094]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8431 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a7d149972b3949757d3b83eff662af98edba5123

Former-commit-id: 63d6d85d5128f78742cc81c32f47904b6574e813

Options
    • -167
    • +0
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 10 more files in changeset.
Friday 24 Feb 2017
3:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Generalized Update and Removing data from the concrete UpdateStrategyBase class implementations and moved it to the base class -- Fixed affected tests - Added condition: observers of the target collection should be notified when the items are added or removed from the collection -- Added test to verify behaviour -- Added deepclone method for TestItem Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8419 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b6a7ca74a432a9524fb4e100936403211e8c74e4

Former-commit-id: 78f360a48b04555133c0aac044cb8878e28ccdb4

Options
    • -24
    • +8
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 5 more files in changeset.
1:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Separated type specific functions from type independent functions in RingtoetsPipingSurfaceLineUpdateDataStrategy - Added missing tests for the UpdateStrategies (base and concrete surface line implementation) - Updated XMLDoc - Improved tests: -- Introduced a deep clone function -- Extracted surface line names to local variables

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8417 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 65de504c56270404f419bc1d959083d05b80e420

Former-commit-id: d81ffd2896c0bdf17f166878684cf4d45d948520

Options
    • -15
    • +29
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 6 more files in changeset.
Thursday 23 Feb 2017
4:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Updated XMLDoc - Refactored ObservableUniqueItemCollectionWithSourcePath: -- Turned class into an abstract class -- Removed generic TFeature, because explicit knowledge is not needed -- Adjusted inherited classes or classes that make direct use of the ObservableUniqueItemCollectionWithSourcePath

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8411 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 68cb3152a1c682b33bb73740c7d2e1300459cde2

Former-commit-id: 3e983eaebb15fdbe735d2ae5c62aa07d82a65242

Options
    • -2
    • +2
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 17 more files in changeset.
3:18 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Adjusted sql script - Added tests for the strategy template classes to assert the correct function arguments are used when the protected functions are called - Updated XMLDocs Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8409 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f4c9ff2c01986c8e24d309d3a1095352ede30c64

Former-commit-id: 668e94b92a17932f62f7583edae32491bec917d1

Options
    • -6
    • +1
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 9 more files in changeset.
Wednesday 22 Feb 2017
11:24 pm

Elmar Kleijn

Review related changes Related to Issue [WTI-1135]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8394 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 79b1c6bb86ceec6e05faa412e77c53419240048b

Former-commit-id: 4e6fb4e002026817f9837bba738e8ac1d44daabf

Options
    • -0
    • +1
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 42 more files in changeset.
10:57 am

Dennis Tang <dennis.tang@deltares.nl>

Added functionality to clear output when surfaceline is updated: - Implemented Equals method for the surface line to determine when two lines are equal (name and geometry are the same) to update only the affected surface lines -- Adjusted the algorithm inside the UpdateStrategy to delete the output when the surface line was updated -- Added tests - Used nameof operator in the SelectableHydraulicBoundaryLocationTest

Related to Issue [WTI-1094]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8376 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4b00fb5b9e8d8b933eba15bbaeed66754c53834b

Former-commit-id: 4c2be2db24a72de84c13b8fc07c0e643395715ce

Options
    • -9
    • +23
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 5 more files in changeset.
Tuesday 21 Feb 2017
2:17 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1468: - Refactored the UpdateDataStrategies by introducing a template class UpDataStrategyBase: -- Applied strategies for the StochasticSoilModelUpdateDataStrategy and RingtoetsPipingSurfaceLineUpdateDataStrategy -- Adjusted affected tests - Corrected UpdateTargetCollectionData algorithm in the template class: only updated target objects should be updated and not the already existing collection Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8361 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5481c6cdf30c56bc4774dac6fd49404e887715af

Former-commit-id: 0d9ddd9a773c4d9d8261c334d21af87069698d81

Options
    • -100
    • +39
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 4 more files in changeset.
10:00 am

Dennis Tang <dennis.tang@deltares.nl>

New functionality added when updating the SurfaceLines: - Stochastic soil models should be updated as well when a new surface line is set - Tests added Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8347 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6110d4d778eaa1a933d8baa484475a2c78b471f1

Former-commit-id: 42df67e1476709f98d68fe9a3c1b1a04d98e57fd

Options
    • -0
    • +27
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 1 more file in changeset.
Friday 17 Feb 2017
1:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1458: - Renamed interface - Improved XMLDoc - Fixed typos in functions, reran Deltares cleanup for to fix formatting - Removed unused reference - Added missing tests Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8290 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 305e56fb79b3fae4b710b6eac5451aa2322c00da

Former-commit-id: 1ca1a584c8584647c595fc516e30304b66a09eb8

Options
    • -4
    • +6
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 12 more files in changeset.
Wednesday 15 Feb 2017
9:51 am

Dennis Tang <dennis.tang@deltares.nl>

- Updated XMLDocs - Added functionality and tests for the replace strategy to prevent addition of duplicate surface lines

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8239 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 36baade81de3d493e441a830159dbb28ab2b6691

Former-commit-id: 50d6609486e0a5819ac9ae3519dc3e25aab16477

Options
    • -4
    • +12
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 3 more files in changeset.
Tuesday 14 Feb 2017
4:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented RingtoetsSurfaceLineCollection to store unique surface lines (no duplicate items with the same name): - Applied class for the strategies - Fixed affected tests - Removed unused references

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8233 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bdfb49b25b2ee5959323ee54f6100d12712031df

Former-commit-id: c61213e8748ebb2f2635ee1f24fb3ebfc5295c7e

Options
    • -1
    • +1
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 23 more files in changeset.
10:45 am

Dennis Tang <dennis.tang@deltares.nl>

- Added UpdateInfos to include update info tests - Extended PipingPlugIn test with asserts on the GetUpdateInfos function - Connected the importers with the correct strategies for the update and import functionality - Rearranged the argument order of the piping surface line importer in a more logical way - Fixed typos in XMLDocs

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8221 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ca4b09061daa8d0e0df9103580097bff04e7793e

Former-commit-id: babb3c57bdbf60b76c8247558d01412ef7043751

Options
    • -2
    • +2
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 9 more files in changeset.
Monday 13 Feb 2017
5:17 pm

Dennis Tang <dennis.tang@deltares.nl>

- Fixed typos, updated XMLDocs - Implemented the Update method of the surface line - Added custom exception to indicate that applying the update strategy has failed

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8214 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ad41877cc547b2fb9e4e025208d57db3a54fdec4

Former-commit-id: e398711b33dacb00592c2dc75ecda8b29b069a75

Options
    • -3
    • +32
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 10 more files in changeset.
2:51 pm

Dennis Tang <dennis.tang@deltares.nl>

- Adjusted license header - Added RingtoetsPipingSurfaceLineUpdateDataStrategy to update the surface lines with imported data. Implemented the following functionality: -- Removing surface lines when they are present in the current collection, but not in the imported collection -- Adding surface lines when they are not present in the current collection, but in the imported collection

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8207 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4bc162de79c06cea9ff4421051357a732d23f99b

Former-commit-id: 91aabbcc0ea3bdbbcfec1f492449946ea754918c

Options
    • -0
    • +154
    ./RingtoetsPipingSurfaceLineUpdateStrategy.cs
  2. … 4 more files in changeset.