DAM / DamClients / DamUI / trunk

src

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 8
Last Commit: 17 Dec
Commits this week: 1
Total Lines of Code (LoC): 87,768
Net change in LoC this week: 78

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading

Subversion Details

1 property
  • svn:mergeinfo = /DamClients/DamUI/branches/DamUI 18.1/src:1460,1761,2115,2119 /DamClients/DamUI/branches/DamUI 19.1/src:2804-2805 /DamClients/DamUI/branches/DamUI 19.3/src:3703,3706-3707,3751,3753-3754,3766-3774 /DamClients/DamUI/branches/DamUI 23.1/src:3941 /DamClients/DamUI/branches/RefactoringClientLibrary/src:1501-1506,1509
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Jul 2020
10:10 am

tang_ds

Modified conversion for a SoilProfile2D:

- Always set the layers to HydroStatic WaterPressureInterPolationModel when importing

Related to Issue [MWDAM-1686]

Options
    • -0
    • +1
    ./DamClientsLibrary/Deltares.Dam.Data/StiImporter/SoilProfile2DImporter.cs
    • -1
    • +1
    ./Dam/Tests/StiImporter/SoilProfile2DImporterTest.cs
9:29 am

tang_ds

Modified conversion for a SoilProfile2D:

- Fixed conversion for the WaterpressureInterpolationModel for a SoilLayer2D

Related to Issue [MWDAM-1686]

Options
    • -4
    • +6
    ./Dam/Tests/DamEngineIo/XmlSoilProfile2DConverterTest.cs
    • -1
    • +1
    ./DamClientsLibrary/Deltares.Dam.Data/DamEngineIo/XmlSoilProfile2DConverter.cs
8:34 am

tang_ds

Modified conversion for a SoilProfile2D:

- Fixed failing unit tests: added aquifer dictionary to the SoilList to prevent KeyNotFoundExceptions

Related to Issue [MWDAM-1686]

Options
    • -3
    • +12
    ./Dam/Tests/DamEngineIo/FillXmlInputFromDamUiTests.cs
Thursday 30 Jul 2020
3:53 pm

tang_ds

Modified conversion for a SoilProfile2D:

- Added step to transfer layer properties in the SoilProfile2DImporter

Related to Issue [MWDAM-1686]

Options
    • -5
    • +31
    ./Dam/Tests/StiImporter/SoilProfile2DImporterTest.cs
    • -0
    • +10
    ./DamClientsLibrary/Deltares.Dam.Data/StiImporter/SoilProfile2DImporter.cs
3:02 pm

tang_ds

Modified conversion for a SoilProfile2D:

- Explicitly set to a SoilProfile2D in case it is a sti file. Sti files are now read by in the FillDamUiFromXmlInput and should be passed as a SoilProfile2D instead

Related to Issue [MWDAM-1686]

Options
    • -0
    • +22
    ./Dam/Tests/DamEngineIo/FillXmlInputFromDamUiTests.cs
    • -1
    • +7
    ./DamClientsLibrary/Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
    • -1
    • +9
    ./DamClientsLibrary/Deltares.Dam.Data/DamEngineIo/FillDamUiFromXmlInput.cs
Wednesday 29 Jul 2020
6:46 pm

John Bokma

Improved error message for obsolete parameters in parameters xml.

Related to Issue [MWDAM-1677]

Options
    • -0
    • +1
    ./DamClientsLibrary/Deltares.Dam.Data/CalculationParameters.cs
6:12 pm

John Bokma

Improved error message for obsolete parameters in parameters xml.

Related to Issue [MWDAM-1677]

Options
    • -12
    • +19
    ./DamClientsLibrary/Deltares.Dam.Data/Assemblers/CalculationParametersAssembler.cs
9:22 am

John Bokma

Corrected reading for v20, stumbled on this when trying to reproduce the error in v20 before it was decided to solve it for v19.

Related to Issue [MWDAM-1579]

Options
    • -2
    • +8
    ./DamClientsLibrary/Deltares.Dam.Data/Assemblers/CalculationParametersAssembler.cs
Thursday 16 Apr 2020
9:12 am

tang_ds

Incorporated comments reviewer:

- Restored and commented original test categories

Related to Issue [MWDAM-1630]

Options
    • -0
    • +4
    ./Dam/Tests/LoadCompatiblityTest.cs
9:05 am

tang_ds

Incorporated comments reviewer:

- Removed dead code

- Fixed string values

Related to Issue [MWDAM-1630]

Options
    • -1
    • +0
    ./Dam/Forms/StabilityKernelTypeSpecificationsControl.cs
    • -17
    • +0
    ./DamClientsLibrary/Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
    • -1
    • +1
    ./Dam/Forms/Translations.xml
    • -1
    • +1
    ./DamClientsLibrary/Deltares.Dam.Data/Translations.xml
9:01 am

tang_ds

Incorporated comments reviewer:

- Made FailureMechanismSystemType.StabilityOutside invisible

- Improved source code by cleaning up the nested switch

Related to Issue [MWDAM-1630]

Options
    • -11
    • +11
    ./DamClientsLibrary/Deltares.Dam.Data/DamFailureMechanismeCalculationSpecification.cs
    • -0
    • +42
    ./Dam/Tests/DamFailureMechanismeCalculationSpecificationTest.cs
8:12 am

tang_ds

Incorporated comments reviewer:

- Ensured that the soil profile names are distinct for 1D profiles

Related to Issue [MWDAM-1380]

Options
    • -4
    • +4
    ./Dam/Tests/DamEngineIo/FillXmlInputFromDamUiTests.cs
Wednesday 15 Apr 2020
1:56 pm

tang_ds

Fixed SonarQube issues

Related to Issue [MWDAM-1374]

Options
    • -1
    • +0
    ./DamClientsLibrary/Deltares.Dam.Data/StiImporter/StiFileReader.cs
11:32 am

tang_ds

Set failing tests to "WorkInProgress" category:

- Tests currently fail due to the functional requirement that only outdated projects with UpliftVan model settings are supported and loaded into the application.

Related to Issue [MWDAM-1630]

Options
    • -3
    • +3
    ./Dam/Tests/LoadCompatiblityTest.cs
9:57 am

tang_ds

Incorporated comments reviewer:

- Added test to verify that the 1D and 2D profiles are serialized correctly

Related to Issue [MWDAM-1380]

Options
    • -0
    • +135
    ./Dam/Tests/DamEngineIo/FillXmlInputFromDamUiTests.cs
Tuesday 14 Apr 2020
4:01 pm

tang_ds

Disabled model selection when StabilityOutside or StabilityInside failure mechanism is active:

- Removed duplicate entry

Related to Issue [MWDAM-1630]

Options
    • -2
    • +0
    ./DamClientsLibrary/Deltares.Dam.Data/UISupport/ConfigurationManager.cs
3:53 pm

tang_ds

Disabled model selection when StabilityOutside or StabilityInside failure mechanism is active:

- Disabled options also in the ConfigurationManager, as this gives problems when loading older projects

Related to Issue [MWDAM-1630]

Options
    • -5
    • +5
    ./DamClientsLibrary/Deltares.Dam.Data/UISupport/ConfigurationManager.cs
    • -5
    • +5
    ./Dam/Tests/UISupport/ConfigurationManagerTest.cs
3:41 pm

tang_ds

Added check to validate whether the outdate file is supported:

- Only files that contain UpliftVan settings are currently supported --> if old files are not made with these settings, do not load further and generate an error message.

Related to Issue [MWDAM-1630]

Options
    • -2
    • +28
    ./DamClientsLibrary/Deltares.Dam.Data/DamProject.cs
    • -0
    • +1
    ./DamClientsLibrary/Deltares.Dam.Data/Translations.xml
12:02 pm

tang_ds

Fixed failing tests:

- Removed all mentions to the Wti kernel

Related to Issue [MWDAM-1630]

Options
    • -9
    • +0
    ./Dam/Tests/UISupport/ConfigurationManagerTest.cs
11:53 am

tang_ds

Removed StabilityKernelType:

- Removed combobox binding and replaced it with a static label indicating which kernel is used

- Removed obsolete Translations.xml entries

Related to Issue [MWDAM-1630]

Options
    • -0
    • +3
    ./Dam/Forms/StabilityKernelTypeSpecificationsControl.cs
    • -20
    • +2
    ./Dam/Forms/StabilityKernelTypeSpecificationsControl.Designer.cs
    • -3
    • +0
    ./DamClientsLibrary/Deltares.Dam.Data/Translations.xml
    • -0
    • +1
    ./Dam/Forms/Translations.xml
11:20 am

tang_ds

Removed StabilityKernelType:

- Removed obsolete enum

Related to Issue [MWDAM-1630]

Options
    • -12
    • +0
    ./DamClientsLibrary/Deltares.Dam.Data/DAMEnumerations.cs
11:19 am

tang_ds

Removed StabilityKernelType:

- Removed from the CsvExportData

Related to Issue [MWDAM-1630]

Options
    • -30
    • +11
    ./DamClientsLibrary/Deltares.Dam.Data/CsvExportData.cs
10:41 am

tang_ds

Removed StabilityKernelType:

- Removed from the FailureMechanismCalculationSpecification and its affected callers.

Related to Issue [MWDAM-1630]

Options
    • -1
    • +0
    ./Dam/Tests/FailureMechanismTests.cs
    • -8
    • +5
    ./Dam/Tests/DamCalculationBenchmarkTest.cs
    • -10
    • +0
    ./DamClientsLibrary/Deltares.Dam.Data/DamFailureMechanismeCalculationSpecification.cs
10:38 am

tang_ds

Removed StabilityKernelType:

- Removed from the DamProjectCalculationSpecification and its affected callers.

Related to Issue [MWDAM-1630]

Options
    • -16
    • +0
    ./DamClientsLibrary/Deltares.Dam.Data/DamProjectCalculationSpecification.cs
    • -3
    • +0
    ./DamClientsLibrary/Deltares.Dam.Data/DamEngineIo/FillDamUiFromXmlOutput.cs
    • -2
    • +0
    ./Dam/Forms/StabilityKernelTypeSpecificationsControl.cs
10:34 am

tang_ds

Removed StabilityKernelType:

- Removed from the ConfigurationManager and its affected callers.

Related to Issue [MWDAM-1630]

Options
    • -38
    • +34
    ./DamClientsLibrary/Deltares.Dam.Data/UISupport/ConfigurationManager.cs
    • -17
    • +14
    ./Dam/Tests/UISupport/ConfigurationManagerTest.cs
    • -4
    • +4
    ./DamClientsLibrary/Deltares.Dam.Data/DamFailureMechanismeCalculationSpecification.cs
10:18 am

tang_ds

Removed StabilityKernelType:

- Removed from the FillXmlInputFromDamUi

Related to Issue [MWDAM-1630]

Options
    • -42
    • +6
    ./DamClientsLibrary/Deltares.Dam.Data/DamEngineIo/FillXmlInputFromDamUi.cs
10:08 am

tang_ds

Disabled model selection when StabilityOutside or StabilityInside failure mechanism is active:

- Set UpLiftVan as default value when a new project is made

- Added tests to verify behaviour

Related to Issue [MWDAM-1630]

Options
    • -1
    • +1
    ./DamClientsLibrary/Deltares.Dam.Data/MStabParameters.cs
    • -0
    • +55
    ./Dam/Tests/MStabParametersTest.cs
    • -0
    • +110
    ./Dam/Tests/DamFailureMechanismeCalculationSpecificationTest.cs
    • -0
    • +2
    ./Dam/Tests/Deltares.Dam.Tests.csproj
    • -10
    • +14
    ./DamClientsLibrary/Deltares.Dam.Data/DamFailureMechanismeCalculationSpecification.cs
9:29 am

tang_ds

Incorporated comments reviewer:

- Reverted SoilGeometry2DName to simply the profile name (without extension)

Related to Issue [MWDAM-1380]

Options
    • -1
    • +1
    ./Dam/Tests/DamEngineIo/FillXmlInputFromDamUiTests.cs
Friday 10 Apr 2020
12:41 pm

tang_ds

Incorporated comments reviewer:

- Moved the naming of the read SoilProfile2D to the Importer as all the information is available there

-- The reader is only responsible for reading the soil profile, not for setting additional postprocessing of the read data

Related to Issue [MWDAM-1374]

Options
    • -3
    • +1
    ./Dam/Tests/StiImporter/StiFileReaderTest.cs
    • -8
    • +8
    ./DamClientsLibrary/Deltares.Dam.Data/StiImporter/SoilProfile2DImporter.cs
    • -2
    • +0
    ./DamClientsLibrary/Deltares.Dam.Data/StiImporter/StiFileReader.cs
    • -4
    • +4
    ./Dam/Tests/StiImporter/SoilProfile2DImporterTest.cs
12:30 pm

tang_ds

Incorporated comments reviewer:

- Removed argument "propertyName" and made dedicated messages for when the soil or geometry version numbers are unsupported

Related to Issue [MWDAM-1374]

Options
    • -3
    • +2
    ./DamClientsLibrary/Deltares.Dam.Data/Translations.xml
    • -5
    • +4
    ./DamClientsLibrary/Deltares.Dam.Data/StiImporter/StiFileValidator.cs