Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Refactored.

Related to Issue [MWDAM-1654]

    • -7
    • +7
    ./MacroStabilityInwards/UpliftVanGridCreator.cs
    • -22
    • +9
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 1 more file in changeset.
First implementation of UpliftVan grid creation (specified grids and tangent lines)

Related to Issue [MWDAM-1654]

    • -24
    • +55
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -21
    • +79
    ./MacroStabilityInwards/UpliftVanGridCreator.cs
Improved getting back results from C#wrapper with tests

Related to Issue [MWDAM-1627]

    • -9
    • +11
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperOutput.cs
    • -5
    • +5
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 2 more files in changeset.
Improved wrapper and test.

Related to Issue [MWDAM-1627]

    • -0
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 2 more files in changeset.
Refactored, prepare for real implementation

Related to Issue [MWDAM-1654]

    • -32
    • +1
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -0
    • +62
    ./MacroStabilityInwards/UpliftVanGridCreator.cs
  1. … 1 more file in changeset.
Added setting mock tangentlines too.

Related to Issue [MWDAM-1627]

    • -0
    • +7
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
Re-instated using UpliftVanCalculationGrid.

Related to Issue [MWDAM-1627]

    • -2
    • +2
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -1
    • +27
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -0
    • +29
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
  1. … 1 more file in changeset.
Adapted to new version of C#wrapper, fixed some WIP-test for the wrapper.

Related to Issue [MWDAM-1627]

    • -14
    • +12
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -24
    • +59
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -7
    • +6
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
  1. … 4 more files in changeset.
Incorporated comments review:

- Adjusted function names

- Removed unused variable

Related to Issue [MWDAM-1398]

    • -5
    • +5
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 2 more files in changeset.
Adapted the calculation grid. Cleaned code a bit.

Related to Issue [MWDAM-1627]

    • -4
    • +0
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperOutputFromEngine.cs
    • -2
    • +26
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -64
    • +39
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -25
    • +32
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -8
    • +4
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperOutput.cs
  1. … 3 more files in changeset.
Removed double using.

Related to Issue [MWDAM-1632]

Cleanup the 1D profile implementation:

- No need for separate CreateHeadLine method, as the generic method will already create one.

Related to Issue [MWDAM-1398]

    • -52
    • +26
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Added NULL checks to the converter routine:

- Generalised log message

Related to Issue [MWDAM-1398]

    • -7
    • +10
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 4 more files in changeset.
Added testcase which represents the edgecase when multiple aquifer layers for the inebtween aquifer layer does not envelope the whole X coordinate range

Related to Issue [MWDAM-1398]

    • -10
    • +27
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Added first implementation of PLLine conversion to waternet input for 2D profiles

Related to Issue [MWDAM-1398]

    • -1
    • +146
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Implemented the required (minimum) output with tests and conversion helper. Removed some obsolete code and tests.

Related to Issue [MWDAM-1627]

    • -1
    • +35
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperOutputFromEngine.cs
    • -4
    • +38
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperOutput.cs
    • -14
    • +0
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 3 more files in changeset.
Finished the issue now soil parameters are all decoded upon and implemented.

Related to Issue [MWDAM-1632]

  1. … 1 more file in changeset.
Re-implemented r=the tangent lines now these are part of the wrapper again.

Related to Issue [MWDAM-1627]

    • -6
    • +5
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -5
    • +4
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  1. … 1 more file in changeset.
Adapted failing tests due to new C#wrapper, Started with correct implementation of MacroStabilityInwardsKernelWrapper based on the C#wrapper, added conversion methods with tests for that to support some result items.

Related to Issue [MWDAM-1627]

    • -52
    • +35
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 6 more files in changeset.
Added testcase for the PLLines to Waternet converter when PLLines lie below the profile

Related to Issue [MWDAM-1398]

    • -9
    • +25
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Updated definitions for PL3 and PL4:

- Waternetline for PL3 is associated with the toplevel of the bottom most aquifer layer

- Waternetline for PL4 is associated with the toplevel of the in between aquifer layer

Related to Issue [MWDAM-1398]

    • -4
    • +4
    ./MacroStabilityCommon/PlLinesToWaternetConverter.cs
  1. … 1 more file in changeset.
Quick fix for compilation errors due to new release of C#wrapper.

Related to Issue [MWDAM-1627]

    • -59
    • +29
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -9
    • +11
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -15
    • +2
    ./MacroStabilityInwards/MacroStabilityKernelDataInput.cs
    • -9
    • +11
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -0
    • +7
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperOutput.cs
  1. … 1 more file in changeset.
Implemented conversions for the waternet from the DamEngine to the calculation kernel.

Related to Issue [MWDAM-1398]

    • -54
    • +54
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -52
    • +52
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
  1. … 1 more file in changeset.
Adapted to review comments bar the renaming of the Fill.. classes themselves. Solved some SonarQube code smells. Complaints by SonarQube about uncovered lines are BUILLSHIT!!!!!!!!!!!!!! All the added lines are covered by the IO tests which is easily verifiable by setting some breakpoints and debugging the IO tests. You see the code is covered.

Related to Issue [MWDAM-1623]

    • -9
    • +17
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
    • -12
    • +12
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
Implemented trafficload with test.

Related to Issue [MWDAM-1638]

    • -0
    • +11
    ./MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
  1. … 1 more file in changeset.
Implemented conversions for the UpliftVanCalculationGrid from the DamEngine to the calculation kernel.

Related to Issue [MWDAM-1399]

    • -18
    • +23
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -18
    • +45
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  1. … 1 more file in changeset.
Added conversion of surfaceline including test.

Related to Issue [MWDAM-1637]

    • -16
    • +16
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -15
    • +12
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  1. … 1 more file in changeset.
Added conversion for SoilProfile2D and PreconcolidationStress (as these are part of the SoilProfile2D in DamEngine) with test. Improved the Factory to rpovide the correct data needed for a FULL test of the SoilProfile2D, so with Points next to CalcPoints.

Related to Issue [MWDAM-1397]

    • -94
    • +76
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -91
    • +88
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
  1. … 2 more files in changeset.
Adapted to review comments.

Related to Issue [MWDAM-1633]

  1. … 1 more file in changeset.
Corrected MoveGrid parameter for kernel. It really is NOT in the DamEngine data model but is must be set to true as we want the brute force approach.

Related to Issue [MWDAM-1633]

    • -7
    • +1
    ./MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -1
    • +1
    ./MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs