DAM / DamEngine / trunk / src / Deltares.DamEngine.Calculators

PlLinesCreator

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 6
Last Commit: 05 Dec
Commits this week: 1
Total Lines of Code (LoC): 3,293
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 17 Nov
3:05 pm

Virginie Trompille

For 2D geometry, if the Penetration zone is situated partly in the in-between aquifer, PL2 is set equal to PL4.

Unit tests added.

Unused methods in FactoryForSoilProfiles removed.

Related to Issue [MWDAM-2376]

Options
    • -61
    • +53
    ./PlLinesCreator.cs
  2. … 4 more files in changeset.
Tuesday 15 Apr
5:33 pm

Virginie Trompille

Reformat and Cleanup Deltares to update the copyright to 2025

Related to Issue [MWDAM-2038]

Options
    • -1
    • +1
    ./PLLineConstructor.cs
    • -1
    • +1
    ./SensorPlLine3Or4CreatorBase.cs
    • -1
    • +1
    ./SensorPlLine1Creator.cs
    • -1
    • +1
    ./SensorPlLine2Creator.cs
    • -1
    • +1
    ./SensorPlLine3Creator.cs
    • -1
    • +1
    ./SensorPlLine4Creator.cs
    • -1
    • +1
    ./SensorPlLineCreator.cs
    • -1
    • +1
    ./SensorPlLineCreatorBase.cs
    • -9
    • +8
    ./SoilProfileValidator.cs
    • -1
    • +1
    ./SensorPlLineCreatorException.cs
    • -116
    • +115
    ./PlLinesCreator.cs
    • -1
    • +1
    ./PlLinesCreatorException.cs
    • -1
    • +1
    ./IPlLineCreator.cs
  14. … 384 more files in changeset.
Monday 24 Mar
5:37 pm

Esther van Zantvoort

Rename CalcPoints to Points and calcPoints to points.

Related to Issue [MWDAM-2768]

Options
    • -64
    • +64
    ./PlLinesCreator.cs
    • -1
    • +1
    ./SoilProfileValidator.cs
  3. … 43 more files in changeset.
Thursday 20 Mar
10:20 am

Virginie Trompille

Unit test added for method GetZValue

Related to Issue [MWDAM-2766]

Options
    • -0
    • +4
    ./PLLineConstructor.cs
  2. … 1 more file in changeset.
Wednesday 19 Mar
1:30 pm

Virginie Trompille

Obsolete soil properties removed from the DAM Engine xml input and Soil data object

Related to Issue [MWDAM-2803]

Options
    • -1
    • +0
    ./PlLinesCreator.cs
  2. … 22 more files in changeset.
Monday 17 Mar
5:27 pm

Virginie Trompille

PL1 creator from sensors corrected (Point DikeToeAtPolder not created if SourceType is Ignore or if no Polder Sensor present).

Unit tests adapted according to change.

Related to Issue [MWDAM-2766]

Options
    • -36
    • +11
    ./SensorPlLine1Creator.cs
    • -0
    • +6
    ./PLLineConstructor.cs
  3. … 1 more file in changeset.
Thursday 13 Mar
11:53 am

John Bokma

Removed GeometryPoint from GeometryPointString/GeometryLoop classes and everywhere it was used. Improved geometry generation and Clone() methods for SoilProfile2D.

Related to Issue [MWDAM-2760]

Options
    • -2
    • +2
    ./SoilProfileValidator.cs
    • -15
    • +4
    ./SensorPlLineCreatorBase.cs
    • -20
    • +20
    ./SensorPlLine1Creator.cs
    • -127
    • +128
    ./PlLinesCreator.cs
  5. … 52 more files in changeset.
Wednesday 12 Mar
10:58 am

Virginie Trompille

unit tests added on lower level + code improved

Related to Issue [MWDAM-2691]

Options
    • -56
    • +64
    ./PlLinesCreator.cs
  2. … 6 more files in changeset.
Friday 07 Mar
9:43 am

Virginie Trompille

Test for 2D profile is updated (shoulder and ditch added) and comparison is extended to the Pl lines of both profiles and both time steps

Related to Issue [MWDAM-2706]

Options
    • -1
    • +1
    ./SensorPlLine1Creator.cs
  2. … 4 more files in changeset.
Tuesday 04 Mar
4:23 pm

Virginie Trompille

Unit test added using the data provided by RPS in issue MWDAM_2631.

Code corrected for searching the intersection point with PL1.

Unused property XSoilGeometry2DOrigin removed from PlLinesCreator.

Related to Issue [MWDAM-2631]

Options
    • -3
    • +2
    ./PlLinesCreator.cs
  2. … 22 more files in changeset.
12:06 pm

Virginie Trompille

Code for the PL3/PL4 reduction re-implemented and improved (1D soil profile is not converted to 2D soil profile to spare calculation time).

Integration tests for piping updated with the new results.

Related to Issue [MWDAM-2691]

Options
    • -58
    • +76
    ./PlLinesCreator.cs
  2. … 3 more files in changeset.
9:18 am

Virginie Trompille

code temporary reverted due to execution timeout

Related to Issue [MWDAM-2691]

Options
    • -4
    • +4
    ./PlLinesCreator.cs
Monday 03 Mar
5:35 pm

Virginie Trompille

Reduction of PL3/PL4 temporary reverted to better investigate the piping failing tests (execution time out)

Related to Issue [MWDAM-2691]

Options
    • -3
    • +5
    ./PlLinesCreator.cs
  2. … 1 more file in changeset.
3:37 pm

Virginie Trompille

Adapted to review: method starting with Get renamed into Determine

Related to Issue [MWDAM-2724]

Options
    • -5
    • +5
    ./PlLinesCreator.cs
  2. … 4 more files in changeset.
3:29 pm

Virginie Trompille

Reduction of PL3/PL4 implemented when the aquifer intersects the surface line (i.e. the ditch)

Related to Issue [MWDAM-2691]

Options
    • -13
    • +103
    ./PlLinesCreator.cs
  2. … 4 more files in changeset.
Saturday 01 Mar
4:07 pm

Esther van Zantvoort

Remove code for reading sti files.

Related to Issue [MWDAM-2160]

Options
    • -6
    • +0
    ./PlLinesCreator.cs
    • -5
    • +1
    ./SoilProfileValidator.cs
  3. … 26 more files in changeset.
Thursday 27 Feb
12:17 pm

Virginie Trompille

Validation performed in PlLinesCreator removed because duplication of the validation performed in ValidateSoilProfileForPlLinesCreation

Related to Issue [MWDAM-2724]

Options
    • -87
    • +22
    ./PlLinesCreator.cs
  2. … 6 more files in changeset.
Wednesday 19 Feb
2:36 pm

Virginie Trompille

Code improved and header in public method added

Related to Issue [MWDAM-2704]

Options
    • -3
    • +1
    ./SoilProfileValidator.cs
  2. … 1 more file in changeset.
2:17 pm

Virginie Trompille

For the validation of the soil profile, an aquifer with aquitard inner loop is valid

Related to Issue [MWDAM-2704]

Options
    • -1
    • +3
    ./SoilProfileValidator.cs
  2. … 2 more files in changeset.
Thursday 13 Feb
5:55 pm

Esther van Zantvoort

Adapted to review

Related to Issue [MWDAM-2643]

Options
    • -1
    • +1
    ./PlLinesCreator.cs
  2. … 2 more files in changeset.
Wednesday 12 Feb
4:45 pm

Esther van Zantvoort

Fix sonarcloud Reliability issues: Do not check floating point equality with exact values, use a range instead

Related to Issue [MWDAM-2643]

Options
    • -2
    • +3
    ./PlLinesCreator.cs
  2. … 2 more files in changeset.
Tuesday 04 Feb
4:59 pm

Esther van Zantvoort

Skip check on CheckWaterLevelIsAboveDikeToeRiverSide in SensorPlLine1Creator.

If no intersection point found with water level at dike river side, add point at DikeToeAtRiver.

Related to Issue [MWDAM-2647]

Options
    • -7
    • +2
    ./SensorPlLineCreatorBase.cs
    • -7
    • +13
    ./SensorPlLine1Creator.cs
11:48 am

Tom The

Added test for using LocationData for the sensor of DikeTopAtPolder

Related to Issue [MWDAM-2627]

Options
    • -1
    • +1
    ./SensorPlLine1Creator.cs
  2. … 4 more files in changeset.
Tuesday 21 Jan
1:01 pm

Virginie Trompille

Adapted to review: isolated aquifer changed to discontinuous aquifer

Related to Issue [MWDAM-2164]

Options
    • -6
    • +6
    ./SoilProfileValidator.cs
  2. … 4 more files in changeset.
Monday 20 Jan
5:29 pm

Virginie Trompille

Adapted to review: typo + renaming + pictures of soil profile added in tests

Related to Issue [MWDAM-2164]

Options
    • -6
    • +6
    ./SoilProfileValidator.cs
  2. … 3 more files in changeset.
9:09 am

Virginie Trompille

Code refactored to solve issues detected by sonarcloud

Related to Issue [MWDAM-2581]

Options
    • -1
    • +1
    ./SoilProfileValidator.cs
  2. … 1 more file in changeset.
Friday 17 Jan
5:13 pm

Virginie Trompille

Add a validation on the presence of isolated in-between aquifers

Related to Issue [MWDAM-2581]

Options
    • -0
    • +20
    ./SoilProfileValidator.cs
  2. … 7 more files in changeset.
9:30 am

Virginie Trompille

Validation of the Dike embankment material is incorrect (material needed only for 1D profile, not 2D)

Related to Issue [MWDAM-2164]

Options
    • -3
    • +3
    ./SoilProfileValidator.cs
  2. … 1 more file in changeset.
Thursday 16 Jan
4:58 pm

Virginie Trompille

Check on the presence of aquifers/aquitards for 1D profile is done at cross section DikeTopAtPolder (instead of DikeToeAtPolder) to include the layers in the dike body.

Related to Issue [MWDAM-2164]

Options
    • -1
    • +1
    ./SoilProfileValidator.cs
11:52 am

Virginie Trompille

Validations of the soil profile performed in class PlLinesCreator.cs and PlLinesToWaternetConverter.cs are moved to a new class SoilProfileValidator and called only by the PlLinesCreator.

Related to Issue [MWDAM-2164]

Options
    • -48
    • +22
    ./PlLinesCreator.cs
    • -0
    • +186
    ./SoilProfileValidator.cs
  3. … 13 more files in changeset.