Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Made sure that file is copied as it is supposed to be.

Related to Issue [MWDAM-1889]

  1. … 25 more files in changeset.
Use string interpolation

Related to Issue [MWDAM-1878]

  1. … 29 more files in changeset.
Convert to file-scoped namespace

Related to Issue [MWDAM-1878]

    • -11
    • +10
    ./SoilProfile1DAquiferLayerCombinerException.cs
    • -553
    • +552
    ./SurfaceLine2Extensions.cs
    • -101
    • +100
    ./SurfaceLine2Validator.cs
  1. … 307 more files in changeset.
Remove trailing comma's

Related to Issue [MWDAM-1877]

  1. … 10 more files in changeset.
Reformat and cleanup

Related to Issue [MWDAM-1874]

    • -103
    • +124
    ./SurfaceLine2Extensions.cs
    • -3
    • +5
    ./SoilProfile1DAquiferLayerCombinerException.cs
    • -117
    • +115
    ./CharacteristicPointSet.cs
    • -14
    • +14
    ./SoilProfile1DAquiferLayerCombiner.cs
  1. … 384 more files in changeset.
Run clean-up to update file headers

Related to Issue [MWDAM-1854]

    • -5
    • +5
    ./SoilProfile1DAquiferLayerCombinerException.cs
    • -5
    • +5
    ./SoilProfile1DAquiferLayerCombiner.cs
  1. … 319 more files in changeset.
Remove number of parameters

Related to Issue [MWDAM-1856]

  1. … 4 more files in changeset.
Remove unused setter

Related to Issue [MWDAM-1856]

Remove the unnecessary Boolean literal(s)

Related to Issue [MWDAM-1856]

  1. … 7 more files in changeset.
Remove unused directives

Related to Issue [MWDAM-1856]

    • -1
    • +0
    ./SoilProfile1DAquiferLayerCombiner.cs
  1. … 21 more files in changeset.
Use getters and setters for properties

Related to Issue [MWDAM-1856]

    • -3
    • +3
    ./SoilProfile1DAquiferLayerCombiner.cs
  1. … 7 more files in changeset.
Solved the bugs in SonarQube. Note that 2 (of the 10) reported bugs were actually false negatives as assessed by me and reviewed by Tom who closed these two bugs.

Related to Issue [MWDAM-1852]

  1. … 3 more files in changeset.
Adaapted to review comments.

Related to Issue [MWDAM-1842]

  1. … 2 more files in changeset.
Re-implemented Adapt Geometry option for OptimizedSlopeAndShoulderAdaption, model Bishop.

Related to Issue [MWDAM-1842]

  1. … 6 more files in changeset.
Updated the headers files for the code projects after updating the template.

Related to Issue [MWDAM-1730]

    • -1
    • +1
    ./SoilProfile1DAquiferLayerCombiner.cs
  1. … 262 more files in changeset.
Fixed the issue by replacing soil as dictionary key by soilname as key for the Aquifer dictionary. Now the aquifers can be found.

Related to Issue [MWDAM-1697]

  1. … 8 more files in changeset.
Incorporated comments CR-DAM55:

- Changed enum values back to original values and fixed failing tests

-- Initialize WaterpressureInterpolationModel for tests that fail and make use of soil layers

-- Initialize the DikeEmbankmentMaterial soil layer with HydroStatic when it is needed

Related to Issue [MWDAM-1650]

  1. … 2 more files in changeset.
Adapted to review comments + added comment for bishop test + some small improvements to code (typo's and correcting signature for CalculateOneTimeEntry). Finally added PipingFactor to enum as we need that for the next step (piping in DamLive).

Related to Issue [MWDAM-1627]

  1. … 5 more files in changeset.
Cleanup:

- Extracted function for retrieving the enclosed areas.

Related to Issue [MWDAM-1683]

Fixed edge case:

- Updated XMLDocs and function argument types to prevent modification to collections

-- Changed a ToList to an ToArray call to prevent modifications

Related to Issue [MWDAM-1683]

Fixed edge case:

- Updated XMLDocs and function argument types to prevent modification to collections

- Added a filter on the layerdata --> the layer data sometimes generates a surface consisting of two curves (which simply cannot represent a surface, because at least 3 curves are necessary). This behavior becomes relevant when running TestRunMacroStabilityWithErrorUpliftVan

Related to Issue [MWDAM-1683]

Fixed edge case:

- Refactored solution: pass a local surface line geometry to prevent rounding off errors from properly recognising the surfaces

Related to Issue [MWDAM-1683]

Fixed edge case:

- Added case to deal with horizontal intersections or when the ZCoordinate has rounding errors at intersections

Related to Issue [MWDAM-1683]

  1. … 1 more file in changeset.
Cleanup:

- Updated XMLDocs and function calls

Related to Issue [MWDAM-1683]

Cleanup:

- Refactored: extracted a function to generate closed outer loop based on coordinates

Related to Issue [MWDAM-1683]

Cleanup:

- Reordered functions for clarity

Related to Issue [MWDAM-1683]

Cleanup:

- Removed obsolete code

Related to Issue [MWDAM-1683]

Improved algorithm for the generation of surfaces:

- Added test to verify that the soil properties are correctly set after generating

Related to Issue [MWDAM-1683]

  1. … 1 more file in changeset.
Improved algorithm for the generation of surfaces:

- Adjustments made when the intersection inflects at the bottom level of a layer

Related to Issue [MWDAM-1683]

  1. … 1 more file in changeset.
Fixed failing unit test:

- Corrected algorithm, because apparently it is possible to get an enclosed area without coordinates ---> corrected filtering

- Adjusted resulting safety factor.

Related to Issue [MWDAM-1683]

  1. … 1 more file in changeset.