DAM / DamEngine / trunk

src

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 17 Dec
Commits this week: 0
Total Lines of Code (LoC): 147,819
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 05 Feb 2020
7:04 pm

John Bokma

Adapted to comments some more.

Related to Issue [MWDAM-1383]

Options
    • -0
    • +4
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/ConversionHelperTests.cs
    • -2
    • +5
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/ConversionHelper.cs
3:18 pm

John Bokma

Adapted in accordance with review comments.

Related to Issue [MWDAM-1618]

Options
    • -2
    • +13
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -4
    • +3
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -19
    • +19
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
    • -0
    • +5
    ./Deltares.DamEngine.Data/General/Dike.cs
Tuesday 04 Feb 2020
6:43 pm

John Bokma

Fixed failing slow tests.

Related to Issue [MWDAM-1618]

Options
    • -4
    • +4
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Invoer10.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile1LocationWithAdaption.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile18.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DeltaDijkZoneringInwards.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/ErrorInDGeoStabilityCalculation.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DeltaDijkZoneringInwardsZone2.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile13.xml
5:50 pm

John Bokma

Fixed failing tests.

Related to Issue [MWDAM-1618]

Options
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTH.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_WtiSellmeijerRevisedFailedDesignInputFile_1Location.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_WtiSellmeijerRevisedInputFile.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DeltaDijkInvoer3VNKAdaptionShoulderLength.xml
3:47 pm

Tom The

Release binaries

Related to Issue [MWDAM-1345]

Related to Issue [MWDAM-1617]

Options
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputForDebugging.xml
  2. … 13 more files in changeset.
2:59 pm

John Bokma

Moved HeadPl2 within Location from WaternetOptions to DesignScenario. Also removed HeadPl3 and HeadPl4 from Location.

Started fixing failing tests.

Related to Issue [MWDAM-1618]

Options
    • -6
    • +6
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/PlLinesHelper.cs
    • -2
    • +2
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -0
    • +2
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapperTests.cs
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_BlighInputFile.xml
    • -1
    • +1
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -1
    • +6
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/PlLinesHelperTests.cs
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_BlighDesignInputFile.xml
    • -2
    • +3
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -3
    • +3
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapperTests.cs
    • -5
    • +5
    ./Deltares.DamEngine.Data/General/Sensors/SensorLocation.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingSellmeijer4Forces/DamPipingSellmeijer4ForcesKernelWrapperTests.cs
    • -4
    • +28
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -2
    • +3
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorLocationTests.cs
  16. … 4 more files in changeset.
2:50 pm

Tom The

Fixed unit test

Update FO

Related to Issue [MWDAM-1617]

Related to Issue [MWDAM-1345]

Related to Issue [MWDAM-1617]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
  2. … 2 more files in changeset.
1:16 pm

Tom The

Fixed failing unit test

Related to Issue [MWDAM-1617]

Options
    • -204
    • +204
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputForDebugging.xml
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geotechnics/SurfaceLine2Extensions.cs
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
12:11 pm

John Bokma

Moved PolderLevel within Location from WaternetOptions to DesignScenario.

Related to Issue [MWDAM-1618]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapper.cs
    • -42
    • +26
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
    • -0
    • +9
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/PlLinesHelper.cs
    • -7
    • +7
    ./Deltares.DamEngine.Calculators.Tests/DikesDesign/SurfaceLineAdapterTest.cs
    • -2
    • +6
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorLocationTests.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -1
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineShoulderAdapter.cs
    • -0
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/DamMacroStabilityTestHelper.cs
    • -3
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamPipingSellmeijerVnk/DamPipingSellmeijerVnkKernelWrapper.cs
    • too large
    ./Deltares.DamEngine.Calculators.Tests/DikesDesign/SurfaceLineShoulderAdapterTest.cs
    • -1
    • +2
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
    • -1
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineHeightAdapter.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorFirstSlopeAdaptionThenShoulderAdaption.cs
  16. … 15 more files in changeset.
9:26 am

Tom The

Add ignored test to be used for debugging input XM files

Related to Issue [MWDAM-1617]

Options
    • -0
    • +535
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputForDebugging.xml
    • -0
    • +4
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
    • -0
    • +55
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/DebuggingTest.cs
Friday 02 Aug 2019
4:01 pm

John Bokma

Fixed some more failing tests by adapting data.

Related to Issue [MWDAM-1345]

Options
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/PipingBlighTests.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityHorizontalBalance/DamMacroStabilityHorizontalBalanceKernelWrapperTests.cs
    • -3
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
    • -44
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityOutwardsTests.cs
3:16 pm

John Bokma

Fixed some more failing tests by adapting data.

Related to Issue [MWDAM-1345]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/MStabXmlDocTests.cs
    • -0
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/DamMacroStabilityTestHelper.cs
    • -8
    • +8
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/TestData/Expected1D1.xml
1:28 pm

John Bokma

Fixed failing test by adapting data.

Related to Issue [MWDAM-1345]

Options
    • -1
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/MStabXmlDocTests.cs
    • -6
    • +6
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/TestData/Expected1D1.xml
11:36 am

John Bokma

Fixed problem 1 as stated by PO in issue, just throw error when water level (high/low) at riverside is below dike toe. Added tests for this.

Related to Issue [MWDAM-1345]

Options
    • too large
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/PlLinesCreatorTest.cs
    • -8
    • +16
    ./Deltares.DamEngine.Data/Geotechnics/SurfaceLine2Extensions.cs
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SensorPlLine1Creator.cs
    • -0
    • +65
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
Thursday 01 Aug 2019
5:25 pm

Tom The

I improved some code (code was correct, but prevent SonarQube message and improved exception testing in the tests)

Related to Issue [MWDAM-1445]

Options
    • -2
    • +0
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
    • -3
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalGrebbedijkTests.cs
  3. … 1 more file in changeset.
12:41 pm

John Bokma

Added code (with tests) to improve handling of "wrong" segments. To be able to test this properly, added PipingModelType.Wti2017 to supported models so we can actually define an improper test project. Adding this also helps for MWDAM-1393 and thus MWDAM-1145, Piping part.

Related to Issue [MWDAM-1445]

Options
    • -8
    • +13
    ./Deltares.DamEngine.Calculators/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
    • -0
    • +66
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalGrebbedijkTests.cs
    • -18
    • +53
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
11:50 am

Tom The

Set version dam engine to 19.1.0 (19.1.1 has not been released yet)

Removed obsolete file

Related to Issue [MWDAM-1513]

Options
    • -10
    • +0
    ./GlobalAssemblyInfo.cs
    • -2
    • +2
    ./Deltares.DamEngine.Version/GlobalAssembly.cs.svn
Monday 29 Jul 2019
6:09 pm

John Bokma

Ensured deleting of created test data folders at end of tests.

Related to Issue [MWDAM-1554]

Options
    • -0
    • +28
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
4:41 pm

Tom The

Fix bug reported by SonarQube

Related to Issue [MWDAM-1513]

Options
    • -13
    • +1
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
9:09 am

Tom The

Fix bug reported by SonarQube

Related to Issue [MWDAM-1514]

Options
    • -2
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
Friday 26 Jul 2019
9:00 am

Tom The

Fix bug reported by SonarQube

Related to Issue [MWDAM-1514]

Options
    • -2
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
Thursday 25 Jul 2019
12:56 pm

John Bokma

Replaced two test files by one, rewrote tests to use common code.

Related to Issue [MWDAM-1554]

Options
    • -331
    • +0
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTHWithNoAdaption.xml
    • -0
    • +331
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTH.xml
    • -103
    • +92
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -331
    • +0
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTHWithAdaption.xml
    • -4
    • +1
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
Wednesday 24 Jul 2019
4:29 pm

Tom The

Typos fixed and improved formatting

Related to Issue [MWDAM-1554]

Options
    • -12
    • +11
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
3:18 pm

John Bokma

Re-instated deep copy and reset of surface line in PerformDesignCalculation to ensure that correct surface line is used for each individual design step in case of Piping as well as in Stability.

Related to Issue [MWDAM-1554]

Options
    • -21
    • +34
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
1:56 pm

John Bokma

Fixed the issue by taking the adaption of the surface line forward to before kernel Prepare statement. Added tests for it.

Related to Issue [MWDAM-1554]

Options
    • -0
    • +331
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTHWithNoAdaption.xml
    • -78
    • +88
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -0
    • +70
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -0
    • +331
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTHWithAdaption.xml
    • -0
    • +6
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
Monday 22 Jul 2019
2:59 pm

Tom The

Improved naming of functions for PL3 and PL4

Related to Issue [MWDAM-1555]

Options
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
Friday 19 Jul 2019
12:05 pm

John Bokma

Whilst investigating this option, came across typo and 2 thing that could easily be fixed when looking at the sonarqube results. So did this whilst waiting for Irene to return her verdict about this issue.

Related to Issue [MWDAM-1554]

Options
    • -7
    • +2
    ./Deltares.DamEngine.Data/Geotechnics/CharacteristicPoint.cs
    • -0
    • +1
    ./Deltares.DamEngine.Data/General/Results/DesignResult.cs
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
Tuesday 16 Jul 2019
11:28 pm

Esther van Zantvoort

Made RequiredSafetyFactorStabilityInnerSlope, RequiredSafetyFactorStabilityOuterSlope, RequiredSafetyFactorPiping, UpliftCriterionStability and UpliftCriterionPiping required in xsd/DamLocation.xsd

Related to Issue [MWDAM-1537]

Options
    • -7
    • +7
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -4
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapper.cs
    • -83
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityOutwards/DamMacroStabilityOutwardsKernelWrapperTests.cs
    • -5
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityOutwards/DamMacroStabilityOutwardsKernelWrapper.cs
    • -4
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamPipingSellmeijerVnk/DamPipingSellmeijerVnkKernelWrapper.cs
    • -10
    • +5
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -4
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamPipingSellmeijer4Forces/DamPipingSellmeijer4ForcesKernelWrapper.cs
    • -4
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
    • -6
    • +6
    ./Deltares.DamEngine.Data/General/ModelFactors.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityCommon/MStabXmlDoc.cs
    • -2
    • +2
    ./Deltares.DamEngine.Data/General/Location.cs
    • -3
    • +0
    ./Deltares.DamEngine.Calculators/Properties/Resources.nl-NL.resx
    • -18
    • +0
    ./Deltares.DamEngine.Calculators/Properties/Resources.Designer.cs
    • -5
    • +5
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -20
    • +5
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
  16. … 5 more files in changeset.
6:34 pm

Esther van Zantvoort

Made PlLineOffsetBelowDikeToeAtPolder, PlLineOffsetBelowDikeTopAtPolder, PlLineOffsetBelowDikeTopAtRiver and PlLineOffsetBelowShoulderBaseInside required in xsd/DamLocation.xsd

Related to Issue [MWDAM-1537]

Options
    • -12
    • +12
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -4
    • +4
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -16
    • +4
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -8
    • +4
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
  6. … 2 more files in changeset.
2:58 pm

John Bokma

Corrected setting DampingFactorPl3 and DampingFactorPl4.

Related to Issue [MWDAM-1533]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -2
    • +2
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs