src

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Incorporated comments CR-DAM55:

- Adjust test name as zones are not longer supported

Related to Issue [MWDAM-1650]

    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
Adapted to review comments + added comment for bishop test + some small improvements to code (typo's and correcting signature for CalculateOneTimeEntry). Finally added PipingFactor to enum as we need that for the next step (piping in DamLive).

Related to Issue [MWDAM-1627]

    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalGrebbedijkTests.cs
    • -2
    • +2
    ./Deltares.DamEngine.Data/General/Dike.cs
    • -8
    • +11
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
Small improvement in check (removed obsolete identical precondition).

Related to Issue [MWDAM-1627]

Replace UpliftVanWti Stability Model Type with UpliftVan Stability Model Type

Related to Issue [MWDAM-1685]

    • -1
    • +0
    ./Deltares.DamEngine.Interface.Tests/FillXmlOutputFromDamTests.cs
    • -6
    • +5
    ./Deltares.DamEngine.Interface.Tests/ConversionHelperTests.cs
    • -1
    • +0
    ./Deltares.DamEngine.Data/General/StabilityEnumerations.cs
    • -11
    • +0
    ./Deltares.DamEngine.Interface/ConversionHelper.cs
Set this test to Wip for now.

Related to Issue [MWDAM-1677]

    • -0
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalGrebbedijkTests.cs
Enabled passing 1D Soil profile UpliftVan tests.

Related to Issue [MWDAM-1650]

    • -11
    • +20
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
Adjusted the SoilGeometryProbability:

- All profiles (regardless of 1D or 2D) are passed as a 2D profile. As such, the ToString() representation needs to be updated to prevent failing tests

Related to Issue [MWDAM-1650]

    • -0
    • +5
    ./Deltares.DamEngine.Data/General/SoilGeometryProbability.cs
    • -0
    • +1
    ./Deltares.DamEngine.Data.Tests/Deltares.DamEngine.Data.Tests.csproj
    • -0
    • +95
    ./Deltares.DamEngine.Data.Tests/General/SoilGeometryProbabilityTest.cs
Fixed Piping in v20 too.

Related to Issue [MWDAM-1677]

    • -2
    • +8
    ./Deltares.DamEngine.Data/General/Dike.cs
    • -12
    • +12
    ./Deltares.DamEngine.IntegrationTests/TestFiles/GrebbedijkStability.xml
    • -7
    • +22
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalGrebbedijkTests.cs
    • -0
    • +8
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculatorTask.cs
    • -1
    • +13
    ./Deltares.DamEngine.Interface/EngineInterface.cs
Updated input file for TestRunMacroStabilityTutorialDesignUpliftVan

Related to Issue [MWDAM-1650]

    • -231
    • +616
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile.xml
Updated test TestRunMacroStabilityWithErrorUpliftVan to make it green:

- Adjusted safety factors

- Adjusted naming of the result 2D soil profile (1D soil profile + surfaceline)

Related to Issue [MWDAM-1650]

    • -9
    • +9
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
Updated input file for TestRunMacroStabilityDeltaDijkZoneAreasUpliftVanWith1D

Related to Issue [MWDAM-1650]

    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DeltaDijkZoneringInwards.xml
Cleanup:

- Extracted function for retrieving the enclosed areas.

Related to Issue [MWDAM-1683]

    • -23
    • +31
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
Fixed edge case:

- Updated XMLDocs and function argument types to prevent modification to collections

-- Changed a ToList to an ToArray call to prevent modifications

Related to Issue [MWDAM-1683]

Fixed edge case:

- Updated XMLDocs and function argument types to prevent modification to collections

- Added a filter on the layerdata --> the layer data sometimes generates a surface consisting of two curves (which simply cannot represent a surface, because at least 3 curves are necessary). This behavior becomes relevant when running TestRunMacroStabilityWithErrorUpliftVan

Related to Issue [MWDAM-1683]

    • -10
    • +20
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
Fixed edge case:

- Refactored solution: pass a local surface line geometry to prevent rounding off errors from properly recognising the surfaces

Related to Issue [MWDAM-1683]

    • -42
    • +47
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
Fixed edge case:

- Fixed test

Related to Issue [MWDAM-1683]

Fixed edge case:

- Added case to deal with horizontal intersections or when the ZCoordinate has rounding errors at intersections

Related to Issue [MWDAM-1683]

    • -0
    • +85
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
    • -11
    • +35
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
Rename function to reflect its functionality

Merged from 19.2 branch

Related to Issue [MWDAM-1579]

Cleanup:

- Updated XMLDocs and function calls

Related to Issue [MWDAM-1683]

    • -9
    • +25
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
Cleanup:

- Refactored: extracted a function to generate closed outer loop based on coordinates

Related to Issue [MWDAM-1683]

    • -15
    • +13
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
Cleanup:

- Reordered functions for clarity

Related to Issue [MWDAM-1683]

    • -124
    • +123
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
Cleanup:

- Removed obsolete code

Related to Issue [MWDAM-1683]

    • -220
    • +0
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
Improved algorithm for the generation of surfaces:

- Added test to verify that the soil properties are correctly set after generating

Related to Issue [MWDAM-1683]

    • -2
    • +14
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
    • -21
    • +62
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
Improved algorithm for the generation of surfaces:

- Added test with a horizontal intersection with the bottom level of a layer

Related to Issue [MWDAM-1683]

    • -0
    • +96
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
Removed WIP categories from unit tests

Related to Issue [MWDAM-1683]

    • -3
    • +1
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
Improved algorithm for the generation of surfaces:

- Adjustments made when the intersection inflects at the bottom level of a layer

Related to Issue [MWDAM-1683]

    • -0
    • +191
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs
    • -7
    • +29
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
Adapted to fix tests.

Related to Issue [MWDAM-1579]

    • -8
    • +21
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
Synchronize Location data with Design Scenario data

Merge from 19.2 branch

Related to Issue [MWDAM-1579]

    • -15
    • +37
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
    • -0
    • +9
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculatorTask.cs
Fixed failing unit test:

- Corrected algorithm, because apparently it is possible to get an enclosed area without coordinates ---> corrected filtering

- Adjusted resulting safety factor.

Related to Issue [MWDAM-1683]

Improved algorithm for the generation of surfaces:

- Added testcase where a layer is fully above the surface line (no intersections)

Related to Issue [MWDAM-1683]

    • -3
    • +70
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilSurfaceProfileTests.cs