DAM / DamEngine / trunk

src

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 17 Dec
Commits this week: 0
Total Lines of Code (LoC): 147,819
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 13 Dec 2022
3:57 pm

Walter Austmann

Add App.config for test projects

Related to Issue [MWDAM-1857]

Options
    • -0
    • +10
    ./Deltares.DamEngine.Data.Tests/App.config
    • -0
    • +10
    ./Deltares.DamEngine.Calculators.Tests/App.config
    • -0
    • +10
    ./Deltares.DamEngine.IntegrationTests/App.config
    • -0
    • +10
    ./Deltares.DamEngine.Interface.Tests/App.config
3:10 pm

Walter Austmann

Add missing packages.config files

Related to Issue [MWDAM-1857]

Options
    • -0
    • +4
    ./Deltares.DamEngine.Calculators.Tests/packages.config
    • -0
    • +4
    ./Deltares.DamEngine.IntegrationTests/packages.config
    • -0
    • +4
    ./Deltares.DamEngine.Data.Tests/packages.config
3:10 pm

John Bokma

Solved problems with multicore caused by static uplift helpers. Making these "dynamic" solves them.

Related to Issue [MWDAM-1852]

Options
    • -4
    • +6
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/UpliftHelperTests.cs
    • -1
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -2
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -4
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/UpliftHelper.cs
3:08 pm

Walter Austmann

Fix some failing unit tests

Related to Issue [MWDAM-1857]

Options
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/Uplift/UpliftCalculatorTest.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapperTests.cs
3:08 pm

Walter Austmann

Resolve NUnit warnings

Related to Issue [MWDAM-1857]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingSellmeijer4Forces/DamPipingSellmeijer4ForcesKernelWrapperTests.cs
2:48 pm

Walter Austmann

Resolve NUnit warnings

Related to Issue [MWDAM-1857]

Options
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/PipingBlighTests.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingSellmeijerVnk/DamPipingSellmeijerVnkKernelWrapperTests.cs
    • -15
    • +15
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapperTests.cs
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/PipingSellmeijer4ForcesTests.cs
    • -3
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapperTests.cs
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/PipingSellmeijerVnkTests.cs
2:37 pm

Walter Austmann

Update to NUnit 3.13.3

Related to Issue [MWDAM-1857]

Options
    • -3
    • +1
    ./Deltares.DamEngine.Calculators.Tests/DikesDesign/SurfaceLineHeightAdapterTest.cs
    • -1
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalPulauTekongTests.cs
    • too large
    ./Deltares.DamEngine.Calculators.Tests/DikesDesign/SurfaceLineShoulderAdapterTest.cs
    • -8
    • +4
    ./Deltares.DamEngine.Calculators.Tests/Uplift/SoilVolumeMassCalculatorEffectiveStressTest.cs
    • -0
    • +1
    ./Deltares.DamEngine.Io.Tests/packages.config
    • -11
    • +7
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingSellmeijer4Forces/DamPipingSellmeijer4ForcesKernelWrapperTests.cs
    • -2
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalGrebbedijkTests.cs
    • -2
    • +11
    ./Deltares.DamEngine.Calculators.Tests/Deltares.DamEngine.Calculators.Tests.csproj
    • -2
    • +1
    ./Deltares.DamEngine.Interface.Tests/FillDamFromXmlInputTests.cs
    • -2
    • +1
    ./Deltares.DamEngine.Interface.Tests/EngineInterfaceTests.cs
    • -11
    • +6
    ./Deltares.DamEngine.Calculators.Tests/DikesDesign/SurfaceLineAdapterTest.cs
    • -6
    • +3
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/ConversionHelperTests.cs
    • -17
    • +19
    ./Deltares.DamEngine.Calculators.Tests/Uplift/SoilVolumeMassCalculatorTest.cs
    • -9
    • +5
    ./Deltares.DamEngine.Calculators.Tests/Uplift/UpliftLocationDeterminatorTest.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorTest.cs
  16. … 21 more files in changeset.
12:00 pm

Walter Austmann

Replace MacrostabilityCSharpWrapper with signed Deterministic MacrostabilityCSharpWrapper

Related to Issue [MWDAM-1854]

Options
    • -14
    • +2
    ./Deltares.DamEngine.Calculators.Tests/Deltares.DamEngine.Calculators.Tests.csproj
    • -13
    • +2
    ./Deltares.DamEngine.Calculators/Deltares.DamEngine.Calculators.csproj
  3. … 33 more files in changeset.
Monday 12 Dec 2022
6:26 pm

John Bokma

Solved the vulnerability and some code smwlls as reported by SonarQube.

Related to Issue [MWDAM-1852]

Options
    • -64
    • +101
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -1
    • +4
    ./Deltares.DamEngine.Data/Standard/ObjectExtensions.cs
9:03 am

Walter Austmann

Use Any instead of Count >0

Related to Issue [MWDAM-1856]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/DtoHelperServices.cs
Friday 09 Dec 2022
11:28 am

Walter Austmann

Remove this formatting call and simply use the input string

Related to Issue [MWDAM-1856]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
11:03 am

Walter Austmann

Replace System.NullReferenceException by ArgumentNullException

Related to Issue [MWDAM-1856]

Options
    • -7
    • +7
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -9
    • +9
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
10:25 am

Walter Austmann

Remove useless assignment

Related to Issue [MWDAM-1856]

Options
    • -2
    • +1
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
10:12 am

Walter Austmann

Remove number of parameters

Related to Issue [MWDAM-1856]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Data/Geometry/GeometryData.cs
    • -83
    • +49
    ./Deltares.DamEngine.Data/Geometry/Routines2D.cs
    • -2
    • +2
    ./Deltares.DamEngine.Data/Geometry/LineHelper.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geometry/GeometryCurve.cs
    • -5
    • +5
    ./Deltares.DamEngine.Data/Geotechnics/LayerDetector.cs
9:11 am

Walter Austmann

Use count property

Related to Issue [MWDAM-1856]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SensorPlLineCreatorBase.cs
8:59 am

Walter Austmann

Remove unnecessary cast

Related to Issue [MWDAM-1856]

Options
    • -35
    • +29
    ./Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/DtoPropertyAttributeMap.cs
8:58 am

Walter Austmann

Rename parameters to match base class or interface declaration

Related to Issue [MWDAM-1856]

Options
    • -7
    • +7
    ./Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/Geometry2DSectionAssembler.cs
    • -32
    • +32
    ./Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/DtoDocumentAssembler.cs
    • -8
    • +8
    ./Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/IDtoAssembler.cs
8:56 am

Walter Austmann

Remove redundant jump

Related to Issue [MWDAM-1856]

Options
    • -3
    • +2
    ./Deltares.DamEngine.Calculators/General/Parallel.cs
8:35 am

Walter Austmann

Remove unused setter

Related to Issue [MWDAM-1856]

Options
    • -20
    • +6
    ./Deltares.DamEngine.Data/Geotechnics/SoilLayer2D.cs
Thursday 08 Dec 2022
5:20 pm

Walter Austmann

Remove unused private method in release mode

Related to Issue [MWDAM-1856]

Options
    • -0
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
4:52 pm

Walter Austmann

Remove unused private methods

Related to Issue [MWDAM-1856]

Options
    • -5
    • +0
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
    • -19
    • +0
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SensorPlLine1Creator.cs
4:45 pm

Walter Austmann

Remove the unnecessary Boolean literal(s)

Related to Issue [MWDAM-1856]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -3
    • +3
    ./Deltares.DamEngine.Data/Geometry/Routines2D.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Standard/ObjectCopier.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -6
    • +6
    ./Deltares.DamEngine.Data/Geometry/GeometryGenerator.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geometry/GeometryData.cs
    • -7
    • +7
    ./Deltares.DamEngine.Data/Geotechnics/LayerDetector.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geometry/GeometrySurface.cs
4:30 pm

Walter Austmann

Short-circuit logic should be used in boolean contexts

Related to Issue [MWDAM-1856]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Data/Standard/ObjectCopier.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geometry/GeometryPointString.cs
4:27 pm

Walter Austmann

Remove unused directives

Related to Issue [MWDAM-1856]

Options
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/TestHelpers/DamEngineDataTestFactory.cs
    • -5
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamPipingSellmeijerVnk/DamPipingSellmeijerVnkOutput.cs
    • -3
    • +0
    ./Deltares.DamEngine.Data/Standard/ThrowHelper.cs
    • -1
    • +0
    ./Deltares.DamEngine.TestHelpers/XmlAdapter.cs
    • -5
    • +0
    ./Deltares.DamEngine.Data/General/Sensors/SensorFactory.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/Interfaces/IKernelWrapper.cs
    • -1
    • +0
    ./Deltares.DamEngine.Io/IdValidator.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineHeightAdapter.cs
    • -6
    • +0
    ./Deltares.DamEngine.Data/General/Physics.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapperTests.cs
    • -1
    • +0
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile1DAquiferLayerCombiner.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/DamPipingHelperTests.cs
    • -1
    • +0
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile1DAquiferLayerCombinerTests.cs
  16. … 8 more files in changeset.
4:16 pm

Walter Austmann

Create UpliftSituation for output parameter

Related to Issue [MWDAM-1856]

Options
    • -14
    • +21
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/PlLinesHelper.cs
4:14 pm

Walter Austmann

Use getters and setters for properties

Related to Issue [MWDAM-1856]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityOutputItem.cs
    • -3
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/DamKernelInput.cs
    • -7
    • +7
    ./Deltares.DamEngine.Data/General/UpliftSituation.cs
    • -2
    • +2
    ./Deltares.DamEngine.Data/Geometry/Point2D.cs
    • -7
    • +7
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineAdapter.cs
    • -3
    • +3
    ./Deltares.DamEngine.Data/Geometry/Routines2D.cs
    • -1
    • +1
    ./Deltares.DamEngine.Data/General/Sensors/SensorPlLineCreatorSettings.cs
    • -3
    • +3
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile1DAquiferLayerCombiner.cs
2:45 pm

John Bokma

Solved the bugs in SonarQube. Note that 2 (of the 10) reported bugs were actually false negatives as assessed by me and reviewed by Tom who closed these two bugs.

Related to Issue [MWDAM-1852]

Options
    • -20
    • +8
    ./Deltares.DamEngine.Data/Standard/ListExtension.cs
    • -0
    • +1754
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -8
    • +7
    ./Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
    • -2
    • +1
    ./Deltares.DamEngine.Data/Geometry/GeometryLoop.cs
    • -1
    • +0
    ./Deltares.DamEngine.Data/Geotechnics/LayerDetector.cs
Monday 05 Dec 2022
12:04 pm

John Bokma

Update the code for the new library of the Macrostability C#-wrapper.

Related to Issue [MWDAM-1848]

Options
    • -3
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillEngineFromMacroStabilityWrapperInput.cs
    • -3
    • +4
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityWrapperInputFromEngine.cs
Friday 07 Oct 2022
3:27 pm

John Bokma

Adapted to review comments.

Related to Issue [MWDAM-1792]

Options
    • -2
    • +148
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
    • -145
    • +37
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -114
    • +8
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
Wednesday 05 Oct 2022
3:26 pm

John Bokma

Adaapted to review comments.

Related to Issue [MWDAM-1842]

Options
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -3
    • +3
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2D.cs
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/DebuggingTest.cs