src

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix Adapt geometry optimized slope and shoulder adjustment

Related to Issue [MWDAM-2474]

    • -4
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorFirstSlopeAdaptionThenShoulderAdaption.cs
    • -23
    • +28
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
Clean-up in MStabParameters.cs : obsolete parameters removed

Related to Issue [MWDAM-2565]

    • -17
    • +0
    ./Deltares.DamEngine.Data/General/FailureMechanismParametersMStab.cs
    • -178
    • +2
    ./Deltares.DamEngine.Data/General/MStabParameters.cs
Clean-up in MStabParameters.cs : obsolete parameters removed

Related to Issue [MWDAM-2565]

    • -69
    • +1
    ./Deltares.DamEngine.Data/General/MStabParameters.cs
    • -16
    • +0
    ./Deltares.DamEngine.Interface.Tests/ConversionHelperTests.cs
    • -24
    • +1
    ./Deltares.DamEngine.Data/General/StabilityEnumerations.cs
    • -2
    • +0
    ./Deltares.DamEngine.Data/General/Dike.cs
    • -49
    • +1
    ./Deltares.DamEngine.Interface/ConversionHelper.cs
Current results are accepted.

Related to Issue [MWDAM-2663]

    • -2
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalMultiCoreTests.cs
Fix sonarcloud: Added assertion

Related to Issue [MWDAM-2674]

    • -1
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
    • -1
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalMultiCoreTests.cs
Issue tests extended with new problems for DWPs 6, 7 and 20

Related to Issue [MWDAM-2690]

Interim commit.

Related to Issue [MWDAM-2648]

    • -0
    • +321
    ./Deltares.DamEngine.Data.Tests/Geometry/GeometryGeneratorTests.cs
    • -45
    • +23
    ./Deltares.DamEngine.Data/Geometry/GeometryGenerator.cs
Adapted to review

Related to Issue [MWDAM-2643]

    • -6
    • +7
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineAdapter.cs
    • -2
    • +3
    ./Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
Fix sonarcloud: Remove TextFixture

Related to Issue [MWDAM-2674]

    • -7
    • +0
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
    • -3
    • +0
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalMultiCoreTests.cs
Reverted revision(s) 5774 from :

Fix sonarcloud Reliability issue: Use a comparison to 'default(TDomainObject)' instead or add a constraint to 'TDomainObject' so that it can't be a value type.

Related to Issue [MWDAM-2643]

........

I corrected the input file so it now contains an inner loop with IsAquifer = true whilst its outer loops are aquitards.

Related to Issue [MWDAM-2462]

Corrected result for change in accuracy of coordinates.

Related to Issue [MWDAM-2400]

    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
Fix sonarcloud Reliability issue: Use a comparison to 'default(TDomainObject)' instead or add a constraint to 'TDomainObject' so that it can't be a value type.

Related to Issue [MWDAM-2643]

Fix sonarcloud Reliability issues: Do not check floating point equality with exact values, use a range instead

Related to Issue [MWDAM-2643]

    • -1
    • +3
    ./Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -3
    • +4
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineAdapter.cs
Adapted to review comment by Tom. Also contains the fix for review comment on Issue [MWDAM-2400] by Virginie.

Related to Issue [MWDAM-2258]

    • -36
    • +31
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs
Adapted to review: obsolete parameter IsTangentLinesAutomatic for Bishop removed

Related to Issue [MWDAM-2665]

Failing tests for shift geometry solved (when calling ReconstructSurfaces the surface line of the original soil profile had no points)

Related to Issue [MWDAM-2677]

    • -2
    • +1
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
    • -8
    • +9
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs
    • -27
    • +28
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
Removed properties from Location that are duplicated in DesignScenario

Related to Issue [MWDAM-2649]

    • -1
    • +0
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -3
    • +4
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalStabilityProfile1DTests.cs
    • -4
    • +4
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -4
    • +4
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorLocationTests.cs
    • -24
    • +0
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -0
    • +1
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
    • binary
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Operational/Profile1DTests/CalculateStabilityInsideBishopGrid1_UseLocationDataOutputFile.xml
    • -6
    • +6
    ./Deltares.DamEngine.TestHelpers/GeneralHelper.cs
Add tests for multicore that do not run with 1 core first, only check on errors and expected number of results.

Related to Issue [MWDAM-2674]

    • -22
    • +71
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
    • -12
    • +51
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalMultiCoreTests.cs
Failing tests temporary moved to WIP

Related to Issue [MWDAM-2677]

    • -1
    • +2
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
Shift temporary set to 0 because implementation is not correct

Related to Issue [MWDAM-2677]

    • -0
    • +4
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs
Commit 5760 partly reverted: Z coord. of point should be modified

Related to Issue [MWDAM-2677]

Input of test updated to not use the shift of the geometry

Related to Issue [MWDAM-2677]

Adapted to review

Related to Issue [MWDAM-2627]

    • -3
    • +24
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalStabilityProfile1DTests.cs
Unit tests including shift of the geometry are extended to highlight new bug

Related to Issue [MWDAM-2677]

    • -9
    • +9
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
    • -43
    • +37
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
TC agents have 8 cores

Related to Issue [MWDAM-2668]

    • -4
    • +4
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
Mention maxCores and processorCount in assertion.

Related to Issue [MWDAM-2668]

    • -1
    • +1
    ./Deltares.DamEngine.TestHelpers/GeneralHelper.cs
Ignore the test when maxCores is larger than processorCount.

Related to Issue [MWDAM-2668]

    • -0
    • +5
    ./Deltares.DamEngine.TestHelpers/GeneralHelper.cs
Limit cores in tests to relevant combinations.

Run all with 4 cores and at least another with less than 12 cores.

Related to Issue [MWDAM-2668]

    • -9
    • +9
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityTests.cs
    • -3
    • +4
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalMultiCoreTests.cs
The shift of the geometry compared to the surface line is implemented and tested.

Related to Issue [MWDAM-2677]

    • -1
    • +1
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
    • -4
    • +39
    ./Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
    • -9
    • +9
    ./Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs