Riskeer / Application

Ringtoets

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 23 May 2018
1:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824: - Renamed DuneLocationOutput to DuneLocationCalculationOutput -- Adjusted CreateExtension file names -- Updated function and parameter names where necessary.

WTI-1574

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +58
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensions.cs
    • -2
    • +2
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCreateExtensions.cs
    • -58
    • +0
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationOutputCreateExtensions.cs
    • -6
    • +6
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationOutputEntityReadExtensions.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +110
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensionsTest.cs
    • -14
    • +14
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCreateExtensionsTest.cs
    • -110
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationOutputCreateExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationEntityReadExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationOutputEntityReadExtensionsTest.cs
    • -13
    • +13
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  14. … 31 more files in changeset.
Tuesday 15 May 2018
11:34 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2811: - Updated XMLDocs - Updated test names - Replaced type casts to byte with Convert.ToByte() calls - Formatting of the migration script

WTI-1706

Options
    • -16
    • +16
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationCreateExtensions.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationCreateExtensionsTest.cs
    • -44
    • +34
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
Monday 14 May 2018
4:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated migration script to fix failing tests: - Updated target values for the Category types --> indices changed from 0 to 1 based

WTI-1706

Options
    • -6
    • +6
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
3:42 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated migration script: - Cleaned up migration integration test: merged separate grass cover erosion outwards assert into the query generator.

WTI-1706

Options
    • -276
    • +254
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
3:09 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated migration script: - Generated initial setup and tests for the migration

WTI-1706

Options
    • -8
    • +112
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -5
    • +241
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
12:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated test files: - Generated empty 181 file with the new CategoryTypeColumns - Updated the 173 testfile to have wave conditions calculations with different norms

WTI-1706

Options
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject173.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject181.rtd
10:50 am

Dennis Tang <dennis.tang@deltares.nl>

Updated test TestHelper: - Initialised CategoryType values with non-default values for the wave conditions inputs

WTI-1706

Options
    • -6
    • +12
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
10:34 am

Dennis Tang <dennis.tang@deltares.nl>

Updated test files for ReadExtensions of the WaveConditionsCalculations: - Added asserts to verify the reference dependent output remains null when the entity has null values

WTI-1706

Options
    • -0
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationEntityReadExtensionsTest.cs
    • -0
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
    • -0
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
10:30 am

Dennis Tang <dennis.tang@deltares.nl>

Updated ReadExtensions for StabilityStoneCover: -- Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions -- Added functionality to read CategoryType

WTI-1706

Options
    • -2
    • +11
    ./src/Application.Ringtoets.Storage/Read/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationEntityReadExtensions.cs
    • -74
    • +69
    ./test/Application.Ringtoets.Storage.Test/Read/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
10:21 am

Dennis Tang <dennis.tang@deltares.nl>

(Editorial): - Removed whiteline from test file for wave impact asphalt cover

WTI-1706

Options
    • -1
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationCreateExtensionsTest.cs
10:20 am

Dennis Tang <dennis.tang@deltares.nl>

Updated CreateExtensions for StabilityStoneCover: -- Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions -- Added functionality to write CategoryType to entity

WTI-1706

Options
    • -17
    • +25
    ./src/Application.Ringtoets.Storage/Create/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationCreateExtensions.cs
    • -58
    • +69
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationCreateExtensionsTest.cs
10:04 am

Dennis Tang <dennis.tang@deltares.nl>

Updated ReadExtensions for WaveImpactAsphaltCover: -- Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions -- Added functionality to read CategoryType

WTI-1706

Options
    • -3
    • +13
    ./src/Application.Ringtoets.Storage/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationEntityReadExtensions.cs
    • -74
    • +69
    ./test/Application.Ringtoets.Storage.Test/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
9:38 am

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up GrassCoverErosionOutwards Calculation CreateExtensions -- Refactored private method -- Adjusted test

WTI-1706

Options
    • -17
    • +18
    ./src/Application.Ringtoets.Storage/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensions.cs
    • -2
    • +3
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensionsTest.cs
9:36 am

Dennis Tang <dennis.tang@deltares.nl>

Updated CreateExtensions for WaveImpactAsphaltCover: -- Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions -- Added functionality to write CategoryType to entity

WTI-1706

Options
    • -17
    • +26
    ./src/Application.Ringtoets.Storage/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationCreateExtensions.cs
    • -55
    • +65
    ./test/Application.Ringtoets.Storage.Test/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationCreateExtensionsTest.cs
9:04 am

Dennis Tang <dennis.tang@deltares.nl>

Merge branch 'master' into Storage

# Conflicts:

# Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql

# build/DatabaseStructure.sql

# design/DatabaseDesign.eap

Options
    • -4
    • +4
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
  2. … 2 more files in changeset.
8:58 am

Dennis Tang <dennis.tang@deltares.nl>

Updated ReadExtensions for GrassCoverErosionOutwards: - Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions - Added functionality to Read CategoryType

WTI-1706

Options
    • -7
    • +19
    ./src/Application.Ringtoets.Storage/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationEntityReadExtensions.cs
    • -74
    • +69
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationEntityReadExtensionsTest.cs
Friday 11 May 2018
10:48 am

Carlos Lubbers

Update db structure sql files WTI-1693

Options
    • -5
    • +5
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
  2. … 1 more file in changeset.
9:44 am

Carlos Lubbers

Update storage tests and extensions with new enum WTI-1693

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneErosionSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/StabilityStoneCover/StabilityStoneCoverSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverSectionResultEntityReadExtensions.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneErosionFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityStoneCover/StabilityStoneCoverFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverFailureMechanismSectionResultCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneErosionSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/StabilityStoneCover/StabilityStoneCoverSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverSectionResultEntityReadExtensionsTest.cs
    • -4
    • +4
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
Wednesday 09 May 2018
4:16 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated CreateExtensions for GrassCoverErosionOutwards: - Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions - Added functionality to write CategoryType

WTI-1706

Options
    • -7
    • +13
    ./src/Application.Ringtoets.Storage/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensions.cs
    • -55
    • +62
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensionsTest.cs
3:23 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated database design to include columns related to the category type: - Regenerated .sql file and corresponding Ringtoets.rtd - Regenerated entities

WTI-1706

Options
    • -1
    • +4
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
    • -0
    • +1
    ./src/Application.Ringtoets.Storage/DbContext/GrassCoverErosionOutwardsWaveConditionsCalculationEntity.cs
    • -0
    • +9
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx
    • -89
    • +89
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram
    • -0
    • +1
    ./src/Application.Ringtoets.Storage/DbContext/StabilityStoneCoverWaveConditionsCalculationEntity.cs
    • -0
    • +1
    ./src/Application.Ringtoets.Storage/DbContext/WaveImpactAsphaltCoverWaveConditionsCalculationEntity.cs
    • binary
    ./src/Application.Ringtoets.Storage/Ringtoets.rtd
  8. … 1 more file in changeset.
Thursday 26 Apr 2018
1:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2751: - Fixed typo

Paired with ~kleijn

WTI-1657

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
1:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2748: - Updated MigrationScript to JOIN on the lookup table - Editiorial changes

WTI-1657

Options
    • -11
    • +12
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
10:22 am

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up test projects: - Renamed FullTestProjects to MigrationTestProjects, as they do not represent a full project that is configured with all options.

WTI-1657

Options
    • -2
    • +2
    ./test/Application.Ringtoets.Migration.Core.Test/RingtoetsVersionedFileTest.cs
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject164.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject171.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject172.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject164.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject171.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject172.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject173.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject181.rtd
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo171IntegrationTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo172IntegrationTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo173IntegrationTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
  16. … 3 more files in changeset.
10:08 am

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up test projects: - Test projects should only contain the information that is necessary to prove that relevant migration items for that version was performed. Due to chaining it is not necessary to repeat this validation for subsequent projects

WTI-1657

Options
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject172.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
Wednesday 25 Apr 2018
4:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration for the grass cover erosion outwards (GCEO) wave condition calculations: - Translated the old GCEO hydraulic boundary location (HBL) PKs to the new HBL PKs on assessment section based on the LocationID of a HBL and its corresponding assessment section. -- Introduced a lookup table, as these translations happen on multiple spots - Adjusted test project to prove the translations are made correctly

WTI-1657

Options
    • -26
    • +61
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
    • -0
    • +54
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
2:21 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2745: - Applied editorial comments

WTI-1657

Options
    • -2
    • +2
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
9:10 am

Elmar Kleijn

Applied some final renames. WTI-1698

Options
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationCalculationEntityReadExtensionsTest.cs
  2. … 4 more files in changeset.
Monday 23 Apr 2018
4:28 pm

Elmar Kleijn

Renamed HydraulicBoundaryLocationOutput into HydraulicBoundaryLocationCalculationOutput. WTI-1698

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +60
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationCalculationOutputCreateExtensions.cs
    • -60
    • +0
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationOutputCreateExtensions.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +151
    ./test/Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationCalculationOutputCreateExtensionsTest.cs
    • -151
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationOutputCreateExtensionsTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationOutputEntityReadExtensionsTest.cs
4:13 pm

Elmar Kleijn

Renamed HydraulicBoundaryLocationOutput into HydraulicBoundaryLocationCalculationOutput. WTI-1698

Options
    • -3
    • +3
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationCalculationCreateExtensions.cs
    • -3
    • +3
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationOutputCreateExtensions.cs
    • -12
    • +12
    ./src/Application.Ringtoets.Storage/Read/HydraulicLocationOutputEntityReadExtensions.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationCalculationCreateExtensionsTest.cs
    • -7
    • +7
    ./test/Application.Ringtoets.Storage.Test/Create/HydraulicBoundaryLocationOutputCreateExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationCalculationEntityReadExtensionsTest.cs
    • -3
    • +3
    ./test/Application.Ringtoets.Storage.Test/Read/HydraulicLocationOutputEntityReadExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -6
    • +6
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  11. … 79 more files in changeset.
1:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted JOINS on the sourceproject for the Hydraulic Boundary Location of Grass Cover Erosion Outwards: - Do not join on the PK of the HBL entries, because these can be different between grass outwards and the hbls on assessment section level, instead join on the LocationID and the containing assessment section -- Adjusted migration logic for the outputs -- Adjusted migration logic for the HBL entries of grass cover erosion outwards --> take the HydraulicLocationEntityId as leading PK - Adjusted test files to represent the following scenarios situation: -- An HBL on the grass cover erosion failure mechanism that has a PK corresponding with a HBL that is not in the same assessment section -- Two HBLs on the grass cover erosion failure mechanism in the same assessment section that differs from the PKs of the HBLs on the assessment section

WTI-1657

Options
    • -15
    • +34
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
    • -4
    • +22
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs