Riskeer / Application

Ringtoets

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 30 May 2018
11:28 am

Dennis Tang <dennis.tang@deltares.nl>

Implement Create and Read Extensions: - Implement create extension methods for the DuneLocationCalculation

WTI-1654

Options
    • -0
    • +1
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +70
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationCreateExtensions.cs
    • -0
    • +1
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +145
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationCreateExtensionsTest.cs
11:05 am

Dennis Tang <dennis.tang@deltares.nl>

Adapt Create and Read Extensions: - Modified extension methods for the DuneLocationOutput --> Cleaned up files, implemented missing NULL check - Adjusted implementation of the Hydraulic Boundary Location Output create extensions --> replaced cast to byte with a convert according to our own guidelines

WTI-1654

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationCalculationOutputCreateExtensions.cs
    • -0
    • +7
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationOutputEntityReadExtensions.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensionsTest.cs
    • -1
    • +11
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationOutputEntityReadExtensionsTest.cs
10:58 am

Dennis Tang <dennis.tang@deltares.nl>

Adapt Create and Read Extensions: - Modified extension methods for the DuneLocation --> it has no reference to an output anymore

WTI-1654

Options
    • -11
    • +6
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCreateExtensions.cs
    • -7
    • +0
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationEntityReadExtensions.cs
    • -55
    • +11
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCreateExtensionsTest.cs
    • -63
    • +0
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationEntityReadExtensionsTest.cs
10:45 am

Dennis Tang <dennis.tang@deltares.nl>

Modified database design: - Regenerated database entities

WTI-1654

Options
    • -0
    • +6
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +10
    ./src/Application.Ringtoets.Storage/DbContext/DuneErosionFailureMechanismMetaEntity.cs
    • -0
    • +69
    ./src/Application.Ringtoets.Storage/DbContext/DuneLocationCalculationCollectionEntity.cs
    • -0
    • +54
    ./src/Application.Ringtoets.Storage/DbContext/DuneLocationCalculationEntity.cs
    • -4
    • +4
    ./src/Application.Ringtoets.Storage/DbContext/DuneLocationEntity.cs
    • -2
    • +2
    ./src/Application.Ringtoets.Storage/DbContext/DuneLocationOutputEntity.cs
    • -0
    • +2
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.Context.cs
    • -24
    • +325
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx
    • -90
    • +99
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram
    • binary
    ./src/Application.Ringtoets.Storage/Ringtoets.rtd
10:38 am

Dennis Tang <dennis.tang@deltares.nl>

Modified database design: - Regenerated SQL files based on the new design

WTI-1654

Options
    • -5
    • +79
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
  2. … 1 more file in changeset.
Friday 25 May 2018
1:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2843: - Rewrote functions - Cleaned up tests - Adjusted DuneErosionFailureMechanism: -- Moved instantiation of the list to class level -- Renamed private field to prevent shadowing

WTI-1574

Options
    • -8
    • +8
    ./src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -4
    • +7
    ./test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
  3. … 4 more files in changeset.
1:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2839: - Performed Resharper cleanup - Renamed test

WTI-1574

Options
    • -0
    • +1
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensions.cs
  2. … 4 more files in changeset.
10:31 am

Dennis Tang <dennis.tang@deltares.nl>

Merge from SVN WTI-1710: Updated version number from 17.3.1 to 17.3.2

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Setup/Application.Ringtoets.Setup.wixproj
  2. … 2 more files in changeset.
Thursday 24 May 2018
3:18 pm

Carlos Lubbers

Merge from SVN WTI-1710: - Added Migration related files: -- Added initial setup of the migration integration test from 172 --> 173

Options
    • -11
    • +1
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo173IntegrationTest.cs
1:39 pm

Carlos Lubbers

Merge from SVN WTI-1710: Updated user manual.

AND

Added new version of user manual (without revision number).

Options
    • binary
    ./src/Application.Ringtoets.Setup/Gebruikershandleiding Ringtoets 17.2.2.pdf
    • binary
    ./src/Application.Ringtoets.Setup/Gebruikershandleiding Ringtoets 17.3.1.pdf
    • -2
    • +2
    ./src/Application.Ringtoets.Setup/Product.wxs
    • -1
    • +1
    ./src/Application.Ringtoets/App.xaml.cs
1:39 pm

Carlos Lubbers

Merge from SVN WTI-1710: Updated user manual.

AND

Added new version of user manual (without revision number).

Options
    • binary
    ./src/Application.Ringtoets.Setup/Gebruikershandleiding Ringtoets 17.2.1.pdf
    • binary
    ./src/Application.Ringtoets.Setup/Gebruikershandleiding Ringtoets 17.3.1.pdf
    • -2
    • +2
    ./src/Application.Ringtoets.Setup/Product.wxs
    • -1
    • +1
    ./src/Application.Ringtoets/App.xaml.cs
1:34 pm

Carlos Lubbers

Merge from SVN WTI-1710: Changed migration script: - Remove all output related to macrostability inwards calculations -- Generate log message when applicable

Options
    • -2
    • +29
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.2_17.3.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject172.rtd
    • -3
    • +16
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo173IntegrationTest.cs
1:34 pm

Carlos Lubbers

Merge from SVN WTI-1710: Changed migration script: - Remove all output related to macrostability inwards calculations -- Generate log message when applicable

Options
    • -2
    • +29
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.2_17.3.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject172.rtd
    • -3
    • +16
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo173IntegrationTest.cs
1:24 pm

Carlos Lubbers

Merge from SVN WTI-1710: Fixed buildserver tests: - Added log message for the verification of chain migration - Changed 17.2 to supported migration file, 17.3 as unsupported

Options
    • -2
    • +3
    ./test/Application.Ringtoets.Migration.Core.Test/RingtoetsSqLiteDatabaseFileMigratorTest.cs
    • -1
    • +6
    ./test/Application.Ringtoets.Migration.Test/RingtoetsProjectMigratorTest.cs
1:23 pm

Carlos Lubbers

Merge from SVN WTI-1710: Fix tests that break on Windows 10. Patched in from git commit 1988601, 01c3d95 and 12c1632

Options
    • -0
    • +1
    ./test/Application.Ringtoets.Migration.Console.Test/RingtoetsMigrationConsoleTest.cs
    • -0
    • +1
    ./test/Application.Ringtoets.Migration.Console.Test/RingtoetsMigrationToolTest.cs
    • -48
    • +11
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationIntegrationTest.cs
  4. … 2 more files in changeset.
1:21 pm

Carlos Lubbers

Merge from SVN WTI-1710: - Added Migration related files: -- Fixed buildserver test: added FullTestProject173.rtd

Options
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject173.rtd
1:19 pm

Carlos Lubbers

Merge from SVN WTI-1710: - Added Migration related files: -- Added initial setup of the migration integration test from 172 --> 173

Options
    • -0
    • +1
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +353
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo173IntegrationTest.cs
1:17 pm

Carlos Lubbers

Merge from SVN WTI-1710: - Updated version number from 17.2 --> 17.3 - Added Migration related files: -- Added empty file of FullTestProject17.3 -- Added empty migration script -- Added copy of DatabaseStructure17.3 which is identical to 17.2 (no DB changes were necessary for this release)

Options
    • -0
    • +6
    ./src/Application.Ringtoets.Migration.Core/Application.Ringtoets.Migration.Core.csproj
    • -0
    • +2615
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure17.3.sql
    • -0
    • +151
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.2_17.3.sql
    • -1
    • +1
    ./src/Application.Ringtoets.Setup/Application.Ringtoets.Setup.wixproj
    • -2
    • +3
    ./test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectMigrationTestHelperTest.cs
    • -0
    • +1
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectMigrationTestHelper.cs
  7. … 3 more files in changeset.
1:17 pm

Carlos Lubbers

Merge from SVN WTI-1710: - Updated version number from 17.2 --> 17.3 - Added Migration related files: -- Added empty file of FullTestProject17.3 -- Added empty migration script -- Added copy of DatabaseStructure17.3 which is identical to 17.2 (no DB changes were necessary for this release)

Options
    • -184
    • +167
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure17.3.sql
12:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Finalise release, made 18.1 compatible with the 'new' 17.3 release: - Adjusted migration script, table HydraRingpreprocessorEntity does not exist in the new 17.3 release -- Adjusted testfile, reopened and saved the test file in the 'new' 17.3 release to get rid of the HydraRingPreprocessorEntityTable

WTI-1710

Options
    • -1
    • +0
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject173.rtd
    • -1
    • +0
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
Wednesday 23 May 2018
2:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824, rename SetDuneLocationCalculations to SetDuneLocations: - Made the DuneLocations property an IObservableEnumerable --> modifications should not be possible from outside the SetDuneLocations() method to prevent the calculations from getting out of sync with the locations

WTI-1574

Options
    • -6
    • +5
    ./src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -4
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
    • -7
    • +8
    ./test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -3
    • +6
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  5. … 15 more files in changeset.
1:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824: - Renamed DuneLocationOutput to DuneLocationCalculationOutput -- Adjusted CreateExtension file names -- Updated function and parameter names where necessary.

WTI-1574

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +58
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensions.cs
    • -2
    • +2
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCreateExtensions.cs
    • -58
    • +0
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationOutputCreateExtensions.cs
    • -6
    • +6
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationOutputEntityReadExtensions.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +110
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensionsTest.cs
    • -14
    • +14
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCreateExtensionsTest.cs
    • -110
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationOutputCreateExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationEntityReadExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationOutputEntityReadExtensionsTest.cs
    • -13
    • +13
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
  14. … 31 more files in changeset.
Tuesday 15 May 2018
11:34 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2811: - Updated XMLDocs - Updated test names - Replaced type casts to byte with Convert.ToByte() calls - Formatting of the migration script

WTI-1706

Options
    • -16
    • +16
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationCreateExtensions.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationCreateExtensionsTest.cs
    • -44
    • +34
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
Monday 14 May 2018
4:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated migration script to fix failing tests: - Updated target values for the Category types --> indices changed from 0 to 1 based

WTI-1706

Options
    • -6
    • +6
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
3:42 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated migration script: - Cleaned up migration integration test: merged separate grass cover erosion outwards assert into the query generator.

WTI-1706

Options
    • -276
    • +254
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
3:09 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated migration script: - Generated initial setup and tests for the migration

WTI-1706

Options
    • -8
    • +112
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -5
    • +241
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
12:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated test files: - Generated empty 181 file with the new CategoryTypeColumns - Updated the 173 testfile to have wave conditions calculations with different norms

WTI-1706

Options
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject173.rtd
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject181.rtd
10:50 am

Dennis Tang <dennis.tang@deltares.nl>

Updated test TestHelper: - Initialised CategoryType values with non-default values for the wave conditions inputs

WTI-1706

Options
    • -6
    • +12
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
10:34 am

Dennis Tang <dennis.tang@deltares.nl>

Updated test files for ReadExtensions of the WaveConditionsCalculations: - Added asserts to verify the reference dependent output remains null when the entity has null values

WTI-1706

Options
    • -0
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsWaveConditionsCalculationEntityReadExtensionsTest.cs
    • -0
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
    • -0
    • +4
    ./test/Application.Ringtoets.Storage.Test/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverWaveConditionsCalculationEntityReadExtensionsTest.cs
10:30 am

Dennis Tang <dennis.tang@deltares.nl>

Updated ReadExtensions for StabilityStoneCover: -- Cleaned up tests, replaced testcase data with random generators and a separate test asserting NaN / NULL conversions -- Added functionality to read CategoryType

WTI-1706

Options
    • -2
    • +11
    ./src/Application.Ringtoets.Storage/Read/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationEntityReadExtensions.cs
    • -74
    • +69
    ./test/Application.Ringtoets.Storage.Test/Read/StabilityStoneCover/StabilityStoneCoverWaveConditionsCalculationEntityReadExtensionsTest.cs