Riskeer / Application

Ringtoets

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 31 May 2018
4:58 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Fixed validation for calculations that are created for locations: - Emulated outer join for the hydraulic boundary locations on grass cover erosion outwards failure mechanism

WTI-1654

Options
    • -9
    • +25
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
4:52 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Fixed validation for calculations that are created for locations: - Emulated outer join for the hydraulic boundary locations on assessment section level

WTI-1654

Options
    • -6
    • +22
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
4:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Fixed validation for calculations that are created for locations: - Emulated outer join for the dune locations

WTI-1654

Options
    • -175
    • +191
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
2:29 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Rename DuneLocationOutputEntity to DuneLocationCalculationOutputEntity: - Fixed migration script and verification tests

WTI-1654

Options
    • -2
    • +2
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject181.rtd
    • -4
    • +3
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
2:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Rename DuneLocationOutputEntity to DuneLocationCalculationOutputEntity: - Fixed compiling errors - Renamed read extension and corresponding test

WTI-1654

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationCreateExtensions.cs
    • -5
    • +7
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensions.cs
    • -2
    • +1
    ./src/Application.Ringtoets.Storage/DbContext/PartialRingtoetsEntities.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationCalculationEntityReadExtensions.cs
    • -0
    • +60
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationCalculationOutputEntityReadExtensions.cs
    • -60
    • +0
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationOutputEntityReadExtensions.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneErosionFailureMechanismCreateExtensionsTest.cs
    • -1
    • +1
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationCollectionCreateExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationCreateExtensionsTest.cs
    • -4
    • +4
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationCollectionEntityReadExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationEntityReadExtensionsTest.cs
    • -0
    • +117
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationOutputEntityReadExtensionsTest.cs
    • -117
    • +0
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationOutputEntityReadExtensionsTest.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
1:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Rename DuneLocationOutputEntity to DuneLocationCalculationOutputEntity: - Regenerated entities

WTI-1654

Options
    • -2
    • +2
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -2
    • +2
    ./src/Application.Ringtoets.Storage/DbContext/DuneLocationCalculationEntity.cs
    • -0
    • +48
    ./src/Application.Ringtoets.Storage/DbContext/DuneLocationCalculationOutputEntity.cs
    • -48
    • +0
    ./src/Application.Ringtoets.Storage/DbContext/DuneLocationOutputEntity.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.Context.cs
    • -71
    • +71
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx
    • -89
    • +89
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram
1:42 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup - Rename DuneLocationOutputEntity to DuneLocationCalculationOutputEntity: - Generated the new .SQL and RT file

WTI-1654

Options
    • -7
    • +7
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
    • binary
    ./src/Application.Ringtoets.Storage/Ringtoets.rtd
  3. … 1 more file in changeset.
1:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Adapted migration script: - Migrated DuneLocationOutput such that they are mapped onto the correct dune location calculation collections -- Adjusted validation tests

WTI-1654

Options
    • -2
    • +37
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -7
    • +96
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
11:46 am

Dennis Tang <dennis.tang@deltares.nl>

Adapted migration script: - Create new (mandatory) rows for the CalculationCollectionEntity and the CalculationEntity for DuneErosion -- Adjusted reference 173 file to include dune locations with output calculated based on either the signaling or the lower limit norm -- Adjusted validation tests

WTI-1654

Options
    • -1
    • +144
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject173.rtd
    • -2
    • +131
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
Wednesday 30 May 2018
3:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed failing test: - Stored new (empty) 181 project with the new database structure

WTI-1654

Options
    • binary
    ./test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject181.rtd
3:51 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted StorageSQLIntegrationTest to verify the round trip saving and opening RT projects: - Fixed failiing test: -- CollectionEntities should always be set for the dune failure mechanism meta entity to prevent ArgumentNullExceptions

WTI-1654

Options
    • -2
    • +12
    ./test/Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
3:40 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted StorageSQLIntegrationTest to verify the round trip saving and opening RT projects: - Included the new entities to be loaded - Switched order in the CreateExtensions: locations should be created first to prevent InvalidOperationExceptions because no matching DuneLocationEntity is found

WTI-1654

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneErosionFailureMechanismCreateExtensions.cs
    • -0
    • +3
    ./src/Application.Ringtoets.Storage/DbContext/PartialRingtoetsEntities.cs
    • -1
    • +34
    ./test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
3:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted GetFullTestProject: - Configured failure mechanism according to the new data model

WTI-1654

Options
    • -24
    • +33
    ./test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -40
    • +25
    ./test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
3:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed obsolete create extension for the general dune erosion input --> the corresponding meta entity is created by the failure mechanism create extensions already

WTI-1654

Options
    • -1
    • +0
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -53
    • +0
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/GeneralDuneErosionInputCreateExtensions.cs
    • -1
    • +0
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -68
    • +0
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/GeneralDuneErosionInputCreateExtensionsTest.cs
2:56 pm

Dennis Tang <dennis.tang@deltares.nl>

Implement Create and Read Extensions: - Implement read extension methods for the DuneErosionFailureMechanism

WTI-1654

Options
    • -1
    • +20
    ./src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -4
    • +132
    ./test/Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
2:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Improved existing test

WTI-1654

Options
    • -5
    • +14
    ./test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismCreateExtensionsTest.cs
2:05 pm

Dennis Tang <dennis.tang@deltares.nl>

Adapt Create and Read Extensions: - Adapt create extension methods for the DuneErosionFailureMechanism

WTI-1654

Options
    • -3
    • +15
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneErosionFailureMechanismCreateExtensions.cs
    • -0
    • +117
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneErosionFailureMechanismCreateExtensionsTest.cs
1:24 pm

Dennis Tang <dennis.tang@deltares.nl>

- Updated XMLDoc

WTI-1654

Options
    • -2
    • +2
    ./src/Application.Ringtoets.Storage/Read/HydraulicLocationCalculationCollectionReadExtensions.cs
1:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Implement Create and Read Extensions: - Implement read extension methods for collections of DuneLocationCalculation

WTI-1654

Options
    • -0
    • +1
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +76
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationCalculationCollectionEntityReadExtensions.cs
    • -0
    • +1
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +139
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationCollectionEntityReadExtensionsTest.cs
12:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Implement Create and Read Extensions: - Implement create extension methods for collections of DuneLocationCalculation

WTI-1654

Options
    • -0
    • +1
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +66
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationCollectionCreateExtensions.cs
    • -0
    • +1
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +90
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationCollectionCreateExtensionsTest.cs
11:47 am

Dennis Tang <dennis.tang@deltares.nl>

- Updated XMLDoc - Cleaned up file

WTI-1654

Options
    • -1
    • +2
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationEntityReadExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Read/HydraulicLocationCalculationEntityReadExtensions.cs
11:46 am

Dennis Tang <dennis.tang@deltares.nl>

Implement Create and Read Extensions: - Implement read extension methods for the DuneLocationCalculation

WTI-1654

Options
    • -0
    • +1
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +62
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationCalculationEntityReadExtensions.cs
    • -0
    • +1
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +130
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationCalculationEntityReadExtensionsTest.cs
11:28 am

Dennis Tang <dennis.tang@deltares.nl>

Implement Create and Read Extensions: - Implement create extension methods for the DuneLocationCalculation

WTI-1654

Options
    • -0
    • +1
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +70
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationCreateExtensions.cs
    • -0
    • +1
    ./test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +145
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationCreateExtensionsTest.cs
11:05 am

Dennis Tang <dennis.tang@deltares.nl>

Adapt Create and Read Extensions: - Modified extension methods for the DuneLocationOutput --> Cleaned up files, implemented missing NULL check - Adjusted implementation of the Hydraulic Boundary Location Output create extensions --> replaced cast to byte with a convert according to our own guidelines

WTI-1654

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensions.cs
    • -1
    • +1
    ./src/Application.Ringtoets.Storage/Create/HydraulicBoundaryLocationCalculationOutputCreateExtensions.cs
    • -0
    • +7
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationOutputEntityReadExtensions.cs
    • -2
    • +2
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensionsTest.cs
    • -1
    • +11
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationOutputEntityReadExtensionsTest.cs
10:58 am

Dennis Tang <dennis.tang@deltares.nl>

Adapt Create and Read Extensions: - Modified extension methods for the DuneLocation --> it has no reference to an output anymore

WTI-1654

Options
    • -11
    • +6
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCreateExtensions.cs
    • -7
    • +0
    ./src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationEntityReadExtensions.cs
    • -55
    • +11
    ./test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCreateExtensionsTest.cs
    • -63
    • +0
    ./test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationEntityReadExtensionsTest.cs
10:45 am

Dennis Tang <dennis.tang@deltares.nl>

Modified database design: - Regenerated database entities

WTI-1654

Options
    • -0
    • +6
    ./src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +10
    ./src/Application.Ringtoets.Storage/DbContext/DuneErosionFailureMechanismMetaEntity.cs
    • -0
    • +69
    ./src/Application.Ringtoets.Storage/DbContext/DuneLocationCalculationCollectionEntity.cs
    • -0
    • +54
    ./src/Application.Ringtoets.Storage/DbContext/DuneLocationCalculationEntity.cs
    • -4
    • +4
    ./src/Application.Ringtoets.Storage/DbContext/DuneLocationEntity.cs
    • -2
    • +2
    ./src/Application.Ringtoets.Storage/DbContext/DuneLocationOutputEntity.cs
    • -0
    • +2
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.Context.cs
    • -24
    • +325
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx
    • -90
    • +99
    ./src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram
    • binary
    ./src/Application.Ringtoets.Storage/Ringtoets.rtd
10:38 am

Dennis Tang <dennis.tang@deltares.nl>

Modified database design: - Regenerated SQL files based on the new design

WTI-1654

Options
    • -5
    • +79
    ./src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
  2. … 1 more file in changeset.
Friday 25 May 2018
1:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2843: - Rewrote functions - Cleaned up tests - Adjusted DuneErosionFailureMechanism: -- Moved instantiation of the list to class level -- Renamed private field to prevent shadowing

WTI-1574

Options
    • -8
    • +8
    ./src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -4
    • +7
    ./test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
  3. … 4 more files in changeset.
1:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2839: - Performed Resharper cleanup - Renamed test

WTI-1574

Options
    • -0
    • +1
    ./src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensions.cs
  2. … 4 more files in changeset.
10:31 am

Dennis Tang <dennis.tang@deltares.nl>

Merge from SVN WTI-1710: Updated version number from 17.3.1 to 17.3.2

Options
    • -1
    • +1
    ./src/Application.Ringtoets.Setup/Application.Ringtoets.Setup.wixproj
  2. … 2 more files in changeset.