Riskeer / Core / Common / src

Core.Common.Base

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 08 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 07 Mar 2017
4:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Final changes to the migrator: - Adjusted inquiry such that it is consistent with the console application - Updated XMLDoc - Refactored RingtoetsProjectMigratorTest: -- Extracted general method which asserts the messages from the inquiry helper -- Added tests to assert behaviour of the migrator when the file to migrate to locks (unable to write) -- Replaced all DirectoryDisposeHelpers with the FileDisposeHelpers, because the SaveFileDialog interactions are now obsolete -- Some minor cleanup

Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8636 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 024a738fb573f6a4a968fba23eb6b54b859b8596

Former-commit-id: acf833a66fdc442a399e5251063d7b6baa08fc0b

Options
    • -1
    • +1
    ./Storage/IMigrateProject.cs
  2. … 4 more files in changeset.
9:31 am

Dennis Tang <dennis.tang@deltares.nl>

Investigate alternative for failing SaveDialogTests on the buildserver: - Expanded the IInquiryHelper with a GetTargetFileLocation which takes a file filter and a suggested initial name as argument - Incorporated mentioned feature in the RingtoetsProjectMigrator - Adjusted failing tests Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8594 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5dcba28f6f531f2c0cc17da88348f279e582a6e1

Former-commit-id: b94f1c1b7bad927661d5eae11fecd6e414e30e71

Options
    • -10
    • +10
    ./Storage/IMigrateProject.cs
  2. … 4 more files in changeset.
Monday 06 Mar 2017
4:39 pm

Dennis Tang <dennis.tang@deltares.nl>

- Fixed failing tests: used Path.Combine to get the desired target path - Introduced a IMigrateProject: -- Will be used to inject the RingtoetsProjectMigrator in the StorageCommandHandler Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8584 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a91dcf37e1ce0202f18834db2b39a8f26fa28191

Former-commit-id: cced646b70846232ac83e9628e40cd58cbea1d2a

Options
    • -0
    • +1
    ./Core.Common.Base.csproj
    • -0
    • +59
    ./Storage/IMigrateProject.cs
  3. … 4 more files in changeset.
Monday 27 Feb 2017
5:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1488: - Improved tests of StrategyBase: -- Replaced the return methods with properties to assert if they're called with the right input arguments -- Renamed several tests - Ran DeltaresClean - Inlined the ValidateItems function in the ObservableUniqueItemCollectionWithSourcePath Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8450 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4ffcec0c1dcd11672904c2b637269d6a80545364

Former-commit-id: eee856fa71a461b074affbe52ed8d0429d4a7333

Options
    • -24
    • +14
    ./ObservableUniqueItemCollectionWithSourcePath.cs
  2. … 4 more files in changeset.
9:00 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Related to Issue [WTI-1133]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8428 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 331f6ea0cfe5494ebfc1e4fb917ee42212e8a114

Former-commit-id: e779a2129e8567975f4f85e6bb8e1ac14bd3bc43

Options
    • -1
    • +1
    ./IO/FileImporterBase.cs
  2. … 26 more files in changeset.
Thursday 23 Feb 2017
4:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Updated XMLDoc - Refactored ObservableUniqueItemCollectionWithSourcePath: -- Turned class into an abstract class -- Removed generic TFeature, because explicit knowledge is not needed -- Adjusted inherited classes or classes that make direct use of the ObservableUniqueItemCollectionWithSourcePath

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8411 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 68cb3152a1c682b33bb73740c7d2e1300459cde2

Former-commit-id: 3e983eaebb15fdbe735d2ae5c62aa07d82a65242

Options
    • -19
    • +8
    ./ObservableUniqueItemCollectionWithSourcePath.cs
  2. … 17 more files in changeset.
Wednesday 22 Feb 2017
11:24 pm

Elmar Kleijn

Review related changes Related to Issue [WTI-1135]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8394 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 79b1c6bb86ceec6e05faa412e77c53419240048b

Former-commit-id: 4e6fb4e002026817f9837bba738e8ac1d44daabf

Options
    • -1
    • +1
    ./ObservableUniqueItemCollectionWithSourcePath.cs
  2. … 42 more files in changeset.
Monday 20 Feb 2017
2:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1468: - Final refactoring of the derived classes from the ObservableCollectionWithSourcePath: -- Extended functionality of the ObservableUniqueItemCollectionWithSourcePath to ensure that at least one feature is given for the validation on the uniqueness of items -- Adjusted the inherited classes with new signature -- Added and fixed failing tests - Moved resource from Forms to Data for the shared display name between the Data and Form layer in Piping

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8326 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8f83ec6400451549356efd9f20d927d42205140d

Former-commit-id: b27663c546ef469624f9a5bf847bd5a118eea841

Options
    • -22
    • +55
    ./ObservableUniqueItemCollectionWithSourcePath.cs
  2. … 23 more files in changeset.
11:25 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1468: - First refactoring of the derived classes from the ObservableCollectionWithSourcePath: -- Renamed class that it represents a collection with unique items -- Extracted method to get unique features from an object Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8315 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ca2e766323a3dab411a508b14467d5230d70be37

Former-commit-id: 70b7615b7831401251adc0a9919d10193828537c

Options
    • -1
    • +1
    ./Core.Common.Base.csproj
    • -159
    • +0
    ./ObservableCollectionWithSourcePath.cs
    • -0
    • +188
    ./ObservableUniqueItemCollectionWithSourcePath.cs
  4. … 18 more files in changeset.
Friday 17 Feb 2017
4:24 pm

Joël van den Berg

Removed obsolete FileResult. Renamed ExpectedFile to FileFilterGenerator. Updated doc and performed cleanups. Other small improvements. Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8297 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c7a7dde63238ab597409a15fa06e4403571bd27c

Former-commit-id: 20d5e5224cd7fb10ee003e29defbe3c4268fe344

Options
    • -6
    • +11
    ./ObservableCollectionWithSourcePath.cs
    • -0
    • +27
    ./Properties/Resources.Designer.cs
    • -0
    • +9
    ./Properties/Resources.resx
  4. … 67 more files in changeset.
Wednesday 15 Feb 2017
9:02 am

Joël van den Berg

Changed ValidateItems interface so that only ArgumentExceptions are allowed to be thrown. Related to Issue [WTI-1093]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8238 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3dd7a95a6aa5d1d7c4f3ed36338c8e2ef7e93fdd

Former-commit-id: 3461c8453d85846474f5077c2f4aded4dd892db4

Options
    • -1
    • +2
    ./ObservableCollectionWithSourcePath.cs
  2. … 1 more file in changeset.
Tuesday 14 Feb 2017
4:05 pm

bouvrie <bouvrie@example.com>

* Introduced Range class and FormattableConstants * Refactored all mentions of value ranges in Resources throughout the solution and replaced those by injecting instances of Range. ** This solution supports globalization of the application better. * Removed Dotspatial Legend related stuff from BruTileLayer and IConfiguration (and it's derivatives). * Cleanup in BruTileLayer. * Extended ProbabilityHelper with method for validating probability values. Related to Issue [WTI-1131]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8230 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d5a767df415eb68fcef3ebd2503020ed5f4979cc

Former-commit-id: 1bdd5e06da36a1dbb69f6e6e4d1e529805155d47

Options
    • -0
    • +2
    ./Core.Common.Base.csproj
    • -0
    • +85
    ./Data/Range.cs
    • -0
    • +48
    ./FormattableConstants.cs
  4. … 82 more files in changeset.
8:53 am

Joël van den Berg

Added verification of the database schema of DSoil-Model in which stochastic soil model names need to be unique. Introduced StochasticSoilModelCollection which has additional validation for the uniqueness of the StochasticSoilModel Name. Renamed files containing Table constants. Related to Issue [WTI-1093]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8216 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 80c9a9206c20d8fdfa23712d2c68f9f13cc67378

Former-commit-id: b1779cca6f30e7472f2c9620524f4f5ae6031db2

Options
    • -0
    • +10
    ./ObservableCollectionWithSourcePath.cs
  2. … 55 more files in changeset.
Friday 10 Feb 2017
2:53 pm

bouvrie <bouvrie@example.com>

* BackgroundMapDataContainer now notifies observers of child map data Related to Issue [WTI-1105]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8185 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fcbaf5742db13c1d222cad41cc7800934236b80d

Former-commit-id: 924688ffb5c515b78849f7eccbb527ae96a2b42c

Options
    • -2
    • +2
    ./Observable.cs
  2. … 2 more files in changeset.
Friday 03 Feb 2017
1:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Turned the StochasticSoilModelCollection into a collection that uses generics: - Stores elements of type T and the source path (same functionality as the StochasticSoilModelCollection) - Modified influenced components, fixed failing tests Related to Issue [WTI-1083]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8063 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e49abec52fc1d6390fe033f62ed83ea72907ec2b

Former-commit-id: 512f88aa9067fcf94700873b63491b69b276b41a

Options
    • -1
    • +8
    ./Core.Common.Base.csproj
    • -0
    • +143
    ./ObservableCollectionWithSourcePath.cs
  3. … 22 more files in changeset.
Tuesday 31 Jan 2017
1:04 pm

Joël van den Berg

Added validation for Probability of StochasticSoilProfile. Added StochasticSoilmodelUpdateException. Provided base implementation of the DoPostImport (cancelable behavior) and an overridable DoPostImportUpdates to implement just the model updates. Added Strategy postfix to IStochasticSoilModelUpdateStrategy implementations. Fixed liskov issue with StochasticSoilModelUpdateDataStrategy. Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8026 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1b86b03430a8714c43abdb447dbf9a561426a94e

Former-commit-id: 781140c2712d3dd80e4e97c162a8455e54d8227d

Options
    • -4
    • +9
    ./IO/FileImporterBase.cs
    • -1
    • +1
    ./IO/IFileImporter.cs
    • -1
    • +1
    ./Service/FileImportActivity.cs
  4. … 38 more files in changeset.
Monday 30 Jan 2017
11:57 am

bouvrie <bouvrie@example.com>

* Introduced base TestFixture class for testing design of custom exceptions: CustomExceptionDesignGuidelinesTestFixture ** Refactored all ExceptionTest classes to used this new base-class. * Functional testcoverage for Core.Components.DotSpatial\Layer\BruTile\Configurations * PersistentCacheConfiguration no longer supports SQLite cache * ITileSourceFactory now guarantees that all ITileSource elements returned have a WmtsTileSchema. * TODO: More functional coverage for WmtsLayerConfiguration

Related to Issue [WTI-1088]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8011 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0cd7c47dc7ee2221f69b7c3b4d88205d087c691e

Former-commit-id: b3dbe965ce4a4266af1d8284ad481d2449db14e7

Options
    • -1
    • +1
    ./Storage/UpdateStorageException.cs
  2. … 61 more files in changeset.
Monday 16 Jan 2017
3:54 pm

Marten Janssen <marten.janssen@deltares.nl>

Merged revision(s) 7802-7807 from branches/Release/16_4: Ran Deltares cleanup Related to Issue [WTI-1065]

........

Adjusted validator of StabilityPointStructureParameterKeyword22 to only validate {{Mean}}

Related to Issue [WTI 1102]

........

Changes after review

paired with bouvrie

Related to Issue [WTI-1065]

........

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7809 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7837197cf36f26bd709d61e3d88aaf4c25e55313

Former-commit-id: ee9e4d26cca941db8a5cbd20d5b9735843e6b06f

Options
    • -3
    • +3
    ./Data/RoundedPoint2DCollection.cs
    • -12
    • +12
    ./Geometry/Math2D.cs
    • -1
    • +1
    ./Geometry/Point2D.cs
    • -2
    • +2
    ./Geometry/Point3D.cs
    • -2
    • +2
    ./Geometry/Point3DExtensions.cs
    • -4
    • +4
    ./Geometry/Segment2D.cs
  7. … 28 more files in changeset.
2:16 pm

Marten Janssen <marten.janssen@deltares.nl>

Ran Deltares cleanup Related to Issue [WTI-1065]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/16_4@7802 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 05a1c976155c91a0c967427812499bb5fef75a8d

Former-commit-id: 08d16a9e8e7c0987ca42dc9f7b5a4a09473501ff

Options
    • -3
    • +3
    ./Data/RoundedDouble.cs
    • -3
    • +3
    ./Data/RoundedPoint2DCollection.cs
    • -12
    • +12
    ./Geometry/Math2D.cs
    • -1
    • +1
    ./Geometry/Point2D.cs
    • -2
    • +2
    ./Geometry/Point3D.cs
    • -2
    • +2
    ./Geometry/Point3DExtensions.cs
    • -4
    • +4
    ./Geometry/Segment2D.cs
  8. … 35 more files in changeset.
Thursday 12 Jan 2017
4:06 pm

Joël van den Berg

use nameof in ArgumentExceptions Reviewed by: tangerma

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7762 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e3c15c6c005fe58c9c93290e71360a514522a360

Former-commit-id: 3c75b59518770b613e8d73e2c0a71b08da4fd8a7

Options
    • -3
    • +3
    ./Geometry/Math2D.cs
    • -1
    • +1
    ./Geometry/Point2D.cs
  3. … 5 more files in changeset.
3:59 pm

Joël van den Berg

use nameof in Argument*Exceptions Reviewed by: tangerma

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7760 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 489d965acd6cbed374e72d9a9f10deec8787bcfd

Former-commit-id: 0ef178298a4e4639093af98897cfb40d331b372d

Options
    • -1
    • +1
    ./Data/RoundedDouble.cs
    • -2
    • +2
    ./Data/RoundedPoint2DCollection.cs
    • -12
    • +12
    ./Geometry/Math2D.cs
    • -5
    • +5
    ./Geometry/Point2D.cs
    • -3
    • +3
    ./Geometry/Point3DExtensions.cs
    • -4
    • +4
    ./Geometry/Segment2D.cs
  7. … 279 more files in changeset.
1:31 pm

Marten Janssen <marten.janssen@deltares.nl>

Added operator overloads for RoundedDouble (as discussed in Tech meeting) paired with tang_ds

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7752 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e2187faa4083564b7a6cae6b9263f57b2ca1304d

Former-commit-id: 0b736ad40e3fd146360771b0d8c692d684fca45d

Options
    • -33
    • +58
    ./Data/RoundedDouble.cs
  2. … 1 more file in changeset.
Monday 09 Jan 2017
4:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1385: (Editorial) - Made the spelling of "Canceled" or "Uncancelable (opposed to "Cancelled" or "Uncancellable") consistent throughout the application.

Note:

"Cancellation" is legit U.S. spelling and therefore unchanged. "Cancelation" is not common and rarely used.

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7669 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 665e259f03237740e63d6441088354043dae52f2

Former-commit-id: 98c98ae04c081843c7bab2c55946744a8d06dad2

Options
    • -2
    • +2
    ./Service/Activity.cs
    • -1
    • +1
    ./Service/ActivityState.cs
  3. … 34 more files in changeset.
12:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1385: - Improved FileImporterBase: -- Use null propagation -- Removed unnecessary setter -- Virtual method to abstract method, fixed affected failing tests - Improved StructuresImporter: -- Used nameof function -- Renamed private field parameter name conform coding standards - Minor editorial changes - Removed redundant aliases

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7668 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ae36ef10b17db21a36e1c42d2fff77760a8665d6

Former-commit-id: 125e339e8568945268976ffc402eba124269dfff

Options
    • -14
    • +8
    ./IO/FileImporterBase.cs
    • -2
    • +2
    ./Properties/Resources.Designer.cs
    • -1
    • +1
    ./Properties/Resources.resx
  4. … 6 more files in changeset.
Friday 06 Jan 2017
5:15 pm

Elmar Kleijn

Get rid of AffectedNonTargetObservableInstances property in FileImporterBase Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7661 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b4399ab53f7c2aac15418f5353df3a273c66df30

Former-commit-id: ad12f9acfead5c0cbdb94f1fdff36c99392b06e6

Options
    • -27
    • +0
    ./IO/FileImporterBase.cs
  2. … 3 more files in changeset.
1:17 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged revision(s) 7595-7638 from branches/WTI-490:

Merged revision(s) 7537-7594 from trunk

........

Initial commit of changes from kleijn:

- Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles

- Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage

- Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

........

Fixed tests of the FileImporterBase and Activity:

- Checks on the states are made for the 4 different paths of the Import:

-- Import successful, canceled or not

-- Import not successful, canceled or not

- Moved logging from the activity to the importer

- Added tests to assert mentioned behaviour

........

Fixed tests of the PipingSurfaceLinesCsvImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Added resource value for the ImportActivity (missing file commit)

........

Fixed tests of the PipingSoilProfilesImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned redundant brackets

........

Fixed tests of the StructuresImporter:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

Adjusted test in PipingSoilProfilesImporterTest

- Changed initial value of the result to make clear that the value is set correctly

........

Fixed tests of the ProfilesImporters:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Removed obsolete Cancel call in the PipingSoilProfilesImporterTest

........

FileImporters should call Observers in case the import was successfull AND was cancelled at an uncancellable stage.

Note: test is missing to verify this behaviour

........

Fixed tests of the ProfilesImporters:

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Temporarily removed the Cancel tests, because the FeatureBasedMapDataImporter does not have a handle for NotifyProgress. Hence, Cancel method cannot be invoked when Import is running.

........

Fixed tests of the FailureMechanismSectionsImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned up tests in the StructuresImporterTest

........

Fixed tests of the ReferenceLineImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

........

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7646 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1c355702dfbd410c7c4733529d8db9e243496eba

Former-commit-id: 75c614862d018947936ef85e3775a125c425c032

Options
    • -6
    • +53
    ./IO/FileImporterBase.cs
    • -1
    • +10
    ./Properties/Resources.Designer.cs
    • -0
    • +3
    ./Properties/Resources.resx
    • -3
    • +12
    ./Service/FileImportActivity.cs
  5. … 23 more files in changeset.
Thursday 05 Jan 2017
4:32 pm

Dennis Tang <dennis.tang@deltares.nl>

FileImporters should call Observers in case the import was successfull AND was cancelled at an uncancellable stage.

Note: test is missing to verify this behaviour

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7633 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e83b44b0f9859bd3ab8158432cbbb7e8f6fcea42

Former-commit-id: 2d24eded9c720fa9d27095f2fe3beee65d42f323

Options
    • -0
    • +1
    ./IO/FileImporterBase.cs
1:47 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed tests of the PipingSurfaceLinesCsvImporter: - Added test to verify behaviour when canceling at the two stages during the import - Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base - Added resource value for the ImportActivity (missing file commit)

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7618 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 57abd999d6185e5e4841d6fa1c380dc3c8c9cc39

Former-commit-id: 836f2fc05903415944c167b13983d49f290d5216

Options
    • -1
    • +10
    ./Properties/Resources.Designer.cs
    • -0
    • +3
    ./Properties/Resources.resx
  3. … 4 more files in changeset.
1:37 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed tests of the FileImporterBase and Activity: - Checks on the states are made for the 4 different paths of the Import: -- Import successful, canceled or not -- Import not successful, canceled or not - Moved logging from the activity to the importer - Added tests to assert mentioned behaviour

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7617 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b54ccb13a0780daf3321fcbc02998200ae3283da

Former-commit-id: 22fd647c89a1cc3b0d4f812e4018335057f64e80

Options
    • -6
    • +52
    ./IO/FileImporterBase.cs
    • -9
    • +2
    ./Service/FileImportActivity.cs
  3. … 2 more files in changeset.
9:58 am

Robert Tangerman <robert.tangerman@deltares.nl>

Changed the log message for when failure mechanism contribution is zero. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7606 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c77e204f8e881e2c6155133b7acf54832702ee0f

Former-commit-id: ef70a113ba014154b93c39241fec8aec9f16f9c4

Options
    • -4
    • +1
    ./Service/Activity.cs
  2. … 5 more files in changeset.