Core.Common.Gui.Test

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Added parameter validation for FileFilterGenerator. Added tests. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9473 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 68dcf3905cf581b23e37f07ee10e3ca2afab6479

Former-commit-id: 3a5f39780c805ad0b52c2910167517513ed8e62a

    • -0
    • +204
    ./FileFilterGeneratorTest.cs
  1. … 2 more files in changeset.
- Merged conditional ?: expressions into conditional access. - Merged sequential checks in && or || expressions.

Paired with berg_jl

Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9469 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 046b2480e95cfbe00503c7529eef55b577d7c563

Former-commit-id: b458cfeda0d4eeff999fab9ba59e439bcb9c9526

    • -1
    • +1
    ./Forms/SplashScreen/SplashScreenTest.cs
  1. … 39 more files in changeset.
Used null propagation where suggested. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9467 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6d1d55a48f678a84b1d7b6279d945d2de8ee71a2

Former-commit-id: ac6b4dc77ee63a4b3e313075cebd822f4d32f432

  1. … 35 more files in changeset.
Changed all local vars to consts if possible. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9448 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4684a5017b9aff9f6175f7d781cb29409f50a18e

Former-commit-id: 853c649ebc49a9513535e40ec705d5b928af0bc4

    • -1
    • +1
    ./Commands/StorageCommandHandlerTest.cs
    • -1
    • +1
    ./ContextMenu/ContextMenuBuilderTest.cs
    • -2
    • +2
    ./ContextMenu/StrictContextMenuItemTest.cs
    • -2
    • +2
    ./ContextMenu/TreeViewContextMenuItemFactoryTest.cs
    • -1
    • +1
    ./Forms/MessageWindow/MessageWindowTest.cs
    • -1
    • +1
    ./Forms/ViewHost/AvalonDockViewHostTest.cs
    • -1
    • +1
    ./PropertyBag/DynamicPropertyBagTest.cs
  1. … 270 more files in changeset.
Cleanup Reviewed by: janssen Related to Issue [WTI-1250]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9442 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2ae79a0f8cf2a113b4416d348120301d39787642

Former-commit-id: 8793ce35d510e26eafef2e024b1eb3840a220b6f

  1. … 1 more file in changeset.
Moved SettingsHelper.cs to Core.Common.Utils Related to Issue [WTI-1250]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9439 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 09302a2b2ecc70cf41788beb1eba3dbff0606111

Former-commit-id: a095bf6913555053a8171c64ca9349a31a7ddadf

    • -1
    • +1
    ./Appenders/RingtoetsUserDataFolderConverterTest.cs
    • -133
    • +0
    ./Settings/SettingsHelperTest.cs
  1. … 58 more files in changeset.
Applied cleanup over Ringtoets.Core Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9424 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e79666c3005d8749a1973fc827c38a6e17a64dfd

Former-commit-id: d1b69716d861a8986cd3fb3e1426d5be26758c48

    • -1
    • +1
    ./Forms/SplashScreen/SplashScreenTest.cs
    • -2
    • +2
    ./PropertyBag/PropertySpecDescriptorTest.cs
  1. … 25 more files in changeset.
Moved ExceptionDialog to Core.Common.Gui. Added tests for coverage. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9402 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4c5faf3e7edeaef347dc7319bc21b14191e7a912

Former-commit-id: 8e0893fa3f8121c9782f4f85505dd5d2777b7598

    • -0
    • +337
    ./ExceptionDialogTest.cs
  1. … 16 more files in changeset.
Core code-cleanup. Searched for superfluous this. for property assignments as well.

Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9369 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ecb498b6096a9d8b0a66e69428411d5ae18ec80a

Former-commit-id: 9cc4bad09e38263256924549eaa807b887009030

    • -2
    • +2
    ./Appenders/RenderedMessageLogAppenderTest.cs
    • -19
    • +19
    ./Attributes/DynamicPropertyOrderAttributeTest.cs
    • -16
    • +16
    ./Attributes/DynamicPropertyOrderEvaluationMethodAttributeTest.cs
    • -19
    • +19
    ./Attributes/DynamicReadOnlyAttributeTest.cs
    • -16
    • +16
    ./Attributes/DynamicReadOnlyValidationMethodAttributeTest.cs
    • -19
    • +19
    ./Attributes/DynamicVisibleAttributeTest.cs
    • -16
    • +16
    ./Attributes/DynamicVisibleValidationMethodAttributeTest.cs
    • -1
    • +1
    ./Attributes/PropertyOrderAttributeTest.cs
    • -2
    • +2
    ./Commands/ApplicationFeatureCommandHandlerTest.cs
    • -13
    • +13
    ./Commands/StorageCommandHandlerTest.cs
    • -1
    • +2
    ./ContextMenu/StrictContextMenuItemTest.cs
    • -6
    • +6
    ./ContextMenu/TreeViewContextMenuItemFactoryTest.cs
    • -9
    • +9
    ./Converters/ExpandableArrayConverterTest.cs
  1. … 276 more files in changeset.
Fixed all license headers for Core.Common Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9363 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fd6670c8f1dc23800f528d8cf1bcca9b59450097

Former-commit-id: 2fcc5b60e67454ddfd4a0d5153de6c37c38f17b8

  1. … 18 more files in changeset.
Initial framework for logging during migration Related to Issue [WTI-1250]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9359 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 65a0be73e41bdcc943cbb6c9aff1219a07b0386f

Former-commit-id: aa8225c3f1cf98b03cf5ebafadf307387df12a9c

  1. … 14 more files in changeset.
Changes after review. Related to Issue [WTI-1108]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9341 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1a30b373d0cabf2adab5866e8f31bc8ab0bf43ea

Former-commit-id: 760c0609bfc169d4671144d76a33c13d8aef9da8

  1. … 1 more file in changeset.
Incorporated comments tester: - Changed log message of the UpdateHandlers in case there's no CurrentPath set - Formatting Related to Issue [WTI-1108]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9327 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 04fb354a8759802b4d95f0f142f8f0019f684298

Former-commit-id: 7f38f5d976210d69e3ca98aa1e6b0e9257309949

  1. … 4 more files in changeset.
* Moved default values from dialogs to *Info objects to improved testability ** Unable to properly test images on the dialogs themselves, due to background color in dialog. Related to Issue [WTI-1159]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8856 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9134e97086c6967f193b7a698ed75d7623df7e92

Former-commit-id: 9cdcdaa9d82d067e5bd0c0e621ff3e32b662d655

  1. … 28 more files in changeset.
Added missing test coverage Related to Issue [WTI-1159]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8829 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a2a972181152d7f3863913453e0be62d3870444d

Former-commit-id: 5b8fd8c3df3a1fa26aa00097b87e826264ab488a

Removed unused references fixed typo paired with bouvrie Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8809 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3d002b4243d9f0109eb93ae7554f04834585ac76

Former-commit-id: b8dc47f846a37f8df0cfe56d8ce83faee121aab7

    • -1
    • +0
    ./Commands/StorageCommandHandlerTest.cs
  1. … 4 more files in changeset.
* Fixed typos. * Renamed MigrationNeeded to MigrationRequired. * Cleanup. * Asserting log messages improved by taking type of message into account. * Moved CriticalFileReadException from Core.Common.IO\Exceptions to Core.Common.Base\IO * Task is now disposed when disposing ActivityProgressDialog * Put license header back Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8786 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 54560eb7ca6c0a99cdcf14b0406c23b9eca57311

Former-commit-id: 3b703601071d34a3cca2779d0c671f3d3ddabcd9

    • -10
    • +38
    ./Commands/StorageCommandHandlerTest.cs
  1. … 121 more files in changeset.
* Refactored IInquiryHelper such that it no longer depends on FileFilterGenerator. ** From the abstraction level point of view, it just feels incorrect to pass generators around. * Extended IInquiryHelper with a method to check if a certain optional step should be performed or not. * Refactored StorageCommandHandler to use IInquiryHelper instead of showing dialogs itself. ** This should solve some issues we're having on the build server (expected dialogs not appearing) ** Also improves consistency with other code. * CalculationConfigurationWriter.WriteDistributionProperties now based on IDictionary instead of IEnumerable<Tuple> * Cleanup Related to Issue [WTI-1153]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8775 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: dec4df77800b65c57be1a8c2b6783e85a0f2c900

Former-commit-id: 9288f6b609cf96bdfa62d1fefa7e13ba956a85b7

    • -53
    • +69
    ./Commands/StorageCommandHandlerTest.cs
  1. … 18 more files in changeset.
Revert commit 8755

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8756 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 943b3c0670fec2b02077c57b2e49a7d22e8adc63

Former-commit-id: 402c5eff0d8c3acbc9a89f36e890e455e4e66d4c

    • -3
    • +3
    ./Commands/StorageCommandHandlerTest.cs
Attempt to fix failing test on builder server (locally the changed test works without problems)

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8755 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9aa647cabd3a49d93f0e82c2843b87607446dd4e

Former-commit-id: 9502c6632c0bbaf2ae9261efd422e0de39107364

    • -3
    • +3
    ./Commands/StorageCommandHandlerTest.cs
* StorageCommandHandler now used SaveProjectActivity for saving a project. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8749 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b8a3b475daa67df690ffd26a1c074ce0dcfef462

Former-commit-id: 6602462746c5f97cfb226d0d0f53dcc4ba0df72b

    • -4
    • +24
    ./Commands/StorageCommandHandlerTest.cs
  1. … 3 more files in changeset.
* Defined activity for saving a IProject instance. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8746 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5af9950e900268761408fba8893c9b5de179fc19

Former-commit-id: c98abd125d6387efba1f28228285c59882984fe6

    • -0
    • +541
    ./SaveProjectActivityTest.cs
  1. … 4 more files in changeset.
Implemented review comments: - Removed obsolete lines in project file - Added assertions for the log level of the generated log messages - Renamed tests for naming consistency - Replaced testcases with a general source for the invalid file paths

Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8730 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fe2b47099a1213a7a063bf08564abb9c1b5562bb

Former-commit-id: 5564b6705928765ed5bc716661f2ba635da89681

    • -42
    • +45
    ./Commands/StorageCommandHandlerTest.cs
  1. … 2 more files in changeset.
* Extended OpenProjectActivity such that Cancel works as expected. * Removed obsolete Memory Fix. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8729 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 19f1e1967a00db9cb01dc715aa3be62eb5b3e7bb

Former-commit-id: 8923f8d5c406e5405957bca74677284dc6b10352

  1. … 2 more files in changeset.
* Progress text for OpenProjectActivity Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8710 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0732d59ab594223d4bbc1bfa411122049a8178e9

Former-commit-id: b9efe454a5381a031fdda9311e36ae3e2def5cee

  1. … 3 more files in changeset.
* Refactored StorageCommandHandler to use OpenProjectActivity. * Fixed bug in ActivityProgressDialog related to cross-threading exceptions. ** Implementation was not guaranteed to use the correct SynchronizationContext. ** Removed ProgressReporter, due to now being obsolete. ** Setting of SynchronizationContext no longer required in unit tests. * Changed default value for MigrationNeeded.

Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8699 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 40eb861411768c4a895eae17f71470458887712d

Former-commit-id: b19c95c5b04582cf50f772cb1dbfcc34f8b1fb6d

    • -13
    • +96
    ./Commands/StorageCommandHandlerTest.cs
  1. … 10 more files in changeset.
Implemented review comments: - Set the owner of the dialog windows of the DialogBasedInquiryHelper -- Fixed affected tests - Added assertions for the log level severity - Corrected typos in XML docs - Corrected reference settings - Added missing integration tests Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8692 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ee73e748a0bfbe46c7cc81b43aeae35429b04b5f

Former-commit-id: 6de73e069e8defde63b355a77826f15c39e4ec30

  1. … 6 more files in changeset.
* Defined OpenProjectActivity class. ** Class handles opening a project and optionally migrating it first to the current version. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8666 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 871238779ed91c9968d4deba9f60c6a84534cda4

Former-commit-id: b7e95c17580c13c42e8b5a2b00b30b6418c30283

    • -0
    • +764
    ./OpenProjectActivityTest.cs
  1. … 3 more files in changeset.
* Refactored RingtoetsProjectMigrator to move responsibility of determining target location for migrated project to seperate method. * Fixed 2 failing tests. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8660 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e725e71ba9d80444c8a49d6618832bee6ccd237d

Former-commit-id: 457b058abc9f8baa453a165f511492c49c895042

    • -15
    • +80
    ./Commands/StorageCommandHandlerTest.cs
  1. … 9 more files in changeset.
* Some refactoring to RingtoetsProjectMigrator ** Now more clear return result for ShouldMigrate method between the need for migration or not or when the migration workflow is aborted. ** Moved responsibility of asking user for accepting migration from Migrate to ShouldMigrate method.

These steps have been taken as preparation to ask user for confirmation and location before starting an Activity to perform the actual migration and subsequently opening the migrated project.

Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8654 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3d793cf304e5f7f685b1d4341368297a7cbebdc7

Former-commit-id: 61ca241d865cafa2dc91367fd1dbf780aa790f73

    • -3
    • +6
    ./Commands/StorageCommandHandlerTest.cs
  1. … 6 more files in changeset.