Riskeer / Core

Common

Clone Tools

Stats

Commits this week: 2
Total Committers: 16
Last Commit: 22 Apr
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 27 Sep 2018
1:16 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Changed calculation skipped log message. WTI-1796

Options
    • -3
    • +3
    ./src/Core.Common.Base/Properties/Resources.Designer.cs
    • -1
    • +1
    ./src/Core.Common.Base/Properties/Resources.resx
    • -1
    • +1
    ./test/Core.Common.Base.Test/Service/ActivityTest.cs
10:20 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed license headers. WTI-1767

Options
    • -3
    • +3
    ./test/Core.Common.TestUtil/ChangePropertyData.cs
    • -0
    • +3
    ./test/Core.Common.TestUtil/Core.Common.TestUtil.csproj
  3. … 27 more files in changeset.
Wednesday 26 Sep 2018
3:47 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Remove unused resource WTI-1767

Options
    • -10
    • +1
    ./test/Core.Common.TestUtil.Test/Properties/Resources.Designer.cs
    • -3
    • +0
    ./test/Core.Common.TestUtil.Test/Properties/Resources.resx
11:21 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Paired with Kleijn. WTI-1691

Options
    • -2
    • +2
    ./test/Core.Common.Controls.Test/DataGrid/DataGridViewControlTest.cs
10:40 am

Dennis Tang <dennis.tang@deltares.nl>

Fix Setup and TearDown locations in test:

- Moved Setup and TearDown overrides to the top of test file documents for cleanups that are already performed

WTI-1767

Options
    • -5
    • +5
    ./test/Core.Common.Gui.Test/Commands/StorageCommandHandlerTest.cs
    • -5
    • +5
    ./test/Core.Common.Gui.Test/ContextMenu/TreeViewContextMenuItemFactoryTest.cs
    • -11
    • +11
    ./test/Core.Common.Gui.Test/DialogBasedInquiryHelperTest.cs
    • -11
    • +11
    ./test/Core.Common.Gui.Test/Forms/MessageWindow/MessageWindowTest.cs
  5. … 1 more file in changeset.
10:03 am

Dennis Tang <dennis.tang@deltares.nl>

Ran Deltares Cleanup:

- Performed for Common.TestUtil and Common.Util.Test namespaces

WTI-1767

Options
    • -1
    • +1
    ./test/Core.Common.TestUtil.Test/ControlsTestHelperTest.cs
    • -0
    • +1
    ./test/Core.Common.TestUtil.Test/DirectoryDisposeHelperTest.cs
    • -6
    • +2
    ./test/Core.Common.TestUtil.Test/DoubleWithToleranceComparerTest.cs
    • -3
    • +6
    ./test/Core.Common.TestUtil.Test/FileDisposeHelperTest.cs
    • -0
    • +1
    ./test/Core.Common.TestUtil/ChangePropertyData.cs
    • -0
    • +2
    ./test/Core.Common.TestUtil/DirectoryDisposeHelper.cs
    • -0
    • +1
    ./test/Core.Common.TestUtil/DirectoryPermissionsRevoker.cs
    • -0
    • +1
    ./test/Core.Common.TestUtil/DoubleWithToleranceComparer.cs
    • -0
    • +1
    ./test/Core.Common.TestUtil/EnumValuesTestFixture.cs
    • -0
    • +2
    ./test/Core.Common.TestUtil/FileDisposeHelper.cs
    • -1
    • +1
    ./test/Core.Common.TestUtil/LogLevelConstant.cs
    • -1
    • +2
    ./test/Core.Common.TestUtil/RandomExtensions.cs
    • -5
    • +5
    ./test/Core.Common.TestUtil/TestDataPath.cs
    • -0
    • +2
    ./test/Core.Common.TestUtil/WpfTestHelper.xaml.cs
    • -0
    • +1
    ./test/Core.Common.Util.Test/IO/EmbeddedResourceFileWriterTest.cs
    • -0
    • +2
    ./test/Core.Common.Util.Test/IOUtilsTest.cs
    • -0
    • +1
    ./test/Core.Common.Util.TestUtil.Test/Settings/UseCustomSettingsHelperTest.cs
9:10 am

Dennis Tang <dennis.tang@deltares.nl>

Ran Deltares Cleanup:

- Performed for Core.Common, except TestUtil

WTI-1767

Options
    • -0
    • +2
    ./src/Core.Common.Base/Data/Range.cs
    • -3
    • +5
    ./src/Core.Common.Base/Data/RoundedDouble.cs
    • -0
    • +1
    ./src/Core.Common.Base/Data/RoundedPoint2DCollection.cs
    • -0
    • +19
    ./src/Core.Common.Base/Geometry/Math2D.cs
    • -0
    • +6
    ./src/Core.Common.Base/Geometry/Point2D.cs
    • -0
    • +2
    ./src/Core.Common.Base/Geometry/Point2DCollectionExtensions.cs
    • -0
    • +3
    ./src/Core.Common.Base/Geometry/Point3D.cs
    • -0
    • +3
    ./src/Core.Common.Base/Geometry/Point3DCollectionExtensions.cs
    • -0
    • +2
    ./src/Core.Common.Base/Geometry/Point3DExtensions.cs
    • -0
    • +6
    ./src/Core.Common.Base/Geometry/Segment2D.cs
    • -0
    • +6
    ./src/Core.Common.Base/ObservableUniqueItemCollectionWithSourcePath.cs
    • -0
    • +1
    ./src/Core.Common.Base/Service/FileImportActivity.cs
    • -0
    • +2
    ./src/Core.Common.Base/TypeConverters/RoundedDoubleConverter.cs
    • -5
    • +10
    ./src/Core.Common.Controls.TreeView/TreeViewControl.cs
    • -1
    • +2
    ./src/Core.Common.Controls/DataGrid/DataGridViewColumnStateDefinition.cs
  16. … 56 more files in changeset.
8:43 am

Robert Tangerman <robert.tangerman@deltares.nl>

Changes after review. WTI-1691

Options
    • -6
    • +4
    ./src/Core.Common.Controls/DataGrid/DataGridViewControl.cs
    • -69
    • +2
    ./test/Core.Common.Controls.Test/DataGrid/DataGridViewControlTest.cs
Tuesday 25 Sep 2018
4:29 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed combobox redraw delay. WTI-1691

Options
    • -5
    • +5
    ./src/Core.Common.Controls/DataGrid/DataGridViewControl.cs
    • -37
    • +55
    ./test/Core.Common.Controls.Test/DataGrid/DataGridViewControlTest.cs
1:16 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Equality comparison of floating point numbers. WTI-1767

Options
    • -1
    • +1
    ./src/Core.Common.Base/Geometry/Math2D.cs
11:19 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Removed redundant string interpolation. WTI-1767

Options
    • -2
    • +2
    ./test/Core.Common.Gui.Test/SaveProjectActivityTest.cs
  2. … 1 more file in changeset.
11:12 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Made methods and properties private where possible. WTI-1767

Options
    • -1
    • +2
    ./src/Core.Common.IO/Readers/SqLiteDatabaseReaderBase.cs
  2. … 4 more files in changeset.
Monday 24 Sep 2018
2:15 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Removed unused usings. WTI-1767

Options
    • -1
    • +0
    ./src/Core.Common.Controls.TreeView/DragDropHandler.cs
    • -1
    • +0
    ./test/Core.Common.Controls.Test/PresentationObjects/WrappedObjectContextBaseTest.cs
    • -1
    • +0
    ./test/Core.Common.Gui.Test/Commands/StorageCommandHandlerTest.cs
  4. … 28 more files in changeset.
1:58 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Conditional access qualifier expression is known to be not null. WTI-1767

Options
    • -1
    • +1
    ./src/Core.Common.Gui/Converters/KeyValueExpandableArrayConverter.cs
1:58 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Revert "Cleanup: Conditional access qualifier expression is known to be not null. WTI-1767"

This reverts commit c4b24c0a4946d7cd20c0fb302aa9c8e30f10afc6.

Options
    • -1
    • +1
    ./src/Core.Common.Gui/Converters/KeyValueExpandableArrayConverter.cs
1:48 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Fixed localizable string. WTI-1767

Options
    • -1
    • +1
    ./src/Core.Common.Base/Data/Range.cs
    • -2
    • +2
    ./src/Core.Common.Gui/OpenProjectActivity.cs
    • -1
    • +1
    ./test/Core.Common.TestUtil/TestHelper.cs
1:37 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Fixed Expression is always null. WTI-1767

Options
    • -16
    • +4
    ./test/Core.Common.TestUtil.Test/RandomExtensionsTest.cs
    • -4
    • +1
    ./test/Core.Common.Util.Test/Drawing/GraphicsExtensionsTest.cs
    • -4
    • +1
    ./test/Core.Common.Util.Test/Extensions/CollectionExtensionsTest.cs
    • -12
    • +3
    ./test/Core.Common.Util.Test/Extensions/EnumerableExtensionsTest.cs
  5. … 21 more files in changeset.
1:00 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Fixed typos. WTI-1767

Options
    • -1
    • +1
    ./src/Core.Common.Geometry/AdvancedMath2D.cs
    • -7
    • +7
    ./test/Core.Common.Base.Test/Geometry/Point2DTest.cs
  3. … 1 more file in changeset.
Thursday 20 Sep 2018
5:11 pm

Robert Tangerman <robert.tangerman@deltares.nl>

"<geen>" => "<selecteer>". WTI-1691

Options
    • -2
    • +2
    ./src/Core.Common.Controls/Properties/Resources.Designer.cs
    • -1
    • +1
    ./src/Core.Common.Controls/Properties/Resources.resx
    • -1
    • +1
    ./test/Core.Common.Controls.Test/DataGrid/DataGridViewComboBoxItemWrapperTest.cs
  4. … 12 more files in changeset.
5:11 pm

Robert Tangerman <robert.tangerman@deltares.nl>

"<geen>" => "<selecteer>". WTI-1691

Options
    • -2
    • +2
    ./src/Core.Common.Controls/Properties/Resources.Designer.cs
    • -1
    • +1
    ./src/Core.Common.Controls/Properties/Resources.resx
    • -1
    • +1
    ./test/Core.Common.Controls.Test/DataGrid/DataGridViewComboBoxItemWrapperTest.cs
  4. … 12 more files in changeset.
4:30 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Set combobox FlatStyle to flat. WTI-1691

Options
    • -1
    • +2
    ./src/Core.Common.Controls/DataGrid/DataGridViewControl.cs
    • -0
    • +3
    ./test/Core.Common.Controls.Test/DataGrid/DataGridViewControlTest.cs
Monday 17 Sep 2018
11:10 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1787

Options
    • -31
    • +33
    ./src/Core.Common.Gui/Forms/MainWindow/MainWindow.xaml.cs
    • -2
    • +4
    ./src/Core.Common.Gui/Forms/ViewHost/AvalonDockViewHost.xaml.cs
    • -3
    • +0
    ./src/Core.Common.Util/IO/EmbeddedResourceFileWriter.cs
    • -1
    • +2
    ./test/Core.Common.TestUtil.Test/InvalidPathHelperTest.cs
    • -1
    • +2
    ./test/Core.Common.TestUtil/InvalidPathHelper.cs
  6. … 9 more files in changeset.
Wednesday 12 Sep 2018
11:58 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Reduce bugs in sonarqube, improve assigning of values to arrays with suspicious operator WTI-1787

Options
    • -4
    • +6
    ./src/Core.Common.Util/Drawing/ColorAccess.cs
  2. … 2 more files in changeset.
Tuesday 11 Sep 2018
10:41 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1803

Options
    • -6
    • +6
    ./test/Core.Common.TestUtil.Test/RandomExtensionsTest.cs
  2. … 1 more file in changeset.
9:50 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3233:

- Updated XMLDocs

- Cleaned tests

- Improved src of the IdGenerator

WTI-1803

Options
    • -19
    • +12
    ./test/Core.Common.TestUtil.Test/RandomExtensionsTest.cs
    • -3
    • +3
    ./test/Core.Common.TestUtil/RandomExtensions.cs
  3. … 4 more files in changeset.
Friday 07 Sep 2018
3:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3223:

- Introduced random extensions to select a subset of enums

- Applied to affected tests

-- Applied to AssessmentSectionAssemblyResult as none and notapplicable are invalid results and will cause a NotSupportedException when generated.

WTI-1803

Options
    • -1
    • +86
    ./test/Core.Common.TestUtil.Test/RandomExtensionsTest.cs
    • -0
    • +37
    ./test/Core.Common.TestUtil/RandomExtensions.cs
  3. … 7 more files in changeset.
Thursday 30 Aug 2018
10:50 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Fix implementation of IDisposable to conform to the dispose pattern. WTI-1787

Options
    • -1
    • +10
    ./src/Core.Common.Base/Observer.cs
    • -1
    • +10
    ./src/Core.Common.Base/RecursiveObserver.cs
    • -2
    • +11
    ./src/Core.Common.Controls.TreeView/TreeViewControl.cs
    • -2
    • +9
    ./src/Core.Common.Gui/Forms/MainWindow/MainWindow.xaml.cs
    • -5
    • +17
    ./src/Core.Common.Gui/Forms/ViewHost/AvalonDockViewHost.xaml.cs
    • -3
    • +11
    ./src/Core.Common.Gui/Forms/ViewHost/DocumentViewController.cs
    • -2
    • +11
    ./src/Core.Common.Gui/Plugin/PluginBase.cs
    • -2
    • +9
    ./src/Core.Common.Util/IO/EmbeddedResourceFileWriter.cs
  9. … 32 more files in changeset.
8:41 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: Parameter validation in yielding methods should be wrapped. WTI-1787

Options
    • -0
    • +6
    ./src/Core.Common.Geometry/AdvancedMath2D.cs
Wednesday 29 Aug 2018
1:50 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup: use an immutable collection or reduce the accessibility of the field. WTI-1787

Options
    • -6
    • +12
    ./test/Core.Common.TestUtil/InvalidPathHelper.cs
Friday 24 Aug 2018
2:27 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Reduce sonarqube Bugs WTI-1787

Options
    • -6
    • +11
    ./src/Core.Common.Util/EnumTypeConverter.cs
    • -1
    • +5
    ./src/Core.Common.Util/NullableEnumConverter.cs
  3. … 2 more files in changeset.