Incorporated comments review 3395: WTI-1887- Fixed compilation errors in the converters after changes in the datamodel for the derived classes of the FeatureBasedMapData-- Moved all generic functions to the base class-- Moved general operation definitions to the base class
Incorporated comments review 3395: WTI-1887- Fixed compilation errors of the derived classes from the FeatureBasedMapData as a consequence of the data model change.
Added missing tests WTI-1887- Added for the derived classes: default category should be added when a theme is defined for an attribute that's not present in the features.- Added for the filter expression, test in the base class to guarantee it always gives the expected expression.- Fixed parameter names
Fixed converters. WTI-1887- Added category creation logic in the converters and pushed tests downwards for the derived datatypes from the converter base class.
Adjusted base converter WTI-1887- Turned the base converter into a template pattern class, as the derived classes should provide the implementations to convert categories
Pushed (Map)Theme property from the base down to derived classes. WTI-1887- Pushed down as the derived classes each has their own specific styling options and thus their own categorical theming.
Made MapTheme typed. WTI-1887- Made it typed as a preparation for pushing the MapTheme property down to its derived classes for the FeatureBasedMapData