ClosingStructuresCalculationService.cs

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improvements after review. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7648 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c797f46ab1f6f4cf0dcc824a7a495f312e529b36

Former-commit-id: 55ee85a64cc1545c9c5dafe3c054b160a5df241e

    • -6
    • +5
    ./ClosingStructuresCalculationService.cs
  1. … 19 more files in changeset.
Refactored HydraRingCalculatorBase so it will only throw one exception. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7640 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a6de8a1ad179588f61a471c820b522033db66125

Former-commit-id: dbe8dc7f4c11ca209636bc2288143268ef5d8149

    • -16
    • +3
    ./ClosingStructuresCalculationService.cs
  1. … 32 more files in changeset.
Added documentation for Hydra-Ring calculation process. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7605 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e5cf1d8d3a806018f43ab7bc2a0a7bd9390af16b

Former-commit-id: 70a9cfa92619125137e1418a1dede18d579bff46

    • -3
    • +16
    ./ClosingStructuresCalculationService.cs
  1. … 19 more files in changeset.
Added null checks in dune erosion and closing structures calculation services. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7588 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 63f021f5741f4dae65ad82aa12c4593af72c8727

Former-commit-id: 19a06c73d09214b5c9422976aeb691946802d415

    • -29
    • +70
    ./ClosingStructuresCalculationService.cs
  1. … 4 more files in changeset.
- Renamed some methods - Improved documentation and exception handling in DuneErosionCalculationService. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7555 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d194f66842310d591e1bbc09ab807bf3bb16aedc

Former-commit-id: 41aa2143aeaac94aaccc9fe38e202ec1c2b3d174

    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  1. … 19 more files in changeset.
* Changed ClosingStructure.ProbabilityOpenStructureBeforeFlooding to ProbabilityOrFrequencyOpenStructureBeforeFlooding, as it's not a probability value. ** Updated related validation methods as well. * Changed validation for the above parameter such at values greater than 1 are accepted during the import. * Improved validation during import for LogNormalDistribution.Mean, guarding validating that the value must be greater than 0.

Related to Issue [WTI-1029]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7239 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1feb3919c0a6ae5bea7ad1d22866bd5bf17f6cff

Former-commit-id: 4042c706d0d3e8e43598a9f73c35bb3418574e2e

    • -3
    • +3
    ./ClosingStructuresCalculationService.cs
  1. … 38 more files in changeset.
Incorporated comments review 1193

Paired with tangerma

Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6624 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8bb152605c66a45e95674b6c3cdf1de51116c3fc

Former-commit-id: cead6acfbad775228a8299b94dc07606827559d2

    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  1. … 12 more files in changeset.
Implemented HydraRingCalculationException in services. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6600 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b3d26fca1deff9d97c3b4fdcdd6e91bb5e487034

Former-commit-id: 1d88356f353578ef2409f223ce86e5fe467280c0

    • -1
    • +3
    ./ClosingStructuresCalculationService.cs
  1. … 18 more files in changeset.
Moved HydraRingFileParserException to separate folder. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6597 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 161b72b8d2f4cca558d2cfa741731ccac9fb3401

Former-commit-id: 801650177c3694c17344ee7da5f9fb38b3335296

    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  1. … 33 more files in changeset.
Changed resource names. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6593 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4b8f4dd6062aef19831f3640882b682be31327d3

Former-commit-id: 2bd1da54d3497aa59f14a4f2135da3ac84ad037a

    • -3
    • +3
    ./ClosingStructuresCalculationService.cs
  1. … 22 more files in changeset.
Made method generic. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6581 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 961d43c8c5f804eb0f6c7b0f10ba3fb62f41c2e6

Former-commit-id: 9c5c86b846cfe319d26338b9d4828ca80f0131c1

    • -6
    • +1
    ./ClosingStructuresCalculationService.cs
  1. … 8 more files in changeset.
Eliminated Try-Finally in finally statement in all calculation services. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6580 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 569d587644a9e914dede8ea2b600b62ac9e2e620

Former-commit-id: 4040bcb278466e5c8699ed489cbe99f68bc3075d

    • -16
    • +20
    ./ClosingStructuresCalculationService.cs
  1. … 6 more files in changeset.
Renamed property. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6579 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: daa9b5eceb67c9a8c89aba6a57de98def278f7a4

Former-commit-id: e4b18b0d55435557fc6e84e3492a334e60aa36f4

    • -2
    • +2
    ./ClosingStructuresCalculationService.cs
  1. … 34 more files in changeset.
Deltares clean-up Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6498 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 63ac7722f8d3890848384ee20816ead3f90cb796

Former-commit-id: d2a9cf4a79400ddb42314b6db73f84ca256b0dc2

    • -5
    • +5
    ./ClosingStructuresCalculationService.cs
  1. … 25 more files in changeset.
Ensured DeviationWaveDirection is no longer checked during validation Related to Issue [WTI-921]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6497 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 190d34210194dd97a3fcf7c3c12bd40e28e40e43

Former-commit-id: cf1fe0a506ab7ed913be7990c0b660e1f2271625

    • -2
    • +0
    ./ClosingStructuresCalculationService.cs
  1. … 5 more files in changeset.
Fixed calculation failed state when canceled by user. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6469 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b3bdf5b36185ee36e3b0302c097a07746bbcc118

Former-commit-id: 5e56f6572f966e7d74e1584ccfd4b8d3dff3ac74

    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  1. … 6 more files in changeset.
Added all calls to AssignSettingsFromDatabase after creating hydraring input. Related to Issue [WTI-919]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6449 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6dc58dbacc0c160612e1593471f38971a56a96c0

Former-commit-id: d9cfd13f1005f553e6d1fa17ee5249dc1e1ede0a

    • -22
    • +43
    ./ClosingStructuresCalculationService.cs
  1. … 15 more files in changeset.
Moved HydraulicDatabaseHelper to Ringtoets.Common.IO project. Added validation for settings database to HydraulicDatabaseHelper. Related to Issue [WTI-919]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6434 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 171ff0f3f3dbe21be31af24be61309853967fd5a

Former-commit-id: 63c8b931ad8d57dd5f011643575ce5367f410bde

    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  1. … 34 more files in changeset.
Some XMLdoc related changes Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6411 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bbaac1a45d2179e5546f77417be59b41eecc6132

Former-commit-id: bb39b174b57eece0753191d02bc3f692afb84fc6

    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  1. … 11 more files in changeset.
Incorporated review comments: - Editorial changes: moved lines around to improve coherence in the validation rules - Incorporated all changes related to the validation rules: changed resource name and documentation, removed unnecessary aliases and renamed function Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6410 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 23de8d55848dbe268d4cf73c0900c9cfe03b4f0f

Former-commit-id: dd70d0530bc045690a16927f5fc56ddbf5cfb98e

    • -12
    • +6
    ./ClosingStructuresCalculationService.cs
  1. … 20 more files in changeset.
Incorporated review comments: - Editorial changes: moved lines around to improve consistency. Checked for similar tests across the Structures - Extracted function to retrieve validation rules depending on the calculation type in ClosingStructuresCalculationService - Changed parameter names

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6407 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e1580d2ed171698fd39b5bc43af134da09314a84

Former-commit-id: f5567d00dde1ac54ef7a753d24bc7c9d73dc1ff8

    • -17
    • +24
    ./ClosingStructuresCalculationService.cs
  1. … 8 more files in changeset.
Deltares clean-up for Demo and Ringtoets.ClosingStructures Related to Issue [WTI-931]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6394 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6d9cbf33f673a9fc02f238e6bc59877b871277db

Former-commit-id: 436f5d6c5a25e7fd20bd93ae2077b05e5abaf038

    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  1. … 11 more files in changeset.
Implemented Hydra-Ring last error handling for closing structures. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6382 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8850e43dc957389dec4b2678e670f944ac539e95

Former-commit-id: 43c617ccbf325a3fc501d4e31e880a837167d5bc

    • -3
    • +32
    ./ClosingStructuresCalculationService.cs
  1. … 9 more files in changeset.
Show temp Hydra-Ring working directory in log messages instead of output file contents. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6362 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ffee509c70a3b27af0b78536abc002b38b1a3d2a

Former-commit-id: 8c1f43038a30d3db98b08807548c7fee71164814

    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  1. … 72 more files in changeset.
Implement validation service: - Implemented validation rule for calculation inputs that implement IUseBreakWater - Added validation tests for the structures (as they do not contain validation procedures with foreshore and/or breakwater combinations)

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6315 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2c05a30a764e39a06d4e7719b7bc726e175d6e97

Former-commit-id: 195e28eced78cf9d4502788d927d419420fb3f32

    • -0
    • +3
    ./ClosingStructuresCalculationService.cs
  1. … 15 more files in changeset.
Implement validation service: - Implemented validation rules for the ClosingStructuresCalculationService Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6300 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7374bcf7bc271ac3908eb5fd9224251d5d528dfb

Former-commit-id: 22326ff17213d83e8d2d2c368acdbcdd857d3840

    • -101
    • +85
    ./ClosingStructuresCalculationService.cs
* Made variabletype explicit. * Added xml docs to method to make it clear what it's behavior is. * Added InvalidEnumArgumentException to default sections of switch statements. * Renamed resource (and reused it)

Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6299 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bc454db9c282f8f142b9ddd4e0d6b2f7141a5ef6

Former-commit-id: f83d1d7387f86e9c8cb1edf2cf839799e3180065

    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  1. … 14 more files in changeset.
- Introduced AssessmentSectionHelper to create assessment section stubs. - Introduced service for stability point structures. - Introduced test calculation for stability point structures. Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6259 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 341b4d67f97ea9ff66407a2f408577674c7c948d

Former-commit-id: f2f1c210714d43fbde39a88be94cd95599efd5b7

    • -1
    • +1
    ./ClosingStructuresCalculationService.cs
  1. … 19 more files in changeset.
Implement validation: - Added validation for the flooded culvert calculations Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6257 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b06381fe2f4d7951d2e79f2a9cd51192c1af9274

Former-commit-id: 2c11dfa81411bf8f924cd9872d30244715f7d6c9

    • -5
    • +34
    ./ClosingStructuresCalculationService.cs
  1. … 1 more file in changeset.
Implement validation: - Resource was removed while file out of date: fixed Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6251 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a90a035a9b302fc410f3ac7a6a476c2de0d8cbe4

Former-commit-id: f50bfecf910d01ff1a8ea6cfdd6976b4427eb33b

    • -1
    • +1
    ./ClosingStructuresCalculationService.cs