Riskeer / Ringtoets / ClosingStructures

src

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 17 Feb 2017
4:24 pm

Joël van den Berg

Removed obsolete FileResult. Renamed ExpectedFile to FileFilterGenerator. Updated doc and performed cleanups. Other small improvements. Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8297 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c7a7dde63238ab597409a15fa06e4403571bd27c

Former-commit-id: 20d5e5224cd7fb10ee003e29defbe3c4268fe344

Options
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  2. … 69 more files in changeset.
10:11 am

bouvrie <bouvrie@example.com>

* Improved XML docs. * Cleanup. * Extended ProbabilityHelper with overload such that caller can provide a custom message instead. Related to Issue [WTI-1131]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8280 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9177505cb61daf6a68a65969379f77c6a6b20f99

Former-commit-id: fba413d5000b603d7c8cd42a7c31cedac7e31dbe

Options
    • -23
    • +3
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs
  2. … 11 more files in changeset.
Wednesday 15 Feb 2017
1:46 pm

bouvrie <bouvrie@example.com>

* MapControl now uses BackgroundMapDataContainer directly. ** TODO: Handling NotifyObservers on BackgroundMapDataContainer, in order to know if MapData property has changed. * Improved robustness of MapControl unit tests that make temporary backup of tile chaches. * BackgroundMapDataContainer moved from Ringtoets.Common.Data to Core.Components.Gis Related to Issue [WTI-1143]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8254 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8368df4f1e33ebe99e86dde01ae0382a118890f8

Former-commit-id: 79fd13aafb4655934d563c8729e0cb4e703f8149

Options
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismView.cs
  2. … 43 more files in changeset.
7:58 am

bouvrie <bouvrie@example.com>

* Refactored all mentions of value ranges in Resources throughout the solution and replaced those by injecting instances of Range. ** This solution supports globalization of the application better. Related to Issue [WTI-1131]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8236 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3c0331a83349c54e02ae5746ce174e63561adc06

Former-commit-id: ed98ee6450cb642865381e24ce3c856f17837bd7

Options
    • -3
    • +6
    ./Ringtoets.ClosingStructures.Data/GeneralClosingStructuresInput.cs
    • -3
    • +3
    ./Ringtoets.ClosingStructures.Data/Properties/Resources.Designer.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Data/Properties/Resources.resx
  4. … 8 more files in changeset.
Tuesday 14 Feb 2017
4:36 pm

Joël van den Berg

Changed file filter type of ImportInfo and ExportInfo to ExpectedFile. Related to Issue [WTI-1093]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8232 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cb521aa99f8ab2aae9fe1e8e140c89e980df0b38

Former-commit-id: 66e86c3638367473d67986cb1c8ec92faa4562a9

Options
    • -1
    • +4
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  2. … 51 more files in changeset.
4:05 pm

bouvrie <bouvrie@example.com>

* Introduced Range class and FormattableConstants * Refactored all mentions of value ranges in Resources throughout the solution and replaced those by injecting instances of Range. ** This solution supports globalization of the application better. * Removed Dotspatial Legend related stuff from BruTileLayer and IConfiguration (and it's derivatives). * Cleanup in BruTileLayer. * Extended ProbabilityHelper with method for validating probability values. Related to Issue [WTI-1131]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8230 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d5a767df415eb68fcef3ebd2503020ed5f4979cc

Former-commit-id: 1bdd5e06da36a1dbb69f6e6e4d1e529805155d47

Options
    • -10
    • +28
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs
  2. … 84 more files in changeset.
Friday 10 Feb 2017
2:08 pm

bouvrie <bouvrie@example.com>

* IAssessmentSection now has a BackgroundMapDataContainer instead of a WmtsMapData. * Added missing assertions to StorageSqLiteIntegrationTest for background map data. Related to Issue [WTI-1105]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8181 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: adb7cf2213f1a01c9d8c63a93e789debaf9b574a

Former-commit-id: 4280f253668d55e313e171f3589ae967a70c56c1

Options
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismView.cs
  2. … 55 more files in changeset.
Monday 06 Feb 2017
9:57 am

Elmar Kleijn

Got rid of ringId in HydraRing calculations Related to Issue [WTI-1059]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8081 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4bc191fed1251037ae4eef4b56b7c26f9422f239

Former-commit-id: ba1406e780c01115aa545539afaef534ff495f40

Options
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  2. … 73 more files in changeset.
Tuesday 24 Jan 2017
8:35 am

Robert Tangerman <robert.tangerman@deltares.nl>

- Moved change handler to separate folder - Added license headers in Ringtoets.Common.Forms. Related to Issue [WTI-1053]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7908 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: da1b2735d3331f3ff850d447a6a010715b607f4e

Former-commit-id: 0a64740b0cdb7538830db04b0f6c4f8677aa6c98

Options
    • -0
    • +1
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  2. … 16 more files in changeset.
Monday 23 Jan 2017
2:27 pm

bouvrie <bouvrie@example.com>

* All MapControl users makes use of available WmtsMapData to put it on MapControl.BackgroundMapData. * Improved unit tests to use test stub object for retrieving map tiles. * Cleanup Related to Issue [WTI-1088]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7891 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5837b0f29024f4d0bdfbeebef29ed9a18e77b6b6

Former-commit-id: 8d4d1b5549793d2f91dbdf707df2a72348bf56f0

Options
    • -1
    • +2
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismView.cs
  2. … 31 more files in changeset.
12:49 pm

Elmar Kleijn

Added contribution validation for piping Related to Issue [WTI-1059]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7882 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8ac490267cceb5ee4a62b2e236a43b305b7484cf

Former-commit-id: c4f5a3602edd0b929932e624f58bf828efb4367b

Options
    • -11
    • +21
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  2. … 10 more files in changeset.
12:27 pm

bouvrie <bouvrie@example.com>

* Renamed FileUtils to IOUtils and extended it with folder related validation methods. ** Defined DirectoryWriterErrorMessageBuilder to be used in validation message generation. * Extended MapControl with BackgroundMapData property. ** MapControl observes BackgroundMapData for changes. ** BackgroundMapData defines the coordinate system used, and will reprojet all other layers when needed. * Defined testing mocks for getting fake tile data, instead of requiring an internet connection for tests. * PipingFailureMechanismView makes use of the BackgroundMapData feature. Related to Issue [WTI-1088]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7881 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ebd8aca90052bb12a8d8167237267eb60e050684

Former-commit-id: 8a9624c64bec0ab4467267d9cbdbe12698bdff96

Options
    • -1
    • +2
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismView.cs
  2. … 65 more files in changeset.
10:40 am

Elmar Kleijn

Added contribution validation for structures failure mechanisms Related to Issue [WTI-1059]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7874 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7a609e01770ea1f08163eb5137836628e9c5ff63

Former-commit-id: 2455b688acec17aeec5ea2d0834b7171e63d96e3

Options
    • -7
    • +13
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  2. … 25 more files in changeset.
8:13 am

Elmar Kleijn

Cleaned up some summaries Related to Issue [WTI-1059]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7871 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5c81e69b79153147cd7b3802d33791461bc0938c

Former-commit-id: 25a86b4fd326a527b2d79129a11af2d5e11f8a63

Options
    • -1
    • +0
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  2. … 2 more files in changeset.
Monday 16 Jan 2017
11:11 am

Dennis Tang <dennis.tang@deltares.nl>

Merged revision(s) 7774-7777 from branches/Release/16_4: Removed validation whether the failuremechanism contains any sections to enable or disable the Validate(All) and Calculate(All) buttons in the context menu: - Adjusted affected tests: assessment section mocks --> stubs - Removed obsolete tests that assert the behavior when a section is set or not - Added missing validation tests for the GroupContext - Cleaned up tests: -- Removed geometry definitions for the failure mechanism sections -- Replaced resource assertions with explicit string messages

........

Removed validation for the ClosingStructures whether the failuremechanism contains any sections to enable or disable the Validate(All) and Calculate(All) buttons in the context menu:

- Adjusted affected tests: assessment section mocks --> stubs, because property getter of AssessmentSection.HydraulicBoundaryDatabase is called

- Removed obsolete tests that assert the behavior when a section is set or not

- Cleaned up tests:

-- Removed geometry definitions for the failure mechanism sections

-- Renamed parameters such that suffices -Stub and -Mock are dropped

Related to Issue [WTI-1064]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7797 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 72c9f1e4c706b1618191dadc0f34d6d5b795c74d

Former-commit-id: 79cfb1c6fef792cdbc4fbdf320ca4f324e16c17b

Options
    • -10
    • +4
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  2. … 7 more files in changeset.
9:06 am

Marten Janssen <marten.janssen@deltares.nl>

Merged revision(s) 7773 from branches/Release/16_4: Changed type of *WidthFlowApertures* (Breedte van doorstroomopening) from CoefficientOfVariation to StandardDeviation note: storage change (names of the columns) has not yet been executed

Removed Application.Ringtoets/Application.Ringtoets.csproj post build action, which was needed for MSBuild2015

........

Related to Issue [WTI-1102]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7794 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 342282b213d520bc60ebd90113af4ab47b1c929d

Former-commit-id: 91abb8a151c800d1c462c52940cdfb3a8c7bb08d

Options
    • -5
    • +5
    ./Ringtoets.ClosingStructures.Data/ClosingStructure.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructureProperties.cs
    • -8
    • +8
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresFailureMechanismProperties.cs
    • -19
    • +19
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.IO/ClosingStructuresImporter.cs
    • -6
    • +6
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  7. … 65 more files in changeset.
Friday 13 Jan 2017
2:49 pm

bouvrie <bouvrie@example.com>

* Reformatted C# 6.0 code to code patterns compatible before C# 6.0 Related to Issue [WTI-1058]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/16_4@7781 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5594b25edc81838facacccfdef2065a6c20304e6

Former-commit-id: d609e70ea13237b79eb634b26215b09d8d9e552e

Options
    • -2
    • +5
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  2. … 13 more files in changeset.
2:10 pm

Dennis Tang <dennis.tang@deltares.nl>

- Removed C#6.0 syntax - Removed unused reference Related to Issue [WTI-1064]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/16_4@7779 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9f91b4f2520678306a9824a25f1d8b1a64df8ca3

Former-commit-id: 696e9141e2906b8dab2a7f72e6b94b39541c9ef6

Options
    • -1
    • +0
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  2. … 2 more files in changeset.
1:50 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed validation for the ClosingStructures whether the failuremechanism contains any sections to enable or disable the Validate(All) and Calculate(All) buttons in the context menu: - Adjusted affected tests: assessment section mocks --> stubs, because property getter of AssessmentSection.HydraulicBoundaryDatabase is called - Removed obsolete tests that assert the behavior when a section is set or not - Cleaned up tests: -- Removed geometry definitions for the failure mechanism sections -- Renamed parameters such that suffices -Stub and -Mock are dropped

Related to Issue [WTI-1064]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/16_4@7777 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 80c273e5de34180566c3f55565c22e9cfd581467

Former-commit-id: 440a227c98c0f9fc26301f0f98caba76243a3a9b

Options
    • -10
    • +4
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  2. … 3 more files in changeset.
1:18 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Merged revision(s) 7770-7772 from branches/Release/16_4

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7775 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3573fbef3cb5a89f0722ceef8cd183f1920fe663

Former-commit-id: d79a40a94fc31ab868d173f60de590cac0fbee30

Options
    • -17
    • +7
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  2. … 41 more files in changeset.
1:07 pm

Marten Janssen <marten.janssen@deltares.nl>

Changed type of *WidthFlowApertures* (Breedte van doorstroomopening) from CoefficientOfVariation to StandardDeviation note: storage change (names of the columns) has not yet been executed

Removed Application.Ringtoets/Application.Ringtoets.csproj post build action, which was needed for MSBuild2015

Related to Issue [WTI-1102]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/16_4@7773 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9a076019f5caf170d779ad16f8f1c8188e9a39a3

Former-commit-id: 068fa68d9844c31b4cd81c4ff74cb1f47ab2d245

Options
    • -5
    • +5
    ./Ringtoets.ClosingStructures.Data/ClosingStructure.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructureProperties.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.IO/ClosingStructuresImporter.cs
    • -4
    • +4
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  6. … 56 more files in changeset.
12:11 pm

Robert Tangerman <robert.tangerman@deltares.nl>

- Removed FailureMechanismSection from structure calculations. - Refactored those inputs so only the section normal is passed. Related to Issue [WTI-1058]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/16_4@7772 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6c0bdf4e704ece33df577ce94f29d6b7de1e8abf

Former-commit-id: c16ae42acda7aa160a2a7af14cea1915bafb78b6

Options
    • -21
    • +7
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  2. … 28 more files in changeset.
12:10 pm

bouvrie <bouvrie@example.com>

* Defined BruTileLayer with WMTS connectivity. ** Classes based on https://github.com/FObermaier/DotSpatial.Plugins * Note: app.config added bu Nuget. Probably in order to resolve BruTile.Desktop dependency on an older version of SQLite, which i've set to ignore the dependency on the old SQLite. Related to Issue [WTI-1088]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7771 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f9fc0e320eea992e04250addb23b310f9b348a02

Former-commit-id: 8f2ecf22a1d5ec3cea0f1d7d342b882b5e6e78e7

Options
    • -0
    • +1
    ./Ringtoets.ClosingStructures.Forms/Ringtoets.ClosingStructures.Forms.csproj
    • -0
    • +11
    ./Ringtoets.ClosingStructures.Forms/app.config
    • -0
    • +1
    ./Ringtoets.ClosingStructures.Plugin/Ringtoets.ClosingStructures.Plugin.csproj
    • -0
    • +11
    ./Ringtoets.ClosingStructures.Plugin/app.config
    • -0
    • +1
    ./Ringtoets.ClosingStructures.Service/Ringtoets.ClosingStructures.Service.csproj
    • -0
    • +11
    ./Ringtoets.ClosingStructures.Service/app.config
  7. … 206 more files in changeset.
Thursday 12 Jan 2017
3:59 pm

Joël van den Berg

use nameof in Argument*Exceptions Reviewed by: tangerma

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7760 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 489d965acd6cbed374e72d9a9f10deec8787bcfd

Former-commit-id: 0ef178298a4e4639093af98897cfb40d331b372d

Options
    • -4
    • +4
    ./Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data/GeneralClosingStructuresInput.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Forms/PresentationObjects/ClosingStructuresContext.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms/PresentationObjects/ClosingStructuresScenariosContext.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresScenarioRow.cs
    • -4
    • +4
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationActivity.cs
    • -3
    • +3
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
  8. … 278 more files in changeset.
3:26 pm

Joël van den Berg

Use of nameof operator in Resource* attributes. Reviewed by: bouvrie

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7758 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f5bb0e00d51b1760f788726105a1fc99df20e024

Former-commit-id: 2624919c5c7a37b1da3486ef3d4dd8d40c6f62c5

Options
    • -3
    • +3
    ./Ringtoets.ClosingStructures.Data/ClosingStructureInflowModelType.cs
    • -51
    • +51
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructureProperties.cs
    • -30
    • +30
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresFailureMechanismProperties.cs
    • -33
    • +33
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
  5. … 79 more files in changeset.
Friday 06 Jan 2017
2:11 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7648 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c797f46ab1f6f4cf0dcc824a7a495f312e529b36

Former-commit-id: 55ee85a64cc1545c9c5dafe3c054b160a5df241e

Options
    • -6
    • +5
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  2. … 19 more files in changeset.
1:17 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged revision(s) 7595-7638 from branches/WTI-490:

Merged revision(s) 7537-7594 from trunk

........

Initial commit of changes from kleijn:

- Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles

- Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage

- Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

........

Fixed tests of the FileImporterBase and Activity:

- Checks on the states are made for the 4 different paths of the Import:

-- Import successful, canceled or not

-- Import not successful, canceled or not

- Moved logging from the activity to the importer

- Added tests to assert mentioned behaviour

........

Fixed tests of the PipingSurfaceLinesCsvImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Added resource value for the ImportActivity (missing file commit)

........

Fixed tests of the PipingSoilProfilesImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned redundant brackets

........

Fixed tests of the StructuresImporter:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

Adjusted test in PipingSoilProfilesImporterTest

- Changed initial value of the result to make clear that the value is set correctly

........

Fixed tests of the ProfilesImporters:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Removed obsolete Cancel call in the PipingSoilProfilesImporterTest

........

FileImporters should call Observers in case the import was successfull AND was cancelled at an uncancellable stage.

Note: test is missing to verify this behaviour

........

Fixed tests of the ProfilesImporters:

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Temporarily removed the Cancel tests, because the FeatureBasedMapDataImporter does not have a handle for NotifyProgress. Hence, Cancel method cannot be invoked when Import is running.

........

Fixed tests of the FailureMechanismSectionsImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned up tests in the StructuresImporterTest

........

Fixed tests of the ReferenceLineImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

........

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7646 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1c355702dfbd410c7c4733529d8db9e243496eba

Former-commit-id: 75c614862d018947936ef85e3775a125c425c032

Options
    • -6
    • +0
    ./Ringtoets.ClosingStructures.IO/ClosingStructuresImporter.cs
  2. … 26 more files in changeset.
8:55 am

Robert Tangerman <robert.tangerman@deltares.nl>

Refactored HydraRingCalculatorBase so it will only throw one exception. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7640 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a6de8a1ad179588f61a471c820b522033db66125

Former-commit-id: dbe8dc7f4c11ca209636bc2288143268ef5d8149

Options
    • -16
    • +3
    ./Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
  2. … 32 more files in changeset.
Thursday 05 Jan 2017
2:24 pm

Joël van den Berg

Clear output on removal of Closing Structures

Related to Issue [WTI-973]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7623 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8053c81a5ceb4bec2b8b68bc72d689181938633f

Former-commit-id: daea1df74c7efc51e5f8e66b4beb3986f406a764

Options
    • -1
    • +0
    ./Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
  2. … 1 more file in changeset.
12:11 pm

Joël van den Berg

Made use of nameof operator. Removed redundancy. Made types explicit in tests. Related to Issue [WTI-973]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7613 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ae0a1774c3921e4893681196f73a6bfa1f084bc4

Former-commit-id: 0304bd841817e0d89abbbb8792162fb125eedae0

Options
    • -1
    • +0
    ./Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresFailureMechanismProperties.cs
  2. … 20 more files in changeset.