Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- Reformatted files - Removed structure from calculation that did not needed the strucure - Renamed private variables to match naming rule settings paired with bouvrie Related to Issue [WTI-923]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6390 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 66c4483b2d44f0e2b11914b792b6c30342f50adb

Former-commit-id: 63ee18ea2d27febd9c0d350e0256ffedca24392f

    • -141
    • +136
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  1. … 1 more file in changeset.
Implemented Hydra-Ring last error handling for stability point structures.

Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6388 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 26ae25adbeac0fd981f4dda93e7b2758624e97e7

Former-commit-id: 9e2a2d9f392d316bcfdabfddadcb6e35b160bfef

    • -2
    • +2
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
    • -12
    • +12
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  1. … 10 more files in changeset.
Implemented Hydra-Ring last error handling for closing structures. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6382 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8850e43dc957389dec4b2678e670f944ac539e95

Former-commit-id: 43c617ccbf325a3fc501d4e31e880a837167d5bc

    • -5
    • +7
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructureFailureMechanismContextTreeNodeInfoTest.cs
    • -2
    • +4
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -7
    • +118
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
    • -0
    • +189
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  1. … 6 more files in changeset.
Review related changes Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6380 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0cf1f8776919dacfbfa186feeb66eaf4bab0cbc3

Former-commit-id: e5dcf337529347eaa7b7b46554b65b47a4fa44ec

    • -2
    • +2
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  1. … 3 more files in changeset.
Implement validation service: - Connected plugin with the validation routine of the calculation service - Added missing test in the failure mechanism for closing structures: validation routine was not asserted

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6375 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8e28ed71866679074ae4ad303d95a2fea394381a

Former-commit-id: 1fb1c2c43d3044e9b9267ffdaf53b29c8e45d9b8

    • -0
    • +68
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructureFailureMechanismContextTreeNodeInfoTest.cs
  1. … 4 more files in changeset.
* Hide particular properties from PropertyGridView, dependent on ModelType of ClosingStructure calculation. Related to Issue [WTI-923]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6368 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6c5790e816fc03ee0476fc7b00f984a25ed99247

Former-commit-id: 9a549599ed680b9cbd84bc895ecd5b9e1d9b4939

    • -3
    • +22
    ./Ringtoets.ClosingStructures.Data.TestUtil.Test/TestClosingStructureTest.cs
    • -6
    • +9
    ./Ringtoets.ClosingStructures.Data.TestUtil/TestClosingStructure.cs
    • -67
    • +473
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  1. … 2 more files in changeset.
Show temp Hydra-Ring working directory in log messages instead of output file contents. Related to Issue [WTI-928]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6362 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ffee509c70a3b27af0b78536abc002b38b1a3d2a

Former-commit-id: 8c1f43038a30d3db98b08807548c7fee71164814

    • -2
    • +2
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructureFailureMechanismContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  1. … 68 more files in changeset.
Review related changes Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6354 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 037c82e46f3bc330e7e436cf57a18b0c7a83d1d2

Former-commit-id: 4ceb1716cbb4ba6f80d7d1c21f7c8b82f558c05c

    • -48
    • +35
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  1. … 3 more files in changeset.
Review related changes Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6347 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c3fae05878814971a1005b95c5b710e92d2b4c2e

Former-commit-id: 3047c86cde0b4464be757d98ba00bf6a78d4f1c5

    • -0
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresInputTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructureFailureMechanismPropertiesTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructurePropertiesTest.cs
    • -1
    • +1
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  1. … 50 more files in changeset.
Implement validation service: - Implemented initial test setup for the StabilityPointStructuresCalculationService

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6341 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8d1b87312bd9a58b460b9c643ae485a65838ab37

Former-commit-id: d60b120f2971dbd1288c5939da1722f301c9c09f

    • -1
    • +2
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  1. … 1 more file in changeset.
Review related changes Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6339 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b017da77bfd60684c84e0905da667fac35bc975a

Former-commit-id: 01b338bf085f8e5ae9cba241c69546cb86fd8f10

    • -35
    • +35
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresInputTest.cs
  1. … 2 more files in changeset.
Quality check: - (Editorial) Removed double call comment in affected service tests - Changed inconsistent types

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6336 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1a0b601976b4ab1601a2c42387eafc04d75fabf9

Former-commit-id: 2b9fe616233429c2da20f794e270342cd830453c

    • -1
    • +0
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  1. … 1 more file in changeset.
Implement validation service: - Removed CreateForeshoreProfile calls: test object TestForeshoreProfile was extended: -- Now possible to specify it with and without default breakwater (optional constructor argument) -- Also possible to set a specific BreakWater object on the foreshore profile

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6325 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bb29fbd42227e2f5fcb45c1f5686602148e25933

Former-commit-id: d3149c5daad18902beae2fb67a5ebf40a35e28be

    • -15
    • +4
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
    • -0
    • +4
    ./Ringtoets.ClosingStructures.Service.Test/Ringtoets.ClosingStructures.Service.Test.csproj
  1. … 5 more files in changeset.
Review related changes Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6322 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 37e86559ae4790987e4af641c1fb382679c89a8f

Former-commit-id: e122779f90d7530bd1f06a3a41b86278552c458b

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresInputTest.cs
    • -2
    • +2
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
  1. … 14 more files in changeset.
Implement validation service: - Made the enum CalculationType generic for the tests. This enum can be used to denote testcases where the calculation input uses -- a valid foreshore, without a breakwater -- a valid foreshore, with a (valid) breakwater -- no foreshore Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6318 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 596e900f974ea5d1daceb55b0ebf0868252e1568

Former-commit-id: 218ad701bad0597568c8462a166c30517222d023

    • -7
    • +0
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  1. … 7 more files in changeset.
Review related changes Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6317 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7a5e41c73c6635419e51a630f58abd062b9c420c

Former-commit-id: f34b314e5d55ca21671d976b871fe184b14dc668

    • -35
    • +0
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresInputTest.cs
  1. … 4 more files in changeset.
Implement validation service: - Implemented validation rule for calculation inputs that implement IUseBreakWater - Added validation tests for the structures (as they do not contain validation procedures with foreshore and/or breakwater combinations)

Related to Issue [WTI-927]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6315 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2c05a30a764e39a06d4e7719b7bc726e175d6e97

Former-commit-id: 195e28eced78cf9d4502788d927d419420fb3f32

    • -21
    • +107
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  1. … 15 more files in changeset.
Implemented performing calculations for stability point structures calculation group and failure mechanism. Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6305 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c2a739570b4ff0a35d2eabe0f444f23332949d01

Former-commit-id: c54810fd1a5311bf2caf83560da29a7732f2522d

    • -2
    • +93
    ./Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructureFailureMechanismContextTreeNodeInfoTest.cs
  1. … 3 more files in changeset.
* Made variabletype explicit. * Added xml docs to method to make it clear what it's behavior is. * Added InvalidEnumArgumentException to default sections of switch statements. * Renamed resource (and reused it)

Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6299 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bc454db9c282f8f142b9ddd4e0d6b2f7141a5ef6

Former-commit-id: f83d1d7387f86e9c8cb1edf2cf839799e3180065

    • -186
    • +174
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  1. … 14 more files in changeset.
First implementation of StabilityPointStructuresCalculationActivity Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6295 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 43daa6f6b856d02e18701e5ec17b170c4d0fd5f1

Former-commit-id: 22b7edf202080596d30cb76742ae96e84db4372d

    • -1
    • +2
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationActivityTest.cs
  1. … 4 more files in changeset.
* Made type explicit or more concrete. * Reformatted code to improve readability and better adherence to code-conventions. Related to Issue [WTI-596]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6287 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b843544708d2da78f91008dbddb0c9bc748e51cb

Former-commit-id: a132052d0d6e775430eca5ca1ccaa8c2730ec7fb

    • -14
    • +14
    ./Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  1. … 4 more files in changeset.
Extended StabilityPointStructuresInputContextPropertiesTest Related to Issue [WTI-570]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6282 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1d9c771f4c6fc2358f2fb84873505730630ae982

Former-commit-id: a5826dbec60eab1b59aa752032cdfe0ce5835775

    • -12
    • +2
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  1. … 2 more files in changeset.
Overall improvement: - Simplified all integration tests fr activity: have 1 test with invalid input and at least 1 tests with valid input. All the tests with invalid cases are already tested in the corresponding lower level service tests and are not necessary in the higher level integration tests

Made grass cover erosion inwards validation procedure consistent with other calculation tracks:

- Removed obsolete hydraulic boundary database check

- If the connection with the hydraulic boundary database becomes invalid, no further validation will be performed

- If the connection remains valid, the hydraulic boundary location will be checked

Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6271 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 24a88dbec5699e1462bef4e9eadfa48d4274d87b

Former-commit-id: b4502f1c90d99960abb201ded6965455f8a8bcb3

    • -49
    • +5
    ./Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
  1. … 6 more files in changeset.
Implemented improvements of review 1143. Related to Issue [WTI-594]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6268 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 421edd42003bb6a398baba98b51e8d0127174d67

Former-commit-id: 0bd25a60e86104fef7664e113a09f8fce1995d6b

    • -1
    • +0
    ./Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
    • -12
    • +1
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
  1. … 30 more files in changeset.
Fix error. Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6260 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 41a272a198e6cbbc472177e9c7731927b8e2efda

Former-commit-id: 9f1510fd6b6fa17fd7288b6a016a174b3e40266b

    • -1
    • +1
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
- Introduced AssessmentSectionHelper to create assessment section stubs. - Introduced service for stability point structures. - Introduced test calculation for stability point structures. Related to Issue [WTI-568]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6259 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 341b4d67f97ea9ff66407a2f408577674c7c948d

Former-commit-id: f2f1c210714d43fbde39a88be94cd95599efd5b7

    • -31
    • +13
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
    • -0
    • +4
    ./Ringtoets.ClosingStructures.Service.Test/Ringtoets.ClosingStructures.Service.Test.csproj
  1. … 18 more files in changeset.
Implement validation: - Added validation for the flooded culvert calculations Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6257 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b06381fe2f4d7951d2e79f2a9cd51192c1af9274

Former-commit-id: 2c11dfa81411bf8f924cd9872d30244715f7d6c9

    • -3
    • +60
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  1. … 1 more file in changeset.
Implement validation: - Added validation for the inputs that are required for a low sill calculation - Simplified tests: introduced a method that sets all the input parameters of the calculation object to invalid values - Added documentation Related to Issue [WTI-926]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6250 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7bd5a770ac99355474ab8d75af6ffc088944770e

Former-commit-id: 69a68ed124717f26cb8c6538a40a84f57f927188

    • -52
    • +124
    ./Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
  1. … 1 more file in changeset.
Added some final tests Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6247 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2e68a7ec420938a47fa181d4fda1290ef54e1c1d

Former-commit-id: c5690edeefdfc97655173da0f532e3592bf488c6

    • -0
    • +34
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  1. … 1 more file in changeset.
Extended ClosingStructuresInputContextPropertiesTest Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6235 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9e35ae9e70dabb766466de039ee2ece71509e749

Former-commit-id: f530372317a69f4e2462197bb07ae48dc132618b

    • -0
    • +275
    ./Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
  1. … 1 more file in changeset.