Riskeer / Ringtoets

ClosingStructures

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 22 Feb 2018
2:33 pm

Carlos Lubbers

Review related improvements. Add xmldocs, remove unneeded null checks in containers and added tests to some detailed assessment extensions WTI-1616

Options
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
  2. … 16 more files in changeset.
1:05 pm

Carlos Lubbers

Cleanup files WTI-1616

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +0
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
  3. … 10 more files in changeset.
12:54 pm

Carlos Lubbers

Review related changes. Improve calculator/factories and their tests. WTI-1616

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultDetailedAssessmentExtensions.cs
    • -37
    • +20
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
  4. … 28 more files in changeset.
Wednesday 21 Feb 2018
3:26 pm

Elmar Kleijn

Adapted tests. WTI-1563

Options
    • -4
    • +11
    ./test/Ringtoets.ClosingStructures.Forms.Test/PresentationObjects/ClosingStructuresCalculationGroupContextTest.cs
  2. … 6 more files in changeset.
3:01 pm

Elmar Kleijn

Improved GetHashCode implementations of all CalculationGroupContext implementations. WTI-1563

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/PresentationObjects/ClosingStructuresCalculationGroupContext.cs
  2. … 7 more files in changeset.
2:47 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2503: - Cleaned up unused references in ClosingStructures - Rewrote treenodeinfo test to be in line with other comparable tests.

WTI-1621

Options
    • -2
    • +7
    ./src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -1
    • +0
    ./src/Ringtoets.ClosingStructures.IO/Configurations/ClosingStructuresCalculationConfigurationImporter.cs
    • -5
    • +0
    ./src/Ringtoets.ClosingStructures.IO/Ringtoets.ClosingStructures.IO.csproj
    • -3
    • +0
    ./src/Ringtoets.ClosingStructures.Plugin/FileImporters/ClosingStructureReplaceDataStrategy.cs
    • -2
    • +0
    ./src/Ringtoets.ClosingStructures.Plugin/FileImporters/ClosingStructureUpdateDataStrategy.cs
    • -5
    • +0
    ./src/Ringtoets.ClosingStructures.Plugin/Ringtoets.ClosingStructures.Plugin.csproj
    • -1
    • +0
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -4
    • +0
    ./test/Ringtoets.ClosingStructures.Plugin.Test/Ringtoets.ClosingStructures.Plugin.Test.csproj
    • -58
    • +46
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresProbabilityFailureMechanismSectionResultContextTreeNodeInfoTest.cs
2:08 pm

Carlos Lubbers

Review related changes. Use data model instead of cell value when checking for read-onlyness WTI-1617

Options
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 21 more files in changeset.
Tuesday 20 Feb 2018
3:52 pm

Dennis Tang <dennis.tang@deltares.nl>

Final cleanup: - Removed every notion of AssessmentLayerOne from Structures, except for .Data - Removed obsolete tests in: -- Common.Forms: AssessmentLayerOne is implemented specifically --- Common.Data: autoproperty tests should not be implemented

WTI-1621

Options
    • -4
    • +4
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  2. … 5 more files in changeset.
3:07 pm

Carlos Lubbers

Review related changes, rename resources and cleanup WTI-1617

Options
    • -3
    • +3
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 22 more files in changeset.
2:53 pm

Carlos Lubbers

Review related changes, renamed HasPassedSimpleAssessment and used test failuremechanism instead of simple failure mechanism WTI-1617

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 20 more files in changeset.
2:45 pm

Carlos Lubbers

Review related changes, update xmldoc and fix tests WTI-1617

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
    • -6
    • +3
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  3. … 18 more files in changeset.
2:29 pm

Carlos Lubbers

Update methods to create test views for gekb and structures WTI-1617

Options
    • -23
    • +12
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  2. … 3 more files in changeset.
2:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed compilation errors: - Mergetool did not work for every file - Fixed failing tests

WTI-1621

Options
    • -18
    • +17
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -6
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
  3. … 4 more files in changeset.
2:02 pm

Carlos Lubbers

Move inheritdoc tag and use helper method for dune erosion result view WTI-1617

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 17 more files in changeset.
1:15 pm

Carlos Lubbers

Review related improvements. Introduce new and use test factory, update test names WTI-1617

Options
    • -42
    • +21
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
  2. … 25 more files in changeset.
10:04 am

Dennis Tang <dennis.tang@deltares.nl>

Implemented SimpleAssessmentResult type for Closing and Height structures: - Adjusted row object - Adjusted view logic to respond on changes of type SimpleAssessmentResultValidityOnly

WTI-1621

Options
    • -15
    • +10
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -5
    • +5
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -0
    • +4
    ./test/Ringtoets.ClosingStructures.Forms.Test/Ringtoets.ClosingStructures.Forms.Test.csproj
    • -57
    • +146
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -6
    • +10
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
  6. … 7 more files in changeset.
Monday 19 Feb 2018
3:55 pm

Carlos Lubbers

Implement review comments. Update xmldoc and use test factory in failure mechanism tests WTI-1617

Options
    • -4
    • +5
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
  2. … 19 more files in changeset.
3:04 pm

Carlos Lubbers

Review related changes. Improve assembly factory formatting. WTI-1620

Options
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
  2. … 6 more files in changeset.
2:50 pm

Carlos Lubbers

Review related changes. Improve formatting of factories WTI-1620

Options
    • -8
    • +12
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
  2. … 9 more files in changeset.
2:12 pm

Carlos Lubbers

Review related changes. Rename AssemblyFactoryException -> AssemblyException WTI-1620

Options
    • -4
    • +4
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -4
    • +4
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
  3. … 42 more files in changeset.
1:57 pm

Carlos Lubbers

Review related changes, update test names for assembly factory methods WTI-1620

Options
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
  2. … 17 more files in changeset.
1:55 pm

Carlos Lubbers

Review related changes, update XMLDoc for assembly factory methods WTI-1620

Options
    • -4
    • +4
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
  2. … 17 more files in changeset.
1:51 pm

Carlos Lubbers

Review related changes, update XMLDoc for assembly factories WTI-1620

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
  2. … 17 more files in changeset.
10:48 am

Carlos Lubbers

Rename detailed assessment extension classes and tests WTI-1616

Options
    • -73
    • +0
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionDetailedAssessmentResultExtensions.cs
    • -0
    • +73
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultDetailedAssessmentExtensions.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -161
    • +0
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionDetailedAssessmentResultExtensionsTest.cs
    • -0
    • +161
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
  7. … 30 more files in changeset.
Saturday 17 Feb 2018
1:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed generic StructuresFailureMechanismSectionResult --> All failure mechanisms have dedicated implementations - Updated XMLDocs

WTI-1621

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
  2. … 8 more files in changeset.
Friday 16 Feb 2018
4:12 pm

Carlos Lubbers

Implement detailed assessment factory methods for closing structures WTI-1616

Options
    • -74
    • +0
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSection2aAssessmentResultExtensions.cs
    • -0
    • +73
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionDetailedAssessmentResultExtensions.cs
    • -0
    • +54
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -6
    • +6
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -4
    • +4
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -161
    • +0
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSection2aAssessmentResultExtensionsTest.cs
    • -0
    • +161
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionDetailedAssessmentResultExtensionsTest.cs
    • -0
    • +181
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
    • -28
    • +28
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -11
    • +11
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
3:33 pm

Carlos Lubbers

Rename AssessmentLayerTwoA -> DetailedAssessmentProbability WTI-1616

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 17 more files in changeset.
1:15 pm

Dennis Tang <dennis.tang@deltares.nl>

- Cleaned up tests that only depend on the coordinates --> use the testfactory to create FailureMechanismSections: -- Performed for ClosingStructures.Data - Replaced StructuresFailureMechanismSectionResult<ClosingStructuresInput> from the Integration.Plugin with the specific implementation.

WTI-1621

Options
    • -6
    • +4
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
  2. … 1 more file in changeset.
12:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up tests that only depend on the coordinates --> use the testfactory to create FailureMechanismSections: - Performed for ClosingStructures.Plugin.Test

WTI-1621

Options
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
11:26 am

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up tests that only depend on the coordinates --> use the testfactory to create FailureMechanismSections: - Performed for ClosingStructures

WTI-1621

Options
    • -6
    • +6
    ./test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationImporterTest.cs
    • -7
    • +2
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -6
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -12
    • +10
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs