Riskeer / Ringtoets

ClosingStructures

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 20 Feb 2018
10:04 am

Dennis Tang <dennis.tang@deltares.nl>

Implemented SimpleAssessmentResult type for Closing and Height structures: - Adjusted row object - Adjusted view logic to respond on changes of type SimpleAssessmentResultValidityOnly

WTI-1621

Options
    • -15
    • +10
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -5
    • +5
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -0
    • +4
    ./test/Ringtoets.ClosingStructures.Forms.Test/Ringtoets.ClosingStructures.Forms.Test.csproj
    • -57
    • +146
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -6
    • +10
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
  6. … 7 more files in changeset.
Monday 19 Feb 2018
3:55 pm

Carlos Lubbers

Implement review comments. Update xmldoc and use test factory in failure mechanism tests WTI-1617

Options
    • -4
    • +5
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
  2. … 19 more files in changeset.
3:04 pm

Carlos Lubbers

Review related changes. Improve assembly factory formatting. WTI-1620

Options
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
  2. … 6 more files in changeset.
2:50 pm

Carlos Lubbers

Review related changes. Improve formatting of factories WTI-1620

Options
    • -8
    • +12
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
  2. … 9 more files in changeset.
2:12 pm

Carlos Lubbers

Review related changes. Rename AssemblyFactoryException -> AssemblyException WTI-1620

Options
    • -4
    • +4
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -4
    • +4
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
  3. … 42 more files in changeset.
1:57 pm

Carlos Lubbers

Review related changes, update test names for assembly factory methods WTI-1620

Options
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
  2. … 17 more files in changeset.
1:55 pm

Carlos Lubbers

Review related changes, update XMLDoc for assembly factory methods WTI-1620

Options
    • -4
    • +4
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
  2. … 17 more files in changeset.
1:51 pm

Carlos Lubbers

Review related changes, update XMLDoc for assembly factories WTI-1620

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
  2. … 17 more files in changeset.
10:48 am

Carlos Lubbers

Rename detailed assessment extension classes and tests WTI-1616

Options
    • -73
    • +0
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionDetailedAssessmentResultExtensions.cs
    • -0
    • +73
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultDetailedAssessmentExtensions.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -161
    • +0
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionDetailedAssessmentResultExtensionsTest.cs
    • -0
    • +161
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultDetailedAssessmentExtensionsTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
  7. … 30 more files in changeset.
Saturday 17 Feb 2018
1:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed generic StructuresFailureMechanismSectionResult --> All failure mechanisms have dedicated implementations - Updated XMLDocs

WTI-1621

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
  2. … 8 more files in changeset.
Friday 16 Feb 2018
4:12 pm

Carlos Lubbers

Implement detailed assessment factory methods for closing structures WTI-1616

Options
    • -74
    • +0
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSection2aAssessmentResultExtensions.cs
    • -0
    • +73
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionDetailedAssessmentResultExtensions.cs
    • -0
    • +54
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -6
    • +6
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -4
    • +4
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -161
    • +0
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSection2aAssessmentResultExtensionsTest.cs
    • -0
    • +161
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionDetailedAssessmentResultExtensionsTest.cs
    • -0
    • +181
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
    • -28
    • +28
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -11
    • +11
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
3:33 pm

Carlos Lubbers

Rename AssessmentLayerTwoA -> DetailedAssessmentProbability WTI-1616

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
  2. … 17 more files in changeset.
1:15 pm

Dennis Tang <dennis.tang@deltares.nl>

- Cleaned up tests that only depend on the coordinates --> use the testfactory to create FailureMechanismSections: -- Performed for ClosingStructures.Data - Replaced StructuresFailureMechanismSectionResult<ClosingStructuresInput> from the Integration.Plugin with the specific implementation.

WTI-1621

Options
    • -6
    • +4
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
  2. … 1 more file in changeset.
12:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up tests that only depend on the coordinates --> use the testfactory to create FailureMechanismSections: - Performed for ClosingStructures.Plugin.Test

WTI-1621

Options
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
11:26 am

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up tests that only depend on the coordinates --> use the testfactory to create FailureMechanismSections: - Performed for ClosingStructures

WTI-1621

Options
    • -6
    • +6
    ./test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationImporterTest.cs
    • -7
    • +2
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -6
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -12
    • +10
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
10:48 am

Dennis Tang <dennis.tang@deltares.nl>

Expanded FailureMechanismSectionTestFactory with factory method that constructs a section based on the coordinates alone: - Certain tests are location dependent - Cleaned up the ClosingStructuresHelperTest

WTI-1621

Options
    • -27
    • +24
    ./test/Ringtoets.ClosingStructures.Util.Test/ClosingStructuresHelperTest.cs
    • -0
    • +4
    ./test/Ringtoets.ClosingStructures.Util.Test/Ringtoets.ClosingStructures.Util.Test.csproj
  3. … 2 more files in changeset.
Thursday 15 Feb 2018
3:42 pm

Dennis Tang <dennis.tang@deltares.nl>

Final cleanup of StructuresFailureMechanismSectionResult<T> implementations for ClosingStructures: - Adjusted TreeNodeInfo and Plugin

WTI-1621

Options
    • -2
    • +1
    ./src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -2
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/ClosingStructuresPluginTest.cs
    • -5
    • +4
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresProbabilityFailureMechanismSectionResultContextTreeNodeInfoTest.cs
2:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed mirror property SectionResults2 for ClosingStructures: - Replaced the old generic SectionResults property with the mirror property - Cleaned up XMLDocs

WTI-1621

Options
    • -1
    • +0
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanism.cs
  2. … 1 more file in changeset.
1:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed mirror property SectionResults2: - Replaced the old generic SectionResults property with the mirror property - Cleaned up test

WTI-1621

Options
    • -4
    • +0
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
1:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed mirror property SectionResults2: - Replaced the old generic SectionResults property with the mirror property

WTI-1621

Options
    • -17
    • +6
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanism.cs
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresScenariosView.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Util/ClosingStructuresHelper.cs
    • -7
    • +6
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
    • -4
    • +4
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationImporterTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -4
    • +4
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -11
    • +11
    ./test/Ringtoets.ClosingStructures.Plugin.Test/ViewInfos/ClosingStructuresFailureMechanismResultViewInfoTest.cs
    • -9
    • +8
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
  16. … 6 more files in changeset.
1:43 pm

Dennis Tang <dennis.tang@deltares.nl>

Simplified ClosingStructuresHelper: - Accepts a ClosingStructuresFailureMechanism now it is a dedicated implementation - Removed obsolete function arguments

WTI-1621

Options
    • -2
    • +1
    ./src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -3
    • +1
    ./src/Ringtoets.ClosingStructures.IO/Configurations/ClosingStructuresCalculationConfigurationImporter.cs
    • -9
    • +3
    ./src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -3
    • +1
    ./src/Ringtoets.ClosingStructures.Plugin/FileImporters/ClosingStructureUpdateDataStrategy.cs
    • -12
    • +7
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
    • -58
    • +21
    ./src/Ringtoets.ClosingStructures.Util/ClosingStructuresHelper.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
    • -93
    • +23
    ./test/Ringtoets.ClosingStructures.Util.Test/ClosingStructuresHelperTest.cs
12:56 pm

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic RingtoetsCommonDataSynchronization service implementation into specific (ClosingStructure) implementation: - Corrected calls in the corresponding Replace- and UpdateDataStrategies - Adjusted tests

WTI-1621

Options
    • -4
    • +2
    ./src/Ringtoets.ClosingStructures.Plugin/FileImporters/ClosingStructureReplaceDataStrategy.cs
    • -7
    • +5
    ./src/Ringtoets.ClosingStructures.Plugin/FileImporters/ClosingStructureUpdateDataStrategy.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -10
    • +7
    ./test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
10:56 am

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic RingtoetsCommonDataSynchronization service implementation into specific (ClosingStructure) implementation: - Performed for the RemoveAllStructures method

WTI-1621

Options
    • -0
    • +33
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
    • -0
    • +111
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
10:43 am

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic RingtoetsCommonDataSynchronization service implementation into specific (ClosingStructure) implementation: - Performed for the RemoveStructure method

WTI-1621

Options
    • -0
    • +64
    ./src/Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.Service/Ringtoets.ClosingStructures.Service.csproj
    • -0
    • +125
    ./test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
9:48 am

Carlos Lubbers

Rename SimpleAssessmentInput->SimpleAssessmentResult WTI-1617

Options
    • -2
    • +2
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +2
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultTest.cs
Wednesday 14 Feb 2018
5:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Merge branch 'master' of https://github.com/Deltares/Riskeer

# Conflicts:

# Application/Ringtoets/src/Application.Ringtoets.Setup/Licentie.rtf

# Ringtoets.sln

# Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs

Options
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.Forms/Ringtoets.ClosingStructures.Forms.csproj
    • -4
    • +11
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -0
    • +17
    ./src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -0
    • +31
    ./test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
  5. … 2 more files in changeset.
4:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic StructuresHelper implementation into specific (ClosingStructure) implementation: - Replaced StructuresHelperCall with the specific ClosingStructure helper implementation -- Except for the UpdateDataStrategy

WTI-1621

Options
    • -2
    • +3
    ./src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.Forms/Ringtoets.ClosingStructures.Forms.csproj
    • -2
    • +3
    ./src/Ringtoets.ClosingStructures.IO/Configurations/ClosingStructuresCalculationConfigurationImporter.cs
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.IO/Ringtoets.ClosingStructures.IO.csproj
    • -6
    • +7
    ./src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -0
    • +5
    ./src/Ringtoets.ClosingStructures.Plugin/Ringtoets.ClosingStructures.Plugin.csproj
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationImporterTest.cs
    • -0
    • +4
    ./test/Ringtoets.ClosingStructures.Plugin.Test/Ringtoets.ClosingStructures.Plugin.Test.csproj
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
4:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic StructuresHelper implementation into specific (ClosingStructure) implementation

WTI-1621

Options
    • -0
    • +124
    ./src/Ringtoets.ClosingStructures.Util/ClosingStructuresHelper.cs
    • -0
    • +23
    ./src/Ringtoets.ClosingStructures.Util/Ringtoets.ClosingStructures.Util.csproj
    • -0
    • +187
    ./test/Ringtoets.ClosingStructures.Util.Test/ClosingStructuresHelperTest.cs
    • -0
    • +31
    ./test/Ringtoets.ClosingStructures.Util.Test/Ringtoets.ClosingStructures.Util.Test.csproj
    • -0
    • +26
    ./test/Ringtoets.ClosingStructures.Util.Test/packages.config
2:19 pm

Elmar Kleijn

Review related changes

WTI-1531

Options
    • -1
    • +1
    ./src/Ringtoets.ClosingStructures.Data/GeneralClosingStructuresInput.cs
    • -1
    • +1
    ./test/Ringtoets.ClosingStructures.Plugin.Test/PropertyInfos/ClosingStructuresFailureMechanismContextPropertyInfoTest.cs
  3. … 12 more files in changeset.
2:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced Util project for closing structures: - Required to separate the generic StructuresHelper implementation into specific (ClosingStructure) implementation

WTI-1621

Options
    • -0
    • +25
    ./src/Ringtoets.ClosingStructures.Util/Properties/AssemblyInfo.cs
    • -0
    • +21
    ./src/Ringtoets.ClosingStructures.Util/Ringtoets.ClosingStructures.Util.csproj
    • -0
    • +25
    ./test/Ringtoets.ClosingStructures.Util.Test/Properties/AssemblyInfo.cs
    • -0
    • +21
    ./test/Ringtoets.ClosingStructures.Util.Test/Ringtoets.ClosingStructures.Util.Test.csproj
  5. … 2 more files in changeset.