Riskeer / Ringtoets / Common / src / Ringtoets.Common.Service

Structures

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 06 Dec 2017
3:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged revision(s) 13255 from branches/Release/17_3

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@13256 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3c9a8aca35b20a4d5b3c22a06e8d34cc5399b7db

Former-commit-id: a7cde6e4dca0b18140a7a7bbdc199d95378e7b88

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 20 more files in changeset.
3:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2370: - Renamed function and updated XMLDoc - Added testcases for the validator

Paired with tangerma

Related to Issue [WTI-1476]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/17_3@13255 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f6450f4c82f425a480c26c7158364e882c0cb411

Former-commit-id: dba529ec421c60ef4bc7bcd3aed6968eb87b0e61

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 20 more files in changeset.
8:51 am

Robert Tangerman <robert.tangerman@deltares.nl>

Merged revision(s) 13197-13218 from branches/Release/17_3

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@13222 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c22f810ca624b873068a9057fcbeebe89831745d

Former-commit-id: 7f4751048a797df995b4526ec8a1f1582fb80c73

Options
    • -2
    • +4
    ./StructuresCalculationServiceBase.cs
  2. … 25 more files in changeset.
Tuesday 05 Dec 2017
3:13 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Used validator in the HydraulicBoundaryDatabaseHelper. Related to Issue [WTI-1476]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Release/17_3@13207 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5a46eace95e285253c717eb1b72b30da247a7844

Former-commit-id: 8a9c243bfc7ffecaf4c7025952b7ef7d64304b9b

Options
    • -2
    • +4
    ./StructuresCalculationServiceBase.cs
  2. … 14 more files in changeset.
Friday 10 Nov 2017
10:39 am

Elmar Kleijn

Merged revision(s) from branches/1444

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12811 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cf752322c5967ec6824f11c711b243f30bf67f0e

Former-commit-id: 9753484fe13d42b8eb5a3c526c4d37f40ca70446

Options
    • -9
    • +25
    ./StructuresCalculationServiceBase.cs
  2. … 245 more files in changeset.
Wednesday 08 Nov 2017
8:26 am

Robert Tangerman <robert.tangerman@deltares.nl>

Set the use preprocessor flag from within the calculation services. Related to Issue [WTI-1476]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12754 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 44f408a17fa5b1fd23da81601ab2da099cf7611b

Former-commit-id: deae48a0d2417ca39e75ed03258d54657f03dba5

Options
    • -2
    • +4
    ./StructuresCalculationServiceBase.cs
  2. … 25 more files in changeset.
Tuesday 07 Nov 2017
6:00 pm

Elmar Kleijn

Unified validation logic Related to Issue [WTI-1477]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12737 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8112e7eaa1bb098fb10fed24c1c6a9b21b9fc2ba

Former-commit-id: 79b8e6b1b920917e14c03b9c10caa8146287a960

Options
    • -7
    • +10
    ./StructuresCalculationServiceBase.cs
  2. … 2 more files in changeset.
2:55 pm

Elmar Kleijn

Extended validation in StructuresCalculationServiceBase Related to Issue [WTI-1477]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12722 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 952457531ccfa1040b4bc20557d4e8b970eacef8

Former-commit-id: bb2f8ecd7535b11457db131f8def59e1d647c7ec

Options
    • -0
    • +8
    ./StructuresCalculationServiceBase.cs
  2. … 3 more files in changeset.
6:57 am

Elmar Kleijn

HydraulicDatabaseHelper => HydraulicBoundaryDatabaseHelper Related to Issue [WTI-1477]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12674 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 18a4e05e6fca5f6e9cf54aa1fd0b83ed772f426a

Former-commit-id: 20ae49907ebc92642adf234b8ccd1c7f7277399f

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 23 more files in changeset.
Friday 03 Nov 2017
2:36 pm

Elmar Kleijn

Extended StructuresCalculationServiceBase Related to Issue [WTI-1477]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12605 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2cfabda0085d353d0e76250ce2a3ea443d993ce1

Former-commit-id: 59b8e6120a84c3462e1591f4841742808e58d80b

Options
    • -4
    • +7
    ./StructuresCalculationServiceBase.cs
  2. … 1 more file in changeset.
Thursday 02 Nov 2017
9:52 pm

Elmar Kleijn

Made Hydra-Ring wrapper preprocessor ready Related to Issue [WTI-1444]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12571 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7369ac6d7f05feac0add28cdd0f2274614d5865f

Former-commit-id: 6ca45261807516ee79db54deaee5010a2e346b70

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 125 more files in changeset.
9:42 pm

Elmar Kleijn

Reverted some changes

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12570 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bf5508218b9c8ba780b0123523bd7c559bf51b1c

Former-commit-id: 2121e3718b2c9bce0aa1bf88e6044a618fc4a5e6

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 125 more files in changeset.
1:29 pm

Elmar Kleijn

Fixed compilation failures

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12563 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a64dd3fa6b52e48204ab4bed16d5d4d0aaac0903

Former-commit-id: d377dc837539347f9d73463b7b3225c7057a479b

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 54 more files in changeset.
Wednesday 11 Oct 2017
1:16 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Changed the API for CalculationServiceHelper and removed all "Validatie mislukt/waarschuwing" prefixes in log messages. Related to Issue [WTI-1296]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12115 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 03e8800a28f0230a4342b35d452bac2b01da444a

Former-commit-id: 33baf7e0be14ef789b5108e7167d78dce4ae2a59

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 39 more files in changeset.
Friday 06 Oct 2017
11:26 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments, simplify calculation service tests and improve logging messages Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12039 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 103dc1fa4f8c5ee91ba04ceac3b851a2b31ce24c

Former-commit-id: bac9d51986c9579366a4bb55172ac1a7576a345d

Options
    • -5
    • +6
    ./StructuresCalculationServiceBase.cs
  2. … 8 more files in changeset.
10:04 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments, update XMLDocs, improve tests, move some values of resources and improve their names. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12037 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 21483bef12f061dd693853d6e33a8aefedfda574

Former-commit-id: 6a3f33b230f7364d277d7045a995e94a9540b0d6

Options
    • -1
    • +3
    ./StructuresCalculationServiceBase.cs
  2. … 22 more files in changeset.
Friday 29 Sep 2017
11:29 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Change error log to warning and change text. Remove groupby call from AnyNonDistinct. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11950 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 662e9d82dfe0817a67d821e7784be330adc47eff

Former-commit-id: d2d886b12d819750c93a66f77a090466fbf69658

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 18 more files in changeset.
Thursday 28 Sep 2017
2:09 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement validation in structures, waveheight and designwaterlevel calculation with corresponding tests. Improve GeneralResult validation with stochast check for toplevel submechanism points. Adapt old tests so they will pass. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11940 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7c5475baca39b2e50fd92cffcd066cb90035b84d

Former-commit-id: 7371f7aa9c2fe4da40051f708686731a7b20ad61

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 12 more files in changeset.
9:02 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement validation in the data model, add tests to data model and started adding tests to calculator services. Old tests have been adapted to create valid generalresult/faulttrees so they won't throw exceptions when creating them. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11925 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 50fbd65dee53f455a510032c25787207ef0332d9

Former-commit-id: 89df2cfd12e7ddc527716a82d3325da29e8bfaef

Options
    • -4
    • +12
    ./StructuresCalculationServiceBase.cs
  2. … 39 more files in changeset.
Wednesday 02 Aug 2017
10:09 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated refactoring comments regarding the SetGeneralResult function and constructor arguments for Structures: - Removed SetGeneralResult function - Preparation for removing the constructor without GeneralResult

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10973 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4ff595cc45ef3da259be523660cb018058c8e23b

Former-commit-id: 478f3d8d407b0da1a72aca9e87fb958f50166390

Options
    • -16
    • +14
    ./StructuresCalculationServiceBase.cs
  2. … 8 more files in changeset.
Thursday 27 Jul 2017
11:09 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement comments from review 1981: - Rename tests and references from IllustrationPoints to GeneralResult - Removed some excessive calls in tests - Added/improved some asserts Related to Issue [WTI-1318]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10894 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4d96ac129eec8de3d7aa5bdd68051a3a50c24693

Former-commit-id: 495106ec1ae86e970f28d4fa9348c1d3885979d6

Options
    • -3
    • +3
    ./StructuresCalculationServiceBase.cs
  2. … 16 more files in changeset.
Tuesday 25 Jul 2017
4:37 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments 1970: - Refactor HasIllustrationPoints and SetIllustrationPoints to HasGeneralResult and SetGeneralResult - ProbabilityAssessmentOutput in GrassCoverErosionInwardsOvertoppingOutput cannot be null - Improve tests for services and output objects - Move Resources to Common - Correct implementation of IllustrationPointsParserErrorMessage - Made ConvertIllustrationPointsResult private Related to Issue [WTI-1318]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10867 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 26b18ecde3707516f72159c322b00f31c74271a9

Former-commit-id: 693f5a23203efef71b2a492062c80e2d8e3202e3

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 56 more files in changeset.
Monday 24 Jul 2017
1:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1959: Relevant comments for Converters - Renamed Create methods to Convert

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10841 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5e0b94a85615f02a7c19028830441a8616e1a88a

Former-commit-id: f46ac23151fc772d5a60dc227ed4f6d222a60ce5

Options
    • -1
    • +1
    ./StructuresCalculationServiceBase.cs
  2. … 23 more files in changeset.
10:37 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1959: Relevant comments for services - Extracted functions - Simplified tests by inlining variables

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10834 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a75ec12cf186a5719eaee92aec98e379e9a12609

Former-commit-id: 7bada798fc2e240edb3ff611fe6057f18a08aade

Options
    • -45
    • +77
    ./StructuresCalculationServiceBase.cs
  2. … 3 more files in changeset.
Thursday 20 Jul 2017
11:15 am

Dennis Tang <dennis.tang@deltares.nl>

Improved illustration points parsing logic - In case an exception occurs in the parser, set the message instead of logging. Logging will always occur regardless of whether the user selected "ShouldIllustrationPointsBeCalculated" - Cleaned up tests - Adjusted the Structures calculation services with the following logic: -- In case illustrationPoints are calculated and there is an error --> log the error as a warning -- In case illustrationPoints are not calculated and there is an error --> do not log the error

Related to Issue [WTI-1354]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10782 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4e6c6ebda34a8e1580c4b81302c7e43ccc9c4d30

Former-commit-id: 6cbf649ac3ac402b2a4719c29a4760751646b747

Options
    • -12
    • +15
    ./StructuresCalculationServiceBase.cs
  2. … 6 more files in changeset.
Tuesday 18 Jul 2017
10:25 am

Dennis Tang <dennis.tang@deltares.nl>

Reverted error handling logic to the old situation: - Do not log exception - Make difference between the situation with and without a last error file content Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10743 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 79a579b6ded4e87561b98beb73daf7f1633c5e4b

Former-commit-id: 185cd61d1f28e40436fe2ac0472f0af5d85d4f44

Options
    • -2
    • +2
    ./StructuresCalculationServiceBase.cs
  2. … 1 more file in changeset.
Monday 17 Jul 2017
3:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Connected the Illustration point outputs with structures: - Introduced test factory for the general result to produce one with SubMechanismIllustrationPoints only - Cleaned up implementations and tests of existing (HBL) services - Moved GeneralResult from the ProbabilityAssessmentOutput to the StructuresOutput, because it should not be part of the ProbabilityAssessmentOutput Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10730 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c7c49b07b1a7f21052e5005afe1854158fd812c6

Former-commit-id: 2df669351e05f07b0265ee10f2f38567e88b76f9

Options
    • -2
    • +38
    ./StructuresCalculationServiceBase.cs
  2. … 13 more files in changeset.
Thursday 13 Jul 2017
2:41 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10683 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f3e2da5e486e49fd7c41a8b4862f9b25ab06212e

Former-commit-id: 9e32d8def96918c22209c7213f3bcf82f3441b2a

Options
    • -7
    • +18
    ./StructuresCalculationServiceBase.cs
  2. … 12 more files in changeset.
Wednesday 12 Jul 2017
3:29 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10664 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1b0aec6a006f082315c3fe347d76687aef6e3d95

Former-commit-id: c74b245e6d8d07774d3f8fb1a6a4482726fbd46c

Options
    • -3
    • +2
    ./StructuresCalculationServiceBase.cs
3:28 pm

Robert Tangerman <robert.tangerman@deltares.nl>

- Moved performing the calculation to the base. - Changed type parameters of base. Related to Issue [WTI-1353]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10663 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4a75417bd348972b9f9f1acbf6e6859ed47a1fbd

Former-commit-id: 220809cd3396870cbb1272378802252605f3fa1b

Options
    • -45
    • +78
    ./StructuresCalculationServiceBase.cs
  2. … 17 more files in changeset.