Riskeer / Ringtoets / Common / test / Ringtoets.Common.Data.Test

UpdateDataStrategies

Clone Tools

Stats

Commits this week: 0
Total Committers: 5
Last Commit: 21 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 10 May 2017
10:59 am

Marten Janssen <marten.janssen@deltares.nl>

Updated XMLdocs Updated UpdateDataStrategyBase to validate uniqueness of read collection (as fix for bad smell) Related to Issue [WTI-1172]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9708 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: eaccfa7b5c2a2875357735fc119c4a3512344692

Former-commit-id: 107f4066f18c56cb7f61e38267e4ab1fea80f67a

Options
    • -5
    • +7
    ./UpdateDataStrategyBaseTest.cs
  2. … 7 more files in changeset.
Tuesday 09 May 2017
10:44 am

Dennis Tang <dennis.tang@deltares.nl>

Refactoring of the ReplaceDataStrategyBase: - Removed failureMechanism argument from ClearData() call, as the failureMechanism is already available

Related to Issue [WTI-1113]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9681 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7f5a3f5a4ec957efce2d3be81a6c288f2a49e9d2

Former-commit-id: b9005eed57438334490ed7c795e20f2ff4d3779f

Options
    • -2
    • +2
    ./ReplaceDataStrategyBaseTest.cs
  2. … 6 more files in changeset.
Friday 28 Apr 2017
9:06 am

Robert Tangerman <robert.tangerman@deltares.nl>

Updated license headers in ringtoets common. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9494 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ce33ce275ba930662636e02ef99d91e788db8757

Former-commit-id: 2a4583aeb892e314df72a61727f806c446493577

Options
    • -1
    • +1
    ./ReplaceDataStrategyBaseTest.cs
    • -1
    • +1
    ./UpdateDataStrategyBaseTest.cs
  3. … 550 more files in changeset.
Wednesday 12 Apr 2017
3:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged all revision(s) from branches/UpdateDikeProfilesFeature

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9282 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5f84130acb4bd2113b949015b4049e0c0b5795c4

Former-commit-id: 86ce2960f4b2cd6be35b62d7b6608749e29f1022

Options
    • -7
    • +13
    ./ReplaceDataStrategyBaseTest.cs
    • -2
    • +35
    ./UpdateDataStrategyBaseTest.cs
  3. … 146 more files in changeset.
Monday 20 Mar 2017
4:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments tester: - Readded the collection to be notified when elements are updated -- This is necessary in case the collection comes from a migrated rtd file (FilePath: "Onbekend") and is updated with a file that contains EXACTLY the same items as the collection. This will notify the Collection property info pane and display the new FilePath location -- Added test to verify behaviour

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8871 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 308e4949f23dd0363b891e91eb6a30e158da41c6

Former-commit-id: 2bc99ad86759a204617b92f7890811a7032db637

Options
    • -2
    • +53
    ./UpdateDataStrategyBaseTest.cs
  2. … 3 more files in changeset.
Monday 13 Mar 2017
4:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments tester: - Reverted rev 8750 - Implemented RecursiveObserver suffices for the goal to be achieved, also results in a "more logical approach" -- Instead of notifying the collection, notify the surface line observers instead when only a surface line has changed - Added the newly introduced observers to the Dispose call

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8761 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 22eb1ad4a9ea4a485e680e7ecc84c263ec5c938f

Former-commit-id: 856d65f2e9dfaadb07212cd972b0b9bba593d094

Options
    • -10
    • +3
    ./UpdateDataStrategyBaseTest.cs
  2. … 6 more files in changeset.
12:47 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments tester: - Added the target collection as an affected object when updating the collection. This is to let the piping failure mechanism view update (redraw) when a surface line is updated. The view does not observe the individual lines and therefore didn't redraw when just a line (unassociated with a calculation) was updated Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8750 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b9dcd8b73b42e0211e10654908ec1df441974560

Former-commit-id: 5c52d8d7c155d08609eeae36f365655be0a4da1c

Options
    • -3
    • +10
    ./UpdateDataStrategyBaseTest.cs
  2. … 3 more files in changeset.
Tuesday 28 Feb 2017
12:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1492: - Improved tests of UpdateStrategyBase: -- Introduced two additional properties which keep track of which arguments were used during function calls -- Removed two obsolete tests, assertions of removed tests are added in the functional tests to achieve better functional coverage -- Reintroduced the ItemsToRemove property to assert whether the RemoveObjectAndDependentData pass the right objects to the caller Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8470 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b68f900396707e7cef5bc71858a0a9e0081f620c

Former-commit-id: c93063f126a7003c1650f36bd9eac0a304c063e7

Options
    • -82
    • +103
    ./UpdateDataStrategyBaseTest.cs
Monday 27 Feb 2017
5:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1488: - Improved tests of StrategyBase: -- Replaced the return methods with properties to assert if they're called with the right input arguments -- Renamed several tests - Ran DeltaresClean - Inlined the ValidateItems function in the ObservableUniqueItemCollectionWithSourcePath Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8450 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4ffcec0c1dcd11672904c2b637269d6a80545364

Former-commit-id: eee856fa71a461b074affbe52ed8d0429d4a7333

Options
    • -11
    • +15
    ./ReplaceDataStrategyBaseTest.cs
    • -51
    • +45
    ./UpdateDataStrategyBaseTest.cs
  3. … 3 more files in changeset.
Friday 24 Feb 2017
3:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Generalized Update and Removing data from the concrete UpdateStrategyBase class implementations and moved it to the base class -- Fixed affected tests - Added condition: observers of the target collection should be notified when the items are added or removed from the collection -- Added test to verify behaviour -- Added deepclone method for TestItem Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8419 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b6a7ca74a432a9524fb4e100936403211e8c74e4

Former-commit-id: 78f360a48b04555133c0aac044cb8878e28ccdb4

Options
    • -49
    • +50
    ./UpdateDataStrategyBaseTest.cs
  2. … 5 more files in changeset.
1:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Separated type specific functions from type independent functions in RingtoetsPipingSurfaceLineUpdateDataStrategy - Added missing tests for the UpdateStrategies (base and concrete surface line implementation) - Updated XMLDoc - Improved tests: -- Introduced a deep clone function -- Extracted surface line names to local variables

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8417 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 65de504c56270404f419bc1d959083d05b80e420

Former-commit-id: d81ffd2896c0bdf17f166878684cf4d45d948520

Options
    • -11
    • +182
    ./UpdateDataStrategyBaseTest.cs
  2. … 6 more files in changeset.
Thursday 23 Feb 2017
4:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Updated XMLDoc - Refactored ObservableUniqueItemCollectionWithSourcePath: -- Turned class into an abstract class -- Removed generic TFeature, because explicit knowledge is not needed -- Adjusted inherited classes or classes that make direct use of the ObservableUniqueItemCollectionWithSourcePath

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8411 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 68cb3152a1c682b33bb73740c7d2e1300459cde2

Former-commit-id: 3e983eaebb15fdbe735d2ae5c62aa07d82a65242

Options
    • -24
    • +18
    ./ReplaceDataStrategyBaseTest.cs
    • -23
    • +16
    ./UpdateDataStrategyBaseTest.cs
  3. … 16 more files in changeset.
3:18 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1478: - Adjusted sql script - Added tests for the strategy template classes to assert the correct function arguments are used when the protected functions are called - Updated XMLDocs Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8409 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f4c9ff2c01986c8e24d309d3a1095352ede30c64

Former-commit-id: 668e94b92a17932f62f7583edae32491bec917d1

Options
    • -2
    • +25
    ./ReplaceDataStrategyBaseTest.cs
    • -13
    • +87
    ./UpdateDataStrategyBaseTest.cs
  3. … 8 more files in changeset.
Tuesday 21 Feb 2017
1:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1468: - Refactored the UpdateDataStrategies by introducing a template class UpDataStrategyBase:

Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8358 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d012126ecc4261bcb460eaa1c5fba7ed5bac1a9b

Former-commit-id: d9faa4ce1d1f641bb915a6c1dba082f9f0c79aba

Options
    • -0
    • +266
    ./UpdateDataStrategyBaseTest.cs
  2. … 3 more files in changeset.
Monday 20 Feb 2017
4:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1468: - Optimized performance when removing all stochastic soil models by introducing a RemoveAllStochasticSoilModels function in the PipingDataSynchronizationService - Refactored the ReplaceDataStrategies by introducing a template class ReplaceDataStrategyBase: -- Applied base for RingtoetsPipingSurfaceLineReplaceDataStrategy -- Applied base for StochasticSoilModelReplaceDataStrategy -- Adjusted failing tests Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8335 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cfb50a1b0fa42c951a1b8c89e5595642c6587487

Former-commit-id: 016494966ba082d3ff5f671b9f0e8dc5540e38c7

Options
    • -0
    • +256
    ./ReplaceDataStrategyBaseTest.cs
  2. … 9 more files in changeset.