Riskeer / Ringtoets / Integration / test / Ringtoets.Integration.Forms.Test

Views

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 May 2018
11:20 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2755: - Cleanup testfile of AssemblyResultTotalViewTest: -- Added separate test to check if the cell formatting is correctly handled. A delegate was used to set the expected formatting, if this is not done, the results of the kernel will overwrite the expected cell format result

WTI-1679

Options
    • -1
    • +42
    ./AssemblyResultTotalViewTest.cs
11:01 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2755: - Cleanup testfile of AssemblyResultTotalViewTest: -- Removed integration tests that verify when or if an error should be set after refreshing -- Incorporated editorial comments: view should not have knowledge about the eception handling -- Removed cell style formatting asserts when data is set on rows --> should be done in a separate test

WTI-1679

Options
    • -78
    • +4
    ./AssemblyResultTotalViewTest.cs
10:57 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2755: - Removed resource from the AssemblyResultTotalView and defined button text in the Designer.cs - Removed parametered test helper function in the corresponding test, because the assessment section is not directly used for the asserts (it doesn't matter what values the assessment section has)

WTI-1679

Options
    • -25
    • +20
    ./AssemblyResultTotalViewTest.cs
  2. … 4 more files in changeset.
10:36 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added refresh button and dataGridViewControl to view. WTI-1684

Options
    • -1
    • +31
    ./AssemblyResultPerSectionViewTest.cs
  2. … 4 more files in changeset.
10:33 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2755: - Adjusted accessors for the row objects --> when classes are declared internal, the constructors, methods must be declared as public - Cleaned up tests and code formatting

WTI-1679

Options
    • -1
    • +2
    ./FailureMechanismAssemblyCategoryGroupResultRowTest.cs
    • -3
    • +0
    ./FailureMechanismAssemblyResultRowBaseTest.cs
    • -1
    • +1
    ./FailureMechanismAssemblyResultRowTest.cs
  4. … 3 more files in changeset.
Tuesday 01 May 2018
3:27 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added assessment section to view. WTI-1684

Options
    • -2
    • +22
    ./AssemblyResultPerSectionViewTest.cs
  2. … 1 more file in changeset.
3:05 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Created view for Assembly result per section. WTI-1684

Options
    • -0
    • +45
    ./AssemblyResultPerSectionViewTest.cs
  2. … 4 more files in changeset.
1:18 pm

Carlos Lubbers

Add control to macro outwards view WTI-1678

Options
    • -0
    • +14
    ./SectionResultViews/MacroStabilityOutwardsResultViewTest.cs
  2. … 1 more file in changeset.
1:06 pm

Carlos Lubbers

Add control to standalone failure mechanisms WTI-1678

Options
    • -0
    • +15
    ./SectionResultViews/GrassCoverSlipOffInwardsResultViewTest.cs
    • -0
    • +15
    ./SectionResultViews/GrassCoverSlipOffOutwardsResultViewTest.cs
    • -0
    • +15
    ./SectionResultViews/MicrostabilityResultViewTest.cs
    • -0
    • +15
    ./SectionResultViews/PipingStructureResultViewTest.cs
    • -0
    • +15
    ./SectionResultViews/StrengthStabilityLengthwiseConstructionResultViewTest.cs
    • -0
    • +15
    ./SectionResultViews/TechnicalInnovationResultViewTest.cs
    • -0
    • +15
    ./SectionResultViews/WaterPressureAsphaltCoverResultViewTest.cs
  8. … 7 more files in changeset.
Monday 30 Apr 2018
9:07 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Renamed testhelper --> ColumnStateDefinitions are not exclusively defined for FailureMechanismSectionResultRows<T>, but are a general thing

WTI-1679

Options
    • -3
    • +3
    ./FailureMechanismAssemblyCategoryGroupResultRowTest.cs
    • -5
    • +5
    ./FailureMechanismAssemblyResultRowBaseTest.cs
    • -3
    • +3
    ./FailureMechanismAssemblyResultRowTest.cs
    • -32
    • +32
    ./SectionResultRows/GrassCoverSlipOffInwardsSectionResultRowTest.cs
    • -32
    • +32
    ./SectionResultRows/GrassCoverSlipOffOutwardsSectionResultRowTest.cs
    • -46
    • +46
    ./SectionResultRows/MacroStabilityOutwardsSectionResultRowTest.cs
    • -32
    • +32
    ./SectionResultRows/MicrostabilitySectionResultRowTest.cs
    • -32
    • +32
    ./SectionResultRows/PipingStructureSectionResultRowTest.cs
    • -23
    • +23
    ./SectionResultRows/StrengthStabilityLengthwiseConstructionSectionResultRowTest.cs
    • -23
    • +23
    ./SectionResultRows/TechnicalInnovationSectionResultRowTest.cs
    • -23
    • +23
    ./SectionResultRows/WaterPressureAsphaltCoverSectionResultRowTest.cs
  12. … 13 more files in changeset.
8:51 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Cleaned up tests related to the AssemblyResultTotalView (includes the row tests)

WTI-1679

Options
    • -29
    • +24
    ./AssemblyResultTotalViewTest.cs
    • -2
    • +4
    ./FailureMechanismAssemblyCategoryGroupResultRowTest.cs
    • -2
    • +4
    ./FailureMechanismAssemblyResultRowTest.cs
Thursday 26 Apr 2018
3:49 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced cell format extension methods: - Applied for the FailureMechanismAssemblyResultRow(s) and the view that hosts these.

WTI-1679

Options
    • -0
    • +2
    ./FailureMechanismAssemblyResultRowBaseTest.cs
  2. … 2 more files in changeset.
2:05 pm

Dennis Tang <dennis.tang@deltares.nl>

Added styling handling for the AssemblyResultTotalView: - Cells are formatted based on the DataGridViewCellColumnStateDefinitions defined in the RowObjects

WTI-1679

Options
    • -4
    • +82
    ./AssemblyResultTotalViewTest.cs
  2. … 2 more files in changeset.
11:56 am

Dennis Tang <dennis.tang@deltares.nl>

- Added background colour styling for the FailureMechanismAssemblyResult rows - Added functional tests for the derived classes - Added protected helper method to retrieve the column state definition for the category

WTI-1679

Options
    • -10
    • +26
    ./FailureMechanismAssemblyCategoryGroupResultRowTest.cs
    • -3
    • +82
    ./FailureMechanismAssemblyResultRowBaseTest.cs
    • -10
    • +29
    ./FailureMechanismAssemblyResultRowTest.cs
  4. … 3 more files in changeset.
Wednesday 25 Apr 2018
2:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Connected assembly factories of groups 3 and 4 to the view - Adjusted corresponding ViewInfo test --> add disposable AssemblyToolCalculatorFactoryConfig to prevent calls to the kernel when testing

WTI-1679

Options
    • -16
    • +37
    ./AssemblyResultTotalViewTest.cs
  2. … 2 more files in changeset.
1:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up tests

WTI-1679

Options
    • -16
    • +1
    ./FailureMechanismAssemblyCategoryGroupResultRowTest.cs
    • -1
    • +29
    ./FailureMechanismAssemblyResultRowBaseTest.cs
    • -24
    • +1
    ./FailureMechanismAssemblyResultRowTest.cs
12:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Extracted base class for the failure mechanism assembly result rows: - Failure mechanism assembly result factories for groups 3 and 4 only return a FailureMechanismCategoryGroup - Applied changes to the view

WTI-1679

Options
    • -0
    • +213
    ./FailureMechanismAssemblyCategoryGroupResultRowTest.cs
    • -0
    • +99
    ./FailureMechanismAssemblyResultRowBaseTest.cs
    • -5
    • +5
    ./FailureMechanismAssemblyResultRowTest.cs
  4. … 6 more files in changeset.
11:03 am

Dennis Tang <dennis.tang@deltares.nl>

Connected assembly factories of groups 1 and 2 to the view - Extended tests: added test to verify UpdateLogic on the rows - Extracted private helper function which asserts all the failure mechanism rows - Made the AssertAssemblyRow more generic by using a ProbabilityFormattingHelper

WTI-1679

Options
    • -55
    • +91
    ./AssemblyResultTotalViewTest.cs
10:47 am

Dennis Tang <dennis.tang@deltares.nl>

- Connected assembly factories of groups 1 and 2 to the view - Cleaned up the row

WTI-1679

Options
    • -43
    • +67
    ./AssemblyResultTotalViewTest.cs
  2. … 2 more files in changeset.
8:54 am

Dennis Tang <dennis.tang@deltares.nl>

Added button to the view: - Added minimum size to prevent button from overflowing the button group box, localized the button text - Connected the button to the refresh logic. Note, it's not tested if the rows are refreshed to the right values

WTI-1679

Options
    • -1
    • +35
    ./AssemblyResultTotalViewTest.cs
  2. … 4 more files in changeset.
Tuesday 24 Apr 2018
4:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed exception messages on both category and probability columns: - Functional change: exception should be displayed for only the category column

WTI-1679

Options
    • -14
    • +3
    ./FailureMechanismAssemblyResultRowTest.cs
  2. … 1 more file in changeset.
2:43 pm

Dennis Tang <dennis.tang@deltares.nl>

- Cleaned up testnames - Used a backing field for the rows --> rows will need to be updated (instead of creating new rows) when the control is updated

WTI-1679

Options
    • -2
    • +2
    ./AssemblyResultTotalViewTest.cs
  2. … 1 more file in changeset.
1:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Added error handling logic in the row: - Columnstates are set accordingly in case an exception occurs when executing the delegate - Default values for both the category group and probability are set

WTI-1679

Options
    • -0
    • +117
    ./FailureMechanismAssemblyResultRowTest.cs
  2. … 1 more file in changeset.
12:53 pm

Dennis Tang <dennis.tang@deltares.nl>

Added column state definitions to the row in order to format the cells based on category and handle exceptions in case they occur.

WTI-1679

Options
    • -0
    • +11
    ./FailureMechanismAssemblyResultRowTest.cs
  2. … 1 more file in changeset.
11:58 am

Dennis Tang <dennis.tang@deltares.nl>

Added columns to the view to display the category group and the probability of the assembly result of a failure mechanism.

WTI-1679

Options
    • -1
    • +9
    ./AssemblyResultTotalViewTest.cs
    • -2
    • +2
    ./FailureMechanismAssemblyResultRowTest.cs
  3. … 2 more files in changeset.
11:51 am

Dennis Tang <dennis.tang@deltares.nl>

Added function to retrieve the failure mechanism assembly to the row: - Function was used, as each failure mechanism has its own dedicated factory that determines how the assembly is calculated.

WTI-1679

Options
    • -2
    • +39
    ./FailureMechanismAssemblyResultRowTest.cs
  2. … 2 more files in changeset.
11:25 am

Dennis Tang <dennis.tang@deltares.nl>

Extracted failure mechanisms and inserting rows manually in the view instead of dynamically resolving them: - Performed due to each failure mechanism having its own factory which determines the assembly result

WTI-1679

Options
    • -14
    • +90
    ./AssemblyResultTotalViewTest.cs
  2. … 3 more files in changeset.
9:06 am

Dennis Tang <dennis.tang@deltares.nl>

Connected the AssemblyResultTotalView to the Ringtoetsplugin: - Added AssessmentSection auto property on the view --> necessary to determine when the view should be closed

WTI-1679

Options
    • -0
    • +1
    ./AssemblyResultTotalViewTest.cs
  2. … 5 more files in changeset.
Monday 23 Apr 2018
4:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Renamed view: - View represents mainly the assembly total results (on assessment section level)

WTI-1679

Options
    • -0
    • +138
    ./AssemblyResultTotalViewTest.cs
    • -137
    • +0
    ./AssessmentSectionCombinedAssemblyResultViewTest.cs
  3. … 8 more files in changeset.
4:36 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced failure mechanism assembly result rows in the view: - Create a row for each failure mechanism that is present in the AssessmentSection

WTI-1679

Options
    • -1
    • +19
    ./AssessmentSectionCombinedAssemblyResultViewTest.cs
  2. … 1 more file in changeset.