Riskeer / Ringtoets / MacroStabilityInwards

src

Clone Tools

Stats

Commits this week: 0
Total Committers: 6
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 28 Feb 2018
4:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2518: - Improved tests - Renamed functions and updated XMLDocs Related to Issue [WTI-1592]

Options
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSection2aAssessmentResultExtensions.cs
    • -2
    • +2
    ./Ringtoets.MacroStabilityInwards.Data/SoilProfile/MacroStabilityInwardsStochasticSoilModelExtensions.cs
    • -4
    • +4
    ./Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataPointsFactory.cs
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsCalculationsView.cs
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsScenariosView.cs
    • -2
    • +2
    ./Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
  7. … 15 more files in changeset.
9:13 am

Carlos Lubbers

Update more resource names and methods WTI-1627

Options
    • -2
    • +2
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  2. … 21 more files in changeset.
Tuesday 27 Feb 2018
2:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented fix for no validation messages when the soil layer bottom lies on the surface line, but the top does not: - Renamed variable names

Related to Issue [WTI-1593]

Options
    • -7
    • +7
    ./Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
2:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.2: Implemented fix for no validation messages when the soil layer bottom lies on the surface line, but the top does not: - Renamed variable names

Related to Issue [WTI-1593]

Options
    • -7
    • +7
    ./Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
2:27 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.3: Implemented fix for no validation messages when the soil layer bottom lies on the surface line, but the top does not: - Renamed variable names

Related to Issue [WTI-1593]

Options
    • -7
    • +7
    ./Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
2:25 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented fix for no validation messages when the soil layer bottom lies on the surface line, but the top does not: - Changed validation: take the maximum Y coordinate for each X coordinate and compare these with the surface line instead of determining if there's any layer on the surface line

Related to Issue [WTI-1593]

Options
    • -8
    • +37
    ./Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
2:25 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.2: Implemented fix for no validation messages when the soil layer bottom lies on the surface line, but the top does not: - Changed validation: take the maximum Y coordinate for each X coordinate and compare these with the surface line instead of determining if there's any layer on the surface line

Related to Issue [WTI-1593]

Options
    • -8
    • +37
    ./Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
2:25 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.3: Implemented fix for no validation messages when the soil layer bottom lies on the surface line, but the top does not: - Changed validation: take the maximum Y coordinate for each X coordinate and compare these with the surface line instead of determining if there's any layer on the surface line

Related to Issue [WTI-1593]

Options
    • -8
    • +32
    ./Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
  2. … 1 more file in changeset.
Monday 26 Feb 2018
3:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented fix for erroneous validation messages when the soil layer has its start- and end point defined on one side of the surfaceline: - Added function in Math2D to convert line points to segments with one added segment to close the gap between start- and end point - Added testcases for the validator Related to Issue [WTI-1592]

Options
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
  2. … 3 more files in changeset.
3:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from 17.3 release:

Implemented fix for erroneous validation messages when the soil layer has its start- and end point defined on one side of the surfaceline:

- Added function in Math2D to convert line points to segments with one added segment to close the gap between start- and end point

- Added testcases for the validator

Related to Issue [WTI-1592]

Options
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
  2. … 3 more files in changeset.
3:54 pm

Dennis Tang <dennis.tang@deltares.nl>

Merged from release 17.2:

Implemented fix for erroneous validation messages when the soil layer has its start- and end point defined on one side of the surfaceline:

- Added function in Math2D to convert line points to segments with one added segment to close the gap between start- and end point

- Added testcases for the validator

Related to Issue [WTI-1592]

Options
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputValidator.cs
  2. … 3 more files in changeset.
9:19 am

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced method to bind events after loading view instead of in constructor. WTI-1627

Options
    • -5
    • +8
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  2. … 20 more files in changeset.
Friday 23 Feb 2018
10:55 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2511: - Updated XMLDocs - Improved tests and testnames

Paired with ~carloslubbers

WTI-1616

Options
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  2. … 6 more files in changeset.
Thursday 22 Feb 2018
7:26 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Made GetDataAtRow return value typed. WTI-1627

Options
    • -3
    • +2
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  2. … 18 more files in changeset.
4:26 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Made AddDataGridColumns abstract. WTI-1627

Options
    • -1
    • +4
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  2. … 19 more files in changeset.
3:50 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Made return type of CreateFailureMechanismSectionResultRow in FailureMechanismResultView the type of the section result row. WTI-1627

Options
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  2. … 19 more files in changeset.
3:14 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added failure mechanism section result row type to the FailureMechanismResultView. WTI-1627

Options
    • -3
    • +2
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
    • -2
    • +2
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismSectionResultRow.cs
  3. … 44 more files in changeset.
3:12 pm

Elmar Kleijn

Improved GetViewName implementation in ViewInfo. WTI-1563 => Original data is now passed instead of view data

Options
    • -6
    • +6
    ./Ringtoets.MacroStabilityInwards.Plugin/MacroStabilityInwardsPlugin.cs
  2. … 13 more files in changeset.
2:33 pm

Carlos Lubbers

Review related improvements. Add xmldocs, remove unneeded null checks in containers and added tests to some detailed assessment extensions WTI-1616

Options
    • -4
    • +4
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -22
    • +60
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultDetailedAssessmentExtensions.cs
  3. … 15 more files in changeset.
12:54 pm

Carlos Lubbers

Review related changes. Improve calculator/factories and their tests. WTI-1616

Options
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  2. … 30 more files in changeset.
Wednesday 21 Feb 2018
2:08 pm

Carlos Lubbers

Review related changes. Use data model instead of cell value when checking for read-onlyness WTI-1617

Options
    • -2
    • +2
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  2. … 21 more files in changeset.
12:58 pm

Carlos Lubbers

Rename resources containing "(afgerond)" to include _Rounded_ WTI-1531

Options
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/MacroStabilityInwardsFailureMechanismProperties.cs
  2. … 8 more files in changeset.
Tuesday 20 Feb 2018
3:07 pm

Carlos Lubbers

Review related changes, rename resources and cleanup WTI-1617

Options
    • -3
    • +3
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  2. … 22 more files in changeset.
2:53 pm

Carlos Lubbers

Review related changes, renamed HasPassedSimpleAssessment and used test failuremechanism instead of simple failure mechanism WTI-1617

Options
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  2. … 20 more files in changeset.
2:45 pm

Carlos Lubbers

Review related changes, update xmldoc and fix tests WTI-1617

Options
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResult.cs
  2. … 19 more files in changeset.
2:02 pm

Carlos Lubbers

Move inheritdoc tag and use helper method for dune erosion result view WTI-1617

Options
    • -1
    • +1
    ./Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  2. … 17 more files in changeset.
Monday 19 Feb 2018
3:04 pm

Carlos Lubbers

Review related changes. Improve assembly factory formatting. WTI-1620

Options
    • -2
    • +2
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  2. … 6 more files in changeset.
2:50 pm

Carlos Lubbers

Review related changes. Improve formatting of factories WTI-1620

Options
    • -9
    • +13
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  2. … 9 more files in changeset.
2:12 pm

Carlos Lubbers

Review related changes. Rename AssemblyFactoryException -> AssemblyException WTI-1620

Options
    • -4
    • +4
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  2. … 43 more files in changeset.
1:55 pm

Carlos Lubbers

Review related changes, update XMLDoc for assembly factory methods WTI-1620

Options
    • -4
    • +4
    ./Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
  2. … 17 more files in changeset.